diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-27 07:46:37 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-27 07:46:37 -0400 |
commit | e6830a86c260d73c6f370aa7ed17ee6c71e5ee05 (patch) | |
tree | c2c7d472184da1549852b86eef551609cddcbcbf /drivers/ide/au1xxx-ide.c | |
parent | b109f526cabcd098131e770fd6232282bce147b4 (diff) |
ide: call ide_build_sglist() prior to ->dma_setup (v2)
* Re-map sg table if needed in ide_build_sglist().
* Move ide_build_sglist() call from ->dma_setup to its users.
* Un-export ide_build_sglist().
v2:
* Build fix for CONFIG_BLK_DEV_IDEDMA=n (noticed by Randy Dunlap).
There should be no functional changes caused by this patch.
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/au1xxx-ide.c')
-rw-r--r-- | drivers/ide/au1xxx-ide.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/ide/au1xxx-ide.c b/drivers/ide/au1xxx-ide.c index 82f153810eb9..3fc3ced8192c 100644 --- a/drivers/ide/au1xxx-ide.c +++ b/drivers/ide/au1xxx-ide.c | |||
@@ -211,21 +211,16 @@ static void auide_set_dma_mode(ide_drive_t *drive, const u8 speed) | |||
211 | #ifdef CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA | 211 | #ifdef CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA |
212 | static int auide_build_dmatable(ide_drive_t *drive) | 212 | static int auide_build_dmatable(ide_drive_t *drive) |
213 | { | 213 | { |
214 | int i, iswrite, count = 0; | ||
215 | ide_hwif_t *hwif = drive->hwif; | 214 | ide_hwif_t *hwif = drive->hwif; |
216 | struct request *rq = hwif->rq; | 215 | struct request *rq = hwif->rq; |
217 | _auide_hwif *ahwif = &auide_hwif; | 216 | _auide_hwif *ahwif = &auide_hwif; |
218 | struct scatterlist *sg; | 217 | struct scatterlist *sg; |
218 | int i = hwif->sg_nents, iswrite, count = 0; | ||
219 | 219 | ||
220 | iswrite = (rq_data_dir(rq) == WRITE); | 220 | iswrite = (rq_data_dir(rq) == WRITE); |
221 | /* Save for interrupt context */ | 221 | /* Save for interrupt context */ |
222 | ahwif->drive = drive; | 222 | ahwif->drive = drive; |
223 | 223 | ||
224 | hwif->sg_nents = i = ide_build_sglist(drive, rq); | ||
225 | |||
226 | if (!i) | ||
227 | return 0; | ||
228 | |||
229 | /* fill the descriptors */ | 224 | /* fill the descriptors */ |
230 | sg = hwif->sg_table; | 225 | sg = hwif->sg_table; |
231 | while (i && sg_dma_len(sg)) { | 226 | while (i && sg_dma_len(sg)) { |