diff options
author | Himangi Saraogi <himangi774@gmail.com> | 2014-08-14 12:44:30 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-10-15 14:27:38 -0400 |
commit | 7546e52b5e3d46d0deae4a336252b6dfd52c6571 (patch) | |
tree | 095ab5f0583801feeb0a06155122e2d685707da2 /drivers/ide/atiixp.c | |
parent | 0429fbc0bdc297d64188483ba029a23773ae07b0 (diff) |
Drivers: ide: Remove typedef atiixp_ide_timing
The Linux kernel coding style guidelines suggest not using typedefs
for structure types. This patch gets rid of the typedef for
atiixp_ide_timing.
The following Coccinelle semantic patch detects the case:
@tn1@
type td;
@@
typedef struct { ... } td;
@script:python tf@
td << tn1.td;
tdres;
@@
coccinelle.tdres = td;
@@
type tn1.td;
identifier tf.tdres;
@@
-typedef
struct
+ tdres
{ ... }
-td
;
@@
type tn1.td;
identifier tf.tdres;
@@
-td
+ struct tdres
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/ide/atiixp.c')
-rw-r--r-- | drivers/ide/atiixp.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/ide/atiixp.c b/drivers/ide/atiixp.c index dbd0f242ec18..76650e92db41 100644 --- a/drivers/ide/atiixp.c +++ b/drivers/ide/atiixp.c | |||
@@ -19,12 +19,12 @@ | |||
19 | #define ATIIXP_IDE_UDMA_CONTROL 0x54 | 19 | #define ATIIXP_IDE_UDMA_CONTROL 0x54 |
20 | #define ATIIXP_IDE_UDMA_MODE 0x56 | 20 | #define ATIIXP_IDE_UDMA_MODE 0x56 |
21 | 21 | ||
22 | typedef struct { | 22 | struct atiixp_ide_timing { |
23 | u8 command_width; | 23 | u8 command_width; |
24 | u8 recover_width; | 24 | u8 recover_width; |
25 | } atiixp_ide_timing; | 25 | }; |
26 | 26 | ||
27 | static atiixp_ide_timing pio_timing[] = { | 27 | static struct atiixp_ide_timing pio_timing[] = { |
28 | { 0x05, 0x0d }, | 28 | { 0x05, 0x0d }, |
29 | { 0x04, 0x07 }, | 29 | { 0x04, 0x07 }, |
30 | { 0x03, 0x04 }, | 30 | { 0x03, 0x04 }, |
@@ -32,7 +32,7 @@ static atiixp_ide_timing pio_timing[] = { | |||
32 | { 0x02, 0x00 }, | 32 | { 0x02, 0x00 }, |
33 | }; | 33 | }; |
34 | 34 | ||
35 | static atiixp_ide_timing mdma_timing[] = { | 35 | static struct atiixp_ide_timing mdma_timing[] = { |
36 | { 0x07, 0x07 }, | 36 | { 0x07, 0x07 }, |
37 | { 0x02, 0x01 }, | 37 | { 0x02, 0x01 }, |
38 | { 0x02, 0x00 }, | 38 | { 0x02, 0x00 }, |