diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-04-26 16:25:14 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-04-26 16:25:14 -0400 |
commit | ac95beedf8bc97b24f9540d4da9952f07221c023 (patch) | |
tree | c29837142c8083b6fcaf1767abcb0a4533676cd1 /drivers/ide/arm/palm_bk3710.c | |
parent | 4a27214d7be31e122db4102166f49ec15958e8e9 (diff) |
ide: add struct ide_port_ops (take 2)
* Move hooks for port/host specific methods from ide_hwif_t to
'struct ide_port_ops'.
* Add 'const struct ide_port_ops *port_ops' to 'struct ide_port_info'
and ide_hwif_t.
* Update host drivers and core code accordingly.
While at it:
* Rename ata66_*() cable detect functions to *_cable_detect() to match
the standard naming. (Suggested by Sergei Shtylyov)
v2:
* Fix build for bast-ide. (Noticed by Andrew Morton)
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/arm/palm_bk3710.c')
-rw-r--r-- | drivers/ide/arm/palm_bk3710.c | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/drivers/ide/arm/palm_bk3710.c b/drivers/ide/arm/palm_bk3710.c index 666df779a5f4..9e21b8e6099c 100644 --- a/drivers/ide/arm/palm_bk3710.c +++ b/drivers/ide/arm/palm_bk3710.c | |||
@@ -317,16 +317,14 @@ static u8 __devinit palm_bk3710_cable_detect(ide_hwif_t *hwif) | |||
317 | return ATA_CBL_PATA80; | 317 | return ATA_CBL_PATA80; |
318 | } | 318 | } |
319 | 319 | ||
320 | static void __devinit palm_bk3710_init_hwif(ide_hwif_t *hwif) | 320 | static const struct ide_port_ops palm_bk3710_ports_ops = { |
321 | { | 321 | .set_pio_mode = palm_bk3710_set_pio_mode, |
322 | hwif->set_pio_mode = palm_bk3710_set_pio_mode; | 322 | .set_dma_mode = palm_bk3710_set_dma_mode, |
323 | hwif->set_dma_mode = palm_bk3710_set_dma_mode; | 323 | .cable_detect = palm_bk3710_cable_detect, |
324 | 324 | }; | |
325 | hwif->cable_detect = palm_bk3710_cable_detect; | ||
326 | } | ||
327 | 325 | ||
328 | static const struct ide_port_info __devinitdata palm_bk3710_port_info = { | 326 | static const struct ide_port_info __devinitdata palm_bk3710_port_info = { |
329 | .init_hwif = palm_bk3710_init_hwif, | 327 | .port_ops = &palm_bk3710_ports_ops, |
330 | .host_flags = IDE_HFLAG_NO_DMA, /* hack (no PCI) */ | 328 | .host_flags = IDE_HFLAG_NO_DMA, /* hack (no PCI) */ |
331 | .pio_mask = ATA_PIO4, | 329 | .pio_mask = ATA_PIO4, |
332 | .udma_mask = ATA_UDMA4, /* (input clk 99MHz) */ | 330 | .udma_mask = ATA_UDMA4, /* (input clk 99MHz) */ |