diff options
author | Tejun Heo <htejun@gmail.com> | 2007-06-13 14:45:17 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-07-11 19:09:06 -0400 |
commit | 7b595756ec1f49e0049a9e01a1298d53a7faaa15 (patch) | |
tree | cd06687ab3e5c7a5a4ef91903dff207a18c4db76 /drivers/i2c | |
parent | dbde0fcf9f8f6d477af3c32d9979e789ee680cde (diff) |
sysfs: kill unnecessary attribute->owner
sysfs is now completely out of driver/module lifetime game. After
deletion, a sysfs node doesn't access anything outside sysfs proper,
so there's no reason to hold onto the attribute owners. Note that
often the wrong modules were accounted for as owners leading to
accessing removed modules.
This patch kills now unnecessary attribute->owner. Note that with
this change, userland holding a sysfs node does not prevent the
backing module from being unloaded.
For more info regarding lifetime rule cleanup, please read the
following message.
http://article.gmane.org/gmane.linux.kernel/510293
(tweaked by Greg to not delete the field just yet, to make it easier to
merge things properly.)
Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/i2c')
-rw-r--r-- | drivers/i2c/chips/eeprom.c | 1 | ||||
-rw-r--r-- | drivers/i2c/chips/max6875.c | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/drivers/i2c/chips/eeprom.c b/drivers/i2c/chips/eeprom.c index bfce13c8f1ff..5990dd5fc773 100644 --- a/drivers/i2c/chips/eeprom.c +++ b/drivers/i2c/chips/eeprom.c | |||
@@ -143,7 +143,6 @@ static struct bin_attribute eeprom_attr = { | |||
143 | .attr = { | 143 | .attr = { |
144 | .name = "eeprom", | 144 | .name = "eeprom", |
145 | .mode = S_IRUGO, | 145 | .mode = S_IRUGO, |
146 | .owner = THIS_MODULE, | ||
147 | }, | 146 | }, |
148 | .size = EEPROM_SIZE, | 147 | .size = EEPROM_SIZE, |
149 | .read = eeprom_read, | 148 | .read = eeprom_read, |
diff --git a/drivers/i2c/chips/max6875.c b/drivers/i2c/chips/max6875.c index 76645c142977..1405ce5b236c 100644 --- a/drivers/i2c/chips/max6875.c +++ b/drivers/i2c/chips/max6875.c | |||
@@ -152,7 +152,6 @@ static struct bin_attribute user_eeprom_attr = { | |||
152 | .attr = { | 152 | .attr = { |
153 | .name = "eeprom", | 153 | .name = "eeprom", |
154 | .mode = S_IRUGO, | 154 | .mode = S_IRUGO, |
155 | .owner = THIS_MODULE, | ||
156 | }, | 155 | }, |
157 | .size = USER_EEPROM_SIZE, | 156 | .size = USER_EEPROM_SIZE, |
158 | .read = max6875_read, | 157 | .read = max6875_read, |