aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/i2c
diff options
context:
space:
mode:
authorMilton Miller <miltonm@bga.com>2008-07-10 17:29:37 -0400
committerJesse Barnes <jbarnes@virtuousgeek.org>2008-10-20 13:48:34 -0400
commitedbc25caaa492a82e19baa915f1f6b0a0db6554d (patch)
tree967dbd4f8d35fd8532a612fef55691586b831965 /drivers/i2c
parent7d67474e506598fe26e0c262acf02132dc730517 (diff)
PCI: remove dynids.use_driver_data
The driver flag dynids.use_driver_data is almost consistently not set, and causes more problems than it solves. It was initially intended as a flag to indicate whether a driver's usage of driver_data had been carefully inspected and was ready for values from userspace. That audit was never done, so most drivers just get a 0 for driver_data when new IDs are added from userspace via sysfs. So remove the flag, allowing drivers to see the data directly (a followon patch validates the passed driver_data value against what the drivers expect). Acked-by: Greg Kroah-Hartman <gregkh@suse.de> Acked-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Milton Miller <miltonm@bga.com> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Diffstat (limited to 'drivers/i2c')
-rw-r--r--drivers/i2c/busses/i2c-amd756.c1
-rw-r--r--drivers/i2c/busses/i2c-viapro.c1
2 files changed, 0 insertions, 2 deletions
diff --git a/drivers/i2c/busses/i2c-amd756.c b/drivers/i2c/busses/i2c-amd756.c
index 1ea39254dac6..a3542b053c8e 100644
--- a/drivers/i2c/busses/i2c-amd756.c
+++ b/drivers/i2c/busses/i2c-amd756.c
@@ -412,7 +412,6 @@ static struct pci_driver amd756_driver = {
412 .id_table = amd756_ids, 412 .id_table = amd756_ids,
413 .probe = amd756_probe, 413 .probe = amd756_probe,
414 .remove = __devexit_p(amd756_remove), 414 .remove = __devexit_p(amd756_remove),
415 .dynids.use_driver_data = 1,
416}; 415};
417 416
418static int __init amd756_init(void) 417static int __init amd756_init(void)
diff --git a/drivers/i2c/busses/i2c-viapro.c b/drivers/i2c/busses/i2c-viapro.c
index 73dc52e114eb..2324780484c0 100644
--- a/drivers/i2c/busses/i2c-viapro.c
+++ b/drivers/i2c/busses/i2c-viapro.c
@@ -483,7 +483,6 @@ static struct pci_driver vt596_driver = {
483 .name = "vt596_smbus", 483 .name = "vt596_smbus",
484 .id_table = vt596_ids, 484 .id_table = vt596_ids,
485 .probe = vt596_probe, 485 .probe = vt596_probe,
486 .dynids.use_driver_data = 1,
487}; 486};
488 487
489static int __init i2c_vt596_init(void) 488static int __init i2c_vt596_init(void)