diff options
author | Jean Delvare <khali@linux-fr.org> | 2005-07-27 16:14:49 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2005-09-05 12:14:14 -0400 |
commit | 7bef559455fc71f66f8573cc1aafe1dd33966c1c (patch) | |
tree | 6c342574710f730d39bf5383f81eaa9f9bb10a25 /drivers/i2c/chips/max6875.c | |
parent | 1ff4e3065b41847b6fe5908b1214cb508dd49e61 (diff) |
[PATCH] I2C: refactor message in i2c_detach_client
We could refactor the error message 34 different i2c drivers print if
i2c_detach_client() fails in this function itself. Saves quite a few
lines of code. Documentation is updated to reflect that change.
Note that this patch should be applied after Rudolf Marek's w83792d
patches.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/i2c/chips/max6875.c')
-rw-r--r-- | drivers/i2c/chips/max6875.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/i2c/chips/max6875.c b/drivers/i2c/chips/max6875.c index d1d48586b90e..52fd6bf29133 100644 --- a/drivers/i2c/chips/max6875.c +++ b/drivers/i2c/chips/max6875.c | |||
@@ -242,10 +242,8 @@ static int max6875_detach_client(struct i2c_client *client) | |||
242 | int err; | 242 | int err; |
243 | 243 | ||
244 | err = i2c_detach_client(client); | 244 | err = i2c_detach_client(client); |
245 | if (err) { | 245 | if (err) |
246 | dev_err(&client->dev, "i2c_detach_client() failed\n"); | ||
247 | return err; | 246 | return err; |
248 | } | ||
249 | kfree(i2c_get_clientdata(client)); | 247 | kfree(i2c_get_clientdata(client)); |
250 | return 0; | 248 | return 0; |
251 | } | 249 | } |