i2c: Fix error value returned by several bus drivers

When adding checks for ACPI resource conflicts to many bus drivers,
not enough attention was paid to the error paths, and for several
drivers this causes 0 to be returned on error in some cases. Fix this
by properly returning a non-zero value on every error.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: stable@kernel.org

1 files changed, 5 insertions, 2 deletions

diff --git a/drivers/i2c/busses/i2c-viapro.c b/drivers/i2c/busses/i2c-viapro.c
index 0b012f1f8ac5..58261d4725b6 100644
--- a/drivers/i2c/busses/i2c-viapro.c
+++ b/drivers/i2c/busses/i2c-viapro.c
@@ -324,7 +324,7 @@ static int __devinit vt596_probe(struct pci_dev *pdev,
                                  const struct pci_device_id *id)
 {
         unsigned char temp;
-        int error = -ENODEV;
+        int error;
 
         /* Determine the address of the SMBus areas */
         if (force_addr) {
@@ -390,6 +390,7 @@ found:
                         dev_err(&pdev->dev, "SMBUS: Error: Host SMBus "
                                 "controller not enabled! - upgrade BIOS or "
                                 "use force=1\n");
+                        error = -ENODEV;
                         goto release_region;
                 }
         }
@@ -422,9 +423,11 @@ found:
                  "SMBus Via Pro adapter at %04x", vt596_smba);
 
         vt596_pdev = pci_dev_get(pdev);
-        if (i2c_add_adapter(&vt596_adapter)) {
+        error = i2c_add_adapter(&vt596_adapter);
+        if (error) {
                 pci_dev_put(vt596_pdev);
                 vt596_pdev = NULL;
+                goto release_region;
         }
 
         /* Always return failure here.  This is to allow other drivers to bind