diff options
author | David Brownell <david-b@pacbell.net> | 2007-05-01 17:26:28 -0400 |
---|---|---|
committer | Jean Delvare <khali@hyperion.delvare> | 2007-05-01 17:26:28 -0400 |
commit | 2096b956d24c4b5950b808fc23b218425d79ebb1 (patch) | |
tree | 9e2c09c2e40c65bd56cbfd50955d5c7355474655 /drivers/i2c/busses/i2c-piix4.c | |
parent | 4ad4eac60667f7c321faae28a3437f7a8b3d17cb (diff) |
i2c: Shrink struct i2c_client
This shrinks the size of "struct i2c_client" by 40 bytes:
- Substantially shrinks the string used to identify the chip type
- The "flags" don't need to be so big
- Removes some internal padding
It also adds kerneldoc for that struct, explaining how "name" is really a
chip type identifier; it's otherwise potentially confusing.
Because the I2C_NAME_SIZE symbol was abused for both i2c_client.name
and for i2c_adapter.name, this needed to affect i2c_adapter too. The
adapters which used that symbol now use the more-obviously-correct
idiom of taking the size of that field.
JD: Shorten i2c_adapter.name from 50 to 48 bytes while we're here, to
avoid wasting space in padding.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Diffstat (limited to 'drivers/i2c/busses/i2c-piix4.c')
-rw-r--r-- | drivers/i2c/busses/i2c-piix4.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c index 21b180904085..5a52bf5e3fb0 100644 --- a/drivers/i2c/busses/i2c-piix4.c +++ b/drivers/i2c/busses/i2c-piix4.c | |||
@@ -428,7 +428,7 @@ static int __devinit piix4_probe(struct pci_dev *dev, | |||
428 | /* set up the sysfs linkage to our parent device */ | 428 | /* set up the sysfs linkage to our parent device */ |
429 | piix4_adapter.dev.parent = &dev->dev; | 429 | piix4_adapter.dev.parent = &dev->dev; |
430 | 430 | ||
431 | snprintf(piix4_adapter.name, I2C_NAME_SIZE, | 431 | snprintf(piix4_adapter.name, sizeof(piix4_adapter.name), |
432 | "SMBus PIIX4 adapter at %04x", piix4_smba); | 432 | "SMBus PIIX4 adapter at %04x", piix4_smba); |
433 | 433 | ||
434 | if ((retval = i2c_add_adapter(&piix4_adapter))) { | 434 | if ((retval = i2c_add_adapter(&piix4_adapter))) { |