i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls

There is simply no reason to be manually setting the private driver
data to NULL in the remove/fail to probe cases.  This is just extra
cruft code that can be removed.

A few notes:
* Nothing relies on drvdata being set to NULL.
* The __device_release_driver() function eventually calls
  dev_set_drvdata(dev, NULL) anyway, so there's no need to do it
  twice.
* I verified that there were no cases where xxx_get_drvdata() was
  being called in these drivers and checking for / relying on the NULL
  return value.

This could be cleaned up kernel-wide but for now just take the baby
step and remove from the i2c subsystem.

Reported-by: Wolfram Sang <wsa@the-dreams.de>
Reported-by: Stephen Warren <swarren@wwwdotorg.org>
Signed-off-by: Doug Anderson <dianders@chromium.org>
Reviewed-by: Jean Delvare <khali@linux-fr.org>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Marek Vasut <marex@denx.de>
Signed-off-by: Wolfram Sang <wolfram@the-dreams.de>

1 files changed, 0 insertions, 3 deletions

diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 4cc2f0528c88..79d05128c77e 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1262,7 +1262,6 @@ err_unuse_clocks:
         pm_runtime_put(dev->dev);
         pm_runtime_disable(&pdev->dev);
 err_free_mem:
-        platform_set_drvdata(pdev, NULL);
 
         return r;
 }
@@ -1272,8 +1271,6 @@ static int omap_i2c_remove(struct platform_device *pdev)
         struct omap_i2c_dev     *dev = platform_get_drvdata(pdev);
         int ret;
 
-        platform_set_drvdata(pdev, NULL);
-
         i2c_del_adapter(&dev->adapter);
         ret = pm_runtime_get_sync(&pdev->dev);
         if (IS_ERR_VALUE(ret))