aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/i2c/busses/i2c-iop3xx.c
diff options
context:
space:
mode:
authorLuotao Fu <l.fu@pengutronix.de>2010-03-01 07:24:24 -0500
committerBen Dooks <ben-linux@fluff.org>2010-03-07 17:10:09 -0500
commitad0194e8d624df67a970a36e8ef9e61514e25553 (patch)
tree0a6ca637423c97d98599d5e17a0f5af4bd03bc39 /drivers/i2c/busses/i2c-iop3xx.c
parent96eb7164e3c2f8c1b53118078e5c06f7c34c2d49 (diff)
i2c-pnx: fix setting start/stop condition
The start/stop condtions are set in different places repetedly in the i2c-pnx driver. Beside in i2c_pnx_start and i2c_pnx_stop the start/stop bit are also set during the transfer of a i2c message in the master_xmit/rcv calls. This is wrong since we can't set the start/stop condition during the transaction of a single message any way. As a matter of fact, the driver will sometimes set both the start and the stop bits at one time. This can be easily reproduced by sending a simple read request like e.g struct i2c_msg msgs[] = { { addr, 0, 1, buf }, { addr, I2C_M_RD, offset, buf } }; While processing the first message the i2c_pnx_master_xmit will set both the start_bit and the stop_bit, which will eventually confuse the slave. Fixed by remove setting start/stop condition from the transmit routines. Signed-off-by: Luotao Fu <l.fu@pengutronix.de> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Diffstat (limited to 'drivers/i2c/busses/i2c-iop3xx.c')
0 files changed, 0 insertions, 0 deletions