Merge master.kernel.org:/pub/scm/linux/kernel/git/torvalds/linux-2.6 into next

author: Dmitry Torokhov <dmitry.torokhov@gmail.com> 2008-07-21 00:55:14 -0400
committer: Dmitry Torokhov <dmitry.torokhov@gmail.com> 2008-07-21 00:55:14 -0400
commit: 908cf4b925e419bc74f3297b2f0e51d6f8a81da2 (patch)
tree: 6c2da79366d4695a9c2560ab18259eca8a2a25b4 /drivers/hwmon
parent: 92c49890922d54cba4b1eadeb0b185773c2c9570 (diff)
parent: 14b395e35d1afdd8019d11b92e28041fad591b71 (diff)
45 files changed, 3000 insertions, 2349 deletions
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 4dc76bc45c9d..00ff53348491 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -330,6 +330,20 @@ config SENSORS_CORETEMP
          sensor inside your CPU. Supported all are all known variants
          of Intel Core family.
+config SENSORS_IBMAEM
+        tristate "IBM Active Energy Manager temperature/power sensors and control"
+        select IPMI_SI
+        depends on IPMI_HANDLER
+        help
+          If you say yes here you get support for the temperature and
+          power sensors and capping hardware in various IBM System X
+          servers that support Active Energy Manager.  This includes
+          the x3350, x3550, x3650, x3655, x3755, x3850 M2, x3950 M2,
+          and certain HS2x/LS2x/QS2x blades.
+          This driver can also be built as a module.  If so, the module
+          will be called ibmaem.
 config SENSORS_IBMPEX
        tristate "IBM PowerExecutive temperature/power sensors"
        select IPMI_SI
diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
index 3bdb05a5cbd7..d098677e08de 100644
--- a/drivers/hwmon/Makefile
+++ b/drivers/hwmon/Makefile
@@ -41,6 +41,7 @@ obj-$(CONFIG_SENSORS_GL518SM)	+= gl518sm.o
 obj-$(CONFIG_SENSORS_GL520SM)   += gl520sm.o
 obj-$(CONFIG_SENSORS_HDAPS)     += hdaps.o
 obj-$(CONFIG_SENSORS_I5K_AMB)   += i5k_amb.o
+obj-$(CONFIG_SENSORS_IBMAEM)    += ibmaem.o
 obj-$(CONFIG_SENSORS_IBMPEX)    += ibmpex.o
 obj-$(CONFIG_SENSORS_IT87)      += it87.o
 obj-$(CONFIG_SENSORS_K8TEMP)    += k8temp.o
diff --git a/drivers/hwmon/abituguru3.c b/drivers/hwmon/abituguru3.c
index ed33fddc4dee..f00f497b9ca9 100644
--- a/drivers/hwmon/abituguru3.c
+++ b/drivers/hwmon/abituguru3.c
@@ -30,6 +30,7 @@
 #include <linux/platform_device.h>
 #include <linux/hwmon.h>
 #include <linux/hwmon-sysfs.h>
+#include <linux/dmi.h>
 #include <asm/io.h>
 /* uGuru3 bank addresses */
@@ -323,7 +324,7 @@ static const struct abituguru3_motherboard_info abituguru3_motherboards[] = {
                { "AUX1 Fan",           36, 2, 60, 1, 0 },
                { NULL, 0, 0, 0, 0, 0 } }
        },
-        { 0x0013, "unknown", {
+        { 0x0013, "Abit AW8D", {
                { "CPU Core",            0, 0, 10, 1, 0 },
                { "DDR",                 1, 0, 10, 1, 0 },
                { "DDR VTT",             2, 0, 10, 1, 0 },
@@ -349,6 +350,7 @@ static const struct abituguru3_motherboard_info abituguru3_motherboards[] = {
                { "AUX2 Fan",           36, 2, 60, 1, 0 },
                { "AUX3 Fan",           37, 2, 60, 1, 0 },
                { "AUX4 Fan",           38, 2, 60, 1, 0 },
+                { "AUX5 Fan",           39, 2, 60, 1, 0 },
                { NULL, 0, 0, 0, 0, 0 } }
        },
        { 0x0014, "Abit AB9 Pro", {
@@ -1111,11 +1113,12 @@ static int __init abituguru3_detect(void)
 {
        /* See if there is an uguru3 there. An idle uGuru3 will hold 0x00 or
           0x08 at DATA and 0xAC at CMD. Sometimes the uGuru3 will hold 0x05
-           at CMD instead, why is unknown. So we test for 0x05 too. */
+           or 0x55 at CMD instead, why is unknown. */
        u8 data_val = inb_p(ABIT_UGURU3_BASE + ABIT_UGURU3_DATA);
        u8 cmd_val = inb_p(ABIT_UGURU3_BASE + ABIT_UGURU3_CMD);
        if (((data_val == 0x00) || (data_val == 0x08)) &&
-                        ((cmd_val == 0xAC) || (cmd_val == 0x05)))
+                        ((cmd_val == 0xAC) || (cmd_val == 0x05) ||
+                         (cmd_val == 0x55)))
                return ABIT_UGURU3_BASE;
        ABIT_UGURU3_DEBUG("no Abit uGuru3 found, data = 0x%02X, cmd = "
@@ -1138,6 +1141,15 @@ static int __init abituguru3_init(void)
        int address, err;
        struct resource res = { .flags = IORESOURCE_IO };
+#ifdef CONFIG_DMI
+        const char *board_vendor = dmi_get_system_info(DMI_BOARD_VENDOR);
+        /* safety check, refuse to load on non Abit motherboards */
+        if (!force && (!board_vendor ||
+                        strcmp(board_vendor, "http://www.abit.com.tw/")))
+                return -ENODEV;
+#endif
        address = abituguru3_detect();
        if (address < 0)
                return address;
diff --git a/drivers/hwmon/ad7418.c b/drivers/hwmon/ad7418.c
index 466b9ee92797..f97b5b356875 100644
--- a/drivers/hwmon/ad7418.c
+++ b/drivers/hwmon/ad7418.c
@@ -23,12 +23,9 @@
 #include "lm75.h"
-#define DRV_VERSION "0.3"
+#define DRV_VERSION "0.4"
-/* Addresses to scan */
+enum chips { ad7416, ad7417, ad7418 };
-static const unsigned short normal_i2c[] = { 0x28, I2C_CLIENT_END };
-/* Insmod parameters */
-I2C_CLIENT_INSMOD_3(ad7416, ad7417, ad7418);
 /* AD7418 registers */
 #define AD7418_REG_TEMP_IN      0x00
@@ -46,7 +43,6 @@ static const u8 AD7418_REG_TEMP[] = { AD7418_REG_TEMP_IN,
                                        AD7418_REG_TEMP_OS };
 struct ad7418_data {
-        struct i2c_client       client;
        struct device           *hwmon_dev;
        struct attribute_group  attrs;
        enum chips              type;
@@ -58,16 +54,25 @@ struct ad7418_data {
        u16                     in[4];
 };
-static int ad7418_attach_adapter(struct i2c_adapter *adapter);
+static int ad7418_probe(struct i2c_client *client,
-static int ad7418_detect(struct i2c_adapter *adapter, int address, int kind);
+                        const struct i2c_device_id *id);
-static int ad7418_detach_client(struct i2c_client *client);
+static int ad7418_remove(struct i2c_client *client);
+static const struct i2c_device_id ad7418_id[] = {
+        { "ad7416", ad7416 },
+        { "ad7417", ad7417 },
+        { "ad7418", ad7418 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, ad7418_id);
 static struct i2c_driver ad7418_driver = {
        .driver = {
                .name   = "ad7418",
        },
-        .attach_adapter = ad7418_attach_adapter,
+        .probe          = ad7418_probe,
-        .detach_client  = ad7418_detach_client,
+        .remove         = ad7418_remove,
+        .id_table       = ad7418_id,
 };
 /* All registers are word-sized, except for the configuration registers.
@@ -192,13 +197,6 @@ static SENSOR_DEVICE_ATTR(in2_input, S_IRUGO, show_adc, NULL, 1);
 static SENSOR_DEVICE_ATTR(in3_input, S_IRUGO, show_adc, NULL, 2);
 static SENSOR_DEVICE_ATTR(in4_input, S_IRUGO, show_adc, NULL, 3);
-static int ad7418_attach_adapter(struct i2c_adapter *adapter)
-{
-        if (!(adapter->class & I2C_CLASS_HWMON))
-                return 0;
-        return i2c_probe(adapter, &addr_data, ad7418_detect);
-}
 static struct attribute *ad7416_attributes[] = {
        &sensor_dev_attr_temp1_max.dev_attr.attr,
        &sensor_dev_attr_temp1_max_hyst.dev_attr.attr,
@@ -225,98 +223,46 @@ static struct attribute *ad7418_attributes[] = {
        NULL
 };
-static int ad7418_detect(struct i2c_adapter *adapter, int address, int kind)
+static int ad7418_probe(struct i2c_client *client,
+                         const struct i2c_device_id *id)
 {
-        struct i2c_client *client;
+        struct i2c_adapter *adapter = client->adapter;
        struct ad7418_data *data;
-        int err = 0;
+        int err;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA |
-                                        I2C_FUNC_SMBUS_WORD_DATA))
+                                        I2C_FUNC_SMBUS_WORD_DATA)) {
+                err = -EOPNOTSUPP;
                goto exit;
+        }
        if (!(data = kzalloc(sizeof(struct ad7418_data), GFP_KERNEL))) {
                err = -ENOMEM;
                goto exit;
        }
-        client = &data->client;
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &ad7418_driver;
        i2c_set_clientdata(client, data);
        mutex_init(&data->lock);
+        data->type = id->driver_data;
-        /* AD7418 has a curious behaviour on registers 6 and 7. They
-         * both always read 0xC071 and are not documented on the datasheet.
-         * We use them to detect the chip.
-         */
-        if (kind <= 0) {
-                int reg, reg6, reg7;
-                /* the AD7416 lies within this address range, but I have
-                 * no means to check.
-                 */
-                if (address >= 0x48 && address <= 0x4f) {
-                        /* XXX add tests for AD7416 here */
-                        /* data->type = ad7416; */
-                }
-                /* here we might have AD7417 or AD7418 */
-                else if (address >= 0x28 && address <= 0x2f) {
-                        reg6 = i2c_smbus_read_word_data(client, 0x06);
-                        reg7 = i2c_smbus_read_word_data(client, 0x07);
-                        if (address == 0x28 && reg6 == 0xC071 && reg7 == 0xC071)
-                                data->type = ad7418;
-                        /* XXX add tests for AD7417 here */
-                        /* both AD7417 and AD7418 have bits 0-5 of
-                         * the CONF2 register at 0
-                         */
-                        reg = i2c_smbus_read_byte_data(client,
-                                                        AD7418_REG_CONF2);
-                        if (reg & 0x3F)
-                                data->type = any_chip; /* detection failed */
-                }
-        } else {
-                dev_dbg(&adapter->dev, "detection forced\n");
-        }
-        if (kind > 0)
-                data->type = kind;
-        else if (kind < 0 && data->type == any_chip) {
-                err = -ENODEV;
-                goto exit_free;
-        }
        switch (data->type) {
-        case any_chip:
        case ad7416:
                data->adc_max = 0;
                data->attrs.attrs = ad7416_attributes;
-                strlcpy(client->name, "ad7416", I2C_NAME_SIZE);
                break;
        case ad7417:
                data->adc_max = 4;
                data->attrs.attrs = ad7417_attributes;
-                strlcpy(client->name, "ad7417", I2C_NAME_SIZE);
                break;
        case ad7418:
                data->adc_max = 1;
                data->attrs.attrs = ad7418_attributes;
-                strlcpy(client->name, "ad7418", I2C_NAME_SIZE);
                break;
        }
-        if ((err = i2c_attach_client(client)))
-                goto exit_free;
        dev_info(&client->dev, "%s chip found\n", client->name);
        /* Initialize the AD7418 chip */
@@ -324,7 +270,7 @@ static int ad7418_detect(struct i2c_adapter *adapter, int address, int kind)
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&client->dev.kobj, &data->attrs)))
-                goto exit_detach;
+                goto exit_free;
        data->hwmon_dev = hwmon_device_register(&client->dev);
        if (IS_ERR(data->hwmon_dev)) {
@@ -336,20 +282,17 @@ static int ad7418_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove:
        sysfs_remove_group(&client->dev.kobj, &data->attrs);
-exit_detach:
-        i2c_detach_client(client);
 exit_free:
        kfree(data);
 exit:
        return err;
 }
-static int ad7418_detach_client(struct i2c_client *client)
+static int ad7418_remove(struct i2c_client *client)
 {
        struct ad7418_data *data = i2c_get_clientdata(client);
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &data->attrs);
-        i2c_detach_client(client);
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/adm1021.c b/drivers/hwmon/adm1021.c
index ecbf69484bf5..b11e06f644b1 100644
--- a/drivers/hwmon/adm1021.c
+++ b/drivers/hwmon/adm1021.c
@@ -78,7 +78,6 @@ clearing it.  Weird, ey?   --Phil  */
 /* Each client has this additional data */
 struct adm1021_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        enum chips type;
@@ -98,23 +97,42 @@ struct adm1021_data {
        u8 remote_temp_offset_prec;
 };
-static int adm1021_attach_adapter(struct i2c_adapter *adapter);
+static int adm1021_probe(struct i2c_client *client,
-static int adm1021_detect(struct i2c_adapter *adapter, int address, int kind);
+                         const struct i2c_device_id *id);
+static int adm1021_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info);
 static void adm1021_init_client(struct i2c_client *client);
-static int adm1021_detach_client(struct i2c_client *client);
+static int adm1021_remove(struct i2c_client *client);
 static struct adm1021_data *adm1021_update_device(struct device *dev);
 /* (amalysh) read only mode, otherwise any limit's writing confuse BIOS */
 static int read_only;
+static const struct i2c_device_id adm1021_id[] = {
+        { "adm1021", adm1021 },
+        { "adm1023", adm1023 },
+        { "max1617", max1617 },
+        { "max1617a", max1617a },
+        { "thmc10", thmc10 },
+        { "lm84", lm84 },
+        { "gl523sm", gl523sm },
+        { "mc1066", mc1066 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, adm1021_id);
 /* This is the driver that will be inserted */
 static struct i2c_driver adm1021_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "adm1021",
        },
-        .attach_adapter = adm1021_attach_adapter,
+        .probe          = adm1021_probe,
-        .detach_client  = adm1021_detach_client,
+        .remove         = adm1021_remove,
+        .id_table       = adm1021_id,
+        .detect         = adm1021_detect,
+        .address_data   = &addr_data,
 };
 static ssize_t show_temp(struct device *dev,
@@ -216,13 +234,6 @@ static SENSOR_DEVICE_ATTR(temp2_fault, S_IRUGO, show_alarm, NULL, 2);
 static DEVICE_ATTR(alarms, S_IRUGO, show_alarms, NULL);
-static int adm1021_attach_adapter(struct i2c_adapter *adapter)
-{
-        if (!(adapter->class & I2C_CLASS_HWMON))
-                return 0;
-        return i2c_probe(adapter, &addr_data, adm1021_detect);
-}
 static struct attribute *adm1021_attributes[] = {
        &sensor_dev_attr_temp1_max.dev_attr.attr,
        &sensor_dev_attr_temp1_min.dev_attr.attr,
@@ -243,36 +254,21 @@ static const struct attribute_group adm1021_group = {
        .attrs = adm1021_attributes,
 };
-static int adm1021_detect(struct i2c_adapter *adapter, int address, int kind)
+/* Return 0 if detection is successful, -ENODEV otherwise */
+static int adm1021_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info)
 {
+        struct i2c_adapter *adapter = client->adapter;
        int i;
-        struct i2c_client *client;
-        struct adm1021_data *data;
-        int err = 0;
        const char *type_name = "";
        int conv_rate, status, config;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
                pr_debug("adm1021: detect failed, "
                         "smbus byte data not supported!\n");
-                goto error0;
+                return -ENODEV;
-        }
-        /* OK. For now, we presume we have a valid client. We now create the
-           client structure, even though we cannot fill it completely yet.
-           But it allows us to access adm1021 register values. */
-        if (!(data = kzalloc(sizeof(struct adm1021_data), GFP_KERNEL))) {
-                pr_debug("adm1021: detect failed, kzalloc failed!\n");
-                err = -ENOMEM;
-                goto error0;
        }
-        client = &data->client;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &adm1021_driver;
        status = i2c_smbus_read_byte_data(client, ADM1021_REG_STATUS);
        conv_rate = i2c_smbus_read_byte_data(client,
                                             ADM1021_REG_CONV_RATE_R);
@@ -284,8 +280,7 @@ static int adm1021_detect(struct i2c_adapter *adapter, int address, int kind)
                    || (conv_rate & 0xF8) != 0x00) {
                        pr_debug("adm1021: detect failed, "
                                 "chip not detected!\n");
-                        err = -ENODEV;
+                        return -ENODEV;
-                        goto error1;
                }
        }
@@ -336,24 +331,36 @@ static int adm1021_detect(struct i2c_adapter *adapter, int address, int kind)
                type_name = "mc1066";
        }
        pr_debug("adm1021: Detected chip %s at adapter %d, address 0x%02x.\n",
-                 type_name, i2c_adapter_id(adapter), address);
+                 type_name, i2c_adapter_id(adapter), client->addr);
+        strlcpy(info->type, type_name, I2C_NAME_SIZE);
-        /* Fill in the remaining client fields */
+        return 0;
-        strlcpy(client->name, type_name, I2C_NAME_SIZE);
+}
-        data->type = kind;
-        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
+static int adm1021_probe(struct i2c_client *client,
-        if ((err = i2c_attach_client(client)))
+                         const struct i2c_device_id *id)
-                goto error1;
+{
+        struct adm1021_data *data;
+        int err;
+        data = kzalloc(sizeof(struct adm1021_data), GFP_KERNEL);
+        if (!data) {
+                pr_debug("adm1021: detect failed, kzalloc failed!\n");
+                err = -ENOMEM;
+                goto error0;
+        }
+        i2c_set_clientdata(client, data);
+        data->type = id->driver_data;
+        mutex_init(&data->update_lock);
        /* Initialize the ADM1021 chip */
-        if (kind != lm84 && !read_only)
+        if (data->type != lm84 && !read_only)
                adm1021_init_client(client);
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&client->dev.kobj, &adm1021_group)))
-                goto error2;
+                goto error1;
        data->hwmon_dev = hwmon_device_register(&client->dev);
        if (IS_ERR(data->hwmon_dev)) {
@@ -365,8 +372,6 @@ static int adm1021_detect(struct i2c_adapter *adapter, int address, int kind)
 error3:
        sysfs_remove_group(&client->dev.kobj, &adm1021_group);
-error2:
-        i2c_detach_client(client);
 error1:
        kfree(data);
 error0:
@@ -382,17 +387,13 @@ static void adm1021_init_client(struct i2c_client *client)
        i2c_smbus_write_byte_data(client, ADM1021_REG_CONV_RATE_W, 0x04);
 }
-static int adm1021_detach_client(struct i2c_client *client)
+static int adm1021_remove(struct i2c_client *client)
 {
        struct adm1021_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &adm1021_group);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/adm1025.c b/drivers/hwmon/adm1025.c
index 1d76de7d75c7..4db04d603ec9 100644
--- a/drivers/hwmon/adm1025.c
+++ b/drivers/hwmon/adm1025.c
@@ -2,7 +2,7 @@
 * adm1025.c
 *
 * Copyright (C) 2000       Chen-Yuan Wu <gwu@esoft.com>
- * Copyright (C) 2003-2004  Jean Delvare <khali@linux-fr.org>
+ * Copyright (C) 2003-2008  Jean Delvare <khali@linux-fr.org>
 *
 * The ADM1025 is a sensor chip made by Analog Devices. It reports up to 6
 * voltages (including its own power source) and up to two temperatures
@@ -109,22 +109,35 @@ static const int in_scale[6] = { 2500, 2250, 3300, 5000, 12000, 3300 };
 * Functions declaration
 */
-static int adm1025_attach_adapter(struct i2c_adapter *adapter);
+static int adm1025_probe(struct i2c_client *client,
-static int adm1025_detect(struct i2c_adapter *adapter, int address, int kind);
+                         const struct i2c_device_id *id);
+static int adm1025_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info);
 static void adm1025_init_client(struct i2c_client *client);
-static int adm1025_detach_client(struct i2c_client *client);
+static int adm1025_remove(struct i2c_client *client);
 static struct adm1025_data *adm1025_update_device(struct device *dev);
 /*
 * Driver data (common to all clients)
 */
+static const struct i2c_device_id adm1025_id[] = {
+        { "adm1025", adm1025 },
+        { "ne1619", ne1619 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, adm1025_id);
 static struct i2c_driver adm1025_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "adm1025",
        },
-        .attach_adapter = adm1025_attach_adapter,
+        .probe          = adm1025_probe,
-        .detach_client  = adm1025_detach_client,
+        .remove         = adm1025_remove,
+        .id_table       = adm1025_id,
+        .detect         = adm1025_detect,
+        .address_data   = &addr_data,
 };
 /*
@@ -132,7 +145,6 @@ static struct i2c_driver adm1025_driver = {
 */
 struct adm1025_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid; /* zero until following fields are valid */
@@ -344,13 +356,6 @@ static DEVICE_ATTR(vrm, S_IRUGO | S_IWUSR, show_vrm, set_vrm);
 * Real code
 */
-static int adm1025_attach_adapter(struct i2c_adapter *adapter)
-{
-        if (!(adapter->class & I2C_CLASS_HWMON))
-                return 0;
-        return i2c_probe(adapter, &addr_data, adm1025_detect);
-}
 static struct attribute *adm1025_attributes[] = {
        &sensor_dev_attr_in0_input.dev_attr.attr,
        &sensor_dev_attr_in1_input.dev_attr.attr,
@@ -403,31 +408,16 @@ static const struct attribute_group adm1025_group_in4 = {
        .attrs = adm1025_attributes_in4,
 };
-/*
+/* Return 0 if detection is successful, -ENODEV otherwise */
- * The following function does more than just detection. If detection
+static int adm1025_detect(struct i2c_client *client, int kind,
- * succeeds, it also registers the new chip.
+                          struct i2c_board_info *info)
- */
-static int adm1025_detect(struct i2c_adapter *adapter, int address, int kind)
 {
-        struct i2c_client *client;
+        struct i2c_adapter *adapter = client->adapter;
-        struct adm1025_data *data;
-        int err = 0;
        const char *name = "";
        u8 config;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
-                goto exit;
+                return -ENODEV;
-        if (!(data = kzalloc(sizeof(struct adm1025_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        client = &data->client;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &adm1025_driver;
        /*
         * Now we do the remaining detection. A negative kind means that
@@ -448,8 +438,8 @@ static int adm1025_detect(struct i2c_adapter *adapter, int address, int kind)
                     ADM1025_REG_STATUS2) & 0xBC) != 0x00) {
                        dev_dbg(&adapter->dev,
                                "ADM1025 detection failed at 0x%02x.\n",
-                                address);
+                                client->addr);
-                        goto exit_free;
+                        return -ENODEV;
                }
        }
@@ -465,7 +455,7 @@ static int adm1025_detect(struct i2c_adapter *adapter, int address, int kind)
                        }
                } else
                if (man_id == 0xA1) { /* Philips */
-                        if (address != 0x2E
+                        if (client->addr != 0x2E
                         && (chip_id & 0xF0) == 0x20) { /* NE1619 */
                                kind = ne1619;
                        }
@@ -475,7 +465,7 @@ static int adm1025_detect(struct i2c_adapter *adapter, int address, int kind)
                        dev_info(&adapter->dev,
                            "Unsupported chip (man_id=0x%02X, "
                            "chip_id=0x%02X).\n", man_id, chip_id);
-                        goto exit_free;
+                        return -ENODEV;
                }
        }
@@ -484,23 +474,36 @@ static int adm1025_detect(struct i2c_adapter *adapter, int address, int kind)
        } else if (kind == ne1619) {
                name = "ne1619";
        }
+        strlcpy(info->type, name, I2C_NAME_SIZE);
-        /* We can fill in the remaining client fields */
+        return 0;
-        strlcpy(client->name, name, I2C_NAME_SIZE);
+}
-        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
+static int adm1025_probe(struct i2c_client *client,
-        if ((err = i2c_attach_client(client)))
+                         const struct i2c_device_id *id)
-                goto exit_free;
+{
+        struct adm1025_data *data;
+        int err;
+        u8 config;
+        data = kzalloc(sizeof(struct adm1025_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(client, data);
+        mutex_init(&data->update_lock);
        /* Initialize the ADM1025 chip */
        adm1025_init_client(client);
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&client->dev.kobj, &adm1025_group)))
-                goto exit_detach;
+                goto exit_free;
        /* Pin 11 is either in4 (+12V) or VID4 */
+        config = i2c_smbus_read_byte_data(client, ADM1025_REG_CONFIG);
        if (!(config & 0x20)) {
                if ((err = sysfs_create_group(&client->dev.kobj,
                                              &adm1025_group_in4)))
@@ -518,8 +521,6 @@ static int adm1025_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove:
        sysfs_remove_group(&client->dev.kobj, &adm1025_group);
        sysfs_remove_group(&client->dev.kobj, &adm1025_group_in4);
-exit_detach:
-        i2c_detach_client(client);
 exit_free:
        kfree(data);
 exit:
@@ -568,18 +569,14 @@ static void adm1025_init_client(struct i2c_client *client)
                                          (reg&0x7E)|0x01);
 }
-static int adm1025_detach_client(struct i2c_client *client)
+static int adm1025_remove(struct i2c_client *client)
 {
        struct adm1025_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &adm1025_group);
        sysfs_remove_group(&client->dev.kobj, &adm1025_group_in4);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/adm1026.c b/drivers/hwmon/adm1026.c
index 904c6ce9d83f..7fe2441fc845 100644
--- a/drivers/hwmon/adm1026.c
+++ b/drivers/hwmon/adm1026.c
@@ -259,7 +259,6 @@ struct pwm_data {
 };
 struct adm1026_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
@@ -293,10 +292,11 @@ struct adm1026_data {
        u8 config3;             /* Register value */
 };
-static int adm1026_attach_adapter(struct i2c_adapter *adapter);
+static int adm1026_probe(struct i2c_client *client,
-static int adm1026_detect(struct i2c_adapter *adapter, int address,
+                         const struct i2c_device_id *id);
-        int kind);
+static int adm1026_detect(struct i2c_client *client, int kind,
-static int adm1026_detach_client(struct i2c_client *client);
+                          struct i2c_board_info *info);
+static int adm1026_remove(struct i2c_client *client);
 static int adm1026_read_value(struct i2c_client *client, u8 reg);
 static int adm1026_write_value(struct i2c_client *client, u8 reg, int value);
 static void adm1026_print_gpio(struct i2c_client *client);
@@ -305,22 +305,24 @@ static struct adm1026_data *adm1026_update_device(struct device *dev);
 static void adm1026_init_client(struct i2c_client *client);
+static const struct i2c_device_id adm1026_id[] = {
+        { "adm1026", adm1026 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, adm1026_id);
 static struct i2c_driver adm1026_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "adm1026",
        },
-        .attach_adapter = adm1026_attach_adapter,
+        .probe          = adm1026_probe,
-        .detach_client  = adm1026_detach_client,
+        .remove         = adm1026_remove,
+        .id_table       = adm1026_id,
+        .detect         = adm1026_detect,
+        .address_data   = &addr_data,
 };
-static int adm1026_attach_adapter(struct i2c_adapter *adapter)
-{
-        if (!(adapter->class & I2C_CLASS_HWMON)) {
-                return 0;
-        }
-        return i2c_probe(adapter, &addr_data, adm1026_detect);
-}
 static int adm1026_read_value(struct i2c_client *client, u8 reg)
 {
        int res;
@@ -1647,48 +1649,32 @@ static const struct attribute_group adm1026_group_in8_9 = {
        .attrs = adm1026_attributes_in8_9,
 };
-static int adm1026_detect(struct i2c_adapter *adapter, int address,
+/* Return 0 if detection is successful, -ENODEV otherwise */
-                          int kind)
+static int adm1026_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info)
 {
+        struct i2c_adapter *adapter = client->adapter;
+        int address = client->addr;
        int company, verstep;
-        struct i2c_client *client;
-        struct adm1026_data *data;
-        int err = 0;
-        const char *type_name = "";
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
                /* We need to be able to do byte I/O */
-                goto exit;
+                return -ENODEV;
        };
-        /* OK. For now, we presume we have a valid client. We now create the
-           client structure, even though we cannot fill it completely yet.
-           But it allows us to access adm1026_{read,write}_value. */
-        if (!(data = kzalloc(sizeof(struct adm1026_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        client = &data->client;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &adm1026_driver;
        /* Now, we do the remaining detection. */
        company = adm1026_read_value(client, ADM1026_REG_COMPANY);
        verstep = adm1026_read_value(client, ADM1026_REG_VERSTEP);
-        dev_dbg(&client->dev, "Detecting device at %d,0x%02x with"
+        dev_dbg(&adapter->dev, "Detecting device at %d,0x%02x with"
                " COMPANY: 0x%02x and VERSTEP: 0x%02x\n",
                i2c_adapter_id(client->adapter), client->addr,
                company, verstep);
        /* If auto-detecting, Determine the chip type. */
        if (kind <= 0) {
-                dev_dbg(&client->dev, "Autodetecting device at %d,0x%02x "
+                dev_dbg(&adapter->dev, "Autodetecting device at %d,0x%02x "
                        "...\n", i2c_adapter_id(adapter), address);
                if (company == ADM1026_COMPANY_ANALOG_DEV
                    && verstep == ADM1026_VERSTEP_ADM1026) {
@@ -1704,7 +1690,7 @@ static int adm1026_detect(struct i2c_adapter *adapter, int address,
                                verstep);
                        kind = any_chip;
                } else {
-                        dev_dbg(&client->dev, ": Autodetection "
+                        dev_dbg(&adapter->dev, ": Autodetection "
                                "failed\n");
                        /* Not an ADM1026 ... */
                        if (kind == 0) { /* User used force=x,y */
@@ -1713,33 +1699,29 @@ static int adm1026_detect(struct i2c_adapter *adapter, int address,
                                        "force_adm1026.\n",
                                        i2c_adapter_id(adapter), address);
                        }
-                        goto exitfree;
+                        return -ENODEV;
                }
        }
+        strlcpy(info->type, "adm1026", I2C_NAME_SIZE);
-        /* Fill in the chip specific driver values */
+        return 0;
-        switch (kind) {
+}
-        case any_chip :
-                type_name = "adm1026";
+static int adm1026_probe(struct i2c_client *client,
-                break;
+                         const struct i2c_device_id *id)
-        case adm1026 :
+{
-                type_name = "adm1026";
+        struct adm1026_data *data;
-                break;
+        int err;
-        default :
-                dev_err(&adapter->dev, ": Internal error, invalid "
+        data = kzalloc(sizeof(struct adm1026_data), GFP_KERNEL);
-                        "kind (%d)!\n", kind);
+        if (!data) {
-                err = -EFAULT;
+                err = -ENOMEM;
-                goto exitfree;
+                goto exit;
        }
-        strlcpy(client->name, type_name, I2C_NAME_SIZE);
-        /* Fill in the remaining client fields */
+        i2c_set_clientdata(client, data);
        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
-        if ((err = i2c_attach_client(client)))
-                goto exitfree;
        /* Set the VRM version */
        data->vrm = vid_which_vrm();
@@ -1748,7 +1730,7 @@ static int adm1026_detect(struct i2c_adapter *adapter, int address,
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&client->dev.kobj, &adm1026_group)))
-                goto exitdetach;
+                goto exitfree;
        if (data->config1 & CFG1_AIN8_9)
                err = sysfs_create_group(&client->dev.kobj,
                                         &adm1026_group_in8_9);
@@ -1773,15 +1755,13 @@ exitremove:
                sysfs_remove_group(&client->dev.kobj, &adm1026_group_in8_9);
        else
                sysfs_remove_group(&client->dev.kobj, &adm1026_group_temp3);
-exitdetach:
-        i2c_detach_client(client);
 exitfree:
        kfree(data);
 exit:
        return err;
 }
-static int adm1026_detach_client(struct i2c_client *client)
+static int adm1026_remove(struct i2c_client *client)
 {
        struct adm1026_data *data = i2c_get_clientdata(client);
        hwmon_device_unregister(data->hwmon_dev);
@@ -1790,7 +1770,6 @@ static int adm1026_detach_client(struct i2c_client *client)
                sysfs_remove_group(&client->dev.kobj, &adm1026_group_in8_9);
        else
                sysfs_remove_group(&client->dev.kobj, &adm1026_group_temp3);
-        i2c_detach_client(client);
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c
index 2c6608d453c2..ba84ca5923f9 100644
--- a/drivers/hwmon/adm1029.c
+++ b/drivers/hwmon/adm1029.c
@@ -115,9 +115,11 @@ static const u8 ADM1029_REG_FAN_DIV[] = {
 * Functions declaration
 */
-static int adm1029_attach_adapter(struct i2c_adapter *adapter);
+static int adm1029_probe(struct i2c_client *client,
-static int adm1029_detect(struct i2c_adapter *adapter, int address, int kind);
+                         const struct i2c_device_id *id);
-static int adm1029_detach_client(struct i2c_client *client);
+static int adm1029_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info);
+static int adm1029_remove(struct i2c_client *client);
 static struct adm1029_data *adm1029_update_device(struct device *dev);
 static int adm1029_init_client(struct i2c_client *client);
@@ -125,12 +127,22 @@ static int adm1029_init_client(struct i2c_client *client);
 * Driver data (common to all clients)
 */
+static const struct i2c_device_id adm1029_id[] = {
+        { "adm1029", adm1029 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, adm1029_id);
 static struct i2c_driver adm1029_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name = "adm1029",
        },
-        .attach_adapter = adm1029_attach_adapter,
+        .probe          = adm1029_probe,
-        .detach_client = adm1029_detach_client,
+        .remove         = adm1029_remove,
+        .id_table       = adm1029_id,
+        .detect         = adm1029_detect,
+        .address_data   = &addr_data,
 };
 /*
@@ -138,7 +150,6 @@ static struct i2c_driver adm1029_driver = {
 */
 struct adm1029_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid;             /* zero until following fields are valid */
@@ -284,37 +295,14 @@ static const struct attribute_group adm1029_group = {
 * Real code
 */
-static int adm1029_attach_adapter(struct i2c_adapter *adapter)
+/* Return 0 if detection is successful, -ENODEV otherwise */
+static int adm1029_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info)
 {
-        if (!(adapter->class & I2C_CLASS_HWMON))
+        struct i2c_adapter *adapter = client->adapter;
-                return 0;
-        return i2c_probe(adapter, &addr_data, adm1029_detect);
-}
-/*
- * The following function does more than just detection. If detection
- * succeeds, it also registers the new chip.
- */
-static int adm1029_detect(struct i2c_adapter *adapter, int address, int kind)
-{
-        struct i2c_client *client;
-        struct adm1029_data *data;
-        int err = 0;
-        const char *name = "";
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
-                goto exit;
+                return -ENODEV;
-        if (!(data = kzalloc(sizeof(struct adm1029_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        client = &data->client;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &adm1029_driver;
        /* Now we do the detection and identification. A negative kind
         * means that the driver was loaded with no force parameter
@@ -362,32 +350,41 @@ static int adm1029_detect(struct i2c_adapter *adapter, int address, int kind)
                if (kind <= 0) {        /* identification failed */
                        pr_debug("adm1029: Unsupported chip (man_id=0x%02X, "
                                 "chip_id=0x%02X)\n", man_id, chip_id);
-                        goto exit_free;
+                        return -ENODEV;
                }
        }
+        strlcpy(info->type, "adm1029", I2C_NAME_SIZE);
-        if (kind == adm1029) {
+        return 0;
-                name = "adm1029";
+}
+static int adm1029_probe(struct i2c_client *client,
+                         const struct i2c_device_id *id)
+{
+        struct adm1029_data *data;
+        int err;
+        data = kzalloc(sizeof(struct adm1029_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
        }
-        /* We can fill in the remaining client fields */
+        i2c_set_clientdata(client, data);
-        strlcpy(client->name, name, I2C_NAME_SIZE);
        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
-        if ((err = i2c_attach_client(client)))
-                goto exit_free;
        /*
         * Initialize the ADM1029 chip
         * Check config register
         */
-        if (adm1029_init_client(client) == 0)
+        if (adm1029_init_client(client) == 0) {
-                goto exit_detach;
+                err = -ENODEV;
+                goto exit_free;
+        }
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&client->dev.kobj, &adm1029_group)))
-                goto exit_detach;
+                goto exit_free;
        data->hwmon_dev = hwmon_device_register(&client->dev);
        if (IS_ERR(data->hwmon_dev)) {
@@ -399,8 +396,6 @@ static int adm1029_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove_files:
        sysfs_remove_group(&client->dev.kobj, &adm1029_group);
- exit_detach:
-        i2c_detach_client(client);
 exit_free:
        kfree(data);
 exit:
@@ -424,17 +419,13 @@ static int adm1029_init_client(struct i2c_client *client)
        return 1;
 }
-static int adm1029_detach_client(struct i2c_client *client)
+static int adm1029_remove(struct i2c_client *client)
 {
        struct adm1029_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &adm1029_group);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/adm1031.c b/drivers/hwmon/adm1031.c
index 2bffcab7dc9f..789441830cd8 100644
--- a/drivers/hwmon/adm1031.c
+++ b/drivers/hwmon/adm1031.c
@@ -70,7 +70,6 @@ typedef u8 auto_chan_table_t[8][2];
 /* Each client has this additional data */
 struct adm1031_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        int chip_type;
@@ -99,19 +98,32 @@ struct adm1031_data {
        s8 temp_crit[3];
 };
-static int adm1031_attach_adapter(struct i2c_adapter *adapter);
+static int adm1031_probe(struct i2c_client *client,
-static int adm1031_detect(struct i2c_adapter *adapter, int address, int kind);
+                         const struct i2c_device_id *id);
+static int adm1031_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info);
 static void adm1031_init_client(struct i2c_client *client);
-static int adm1031_detach_client(struct i2c_client *client);
+static int adm1031_remove(struct i2c_client *client);
 static struct adm1031_data *adm1031_update_device(struct device *dev);
+static const struct i2c_device_id adm1031_id[] = {
+        { "adm1030", adm1030 },
+        { "adm1031", adm1031 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, adm1031_id);
 /* This is the driver that will be inserted */
 static struct i2c_driver adm1031_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name = "adm1031",
        },
-        .attach_adapter = adm1031_attach_adapter,
+        .probe          = adm1031_probe,
-        .detach_client = adm1031_detach_client,
+        .remove         = adm1031_remove,
+        .id_table       = adm1031_id,
+        .detect         = adm1031_detect,
+        .address_data   = &addr_data,
 };
 static inline u8 adm1031_read_value(struct i2c_client *client, u8 reg)
@@ -693,13 +705,6 @@ static SENSOR_DEVICE_ATTR(temp3_crit_alarm, S_IRUGO, show_alarm, NULL, 12);
 static SENSOR_DEVICE_ATTR(temp3_fault, S_IRUGO, show_alarm, NULL, 13);
 static SENSOR_DEVICE_ATTR(temp1_crit_alarm, S_IRUGO, show_alarm, NULL, 14);
-static int adm1031_attach_adapter(struct i2c_adapter *adapter)
-{
-        if (!(adapter->class & I2C_CLASS_HWMON))
-                return 0;
-        return i2c_probe(adapter, &addr_data, adm1031_detect);
-}
 static struct attribute *adm1031_attributes[] = {
        &sensor_dev_attr_fan1_input.dev_attr.attr,
        &sensor_dev_attr_fan1_div.dev_attr.attr,
@@ -770,27 +775,15 @@ static const struct attribute_group adm1031_group_opt = {
        .attrs = adm1031_attributes_opt,
 };
-/* This function is called by i2c_probe */
+/* Return 0 if detection is successful, -ENODEV otherwise */
-static int adm1031_detect(struct i2c_adapter *adapter, int address, int kind)
+static int adm1031_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info)
 {
-        struct i2c_client *client;
+        struct i2c_adapter *adapter = client->adapter;
-        struct adm1031_data *data;
-        int err = 0;
        const char *name = "";
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
-                goto exit;
+                return -ENODEV;
-        if (!(data = kzalloc(sizeof(struct adm1031_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        client = &data->client;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &adm1031_driver;
        if (kind < 0) {
                int id, co;
@@ -798,7 +791,7 @@ static int adm1031_detect(struct i2c_adapter *adapter, int address, int kind)
                co = i2c_smbus_read_byte_data(client, 0x3e);
                if (!((id == 0x31 || id == 0x30) && co == 0x41))
-                        goto exit_free;
+                        return -ENODEV;
                kind = (id == 0x30) ? adm1030 : adm1031;
        }
@@ -809,28 +802,43 @@ static int adm1031_detect(struct i2c_adapter *adapter, int address, int kind)
         * auto fan control helper table. */
        if (kind == adm1030) {
                name = "adm1030";
-                data->chan_select_table = &auto_channel_select_table_adm1030;
        } else if (kind == adm1031) {
                name = "adm1031";
-                data->chan_select_table = &auto_channel_select_table_adm1031;
        }
-        data->chip_type = kind;
+        strlcpy(info->type, name, I2C_NAME_SIZE);
-        strlcpy(client->name, name, I2C_NAME_SIZE);
+        return 0;
+}
+static int adm1031_probe(struct i2c_client *client,
+                         const struct i2c_device_id *id)
+{
+        struct adm1031_data *data;
+        int err;
+        data = kzalloc(sizeof(struct adm1031_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(client, data);
+        data->chip_type = id->driver_data;
        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
+        if (data->chip_type == adm1030)
-        if ((err = i2c_attach_client(client)))
+                data->chan_select_table = &auto_channel_select_table_adm1030;
-                goto exit_free;
+        else
+                data->chan_select_table = &auto_channel_select_table_adm1031;
        /* Initialize the ADM1031 chip */
        adm1031_init_client(client);
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&client->dev.kobj, &adm1031_group)))
-                goto exit_detach;
+                goto exit_free;
-        if (kind == adm1031) {
+        if (data->chip_type == adm1031) {
                if ((err = sysfs_create_group(&client->dev.kobj,
                                                &adm1031_group_opt)))
                        goto exit_remove;
@@ -847,25 +855,19 @@ static int adm1031_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove:
        sysfs_remove_group(&client->dev.kobj, &adm1031_group);
        sysfs_remove_group(&client->dev.kobj, &adm1031_group_opt);
-exit_detach:
-        i2c_detach_client(client);
 exit_free:
        kfree(data);
 exit:
        return err;
 }
-static int adm1031_detach_client(struct i2c_client *client)
+static int adm1031_remove(struct i2c_client *client)
 {
        struct adm1031_data *data = i2c_get_clientdata(client);
-        int ret;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &adm1031_group);
        sysfs_remove_group(&client->dev.kobj, &adm1031_group_opt);
-        if ((ret = i2c_detach_client(client)) != 0) {
-                return ret;
-        }
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/adm9240.c b/drivers/hwmon/adm9240.c
index 149ef25252e7..2444b15f2e9d 100644
--- a/drivers/hwmon/adm9240.c
+++ b/drivers/hwmon/adm9240.c
@@ -130,25 +130,37 @@ static inline unsigned int AOUT_FROM_REG(u8 reg)
        return SCALE(reg, 1250, 255);
 }
-static int adm9240_attach_adapter(struct i2c_adapter *adapter);
+static int adm9240_probe(struct i2c_client *client,
-static int adm9240_detect(struct i2c_adapter *adapter, int address, int kind);
+                         const struct i2c_device_id *id);
+static int adm9240_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info);
 static void adm9240_init_client(struct i2c_client *client);
-static int adm9240_detach_client(struct i2c_client *client);
+static int adm9240_remove(struct i2c_client *client);
 static struct adm9240_data *adm9240_update_device(struct device *dev);
 /* driver data */
+static const struct i2c_device_id adm9240_id[] = {
+        { "adm9240", adm9240 },
+        { "ds1780", ds1780 },
+        { "lm81", lm81 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, adm9240_id);
 static struct i2c_driver adm9240_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "adm9240",
        },
-        .attach_adapter = adm9240_attach_adapter,
+        .probe          = adm9240_probe,
-        .detach_client  = adm9240_detach_client,
+        .remove         = adm9240_remove,
+        .id_table       = adm9240_id,
+        .detect         = adm9240_detect,
+        .address_data   = &addr_data,
 };
 /* per client data */
 struct adm9240_data {
-        enum chips type;
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid;
@@ -532,28 +544,17 @@ static const struct attribute_group adm9240_group = {
 /*** sensor chip detect and driver install ***/
-static int adm9240_detect(struct i2c_adapter *adapter, int address, int kind)
+/* Return 0 if detection is successful, -ENODEV otherwise */
+static int adm9240_detect(struct i2c_client *new_client, int kind,
+                          struct i2c_board_info *info)
 {
-        struct i2c_client *new_client;
+        struct i2c_adapter *adapter = new_client->adapter;
-        struct adm9240_data *data;
-        int err = 0;
        const char *name = "";
+        int address = new_client->addr;
        u8 man_id, die_rev;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
-                goto exit;
+                return -ENODEV;
-        if (!(data = kzalloc(sizeof(*data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        new_client = &data->client;
-        i2c_set_clientdata(new_client, data);
-        new_client->addr = address;
-        new_client->adapter = adapter;
-        new_client->driver = &adm9240_driver;
-        new_client->flags = 0;
        if (kind == 0) {
                kind = adm9240;
@@ -566,7 +567,7 @@ static int adm9240_detect(struct i2c_adapter *adapter, int address, int kind)
                                != address) {
                        dev_err(&adapter->dev, "detect fail: address match, "
                                        "0x%02x\n", address);
-                        goto exit_free;
+                        return -ENODEV;
                }
                /* check known chip manufacturer */
@@ -581,7 +582,7 @@ static int adm9240_detect(struct i2c_adapter *adapter, int address, int kind)
                } else {
                        dev_err(&adapter->dev, "detect fail: unknown manuf, "
                                        "0x%02x\n", man_id);
-                        goto exit_free;
+                        return -ENODEV;
                }
                /* successful detect, print chip info */
@@ -600,20 +601,31 @@ static int adm9240_detect(struct i2c_adapter *adapter, int address, int kind)
        } else if (kind == lm81) {
                name = "lm81";
        }
+        strlcpy(info->type, name, I2C_NAME_SIZE);
-        /* fill in the remaining client fields and attach */
+        return 0;
-        strlcpy(new_client->name, name, I2C_NAME_SIZE);
+}
-        data->type = kind;
-        mutex_init(&data->update_lock);
-        if ((err = i2c_attach_client(new_client)))
+static int adm9240_probe(struct i2c_client *new_client,
-                goto exit_free;
+                         const struct i2c_device_id *id)
+{
+        struct adm9240_data *data;
+        int err;
+        data = kzalloc(sizeof(*data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(new_client, data);
+        mutex_init(&data->update_lock);
        adm9240_init_client(new_client);
        /* populate sysfs filesystem */
        if ((err = sysfs_create_group(&new_client->dev.kobj, &adm9240_group)))
-                goto exit_detach;
+                goto exit_free;
        data->hwmon_dev = hwmon_device_register(&new_client->dev);
        if (IS_ERR(data->hwmon_dev)) {
@@ -625,32 +637,19 @@ static int adm9240_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove:
        sysfs_remove_group(&new_client->dev.kobj, &adm9240_group);
-exit_detach:
-        i2c_detach_client(new_client);
 exit_free:
        kfree(data);
 exit:
        return err;
 }
-static int adm9240_attach_adapter(struct i2c_adapter *adapter)
+static int adm9240_remove(struct i2c_client *client)
-{
-        if (!(adapter->class & I2C_CLASS_HWMON))
-                return 0;
-        return i2c_probe(adapter, &addr_data, adm9240_detect);
-}
-static int adm9240_detach_client(struct i2c_client *client)
 {
        struct adm9240_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &adm9240_group);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/ads7828.c b/drivers/hwmon/ads7828.c
index 5c8b6e0ff47c..5c39b4af1b23 100644
--- a/drivers/hwmon/ads7828.c
+++ b/drivers/hwmon/ads7828.c
@@ -64,7 +64,6 @@ static unsigned int ads7828_lsb_resol; /* resolution of the ADC sample lsb */
 /* Each client has this additional data */
 struct ads7828_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock; /* mutex protect updates */
        char valid; /* !=0 if following fields are valid */
@@ -73,7 +72,10 @@ struct ads7828_data {
 };
 /* Function declaration - necessary due to function dependencies */
-static int ads7828_detect(struct i2c_adapter *adapter, int address, int kind);
+static int ads7828_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info);
+static int ads7828_probe(struct i2c_client *client,
+                         const struct i2c_device_id *id);
 /* The ADS7828 returns the 12-bit sample in two bytes,
        these are read as a word then byte-swapped */
@@ -156,58 +158,43 @@ static const struct attribute_group ads7828_group = {
        .attrs = ads7828_attributes,
 };
-static int ads7828_attach_adapter(struct i2c_adapter *adapter)
+static int ads7828_remove(struct i2c_client *client)
-{
-        if (!(adapter->class & I2C_CLASS_HWMON))
-                return 0;
-        return i2c_probe(adapter, &addr_data, ads7828_detect);
-}
-static int ads7828_detach_client(struct i2c_client *client)
 {
        struct ads7828_data *data = i2c_get_clientdata(client);
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &ads7828_group);
-        i2c_detach_client(client);
        kfree(i2c_get_clientdata(client));
        return 0;
 }
+static const struct i2c_device_id ads7828_id[] = {
+        { "ads7828", ads7828 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, ads7828_id);
 /* This is the driver that will be inserted */
 static struct i2c_driver ads7828_driver = {
+        .class = I2C_CLASS_HWMON,
        .driver = {
                .name = "ads7828",
        },
-        .attach_adapter = ads7828_attach_adapter,
+        .probe = ads7828_probe,
-        .detach_client = ads7828_detach_client,
+        .remove = ads7828_remove,
+        .id_table = ads7828_id,
+        .detect = ads7828_detect,
+        .address_data = &addr_data,
 };
-/* This function is called by i2c_probe */
+/* Return 0 if detection is successful, -ENODEV otherwise */
-static int ads7828_detect(struct i2c_adapter *adapter, int address, int kind)
+static int ads7828_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info)
 {
-        struct i2c_client *client;
+        struct i2c_adapter *adapter = client->adapter;
-        struct ads7828_data *data;
-        int err = 0;
-        const char *name = "";
        /* Check we have a valid client */
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_READ_WORD_DATA))
-                goto exit;
+                return -ENODEV;
-        /* OK. For now, we presume we have a valid client. We now create the
-        client structure, even though we cannot fill it completely yet.
-        But it allows us to access ads7828_read_value. */
-        data = kzalloc(sizeof(struct ads7828_data), GFP_KERNEL);
-        if (!data) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        client = &data->client;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &ads7828_driver;
        /* Now, we do the remaining detection. There is no identification
        dedicated register so attempt to sanity check using knowledge of
@@ -225,32 +212,34 @@ static int ads7828_detect(struct i2c_adapter *adapter, int address, int kind)
                                printk(KERN_DEBUG
                                "%s : Doesn't look like an ads7828 device\n",
                                __func__);
-                                goto exit_free;
+                                return -ENODEV;
                        }
                }
        }
+        strlcpy(info->type, "ads7828", I2C_NAME_SIZE);
-        /* Determine the chip type - only one kind supported! */
+        return 0;
-        if (kind <= 0)
+}
-                kind = ads7828;
-        if (kind == ads7828)
+static int ads7828_probe(struct i2c_client *client,
-                name = "ads7828";
+                         const struct i2c_device_id *id)
+{
+        struct ads7828_data *data;
+        int err;
-        /* Fill in the remaining client fields, put it into the global list */
+        data = kzalloc(sizeof(struct ads7828_data), GFP_KERNEL);
-        strlcpy(client->name, name, I2C_NAME_SIZE);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(client, data);
        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
-        err = i2c_attach_client(client);
-        if (err)
-                goto exit_free;
        /* Register sysfs hooks */
        err = sysfs_create_group(&client->dev.kobj, &ads7828_group);
        if (err)
-                goto exit_detach;
+                goto exit_free;
        data->hwmon_dev = hwmon_device_register(&client->dev);
        if (IS_ERR(data->hwmon_dev)) {
@@ -262,8 +251,6 @@ static int ads7828_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove:
        sysfs_remove_group(&client->dev.kobj, &ads7828_group);
-exit_detach:
-        i2c_detach_client(client);
 exit_free:
        kfree(data);
 exit:
diff --git a/drivers/hwmon/adt7470.c b/drivers/hwmon/adt7470.c
index 6b5325f33a2c..d368d8f845e1 100644
--- a/drivers/hwmon/adt7470.c
+++ b/drivers/hwmon/adt7470.c
@@ -138,7 +138,6 @@ I2C_CLIENT_INSMOD_1(adt7470);
 #define FAN_DATA_VALID(x)       ((x) && (x) != FAN_PERIOD_INVALID)
 struct adt7470_data {
-        struct i2c_client       client;
        struct device           *hwmon_dev;
        struct attribute_group  attrs;
        struct mutex            lock;
@@ -164,16 +163,28 @@ struct adt7470_data {
        u8                      pwm_auto_temp[ADT7470_PWM_COUNT];
 };
-static int adt7470_attach_adapter(struct i2c_adapter *adapter);
+static int adt7470_probe(struct i2c_client *client,
-static int adt7470_detect(struct i2c_adapter *adapter, int address, int kind);
+                         const struct i2c_device_id *id);
-static int adt7470_detach_client(struct i2c_client *client);
+static int adt7470_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info);
+static int adt7470_remove(struct i2c_client *client);
+static const struct i2c_device_id adt7470_id[] = {
+        { "adt7470", adt7470 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, adt7470_id);
 static struct i2c_driver adt7470_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "adt7470",
        },
-        .attach_adapter = adt7470_attach_adapter,
+        .probe          = adt7470_probe,
-        .detach_client  = adt7470_detach_client,
+        .remove         = adt7470_remove,
+        .id_table       = adt7470_id,
+        .detect         = adt7470_detect,
+        .address_data   = &addr_data,
 };
 /*
@@ -1004,64 +1015,52 @@ static struct attribute *adt7470_attr[] =
        NULL
 };
-static int adt7470_attach_adapter(struct i2c_adapter *adapter)
+/* Return 0 if detection is successful, -ENODEV otherwise */
-{
+static int adt7470_detect(struct i2c_client *client, int kind,
-        if (!(adapter->class & I2C_CLASS_HWMON))
+                          struct i2c_board_info *info)
-                return 0;
-        return i2c_probe(adapter, &addr_data, adt7470_detect);
-}
-static int adt7470_detect(struct i2c_adapter *adapter, int address, int kind)
 {
-        struct i2c_client *client;
+        struct i2c_adapter *adapter = client->adapter;
-        struct adt7470_data *data;
-        int err = 0;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
-                goto exit;
+                return -ENODEV;
-        if (!(data = kzalloc(sizeof(struct adt7470_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        client = &data->client;
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &adt7470_driver;
-        i2c_set_clientdata(client, data);
-        mutex_init(&data->lock);
        if (kind <= 0) {
                int vendor, device, revision;
                vendor = i2c_smbus_read_byte_data(client, ADT7470_REG_VENDOR);
-                if (vendor != ADT7470_VENDOR) {
+                if (vendor != ADT7470_VENDOR)
-                        err = -ENODEV;
+                        return -ENODEV;
-                        goto exit_free;
-                }
                device = i2c_smbus_read_byte_data(client, ADT7470_REG_DEVICE);
-                if (device != ADT7470_DEVICE) {
+                if (device != ADT7470_DEVICE)
-                        err = -ENODEV;
+                        return -ENODEV;
-                        goto exit_free;
-                }
                revision = i2c_smbus_read_byte_data(client,
                                                    ADT7470_REG_REVISION);
-                if (revision != ADT7470_REVISION) {
+                if (revision != ADT7470_REVISION)
-                        err = -ENODEV;
+                        return -ENODEV;
-                        goto exit_free;
-                }
        } else
                dev_dbg(&adapter->dev, "detection forced\n");
-        strlcpy(client->name, "adt7470", I2C_NAME_SIZE);
+        strlcpy(info->type, "adt7470", I2C_NAME_SIZE);
-        if ((err = i2c_attach_client(client)))
+        return 0;
-                goto exit_free;
+}
+static int adt7470_probe(struct i2c_client *client,
+                         const struct i2c_device_id *id)
+{
+        struct adt7470_data *data;
+        int err;
+        data = kzalloc(sizeof(struct adt7470_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(client, data);
+        mutex_init(&data->lock);
        dev_info(&client->dev, "%s chip found\n", client->name);
@@ -1071,7 +1070,7 @@ static int adt7470_detect(struct i2c_adapter *adapter, int address, int kind)
        /* Register sysfs hooks */
        data->attrs.attrs = adt7470_attr;
        if ((err = sysfs_create_group(&client->dev.kobj, &data->attrs)))
-                goto exit_detach;
+                goto exit_free;
        data->hwmon_dev = hwmon_device_register(&client->dev);
        if (IS_ERR(data->hwmon_dev)) {
@@ -1083,21 +1082,18 @@ static int adt7470_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove:
        sysfs_remove_group(&client->dev.kobj, &data->attrs);
-exit_detach:
-        i2c_detach_client(client);
 exit_free:
        kfree(data);
 exit:
        return err;
 }
-static int adt7470_detach_client(struct i2c_client *client)
+static int adt7470_remove(struct i2c_client *client)
 {
        struct adt7470_data *data = i2c_get_clientdata(client);
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &data->attrs);
-        i2c_detach_client(client);
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/adt7473.c b/drivers/hwmon/adt7473.c
index c1009d6f9796..ce4a7cb5a116 100644
--- a/drivers/hwmon/adt7473.c
+++ b/drivers/hwmon/adt7473.c
@@ -143,7 +143,6 @@ I2C_CLIENT_INSMOD_1(adt7473);
 #define FAN_DATA_VALID(x)       ((x) && (x) != FAN_PERIOD_INVALID)
 struct adt7473_data {
-        struct i2c_client       client;
        struct device           *hwmon_dev;
        struct attribute_group  attrs;
        struct mutex            lock;
@@ -178,16 +177,28 @@ struct adt7473_data {
        u8                      max_duty_at_overheat;
 };
-static int adt7473_attach_adapter(struct i2c_adapter *adapter);
+static int adt7473_probe(struct i2c_client *client,
-static int adt7473_detect(struct i2c_adapter *adapter, int address, int kind);
+                         const struct i2c_device_id *id);
-static int adt7473_detach_client(struct i2c_client *client);
+static int adt7473_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info);
+static int adt7473_remove(struct i2c_client *client);
+static const struct i2c_device_id adt7473_id[] = {
+        { "adt7473", adt7473 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, adt7473_id);
 static struct i2c_driver adt7473_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "adt7473",
        },
-        .attach_adapter = adt7473_attach_adapter,
+        .probe          = adt7473_probe,
-        .detach_client  = adt7473_detach_client,
+        .remove         = adt7473_remove,
+        .id_table       = adt7473_id,
+        .detect         = adt7473_detect,
+        .address_data   = &addr_data,
 };
 /*
@@ -309,6 +320,9 @@ no_sensor_update:
                                                ADT7473_REG_PWM_BHVR(i));
        }
+        i = i2c_smbus_read_byte_data(client, ADT7473_REG_CFG4);
+        data->max_duty_at_overheat = !!(i & ADT7473_CFG4_MAX_DUTY_AT_OVT);
        data->limits_last_updated = local_jiffies;
        data->limits_valid = 1;
@@ -1039,66 +1053,52 @@ static struct attribute *adt7473_attr[] =
        NULL
 };
-static int adt7473_attach_adapter(struct i2c_adapter *adapter)
+/* Return 0 if detection is successful, -ENODEV otherwise */
+static int adt7473_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info)
 {
-        if (!(adapter->class & I2C_CLASS_HWMON))
+        struct i2c_adapter *adapter = client->adapter;
-                return 0;
-        return i2c_probe(adapter, &addr_data, adt7473_detect);
-}
-static int adt7473_detect(struct i2c_adapter *adapter, int address, int kind)
-{
-        struct i2c_client *client;
-        struct adt7473_data *data;
-        int err = 0;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
-                goto exit;
+                return -ENODEV;
-        data = kzalloc(sizeof(struct adt7473_data), GFP_KERNEL);
-        if (!data) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        client = &data->client;
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &adt7473_driver;
-        i2c_set_clientdata(client, data);
-        mutex_init(&data->lock);
        if (kind <= 0) {
                int vendor, device, revision;
                vendor = i2c_smbus_read_byte_data(client, ADT7473_REG_VENDOR);
-                if (vendor != ADT7473_VENDOR) {
+                if (vendor != ADT7473_VENDOR)
-                        err = -ENODEV;
+                        return -ENODEV;
-                        goto exit_free;
-                }
                device = i2c_smbus_read_byte_data(client, ADT7473_REG_DEVICE);
-                if (device != ADT7473_DEVICE) {
+                if (device != ADT7473_DEVICE)
-                        err = -ENODEV;
+                        return -ENODEV;
-                        goto exit_free;
-                }
                revision = i2c_smbus_read_byte_data(client,
                                                    ADT7473_REG_REVISION);
-                if (revision != ADT7473_REV_68 && revision != ADT7473_REV_69) {
+                if (revision != ADT7473_REV_68 && revision != ADT7473_REV_69)
-                        err = -ENODEV;
+                        return -ENODEV;
-                        goto exit_free;
-                }
        } else
                dev_dbg(&adapter->dev, "detection forced\n");
-        strlcpy(client->name, "adt7473", I2C_NAME_SIZE);
+        strlcpy(info->type, "adt7473", I2C_NAME_SIZE);
-        err = i2c_attach_client(client);
+        return 0;
-        if (err)
+}
-                goto exit_free;
+static int adt7473_probe(struct i2c_client *client,
+                         const struct i2c_device_id *id)
+{
+        struct adt7473_data *data;
+        int err;
+        data = kzalloc(sizeof(struct adt7473_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(client, data);
+        mutex_init(&data->lock);
        dev_info(&client->dev, "%s chip found\n", client->name);
@@ -1109,7 +1109,7 @@ static int adt7473_detect(struct i2c_adapter *adapter, int address, int kind)
        data->attrs.attrs = adt7473_attr;
        err = sysfs_create_group(&client->dev.kobj, &data->attrs);
        if (err)
-                goto exit_detach;
+                goto exit_free;
        data->hwmon_dev = hwmon_device_register(&client->dev);
        if (IS_ERR(data->hwmon_dev)) {
@@ -1121,21 +1121,18 @@ static int adt7473_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove:
        sysfs_remove_group(&client->dev.kobj, &data->attrs);
-exit_detach:
-        i2c_detach_client(client);
 exit_free:
        kfree(data);
 exit:
        return err;
 }
-static int adt7473_detach_client(struct i2c_client *client)
+static int adt7473_remove(struct i2c_client *client)
 {
        struct adt7473_data *data = i2c_get_clientdata(client);
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &data->attrs);
-        i2c_detach_client(client);
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/ams/ams-core.c b/drivers/hwmon/ams/ams-core.c
index a112a03e8f29..fbefa82a015c 100644
--- a/drivers/hwmon/ams/ams-core.c
+++ b/drivers/hwmon/ams/ams-core.c
@@ -23,8 +23,8 @@
 #include <linux/types.h>
 #include <linux/errno.h>
 #include <linux/init.h>
+#include <linux/of_platform.h>
 #include <asm/pmac_pfunc.h>
-#include <asm/of_platform.h>
 #include "ams.h"
diff --git a/drivers/hwmon/asb100.c b/drivers/hwmon/asb100.c
index fe2eea4d799b..8a45a2e6ba8a 100644
--- a/drivers/hwmon/asb100.c
+++ b/drivers/hwmon/asb100.c
@@ -176,10 +176,8 @@ static u8 DIV_TO_REG(long val)
   data is pointed to by client->data. The structure itself is
   dynamically allocated, at the same time the client itself is allocated. */
 struct asb100_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex lock;
-        enum chips type;
        struct mutex update_lock;
        unsigned long last_updated;     /* In jiffies */
@@ -206,18 +204,30 @@ struct asb100_data {
 static int asb100_read_value(struct i2c_client *client, u16 reg);
 static void asb100_write_value(struct i2c_client *client, u16 reg, u16 val);
-static int asb100_attach_adapter(struct i2c_adapter *adapter);
+static int asb100_probe(struct i2c_client *client,
-static int asb100_detect(struct i2c_adapter *adapter, int address, int kind);
+                        const struct i2c_device_id *id);
-static int asb100_detach_client(struct i2c_client *client);
+static int asb100_detect(struct i2c_client *client, int kind,
+                         struct i2c_board_info *info);
+static int asb100_remove(struct i2c_client *client);
 static struct asb100_data *asb100_update_device(struct device *dev);
 static void asb100_init_client(struct i2c_client *client);
+static const struct i2c_device_id asb100_id[] = {
+        { "asb100", asb100 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, asb100_id);
 static struct i2c_driver asb100_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "asb100",
        },
-        .attach_adapter = asb100_attach_adapter,
+        .probe          = asb100_probe,
-        .detach_client  = asb100_detach_client,
+        .remove         = asb100_remove,
+        .id_table       = asb100_id,
+        .detect         = asb100_detect,
+        .address_data   = &addr_data,
 };
 /* 7 Voltages */
@@ -619,35 +629,13 @@ static const struct attribute_group asb100_group = {
        .attrs = asb100_attributes,
 };
-/* This function is called when:
+static int asb100_detect_subclients(struct i2c_client *client)
-        asb100_driver is inserted (when this module is loaded), for each
-                available adapter
-        when a new adapter is inserted (and asb100_driver is still present)
- */
-static int asb100_attach_adapter(struct i2c_adapter *adapter)
-{
-        if (!(adapter->class & I2C_CLASS_HWMON))
-                return 0;
-        return i2c_probe(adapter, &addr_data, asb100_detect);
-}
-static int asb100_detect_subclients(struct i2c_adapter *adapter, int address,
-                int kind, struct i2c_client *client)
 {
        int i, id, err;
+        int address = client->addr;
+        unsigned short sc_addr[2];
        struct asb100_data *data = i2c_get_clientdata(client);
+        struct i2c_adapter *adapter = client->adapter;
-        data->lm75[0] = kzalloc(sizeof(struct i2c_client), GFP_KERNEL);
-        if (!(data->lm75[0])) {
-                err = -ENOMEM;
-                goto ERROR_SC_0;
-        }
-        data->lm75[1] = kzalloc(sizeof(struct i2c_client), GFP_KERNEL);
-        if (!(data->lm75[1])) {
-                err = -ENOMEM;
-                goto ERROR_SC_1;
-        }
        id = i2c_adapter_id(adapter);
@@ -665,37 +653,34 @@ static int asb100_detect_subclients(struct i2c_adapter *adapter, int address,
                asb100_write_value(client, ASB100_REG_I2C_SUBADDR,
                                        (force_subclients[2] & 0x07) |
                                        ((force_subclients[3] & 0x07) << 4));
-                data->lm75[0]->addr = force_subclients[2];
+                sc_addr[0] = force_subclients[2];
-                data->lm75[1]->addr = force_subclients[3];
+                sc_addr[1] = force_subclients[3];
        } else {
                int val = asb100_read_value(client, ASB100_REG_I2C_SUBADDR);
-                data->lm75[0]->addr = 0x48 + (val & 0x07);
+                sc_addr[0] = 0x48 + (val & 0x07);
-                data->lm75[1]->addr = 0x48 + ((val >> 4) & 0x07);
+                sc_addr[1] = 0x48 + ((val >> 4) & 0x07);
        }
-        if (data->lm75[0]->addr == data->lm75[1]->addr) {
+        if (sc_addr[0] == sc_addr[1]) {
                dev_err(&client->dev, "duplicate addresses 0x%x "
-                                "for subclients\n", data->lm75[0]->addr);
+                                "for subclients\n", sc_addr[0]);
                err = -ENODEV;
                goto ERROR_SC_2;
        }
-        for (i = 0; i <= 1; i++) {
+        data->lm75[0] = i2c_new_dummy(adapter, sc_addr[0]);
-                i2c_set_clientdata(data->lm75[i], NULL);
+        if (!data->lm75[0]) {
-                data->lm75[i]->adapter = adapter;
-                data->lm75[i]->driver = &asb100_driver;
-                strlcpy(data->lm75[i]->name, "asb100 subclient", I2C_NAME_SIZE);
-        }
-        if ((err = i2c_attach_client(data->lm75[0]))) {
                dev_err(&client->dev, "subclient %d registration "
-                        "at address 0x%x failed.\n", i, data->lm75[0]->addr);
+                        "at address 0x%x failed.\n", 1, sc_addr[0]);
+                err = -ENOMEM;
                goto ERROR_SC_2;
        }
-        if ((err = i2c_attach_client(data->lm75[1]))) {
+        data->lm75[1] = i2c_new_dummy(adapter, sc_addr[1]);
+        if (!data->lm75[1]) {
                dev_err(&client->dev, "subclient %d registration "
-                        "at address 0x%x failed.\n", i, data->lm75[1]->addr);
+                        "at address 0x%x failed.\n", 2, sc_addr[1]);
+                err = -ENOMEM;
                goto ERROR_SC_3;
        }
@@ -703,55 +688,31 @@ static int asb100_detect_subclients(struct i2c_adapter *adapter, int address,
 /* Undo inits in case of errors */
 ERROR_SC_3:
-        i2c_detach_client(data->lm75[0]);
+        i2c_unregister_device(data->lm75[0]);
 ERROR_SC_2:
-        kfree(data->lm75[1]);
-ERROR_SC_1:
-        kfree(data->lm75[0]);
-ERROR_SC_0:
        return err;
 }
-static int asb100_detect(struct i2c_adapter *adapter, int address, int kind)
+/* Return 0 if detection is successful, -ENODEV otherwise */
+static int asb100_detect(struct i2c_client *client, int kind,
+                         struct i2c_board_info *info)
 {
-        int err;
+        struct i2c_adapter *adapter = client->adapter;
-        struct i2c_client *client;
-        struct asb100_data *data;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
                pr_debug("asb100.o: detect failed, "
                                "smbus byte data not supported!\n");
-                err = -ENODEV;
+                return -ENODEV;
-                goto ERROR0;
        }
-        /* OK. For now, we presume we have a valid client. We now create the
-           client structure, even though we cannot fill it completely yet.
-           But it allows us to access asb100_{read,write}_value. */
-        if (!(data = kzalloc(sizeof(struct asb100_data), GFP_KERNEL))) {
-                pr_debug("asb100.o: detect failed, kzalloc failed!\n");
-                err = -ENOMEM;
-                goto ERROR0;
-        }
-        client = &data->client;
-        mutex_init(&data->lock);
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &asb100_driver;
-        /* Now, we do the remaining detection. */
        /* The chip may be stuck in some other bank than bank 0. This may
           make reading other information impossible. Specify a force=... or
           force_*=... parameter, and the chip will be reset to the right
           bank. */
        if (kind < 0) {
-                int val1 = asb100_read_value(client, ASB100_REG_BANK);
+                int val1 = i2c_smbus_read_byte_data(client, ASB100_REG_BANK);
-                int val2 = asb100_read_value(client, ASB100_REG_CHIPMAN);
+                int val2 = i2c_smbus_read_byte_data(client, ASB100_REG_CHIPMAN);
                /* If we're in bank 0 */
                if ((!(val1 & 0x07)) &&
@@ -761,48 +722,60 @@ static int asb100_detect(struct i2c_adapter *adapter, int address, int kind)
                                ((val1 & 0x80) && (val2 != 0x06)))) {
                        pr_debug("asb100.o: detect failed, "
                                        "bad chip id 0x%02x!\n", val2);
-                        err = -ENODEV;
+                        return -ENODEV;
-                        goto ERROR1;
                }
        } /* kind < 0 */
        /* We have either had a force parameter, or we have already detected
           Winbond. Put it now into bank 0 and Vendor ID High Byte */
-        asb100_write_value(client, ASB100_REG_BANK,
+        i2c_smbus_write_byte_data(client, ASB100_REG_BANK,
-                (asb100_read_value(client, ASB100_REG_BANK) & 0x78) | 0x80);
+                (i2c_smbus_read_byte_data(client, ASB100_REG_BANK) & 0x78)
+                | 0x80);
        /* Determine the chip type. */
        if (kind <= 0) {
-                int val1 = asb100_read_value(client, ASB100_REG_WCHIPID);
+                int val1 = i2c_smbus_read_byte_data(client, ASB100_REG_WCHIPID);
-                int val2 = asb100_read_value(client, ASB100_REG_CHIPMAN);
+                int val2 = i2c_smbus_read_byte_data(client, ASB100_REG_CHIPMAN);
                if ((val1 == 0x31) && (val2 == 0x06))
                        kind = asb100;
                else {
                        if (kind == 0)
-                                dev_warn(&client->dev, "ignoring "
+                                dev_warn(&adapter->dev, "ignoring "
                                        "'force' parameter for unknown chip "
                                        "at adapter %d, address 0x%02x.\n",
-                                        i2c_adapter_id(adapter), address);
+                                        i2c_adapter_id(adapter), client->addr);
-                        err = -ENODEV;
+                        return -ENODEV;
-                        goto ERROR1;
                }
        }
-        /* Fill in remaining client fields and put it into the global list */
+        strlcpy(info->type, "asb100", I2C_NAME_SIZE);
-        strlcpy(client->name, "asb100", I2C_NAME_SIZE);
-        data->type = kind;
-        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
+        return 0;
-        if ((err = i2c_attach_client(client)))
+}
-                goto ERROR1;
+static int asb100_probe(struct i2c_client *client,
+                        const struct i2c_device_id *id)
+{
+        int err;
+        struct asb100_data *data;
+        data = kzalloc(sizeof(struct asb100_data), GFP_KERNEL);
+        if (!data) {
+                pr_debug("asb100.o: probe failed, kzalloc failed!\n");
+                err = -ENOMEM;
+                goto ERROR0;
+        }
+        i2c_set_clientdata(client, data);
+        mutex_init(&data->lock);
+        mutex_init(&data->update_lock);
        /* Attach secondary lm75 clients */
-        if ((err = asb100_detect_subclients(adapter, address, kind,
+        err = asb100_detect_subclients(client);
-                        client)))
+        if (err)
-                goto ERROR2;
+                goto ERROR1;
        /* Initialize the chip */
        asb100_init_client(client);
@@ -827,39 +800,25 @@ static int asb100_detect(struct i2c_adapter *adapter, int address, int kind)
 ERROR4:
        sysfs_remove_group(&client->dev.kobj, &asb100_group);
 ERROR3:
-        i2c_detach_client(data->lm75[1]);
+        i2c_unregister_device(data->lm75[1]);
-        i2c_detach_client(data->lm75[0]);
+        i2c_unregister_device(data->lm75[0]);
-        kfree(data->lm75[1]);
-        kfree(data->lm75[0]);
-ERROR2:
-        i2c_detach_client(client);
 ERROR1:
        kfree(data);
 ERROR0:
        return err;
 }
-static int asb100_detach_client(struct i2c_client *client)
+static int asb100_remove(struct i2c_client *client)
 {
        struct asb100_data *data = i2c_get_clientdata(client);
-        int err;
-        /* main client */
-        if (data) {
-                hwmon_device_unregister(data->hwmon_dev);
-                sysfs_remove_group(&client->dev.kobj, &asb100_group);
-        }
-        if ((err = i2c_detach_client(client)))
+        hwmon_device_unregister(data->hwmon_dev);
-                return err;
+        sysfs_remove_group(&client->dev.kobj, &asb100_group);
-        /* main client */
+        i2c_unregister_device(data->lm75[1]);
-        if (data)
+        i2c_unregister_device(data->lm75[0]);
-                kfree(data);
-        /* subclient */
+        kfree(data);
-        else
-                kfree(client);
        return 0;
 }
diff --git a/drivers/hwmon/atxp1.c b/drivers/hwmon/atxp1.c
index 01c17e387f03..d191118ba0cb 100644
--- a/drivers/hwmon/atxp1.c
+++ b/drivers/hwmon/atxp1.c
@@ -46,21 +46,32 @@ static const unsigned short normal_i2c[] = { 0x37, 0x4e, I2C_CLIENT_END };
 I2C_CLIENT_INSMOD_1(atxp1);
-static int atxp1_attach_adapter(struct i2c_adapter * adapter);
+static int atxp1_probe(struct i2c_client *client,
-static int atxp1_detach_client(struct i2c_client * client);
+                       const struct i2c_device_id *id);
+static int atxp1_remove(struct i2c_client *client);
 static struct atxp1_data * atxp1_update_device(struct device *dev);
-static int atxp1_detect(struct i2c_adapter *adapter, int address, int kind);
+static int atxp1_detect(struct i2c_client *client, int kind,
+                        struct i2c_board_info *info);
+static const struct i2c_device_id atxp1_id[] = {
+        { "atxp1", atxp1 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, atxp1_id);
 static struct i2c_driver atxp1_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "atxp1",
        },
-        .attach_adapter = atxp1_attach_adapter,
+        .probe          = atxp1_probe,
-        .detach_client  = atxp1_detach_client,
+        .remove         = atxp1_remove,
+        .id_table       = atxp1_id,
+        .detect         = atxp1_detect,
+        .address_data   = &addr_data,
 };
 struct atxp1_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        unsigned long last_updated;
@@ -263,35 +274,16 @@ static const struct attribute_group atxp1_group = {
 };
-static int atxp1_attach_adapter(struct i2c_adapter *adapter)
+/* Return 0 if detection is successful, -ENODEV otherwise */
+static int atxp1_detect(struct i2c_client *new_client, int kind,
+                        struct i2c_board_info *info)
 {
-        if (!(adapter->class & I2C_CLASS_HWMON))
+        struct i2c_adapter *adapter = new_client->adapter;
-                return 0;
-        return i2c_probe(adapter, &addr_data, &atxp1_detect);
-};
-static int atxp1_detect(struct i2c_adapter *adapter, int address, int kind)
-{
-        struct i2c_client * new_client;
-        struct atxp1_data * data;
-        int err = 0;
        u8 temp;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
-                goto exit;
+                return -ENODEV;
-        if (!(data = kzalloc(sizeof(struct atxp1_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        new_client = &data->client;
-        i2c_set_clientdata(new_client, data);
-        new_client->addr = address;
-        new_client->adapter = adapter;
-        new_client->driver = &atxp1_driver;
-        new_client->flags = 0;
        /* Detect ATXP1, checking if vendor ID registers are all zero */
        if (!((i2c_smbus_read_byte_data(new_client, 0x3e) == 0) &&
@@ -305,35 +297,46 @@ static int atxp1_detect(struct i2c_adapter *adapter, int address, int kind)
                if (!((i2c_smbus_read_byte_data(new_client, 0x10) == temp) &&
                         (i2c_smbus_read_byte_data(new_client, 0x11) == temp) ))
-                        goto exit_free;
+                        return -ENODEV;
        }
        /* Get VRM */
-        data->vrm = vid_which_vrm();
+        temp = vid_which_vrm();
-        if ((data->vrm != 90) && (data->vrm != 91)) {
+        if ((temp != 90) && (temp != 91)) {
-                dev_err(&new_client->dev, "Not supporting VRM %d.%d\n",
+                dev_err(&adapter->dev, "atxp1: Not supporting VRM %d.%d\n",
-                                data->vrm / 10, data->vrm % 10);
+                                temp / 10, temp % 10);
-                goto exit_free;
+                return -ENODEV;
        }
-        strncpy(new_client->name, "atxp1", I2C_NAME_SIZE);
+        strlcpy(info->type, "atxp1", I2C_NAME_SIZE);
-        data->valid = 0;
-        mutex_init(&data->update_lock);
+        return 0;
+}
-        err = i2c_attach_client(new_client);
+static int atxp1_probe(struct i2c_client *new_client,
+                       const struct i2c_device_id *id)
+{
+        struct atxp1_data *data;
+        int err;
-        if (err)
+        data = kzalloc(sizeof(struct atxp1_data), GFP_KERNEL);
-        {
+        if (!data) {
-                dev_err(&new_client->dev, "Attach client error.\n");
+                err = -ENOMEM;
-                goto exit_free;
+                goto exit;
        }
+        /* Get VRM */
+        data->vrm = vid_which_vrm();
+        i2c_set_clientdata(new_client, data);
+        data->valid = 0;
+        mutex_init(&data->update_lock);
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&new_client->dev.kobj, &atxp1_group)))
-                goto exit_detach;
+                goto exit_free;
        data->hwmon_dev = hwmon_device_register(&new_client->dev);
        if (IS_ERR(data->hwmon_dev)) {
@@ -348,30 +351,22 @@ static int atxp1_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove_files:
        sysfs_remove_group(&new_client->dev.kobj, &atxp1_group);
-exit_detach:
-        i2c_detach_client(new_client);
 exit_free:
        kfree(data);
 exit:
        return err;
 };
-static int atxp1_detach_client(struct i2c_client * client)
+static int atxp1_remove(struct i2c_client *client)
 {
        struct atxp1_data * data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &atxp1_group);
-        err = i2c_detach_client(client);
+        kfree(data);
-        if (err)
-                dev_err(&client->dev, "Failed to detach client.\n");
-        else
-                kfree(data);
-        return err;
+        return 0;
 };
 static int __init atxp1_init(void)
diff --git a/drivers/hwmon/ds1621.c b/drivers/hwmon/ds1621.c
index 5f300ffed657..7415381601c3 100644
--- a/drivers/hwmon/ds1621.c
+++ b/drivers/hwmon/ds1621.c
@@ -72,7 +72,6 @@ static const u8 DS1621_REG_TEMP[3] = {
 /* Each client has this additional data */
 struct ds1621_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid;                     /* !=0 if following fields are valid */
@@ -82,20 +81,32 @@ struct ds1621_data {
        u8 conf;                        /* Register encoding, combined */
 };
-static int ds1621_attach_adapter(struct i2c_adapter *adapter);
+static int ds1621_probe(struct i2c_client *client,
-static int ds1621_detect(struct i2c_adapter *adapter, int address,
+                        const struct i2c_device_id *id);
-                         int kind);
+static int ds1621_detect(struct i2c_client *client, int kind,
+                         struct i2c_board_info *info);
 static void ds1621_init_client(struct i2c_client *client);
-static int ds1621_detach_client(struct i2c_client *client);
+static int ds1621_remove(struct i2c_client *client);
 static struct ds1621_data *ds1621_update_client(struct device *dev);
+static const struct i2c_device_id ds1621_id[] = {
+        { "ds1621", ds1621 },
+        { "ds1625", ds1621 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, ds1621_id);
 /* This is the driver that will be inserted */
 static struct i2c_driver ds1621_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "ds1621",
        },
-        .attach_adapter = ds1621_attach_adapter,
+        .probe          = ds1621_probe,
-        .detach_client  = ds1621_detach_client,
+        .remove         = ds1621_remove,
+        .id_table       = ds1621_id,
+        .detect         = ds1621_detect,
+        .address_data   = &addr_data,
 };
 /* All registers are word-sized, except for the configuration register.
@@ -199,40 +210,18 @@ static const struct attribute_group ds1621_group = {
 };
-static int ds1621_attach_adapter(struct i2c_adapter *adapter)
+/* Return 0 if detection is successful, -ENODEV otherwise */
-{
+static int ds1621_detect(struct i2c_client *client, int kind,
-        if (!(adapter->class & I2C_CLASS_HWMON))
+                         struct i2c_board_info *info)
-                return 0;
-        return i2c_probe(adapter, &addr_data, ds1621_detect);
-}
-/* This function is called by i2c_probe */
-static int ds1621_detect(struct i2c_adapter *adapter, int address,
-                         int kind)
 {
+        struct i2c_adapter *adapter = client->adapter;
        int conf, temp;
-        struct i2c_client *client;
+        int i;
-        struct ds1621_data *data;
-        int i, err = 0;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA 
                                     | I2C_FUNC_SMBUS_WORD_DATA 
                                     | I2C_FUNC_SMBUS_WRITE_BYTE))
-                goto exit;
+                return -ENODEV;
-        /* OK. For now, we presume we have a valid client. We now create the
-           client structure, even though we cannot fill it completely yet.
-           But it allows us to access ds1621_{read,write}_value. */
-        if (!(data = kzalloc(sizeof(struct ds1621_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        
-        client = &data->client;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &ds1621_driver;
        /* Now, we do the remaining detection. It is lousy. */
        if (kind < 0) {
@@ -241,29 +230,41 @@ static int ds1621_detect(struct i2c_adapter *adapter, int address,
                   improbable in our case. */
                conf = ds1621_read_value(client, DS1621_REG_CONF);
                if (conf & DS1621_REG_CONFIG_NVB)
-                        goto exit_free;
+                        return -ENODEV;
                /* The 7 lowest bits of a temperature should always be 0. */
-                for (i = 0; i < ARRAY_SIZE(data->temp); i++) {
+                for (i = 0; i < ARRAY_SIZE(DS1621_REG_TEMP); i++) {
                        temp = ds1621_read_value(client, DS1621_REG_TEMP[i]);
                        if (temp & 0x007f)
-                                goto exit_free;
+                                return -ENODEV;
                }
        }
-        /* Fill in remaining client fields and put it into the global list */
+        strlcpy(info->type, "ds1621", I2C_NAME_SIZE);
-        strlcpy(client->name, "ds1621", I2C_NAME_SIZE);
-        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
+        return 0;
-        if ((err = i2c_attach_client(client)))
+}
-                goto exit_free;
+static int ds1621_probe(struct i2c_client *client,
+                        const struct i2c_device_id *id)
+{
+        struct ds1621_data *data;
+        int err;
+        data = kzalloc(sizeof(struct ds1621_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(client, data);
+        mutex_init(&data->update_lock);
        /* Initialize the DS1621 chip */
        ds1621_init_client(client);
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&client->dev.kobj, &ds1621_group)))
-                goto exit_detach;
+                goto exit_free;
        data->hwmon_dev = hwmon_device_register(&client->dev);
        if (IS_ERR(data->hwmon_dev)) {
@@ -275,25 +276,19 @@ static int ds1621_detect(struct i2c_adapter *adapter, int address,
      exit_remove_files:
        sysfs_remove_group(&client->dev.kobj, &ds1621_group);
-      exit_detach:
-        i2c_detach_client(client);
      exit_free:
        kfree(data);
      exit:
        return err;
 }
-static int ds1621_detach_client(struct i2c_client *client)
+static int ds1621_remove(struct i2c_client *client)
 {
        struct ds1621_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &ds1621_group);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
diff --git a/drivers/hwmon/f75375s.c b/drivers/hwmon/f75375s.c
index dc1f30e432ea..1692de369969 100644
--- a/drivers/hwmon/f75375s.c
+++ b/drivers/hwmon/f75375s.c
@@ -87,7 +87,6 @@ I2C_CLIENT_INSMOD_2(f75373, f75375);
 struct f75375_data {
        unsigned short addr;
-        struct i2c_client *client;
        struct device *hwmon_dev;
        const char *name;
@@ -114,21 +113,12 @@ struct f75375_data {
        s8 temp_max_hyst[2];
 };
-static int f75375_attach_adapter(struct i2c_adapter *adapter);
+static int f75375_detect(struct i2c_client *client, int kind,
-static int f75375_detect(struct i2c_adapter *adapter, int address, int kind);
+                         struct i2c_board_info *info);
-static int f75375_detach_client(struct i2c_client *client);
 static int f75375_probe(struct i2c_client *client,
                        const struct i2c_device_id *id);
 static int f75375_remove(struct i2c_client *client);
-static struct i2c_driver f75375_legacy_driver = {
-        .driver = {
-                .name = "f75375_legacy",
-        },
-        .attach_adapter = f75375_attach_adapter,
-        .detach_client = f75375_detach_client,
-};
 static const struct i2c_device_id f75375_id[] = {
        { "f75373", f75373 },
        { "f75375", f75375 },
@@ -137,12 +127,15 @@ static const struct i2c_device_id f75375_id[] = {
 MODULE_DEVICE_TABLE(i2c, f75375_id);
 static struct i2c_driver f75375_driver = {
+        .class = I2C_CLASS_HWMON,
        .driver = {
                .name = "f75375",
        },
        .probe = f75375_probe,
        .remove = f75375_remove,
        .id_table = f75375_id,
+        .detect = f75375_detect,
+        .address_data = &addr_data,
 };
 static inline int f75375_read8(struct i2c_client *client, u8 reg)
@@ -607,22 +600,6 @@ static const struct attribute_group f75375_group = {
        .attrs = f75375_attributes,
 };
-static int f75375_detach_client(struct i2c_client *client)
-{
-        int err;
-        f75375_remove(client);
-        err = i2c_detach_client(client);
-        if (err) {
-                dev_err(&client->dev,
-                        "Client deregistration failed, "
-                        "client not detached.\n");
-                return err;
-        }
-        kfree(client);
-        return 0;
-}
 static void f75375_init(struct i2c_client *client, struct f75375_data *data,
                struct f75375s_platform_data *f75375s_pdata)
 {
@@ -651,7 +628,6 @@ static int f75375_probe(struct i2c_client *client,
                return -ENOMEM;
        i2c_set_clientdata(client, data);
-        data->client = client;
        mutex_init(&data->update_lock);
        data->kind = id->driver_data;
@@ -700,29 +676,13 @@ static int f75375_remove(struct i2c_client *client)
        return 0;
 }
-static int f75375_attach_adapter(struct i2c_adapter *adapter)
+/* Return 0 if detection is successful, -ENODEV otherwise */
-{
+static int f75375_detect(struct i2c_client *client, int kind,
-        if (!(adapter->class & I2C_CLASS_HWMON))
+                         struct i2c_board_info *info)
-                return 0;
-        return i2c_probe(adapter, &addr_data, f75375_detect);
-}
-/* This function is called by i2c_probe */
-static int f75375_detect(struct i2c_adapter *adapter, int address, int kind)
 {
-        struct i2c_client *client;
+        struct i2c_adapter *adapter = client->adapter;
        u8 version = 0;
-        int err = 0;
        const char *name = "";
-        struct i2c_device_id id;
-        if (!(client = kzalloc(sizeof(*client), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &f75375_legacy_driver;
        if (kind < 0) {
                u16 vendid = f75375_read16(client, F75375_REG_VENDOR);
@@ -736,7 +696,7 @@ static int f75375_detect(struct i2c_adapter *adapter, int address, int kind)
                        dev_err(&adapter->dev,
                                "failed,%02X,%02X,%02X\n",
                                chipid, version, vendid);
-                        goto exit_free;
+                        return -ENODEV;
                }
        }
@@ -746,43 +706,18 @@ static int f75375_detect(struct i2c_adapter *adapter, int address, int kind)
                name = "f75373";
        }
        dev_info(&adapter->dev, "found %s version: %02X\n", name, version);
-        strlcpy(client->name, name, I2C_NAME_SIZE);
+        strlcpy(info->type, name, I2C_NAME_SIZE);
-        if ((err = i2c_attach_client(client)))
-                goto exit_free;
-        strlcpy(id.name, name, I2C_NAME_SIZE);
-        id.driver_data = kind;
-        if ((err = f75375_probe(client, &id)) < 0)
-                goto exit_detach;
        return 0;
-exit_detach:
-        i2c_detach_client(client);
-exit_free:
-        kfree(client);
-exit:
-        return err;
 }
 static int __init sensors_f75375_init(void)
 {
-        int status;
+        return i2c_add_driver(&f75375_driver);
-        status = i2c_add_driver(&f75375_driver);
-        if (status)
-                return status;
-        status = i2c_add_driver(&f75375_legacy_driver);
-        if (status)
-                i2c_del_driver(&f75375_driver);
-        return status;
 }
 static void __exit sensors_f75375_exit(void)
 {
-        i2c_del_driver(&f75375_legacy_driver);
        i2c_del_driver(&f75375_driver);
 }
diff --git a/drivers/hwmon/fscher.c b/drivers/hwmon/fscher.c
index ed26b66e0831..12c70e402cb2 100644
--- a/drivers/hwmon/fscher.c
+++ b/drivers/hwmon/fscher.c
@@ -106,9 +106,11 @@ I2C_CLIENT_INSMOD_1(fscher);
 * Functions declaration
 */
-static int fscher_attach_adapter(struct i2c_adapter *adapter);
+static int fscher_probe(struct i2c_client *client,
-static int fscher_detect(struct i2c_adapter *adapter, int address, int kind);
+                        const struct i2c_device_id *id);
-static int fscher_detach_client(struct i2c_client *client);
+static int fscher_detect(struct i2c_client *client, int kind,
+                         struct i2c_board_info *info);
+static int fscher_remove(struct i2c_client *client);
 static struct fscher_data *fscher_update_device(struct device *dev);
 static void fscher_init_client(struct i2c_client *client);
@@ -119,12 +121,21 @@ static int fscher_write_value(struct i2c_client *client, u8 reg, u8 value);
 * Driver data (common to all clients)
 */
 
+static const struct i2c_device_id fscher_id[] = {
+        { "fscher", fscher },
+        { }
+};
 static struct i2c_driver fscher_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "fscher",
        },
-        .attach_adapter = fscher_attach_adapter,
+        .probe          = fscher_probe,
-        .detach_client  = fscher_detach_client,
+        .remove         = fscher_remove,
+        .id_table       = fscher_id,
+        .detect         = fscher_detect,
+        .address_data   = &addr_data,
 };
 /*
@@ -132,7 +143,6 @@ static struct i2c_driver fscher_driver = {
 */
 struct fscher_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid; /* zero until following fields are valid */
@@ -283,38 +293,14 @@ static const struct attribute_group fscher_group = {
 * Real code
 */
-static int fscher_attach_adapter(struct i2c_adapter *adapter)
+/* Return 0 if detection is successful, -ENODEV otherwise */
-{
+static int fscher_detect(struct i2c_client *new_client, int kind,
-        if (!(adapter->class & I2C_CLASS_HWMON))
+                         struct i2c_board_info *info)
-                return 0;
-        return i2c_probe(adapter, &addr_data, fscher_detect);
-}
-static int fscher_detect(struct i2c_adapter *adapter, int address, int kind)
 {
-        struct i2c_client *new_client;
+        struct i2c_adapter *adapter = new_client->adapter;
-        struct fscher_data *data;
-        int err = 0;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
-                goto exit;
+                return -ENODEV;
-        /* OK. For now, we presume we have a valid client. We now create the
-         * client structure, even though we cannot fill it completely yet.
-         * But it allows us to access i2c_smbus_read_byte_data. */
-        if (!(data = kzalloc(sizeof(struct fscher_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        /* The common I2C client data is placed right before the
-         * Hermes-specific data. */
-        new_client = &data->client;
-        i2c_set_clientdata(new_client, data);
-        new_client->addr = address;
-        new_client->adapter = adapter;
-        new_client->driver = &fscher_driver;
-        new_client->flags = 0;
        /* Do the remaining detection unless force or force_fscher parameter */
        if (kind < 0) {
@@ -324,24 +310,35 @@ static int fscher_detect(struct i2c_adapter *adapter, int address, int kind)
                     FSCHER_REG_IDENT_1) != 0x45)       /* 'E' */
                 || (i2c_smbus_read_byte_data(new_client,
                     FSCHER_REG_IDENT_2) != 0x52))      /* 'R' */
-                        goto exit_free;
+                        return -ENODEV;
+        }
+        strlcpy(info->type, "fscher", I2C_NAME_SIZE);
+        return 0;
+}
+static int fscher_probe(struct i2c_client *new_client,
+                        const struct i2c_device_id *id)
+{
+        struct fscher_data *data;
+        int err;
+        data = kzalloc(sizeof(struct fscher_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
        }
-        /* Fill in the remaining client fields and put it into the
+        i2c_set_clientdata(new_client, data);
-         * global list */
-        strlcpy(new_client->name, "fscher", I2C_NAME_SIZE);
        data->valid = 0;
        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
-        if ((err = i2c_attach_client(new_client)))
-                goto exit_free;
        fscher_init_client(new_client);
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&new_client->dev.kobj, &fscher_group)))
-                goto exit_detach;
+                goto exit_free;
        data->hwmon_dev = hwmon_device_register(&new_client->dev);
        if (IS_ERR(data->hwmon_dev)) {
@@ -353,25 +350,19 @@ static int fscher_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove_files:
        sysfs_remove_group(&new_client->dev.kobj, &fscher_group);
-exit_detach:
-        i2c_detach_client(new_client);
 exit_free:
        kfree(data);
 exit:
        return err;
 }
-static int fscher_detach_client(struct i2c_client *client)
+static int fscher_remove(struct i2c_client *client)
 {
        struct fscher_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &fscher_group);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/fschmd.c b/drivers/hwmon/fschmd.c
index bd89d270a5ed..967170368933 100644
--- a/drivers/hwmon/fschmd.c
+++ b/drivers/hwmon/fschmd.c
@@ -171,20 +171,37 @@ static const int FSCHMD_NO_TEMP_SENSORS[5] = { 3, 3, 4, 3, 5 };
 * Functions declarations
 */
-static int fschmd_attach_adapter(struct i2c_adapter *adapter);
+static int fschmd_probe(struct i2c_client *client,
-static int fschmd_detach_client(struct i2c_client *client);
+                        const struct i2c_device_id *id);
+static int fschmd_detect(struct i2c_client *client, int kind,
+                         struct i2c_board_info *info);
+static int fschmd_remove(struct i2c_client *client);
 static struct fschmd_data *fschmd_update_device(struct device *dev);
 /*
 * Driver data (common to all clients)
 */
+static const struct i2c_device_id fschmd_id[] = {
+        { "fscpos", fscpos },
+        { "fscher", fscher },
+        { "fscscy", fscscy },
+        { "fschrc", fschrc },
+        { "fschmd", fschmd },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, fschmd_id);
 static struct i2c_driver fschmd_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = FSCHMD_NAME,
        },
-        .attach_adapter = fschmd_attach_adapter,
+        .probe          = fschmd_probe,
-        .detach_client  = fschmd_detach_client,
+        .remove         = fschmd_remove,
+        .id_table       = fschmd_id,
+        .detect         = fschmd_detect,
+        .address_data   = &addr_data,
 };
 /*
@@ -192,7 +209,6 @@ static struct i2c_driver fschmd_driver = {
 */
 struct fschmd_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        int kind;
@@ -269,7 +285,7 @@ static ssize_t store_temp_max(struct device *dev, struct device_attribute
        v = SENSORS_LIMIT(v, -128, 127) + 128;
        mutex_lock(&data->update_lock);
-        i2c_smbus_write_byte_data(&data->client,
+        i2c_smbus_write_byte_data(to_i2c_client(dev),
                FSCHMD_REG_TEMP_LIMIT[data->kind][index], v);
        data->temp_max[index] = v;
        mutex_unlock(&data->update_lock);
@@ -346,14 +362,14 @@ static ssize_t store_fan_div(struct device *dev, struct device_attribute
        mutex_lock(&data->update_lock);
-        reg = i2c_smbus_read_byte_data(&data->client,
+        reg = i2c_smbus_read_byte_data(to_i2c_client(dev),
                FSCHMD_REG_FAN_RIPPLE[data->kind][index]);
        /* bits 2..7 reserved => mask with 0x03 */
        reg &= ~0x03;
        reg |= v;
-        i2c_smbus_write_byte_data(&data->client,
+        i2c_smbus_write_byte_data(to_i2c_client(dev),
                FSCHMD_REG_FAN_RIPPLE[data->kind][index], reg);
        data->fan_ripple[index] = reg;
@@ -416,7 +432,7 @@ static ssize_t store_pwm_auto_point1_pwm(struct device *dev,
        mutex_lock(&data->update_lock);
-        i2c_smbus_write_byte_data(&data->client,
+        i2c_smbus_write_byte_data(to_i2c_client(dev),
                FSCHMD_REG_FAN_MIN[data->kind][index], v);
        data->fan_min[index] = v;
@@ -448,14 +464,14 @@ static ssize_t store_alert_led(struct device *dev,
        mutex_lock(&data->update_lock);
-        reg = i2c_smbus_read_byte_data(&data->client, FSCHMD_REG_CONTROL);
+        reg = i2c_smbus_read_byte_data(to_i2c_client(dev), FSCHMD_REG_CONTROL);
        if (v)
                reg |= FSCHMD_CONTROL_ALERT_LED_MASK;
        else
                reg &= ~FSCHMD_CONTROL_ALERT_LED_MASK;
-        i2c_smbus_write_byte_data(&data->client, FSCHMD_REG_CONTROL, reg);
+        i2c_smbus_write_byte_data(to_i2c_client(dev), FSCHMD_REG_CONTROL, reg);
        data->global_control = reg;
@@ -600,32 +616,15 @@ static void fschmd_dmi_decode(const struct dmi_header *header)
        }
 }
-static int fschmd_detect(struct i2c_adapter *adapter, int address, int kind)
+static int fschmd_detect(struct i2c_client *client, int kind,
+                         struct i2c_board_info *info)
 {
-        struct i2c_client *client;
+        struct i2c_adapter *adapter = client->adapter;
-        struct fschmd_data *data;
-        u8 revision;
-        const char * const names[5] = { "Poseidon", "Hermes", "Scylla",
-                                        "Heracles", "Heimdall" };
        const char * const client_names[5] = { "fscpos", "fscher", "fscscy",
                                                "fschrc", "fschmd" };
-        int i, err = 0;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
-                return 0;
+                return -ENODEV;
-        /* OK. For now, we presume we have a valid client. We now create the
-         * client structure, even though we cannot fill it completely yet.
-         * But it allows us to access i2c_smbus_read_byte_data. */
-        if (!(data = kzalloc(sizeof(struct fschmd_data), GFP_KERNEL)))
-                return -ENOMEM;
-        client = &data->client;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &fschmd_driver;
-        mutex_init(&data->update_lock);
        /* Detect & Identify the chip */
        if (kind <= 0) {
@@ -650,9 +649,31 @@ static int fschmd_detect(struct i2c_adapter *adapter, int address, int kind)
                else if (!strcmp(id, "HMD"))
                        kind = fschmd;
                else
-                        goto exit_free;
+                        return -ENODEV;
        }
+        strlcpy(info->type, client_names[kind - 1], I2C_NAME_SIZE);
+        return 0;
+}
+static int fschmd_probe(struct i2c_client *client,
+                        const struct i2c_device_id *id)
+{
+        struct fschmd_data *data;
+        u8 revision;
+        const char * const names[5] = { "Poseidon", "Hermes", "Scylla",
+                                        "Heracles", "Heimdall" };
+        int i, err;
+        enum chips kind = id->driver_data;
+        data = kzalloc(sizeof(struct fschmd_data), GFP_KERNEL);
+        if (!data)
+                return -ENOMEM;
+        i2c_set_clientdata(client, data);
+        mutex_init(&data->update_lock);
        if (kind == fscpos) {
                /* The Poseidon has hardwired temp limits, fill these
                   in for the alarm resetting code */
@@ -674,11 +695,6 @@ static int fschmd_detect(struct i2c_adapter *adapter, int address, int kind)
        /* i2c kind goes from 1-5, we want from 0-4 to address arrays */
        data->kind = kind - 1;
-        strlcpy(client->name, client_names[data->kind], I2C_NAME_SIZE);
-        /* Tell the I2C layer a new client has arrived */
-        if ((err = i2c_attach_client(client)))
-                goto exit_free;
        for (i = 0; i < ARRAY_SIZE(fschmd_attr); i++) {
                err = device_create_file(&client->dev,
@@ -726,25 +742,14 @@ static int fschmd_detect(struct i2c_adapter *adapter, int address, int kind)
        return 0;
 exit_detach:
-        fschmd_detach_client(client); /* will also free data for us */
+        fschmd_remove(client); /* will also free data for us */
-        return err;
-exit_free:
-        kfree(data);
        return err;
 }
-static int fschmd_attach_adapter(struct i2c_adapter *adapter)
+static int fschmd_remove(struct i2c_client *client)
-{
-        if (!(adapter->class & I2C_CLASS_HWMON))
-                return 0;
-        return i2c_probe(adapter, &addr_data, fschmd_detect);
-}
-static int fschmd_detach_client(struct i2c_client *client)
 {
        struct fschmd_data *data = i2c_get_clientdata(client);
-        int i, err;
+        int i;
        /* Check if registered in case we're called from fschmd_detect
           to cleanup after an error */
@@ -760,9 +765,6 @@ static int fschmd_detach_client(struct i2c_client *client)
                device_remove_file(&client->dev,
                                        &fschmd_fan_attr[i].dev_attr);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/fscpos.c b/drivers/hwmon/fscpos.c
index 00f48484e54b..8a7bcf500b4e 100644
--- a/drivers/hwmon/fscpos.c
+++ b/drivers/hwmon/fscpos.c
@@ -87,9 +87,11 @@ static u8 FSCPOS_REG_TEMP_STATE[] = { 0x71, 0x81, 0x91 };
 /*
 * Functions declaration
 */
-static int fscpos_attach_adapter(struct i2c_adapter *adapter);
+static int fscpos_probe(struct i2c_client *client,
-static int fscpos_detect(struct i2c_adapter *adapter, int address, int kind);
+                        const struct i2c_device_id *id);
-static int fscpos_detach_client(struct i2c_client *client);
+static int fscpos_detect(struct i2c_client *client, int kind,
+                         struct i2c_board_info *info);
+static int fscpos_remove(struct i2c_client *client);
 static int fscpos_read_value(struct i2c_client *client, u8 reg);
 static int fscpos_write_value(struct i2c_client *client, u8 reg, u8 value);
@@ -101,19 +103,27 @@ static void reset_fan_alarm(struct i2c_client *client, int nr);
 /*
 * Driver data (common to all clients)
 */
+static const struct i2c_device_id fscpos_id[] = {
+        { "fscpos", fscpos },
+        { }
+};
 static struct i2c_driver fscpos_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "fscpos",
        },
-        .attach_adapter = fscpos_attach_adapter,
+        .probe          = fscpos_probe,
-        .detach_client  = fscpos_detach_client,
+        .remove         = fscpos_remove,
+        .id_table       = fscpos_id,
+        .detect         = fscpos_detect,
+        .address_data   = &addr_data,
 };
 /*
 * Client data (each client gets its own)
 */
 struct fscpos_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid;             /* 0 until following fields are valid */
@@ -470,39 +480,14 @@ static const struct attribute_group fscpos_group = {
        .attrs = fscpos_attributes,
 };
-static int fscpos_attach_adapter(struct i2c_adapter *adapter)
+/* Return 0 if detection is successful, -ENODEV otherwise */
-{
+static int fscpos_detect(struct i2c_client *new_client, int kind,
-        if (!(adapter->class & I2C_CLASS_HWMON))
+                         struct i2c_board_info *info)
-                return 0;
-        return i2c_probe(adapter, &addr_data, fscpos_detect);
-}
-static int fscpos_detect(struct i2c_adapter *adapter, int address, int kind)
 {
-        struct i2c_client *new_client;
+        struct i2c_adapter *adapter = new_client->adapter;
-        struct fscpos_data *data;
-        int err = 0;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
-                goto exit;
+                return -ENODEV;
-        /*
-         * OK. For now, we presume we have a valid client. We now create the
-         * client structure, even though we cannot fill it completely yet.
-         * But it allows us to access fscpos_{read,write}_value.
-         */
-        if (!(data = kzalloc(sizeof(struct fscpos_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        new_client = &data->client;
-        i2c_set_clientdata(new_client, data);
-        new_client->addr = address;
-        new_client->adapter = adapter;
-        new_client->driver = &fscpos_driver;
-        new_client->flags = 0;
        /* Do the remaining detection unless force or force_fscpos parameter */
        if (kind < 0) {
@@ -512,22 +497,30 @@ static int fscpos_detect(struct i2c_adapter *adapter, int address, int kind)
                        != 0x45) /* 'E' */
                || (fscpos_read_value(new_client, FSCPOS_REG_IDENT_2)
                        != 0x47))/* 'G' */
-                {
+                        return -ENODEV;
-                        dev_dbg(&new_client->dev, "fscpos detection failed\n");
-                        goto exit_free;
-                }
        }
-        /* Fill in the remaining client fields and put it in the global list */
+        strlcpy(info->type, "fscpos", I2C_NAME_SIZE);
-        strlcpy(new_client->name, "fscpos", I2C_NAME_SIZE);
+        return 0;
+}
+static int fscpos_probe(struct i2c_client *new_client,
+                        const struct i2c_device_id *id)
+{
+        struct fscpos_data *data;
+        int err;
+        data = kzalloc(sizeof(struct fscpos_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(new_client, data);
        data->valid = 0;
        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
-        if ((err = i2c_attach_client(new_client)))
-                goto exit_free;
        /* Inizialize the fscpos chip */
        fscpos_init_client(new_client);
@@ -536,7 +529,7 @@ static int fscpos_detect(struct i2c_adapter *adapter, int address, int kind)
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&new_client->dev.kobj, &fscpos_group)))
-                goto exit_detach;
+                goto exit_free;
        data->hwmon_dev = hwmon_device_register(&new_client->dev);
        if (IS_ERR(data->hwmon_dev)) {
@@ -548,24 +541,19 @@ static int fscpos_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove_files:
        sysfs_remove_group(&new_client->dev.kobj, &fscpos_group);
-exit_detach:
-        i2c_detach_client(new_client);
 exit_free:
        kfree(data);
 exit:
        return err;
 }
-static int fscpos_detach_client(struct i2c_client *client)
+static int fscpos_remove(struct i2c_client *client)
 {
        struct fscpos_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &fscpos_group);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/gl518sm.c b/drivers/hwmon/gl518sm.c
index 33e9e8a8d1ce..7820df45d77a 100644
--- a/drivers/hwmon/gl518sm.c
+++ b/drivers/hwmon/gl518sm.c
@@ -114,7 +114,6 @@ static inline u8 FAN_TO_REG(long rpm, int div)
 /* Each client has this additional data */
 struct gl518_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        enum chips type;
@@ -138,21 +137,33 @@ struct gl518_data {
        u8 beep_enable;         /* Boolean */
 };
-static int gl518_attach_adapter(struct i2c_adapter *adapter);
+static int gl518_probe(struct i2c_client *client,
-static int gl518_detect(struct i2c_adapter *adapter, int address, int kind);
+                       const struct i2c_device_id *id);
+static int gl518_detect(struct i2c_client *client, int kind,
+                        struct i2c_board_info *info);
 static void gl518_init_client(struct i2c_client *client);
-static int gl518_detach_client(struct i2c_client *client);
+static int gl518_remove(struct i2c_client *client);
 static int gl518_read_value(struct i2c_client *client, u8 reg);
 static int gl518_write_value(struct i2c_client *client, u8 reg, u16 value);
 static struct gl518_data *gl518_update_device(struct device *dev);
+static const struct i2c_device_id gl518_id[] = {
+        { "gl518sm", 0 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, gl518_id);
 /* This is the driver that will be inserted */
 static struct i2c_driver gl518_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "gl518sm",
        },
-        .attach_adapter = gl518_attach_adapter,
+        .probe          = gl518_probe,
-        .detach_client  = gl518_detach_client,
+        .remove         = gl518_remove,
+        .id_table       = gl518_id,
+        .detect         = gl518_detect,
+        .address_data   = &addr_data,
 };
 /*
@@ -472,46 +483,23 @@ static const struct attribute_group gl518_group_r80 = {
 * Real code
 */
-static int gl518_attach_adapter(struct i2c_adapter *adapter)
+/* Return 0 if detection is successful, -ENODEV otherwise */
-{
+static int gl518_detect(struct i2c_client *client, int kind,
-        if (!(adapter->class & I2C_CLASS_HWMON))
+                        struct i2c_board_info *info)
-                return 0;
-        return i2c_probe(adapter, &addr_data, gl518_detect);
-}
-static int gl518_detect(struct i2c_adapter *adapter, int address, int kind)
 {
+        struct i2c_adapter *adapter = client->adapter;
        int i;
-        struct i2c_client *client;
-        struct gl518_data *data;
-        int err = 0;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA |
                                     I2C_FUNC_SMBUS_WORD_DATA))
-                goto exit;
+                return -ENODEV;
-        /* OK. For now, we presume we have a valid client. We now create the
-           client structure, even though we cannot fill it completely yet.
-           But it allows us to access gl518_{read,write}_value. */
-        if (!(data = kzalloc(sizeof(struct gl518_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        client = &data->client;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &gl518_driver;
        /* Now, we do the remaining detection. */
        if (kind < 0) {
                if ((gl518_read_value(client, GL518_REG_CHIP_ID) != 0x80)
                 || (gl518_read_value(client, GL518_REG_CONF) & 0x80))
-                        goto exit_free;
+                        return -ENODEV;
        }
        /* Determine the chip type. */
@@ -526,19 +514,32 @@ static int gl518_detect(struct i2c_adapter *adapter, int address, int kind)
                                dev_info(&adapter->dev,
                                    "Ignoring 'force' parameter for unknown "
                                    "chip at adapter %d, address 0x%02x\n",
-                                    i2c_adapter_id(adapter), address);
+                                    i2c_adapter_id(adapter), client->addr);
-                        goto exit_free;
+                        return -ENODEV;
                }
        }
-        /* Fill in the remaining client fields */
+        strlcpy(info->type, "gl518sm", I2C_NAME_SIZE);
-        strlcpy(client->name, "gl518sm", I2C_NAME_SIZE);
-        data->type = kind;
-        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
+        return 0;
-        if ((err = i2c_attach_client(client)))
+}
-                goto exit_free;
+static int gl518_probe(struct i2c_client *client,
+                       const struct i2c_device_id *id)
+{
+        struct gl518_data *data;
+        int err, revision;
+        data = kzalloc(sizeof(struct gl518_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(client, data);
+        revision = gl518_read_value(client, GL518_REG_REVISION);
+        data->type = revision == 0x80 ? gl518sm_r80 : gl518sm_r00;
+        mutex_init(&data->update_lock);
        /* Initialize the GL518SM chip */
        data->alarm_mask = 0xff;
@@ -546,7 +547,7 @@ static int gl518_detect(struct i2c_adapter *adapter, int address, int kind)
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&client->dev.kobj, &gl518_group)))
-                goto exit_detach;
+                goto exit_free;
        if (data->type == gl518sm_r80)
                if ((err = sysfs_create_group(&client->dev.kobj,
                                              &gl518_group_r80)))
@@ -564,8 +565,6 @@ exit_remove_files:
        sysfs_remove_group(&client->dev.kobj, &gl518_group);
        if (data->type == gl518sm_r80)
                sysfs_remove_group(&client->dev.kobj, &gl518_group_r80);
-exit_detach:
-        i2c_detach_client(client);
 exit_free:
        kfree(data);
 exit:
@@ -591,19 +590,15 @@ static void gl518_init_client(struct i2c_client *client)
        gl518_write_value(client, GL518_REG_CONF, 0x40 | regvalue);
 }
-static int gl518_detach_client(struct i2c_client *client)
+static int gl518_remove(struct i2c_client *client)
 {
        struct gl518_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &gl518_group);
        if (data->type == gl518sm_r80)
                sysfs_remove_group(&client->dev.kobj, &gl518_group_r80);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/gl520sm.c b/drivers/hwmon/gl520sm.c
index 8984ef141627..19616f2242b0 100644
--- a/drivers/hwmon/gl520sm.c
+++ b/drivers/hwmon/gl520sm.c
@@ -79,26 +79,37 @@ static const u8 GL520_REG_TEMP_MAX_HYST[]	= { 0x06, 0x18 };
 * Function declarations
 */
-static int gl520_attach_adapter(struct i2c_adapter *adapter);
+static int gl520_probe(struct i2c_client *client,
-static int gl520_detect(struct i2c_adapter *adapter, int address, int kind);
+                       const struct i2c_device_id *id);
+static int gl520_detect(struct i2c_client *client, int kind,
+                        struct i2c_board_info *info);
 static void gl520_init_client(struct i2c_client *client);
-static int gl520_detach_client(struct i2c_client *client);
+static int gl520_remove(struct i2c_client *client);
 static int gl520_read_value(struct i2c_client *client, u8 reg);
 static int gl520_write_value(struct i2c_client *client, u8 reg, u16 value);
 static struct gl520_data *gl520_update_device(struct device *dev);
 /* Driver data */
+static const struct i2c_device_id gl520_id[] = {
+        { "gl520sm", gl520sm },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, gl520_id);
 static struct i2c_driver gl520_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "gl520sm",
        },
-        .attach_adapter = gl520_attach_adapter,
+        .probe          = gl520_probe,
-        .detach_client  = gl520_detach_client,
+        .remove         = gl520_remove,
+        .id_table       = gl520_id,
+        .detect         = gl520_detect,
+        .address_data   = &addr_data,
 };
 /* Client data */
 struct gl520_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid;             /* zero until the following fields are valid */
@@ -669,37 +680,15 @@ static const struct attribute_group gl520_group_opt = {
 * Real code
 */
-static int gl520_attach_adapter(struct i2c_adapter *adapter)
+/* Return 0 if detection is successful, -ENODEV otherwise */
-{
+static int gl520_detect(struct i2c_client *client, int kind,
-        if (!(adapter->class & I2C_CLASS_HWMON))
+                        struct i2c_board_info *info)
-                return 0;
-        return i2c_probe(adapter, &addr_data, gl520_detect);
-}
-static int gl520_detect(struct i2c_adapter *adapter, int address, int kind)
 {
-        struct i2c_client *client;
+        struct i2c_adapter *adapter = client->adapter;
-        struct gl520_data *data;
-        int err = 0;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA |
                                     I2C_FUNC_SMBUS_WORD_DATA))
-                goto exit;
+                return -ENODEV;
-        /* OK. For now, we presume we have a valid client. We now create the
-           client structure, even though we cannot fill it completely yet.
-           But it allows us to access gl520_{read,write}_value. */
-        if (!(data = kzalloc(sizeof(struct gl520_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        client = &data->client;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &gl520_driver;
        /* Determine the chip type. */
        if (kind < 0) {
@@ -707,24 +696,36 @@ static int gl520_detect(struct i2c_adapter *adapter, int address, int kind)
                    ((gl520_read_value(client, GL520_REG_REVISION) & 0x7f) != 0x00) ||
                    ((gl520_read_value(client, GL520_REG_CONF) & 0x80) != 0x00)) {
                        dev_dbg(&client->dev, "Unknown chip type, skipping\n");
-                        goto exit_free;
+                        return -ENODEV;
                }
        }
-        /* Fill in the remaining client fields */
+        strlcpy(info->type, "gl520sm", I2C_NAME_SIZE);
-        strlcpy(client->name, "gl520sm", I2C_NAME_SIZE);
-        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
+        return 0;
-        if ((err = i2c_attach_client(client)))
+}
-                goto exit_free;
+static int gl520_probe(struct i2c_client *client,
+                       const struct i2c_device_id *id)
+{
+        struct gl520_data *data;
+        int err;
+        data = kzalloc(sizeof(struct gl520_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(client, data);
+        mutex_init(&data->update_lock);
        /* Initialize the GL520SM chip */
        gl520_init_client(client);
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&client->dev.kobj, &gl520_group)))
-                goto exit_detach;
+                goto exit_free;
        if (data->two_temps) {
                if ((err = device_create_file(&client->dev,
@@ -764,8 +765,6 @@ static int gl520_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove_files:
        sysfs_remove_group(&client->dev.kobj, &gl520_group);
        sysfs_remove_group(&client->dev.kobj, &gl520_group_opt);
-exit_detach:
-        i2c_detach_client(client);
 exit_free:
        kfree(data);
 exit:
@@ -811,18 +810,14 @@ static void gl520_init_client(struct i2c_client *client)
        gl520_write_value(client, GL520_REG_BEEP_MASK, data->beep_mask);
 }
-static int gl520_detach_client(struct i2c_client *client)
+static int gl520_remove(struct i2c_client *client)
 {
        struct gl520_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &gl520_group);
        sysfs_remove_group(&client->dev.kobj, &gl520_group_opt);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/hdaps.c b/drivers/hwmon/hdaps.c
index ea4fc6577593..a4d92d246d52 100644
--- a/drivers/hwmon/hdaps.c
+++ b/drivers/hwmon/hdaps.c
@@ -515,16 +515,24 @@ static struct dmi_system_id __initdata hdaps_whitelist[] = {
        HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad R50"),
        HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad R51"),
        HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad R52"),
+        HDAPS_DMI_MATCH_INVERT("LENOVO", "ThinkPad R61i"),
+        HDAPS_DMI_MATCH_INVERT("LENOVO", "ThinkPad R61"),
        HDAPS_DMI_MATCH_INVERT("IBM", "ThinkPad T41p"),
        HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad T41"),
        HDAPS_DMI_MATCH_INVERT("IBM", "ThinkPad T42p"),
        HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad T42"),
        HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad T43"),
        HDAPS_DMI_MATCH_INVERT("LENOVO", "ThinkPad T60"),
+        HDAPS_DMI_MATCH_INVERT("LENOVO", "ThinkPad T61p"),
+        HDAPS_DMI_MATCH_INVERT("LENOVO", "ThinkPad T61"),
        HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad X40"),
        HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad X41"),
        HDAPS_DMI_MATCH_INVERT("LENOVO", "ThinkPad X60"),
+        HDAPS_DMI_MATCH_INVERT("LENOVO", "ThinkPad X61s"),
+        HDAPS_DMI_MATCH_INVERT("LENOVO", "ThinkPad X61"),
        HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad Z60m"),
+        HDAPS_DMI_MATCH_INVERT("LENOVO", "ThinkPad Z61m"),
+        HDAPS_DMI_MATCH_INVERT("LENOVO", "ThinkPad Z61p"),
        { .ident = NULL }
 };
diff --git a/drivers/hwmon/i5k_amb.c b/drivers/hwmon/i5k_amb.c
index 6ac5c6f53585..f9e2ed621f7b 100644
--- a/drivers/hwmon/i5k_amb.c
+++ b/drivers/hwmon/i5k_amb.c
@@ -111,6 +111,7 @@ struct i5k_amb_data {
        void __iomem *amb_mmio;
        struct i5k_device_attribute *attrs;
        unsigned int num_attrs;
+        unsigned long chipset_id;
 };
 static ssize_t show_name(struct device *dev, struct device_attribute *devattr,
@@ -382,7 +383,8 @@ err:
        return res;
 }
-static int __devinit i5k_find_amb_registers(struct i5k_amb_data *data)
+static int __devinit i5k_find_amb_registers(struct i5k_amb_data *data,
+                                            unsigned long devid)
 {
        struct pci_dev *pcidev;
        u32 val32;
@@ -390,7 +392,7 @@ static int __devinit i5k_find_amb_registers(struct i5k_amb_data *data)
        /* Find AMB register memory space */
        pcidev = pci_get_device(PCI_VENDOR_ID_INTEL,
-                                PCI_DEVICE_ID_INTEL_5000_ERR,
+                                devid,
                                NULL);
        if (!pcidev)
                return -ENODEV;
@@ -409,6 +411,8 @@ static int __devinit i5k_find_amb_registers(struct i5k_amb_data *data)
                goto out;
        }
+        data->chipset_id = devid;
        res = 0;
 out:
        pci_dev_put(pcidev);
@@ -441,10 +445,30 @@ out:
        return res;
 }
+static unsigned long i5k_channel_pci_id(struct i5k_amb_data *data,
+                                        unsigned long channel)
+{
+        switch (data->chipset_id) {
+        case PCI_DEVICE_ID_INTEL_5000_ERR:
+                return PCI_DEVICE_ID_INTEL_5000_FBD0 + channel;
+        case PCI_DEVICE_ID_INTEL_5400_ERR:
+                return PCI_DEVICE_ID_INTEL_5400_FBD0 + channel;
+        default:
+                BUG();
+        }
+}
+static unsigned long chipset_ids[] = {
+        PCI_DEVICE_ID_INTEL_5000_ERR,
+        PCI_DEVICE_ID_INTEL_5400_ERR,
+        0
+};
 static int __devinit i5k_amb_probe(struct platform_device *pdev)
 {
        struct i5k_amb_data *data;
        struct resource *reso;
+        int i;
        int res = -ENODEV;
        data = kzalloc(sizeof(*data), GFP_KERNEL);
@@ -452,19 +476,24 @@ static int __devinit i5k_amb_probe(struct platform_device *pdev)
                return -ENOMEM;
        /* Figure out where the AMB registers live */
-        res = i5k_find_amb_registers(data);
+        i = 0;
+        do {
+                res = i5k_find_amb_registers(data, chipset_ids[i]);
+                i++;
+        } while (res && chipset_ids[i]);
        if (res)
                goto err;
        /* Copy the DIMM presence map for the first two channels */
        res = i5k_channel_probe(&data->amb_present[0],
-                                PCI_DEVICE_ID_INTEL_5000_FBD0);
+                                i5k_channel_pci_id(data, 0));
        if (res)
                goto err;
        /* Copy the DIMM presence map for the optional second two channels */
        i5k_channel_probe(&data->amb_present[2],
-                          PCI_DEVICE_ID_INTEL_5000_FBD1);
+                          i5k_channel_pci_id(data, 1));
        /* Set up resource regions */
        reso = request_mem_region(data->amb_base, data->amb_len, DRVNAME);
diff --git a/drivers/hwmon/ibmaem.c b/drivers/hwmon/ibmaem.c
new file mode 100644
index 000000000000..c9416e657487
--- /dev/null
+++ b/drivers/hwmon/ibmaem.c
@@ -0,0 +1,1111 @@
+/*
+ * A hwmon driver for the IBM Active Energy Manager temperature/power sensors
+ * and capping functionality.
+ * Copyright (C) 2008 IBM
+ *
+ * Author: Darrick J. Wong <djwong@us.ibm.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ */
+#include <linux/ipmi.h>
+#include <linux/module.h>
+#include <linux/hwmon.h>
+#include <linux/hwmon-sysfs.h>
+#include <linux/jiffies.h>
+#include <linux/mutex.h>
+#include <linux/kdev_t.h>
+#include <linux/spinlock.h>
+#include <linux/idr.h>
+#include <linux/sched.h>
+#include <linux/platform_device.h>
+#include <linux/math64.h>
+#include <linux/time.h>
+#define REFRESH_INTERVAL        (HZ)
+#define IPMI_TIMEOUT            (30 * HZ)
+#define DRVNAME                 "aem"
+#define AEM_NETFN               0x2E
+#define AEM_FIND_FW_CMD         0x80
+#define AEM_ELEMENT_CMD         0x81
+#define AEM_FW_INSTANCE_CMD     0x82
+#define AEM_READ_ELEMENT_CFG    0x80
+#define AEM_READ_BUFFER         0x81
+#define AEM_READ_REGISTER       0x82
+#define AEM_WRITE_REGISTER      0x83
+#define AEM_SET_REG_MASK        0x84
+#define AEM_CLEAR_REG_MASK      0x85
+#define AEM_READ_ELEMENT_CFG2   0x86
+#define AEM_CONTROL_ELEMENT     0
+#define AEM_ENERGY_ELEMENT      1
+#define AEM_CLOCK_ELEMENT       4
+#define AEM_POWER_CAP_ELEMENT   7
+#define AEM_EXHAUST_ELEMENT     9
+#define AEM_POWER_ELEMENT       10
+#define AEM_MODULE_TYPE_ID      0x0001
+#define AEM2_NUM_ENERGY_REGS    2
+#define AEM2_NUM_PCAP_REGS      6
+#define AEM2_NUM_TEMP_REGS      2
+#define AEM2_NUM_SENSORS        14
+#define AEM1_NUM_ENERGY_REGS    1
+#define AEM1_NUM_SENSORS        3
+/* AEM 2.x has more energy registers */
+#define AEM_NUM_ENERGY_REGS     AEM2_NUM_ENERGY_REGS
+/* AEM 2.x needs more sensor files */
+#define AEM_NUM_SENSORS         AEM2_NUM_SENSORS
+#define POWER_CAP               0
+#define POWER_CAP_MAX_HOTPLUG   1
+#define POWER_CAP_MAX           2
+#define POWER_CAP_MIN_WARNING   3
+#define POWER_CAP_MIN           4
+#define POWER_AUX               5
+#define AEM_DEFAULT_POWER_INTERVAL 1000
+#define AEM_MIN_POWER_INTERVAL  200
+#define UJ_PER_MJ               1000L
+static DEFINE_IDR(aem_idr);
+static DEFINE_SPINLOCK(aem_idr_lock);
+static struct device_driver aem_driver = {
+        .name = DRVNAME,
+        .bus = &platform_bus_type,
+};
+struct aem_ipmi_data {
+        struct completion       read_complete;
+        struct ipmi_addr        address;
+        ipmi_user_t             user;
+        int                     interface;
+        struct kernel_ipmi_msg  tx_message;
+        long                    tx_msgid;
+        void                    *rx_msg_data;
+        unsigned short          rx_msg_len;
+        unsigned char           rx_result;
+        int                     rx_recv_type;
+        struct device           *bmc_device;
+};
+struct aem_ro_sensor_template {
+        char *label;
+        ssize_t (*show)(struct device *dev,
+                        struct device_attribute *devattr,
+                        char *buf);
+        int index;
+};
+struct aem_rw_sensor_template {
+        char *label;
+        ssize_t (*show)(struct device *dev,
+                        struct device_attribute *devattr,
+                        char *buf);
+        ssize_t (*set)(struct device *dev,
+                       struct device_attribute *devattr,
+                       const char *buf, size_t count);
+        int index;
+};
+struct aem_data {
+        struct list_head        list;
+        struct device           *hwmon_dev;
+        struct platform_device  *pdev;
+        struct mutex            lock;
+        char                    valid;
+        unsigned long           last_updated;   /* In jiffies */
+        u8                      ver_major;
+        u8                      ver_minor;
+        u8                      module_handle;
+        int                     id;
+        struct aem_ipmi_data    ipmi;
+        /* Function to update sensors */
+        void (*update)(struct aem_data *data);
+        /*
+         * AEM 1.x sensors:
+         * Available sensors:
+         * Energy meter
+         * Power meter
+         *
+         * AEM 2.x sensors:
+         * Two energy meters
+         * Two power meters
+         * Two temperature sensors
+         * Six power cap registers
+         */
+        /* sysfs attrs */
+        struct sensor_device_attribute  sensors[AEM_NUM_SENSORS];
+        /* energy use in mJ */
+        u64                     energy[AEM_NUM_ENERGY_REGS];
+        /* power sampling interval in ms */
+        unsigned long           power_period[AEM_NUM_ENERGY_REGS];
+        /* Everything past here is for AEM2 only */
+        /* power caps in dW */
+        u16                     pcap[AEM2_NUM_PCAP_REGS];
+        /* exhaust temperature in C */
+        u8                      temp[AEM2_NUM_TEMP_REGS];
+};
+/* Data structures returned by the AEM firmware */
+struct aem_iana_id {
+        u8                      bytes[3];
+};
+static struct aem_iana_id system_x_id = {
+        .bytes = {0x4D, 0x4F, 0x00}
+};
+/* These are used to find AEM1 instances */
+struct aem_find_firmware_req {
+        struct aem_iana_id      id;
+        u8                      rsvd;
+        __be16                  index;
+        __be16                  module_type_id;
+} __packed;
+struct aem_find_firmware_resp {
+        struct aem_iana_id      id;
+        u8                      num_instances;
+} __packed;
+/* These are used to find AEM2 instances */
+struct aem_find_instance_req {
+        struct aem_iana_id      id;
+        u8                      instance_number;
+        __be16                  module_type_id;
+} __packed;
+struct aem_find_instance_resp {
+        struct aem_iana_id      id;
+        u8                      num_instances;
+        u8                      major;
+        u8                      minor;
+        u8                      module_handle;
+        u16                     record_id;
+} __packed;
+/* These are used to query sensors */
+struct aem_read_sensor_req {
+        struct aem_iana_id      id;
+        u8                      module_handle;
+        u8                      element;
+        u8                      subcommand;
+        u8                      reg;
+        u8                      rx_buf_size;
+} __packed;
+struct aem_read_sensor_resp {
+        struct aem_iana_id      id;
+        u8                      bytes[0];
+} __packed;
+/* Data structures to talk to the IPMI layer */
+struct aem_driver_data {
+        struct list_head        aem_devices;
+        struct ipmi_smi_watcher bmc_events;
+        struct ipmi_user_hndl   ipmi_hndlrs;
+};
+static void aem_register_bmc(int iface, struct device *dev);
+static void aem_bmc_gone(int iface);
+static void aem_msg_handler(struct ipmi_recv_msg *msg, void *user_msg_data);
+static void aem_remove_sensors(struct aem_data *data);
+static int aem_init_aem1(struct aem_ipmi_data *probe);
+static int aem_init_aem2(struct aem_ipmi_data *probe);
+static int aem1_find_sensors(struct aem_data *data);
+static int aem2_find_sensors(struct aem_data *data);
+static void update_aem1_sensors(struct aem_data *data);
+static void update_aem2_sensors(struct aem_data *data);
+static struct aem_driver_data driver_data = {
+        .aem_devices = LIST_HEAD_INIT(driver_data.aem_devices),
+        .bmc_events = {
+                .owner = THIS_MODULE,
+                .new_smi = aem_register_bmc,
+                .smi_gone = aem_bmc_gone,
+        },
+        .ipmi_hndlrs = {
+                .ipmi_recv_hndl = aem_msg_handler,
+        },
+};
+/* Functions to talk to the IPMI layer */
+/* Initialize IPMI address, message buffers and user data */
+static int aem_init_ipmi_data(struct aem_ipmi_data *data, int iface,
+                              struct device *bmc)
+{
+        int err;
+        init_completion(&data->read_complete);
+        data->bmc_device = bmc;
+        /* Initialize IPMI address */
+        data->address.addr_type = IPMI_SYSTEM_INTERFACE_ADDR_TYPE;
+        data->address.channel = IPMI_BMC_CHANNEL;
+        data->address.data[0] = 0;
+        data->interface = iface;
+        /* Initialize message buffers */
+        data->tx_msgid = 0;
+        data->tx_message.netfn = AEM_NETFN;
+        /* Create IPMI messaging interface user */
+        err = ipmi_create_user(data->interface, &driver_data.ipmi_hndlrs,
+                               data, &data->user);
+        if (err < 0) {
+                dev_err(bmc, "Unable to register user with IPMI "
+                        "interface %d\n", data->interface);
+                return -EACCES;
+        }
+        return 0;
+}
+/* Send an IPMI command */
+static int aem_send_message(struct aem_ipmi_data *data)
+{
+        int err;
+        err = ipmi_validate_addr(&data->address, sizeof(data->address));
+        if (err)
+                goto out;
+        data->tx_msgid++;
+        err = ipmi_request_settime(data->user, &data->address, data->tx_msgid,
+                                   &data->tx_message, data, 0, 0, 0);
+        if (err)
+                goto out1;
+        return 0;
+out1:
+        dev_err(data->bmc_device, "request_settime=%x\n", err);
+        return err;
+out:
+        dev_err(data->bmc_device, "validate_addr=%x\n", err);
+        return err;
+}
+/* Dispatch IPMI messages to callers */
+static void aem_msg_handler(struct ipmi_recv_msg *msg, void *user_msg_data)
+{
+        unsigned short rx_len;
+        struct aem_ipmi_data *data = user_msg_data;
+        if (msg->msgid != data->tx_msgid) {
+                dev_err(data->bmc_device, "Mismatch between received msgid "
+                        "(%02x) and transmitted msgid (%02x)!\n",
+                        (int)msg->msgid,
+                        (int)data->tx_msgid);
+                ipmi_free_recv_msg(msg);
+                return;
+        }
+        data->rx_recv_type = msg->recv_type;
+        if (msg->msg.data_len > 0)
+                data->rx_result = msg->msg.data[0];
+        else
+                data->rx_result = IPMI_UNKNOWN_ERR_COMPLETION_CODE;
+        if (msg->msg.data_len > 1) {
+                rx_len = msg->msg.data_len - 1;
+                if (data->rx_msg_len < rx_len)
+                        rx_len = data->rx_msg_len;
+                data->rx_msg_len = rx_len;
+                memcpy(data->rx_msg_data, msg->msg.data + 1, data->rx_msg_len);
+        } else
+                data->rx_msg_len = 0;
+        ipmi_free_recv_msg(msg);
+        complete(&data->read_complete);
+}
+/* ID functions */
+/* Obtain an id */
+static int aem_idr_get(int *id)
+{
+        int i, err;
+again:
+        if (unlikely(!idr_pre_get(&aem_idr, GFP_KERNEL)))
+                return -ENOMEM;
+        spin_lock(&aem_idr_lock);
+        err = idr_get_new(&aem_idr, NULL, &i);
+        spin_unlock(&aem_idr_lock);
+        if (unlikely(err == -EAGAIN))
+                goto again;
+        else if (unlikely(err))
+                return err;
+        *id = i & MAX_ID_MASK;
+        return 0;
+}
+/* Release an object ID */
+static void aem_idr_put(int id)
+{
+        spin_lock(&aem_idr_lock);
+        idr_remove(&aem_idr, id);
+        spin_unlock(&aem_idr_lock);
+}
+/* Sensor support functions */
+/* Read a sensor value */
+static int aem_read_sensor(struct aem_data *data, u8 elt, u8 reg,
+                           void *buf, size_t size)
+{
+        int rs_size, res;
+        struct aem_read_sensor_req rs_req;
+        struct aem_read_sensor_resp *rs_resp;
+        struct aem_ipmi_data *ipmi = &data->ipmi;
+        /* AEM registers are 1, 2, 4 or 8 bytes */
+        switch (size) {
+        case 1:
+        case 2:
+        case 4:
+        case 8:
+                break;
+        default:
+                return -EINVAL;
+        }
+        rs_req.id = system_x_id;
+        rs_req.module_handle = data->module_handle;
+        rs_req.element = elt;
+        rs_req.subcommand = AEM_READ_REGISTER;
+        rs_req.reg = reg;
+        rs_req.rx_buf_size = size;
+        ipmi->tx_message.cmd = AEM_ELEMENT_CMD;
+        ipmi->tx_message.data = (char *)&rs_req;
+        ipmi->tx_message.data_len = sizeof(rs_req);
+        rs_size = sizeof(*rs_resp) + size;
+        rs_resp = kzalloc(rs_size, GFP_KERNEL);
+        if (!rs_resp)
+                return -ENOMEM;
+        ipmi->rx_msg_data = rs_resp;
+        ipmi->rx_msg_len = rs_size;
+        aem_send_message(ipmi);
+        res = wait_for_completion_timeout(&ipmi->read_complete, IPMI_TIMEOUT);
+        if (!res)
+                return -ETIMEDOUT;
+        if (ipmi->rx_result || ipmi->rx_msg_len != rs_size ||
+            memcmp(&rs_resp->id, &system_x_id, sizeof(system_x_id))) {
+                kfree(rs_resp);
+                return -ENOENT;
+        }
+        switch (size) {
+        case 1: {
+                u8 *x = buf;
+                *x = rs_resp->bytes[0];
+                break;
+        }
+        case 2: {
+                u16 *x = buf;
+                *x = be16_to_cpup((__be16 *)rs_resp->bytes);
+                break;
+        }
+        case 4: {
+                u32 *x = buf;
+                *x = be32_to_cpup((__be32 *)rs_resp->bytes);
+                break;
+        }
+        case 8: {
+                u64 *x = buf;
+                *x = be64_to_cpup((__be64 *)rs_resp->bytes);
+                break;
+        }
+        }
+        return 0;
+}
+/* Update AEM energy registers */
+static void update_aem_energy(struct aem_data *data)
+{
+        aem_read_sensor(data, AEM_ENERGY_ELEMENT, 0, &data->energy[0], 8);
+        if (data->ver_major < 2)
+                return;
+        aem_read_sensor(data, AEM_ENERGY_ELEMENT, 1, &data->energy[1], 8);
+}
+/* Update all AEM1 sensors */
+static void update_aem1_sensors(struct aem_data *data)
+{
+        mutex_lock(&data->lock);
+        if (time_before(jiffies, data->last_updated + REFRESH_INTERVAL) &&
+            data->valid)
+                goto out;
+        update_aem_energy(data);
+out:
+        mutex_unlock(&data->lock);
+}
+/* Update all AEM2 sensors */
+static void update_aem2_sensors(struct aem_data *data)
+{
+        int i;
+        mutex_lock(&data->lock);
+        if (time_before(jiffies, data->last_updated + REFRESH_INTERVAL) &&
+            data->valid)
+                goto out;
+        update_aem_energy(data);
+        aem_read_sensor(data, AEM_EXHAUST_ELEMENT, 0, &data->temp[0], 1);
+        aem_read_sensor(data, AEM_EXHAUST_ELEMENT, 1, &data->temp[1], 1);
+        for (i = POWER_CAP; i <= POWER_AUX; i++)
+                aem_read_sensor(data, AEM_POWER_CAP_ELEMENT, i,
+                                &data->pcap[i], 2);
+out:
+        mutex_unlock(&data->lock);
+}
+/* Delete an AEM instance */
+static void aem_delete(struct aem_data *data)
+{
+        list_del(&data->list);
+        aem_remove_sensors(data);
+        hwmon_device_unregister(data->hwmon_dev);
+        ipmi_destroy_user(data->ipmi.user);
+        dev_set_drvdata(&data->pdev->dev, NULL);
+        platform_device_unregister(data->pdev);
+        aem_idr_put(data->id);
+        kfree(data);
+}
+/* Probe functions for AEM1 devices */
+/* Retrieve version and module handle for an AEM1 instance */
+static int aem_find_aem1_count(struct aem_ipmi_data *data)
+{
+        int res;
+        struct aem_find_firmware_req    ff_req;
+        struct aem_find_firmware_resp   ff_resp;
+        ff_req.id = system_x_id;
+        ff_req.index = 0;
+        ff_req.module_type_id = cpu_to_be16(AEM_MODULE_TYPE_ID);
+        data->tx_message.cmd = AEM_FIND_FW_CMD;
+        data->tx_message.data = (char *)&ff_req;
+        data->tx_message.data_len = sizeof(ff_req);
+        data->rx_msg_data = &ff_resp;
+        data->rx_msg_len = sizeof(ff_resp);
+        aem_send_message(data);
+        res = wait_for_completion_timeout(&data->read_complete, IPMI_TIMEOUT);
+        if (!res)
+                return -ETIMEDOUT;
+        if (data->rx_result || data->rx_msg_len != sizeof(ff_resp) ||
+            memcmp(&ff_resp.id, &system_x_id, sizeof(system_x_id)))
+                return -ENOENT;
+        return ff_resp.num_instances;
+}
+/* Find and initialize one AEM1 instance */
+static int aem_init_aem1_inst(struct aem_ipmi_data *probe, u8 module_handle)
+{
+        struct aem_data *data;
+        int i;
+        int res = -ENOMEM;
+        data = kzalloc(sizeof(*data), GFP_KERNEL);
+        if (!data)
+                return res;
+        mutex_init(&data->lock);
+        /* Copy instance data */
+        data->ver_major = 1;
+        data->ver_minor = 0;
+        data->module_handle = module_handle;
+        for (i = 0; i < AEM1_NUM_ENERGY_REGS; i++)
+                data->power_period[i] = AEM_DEFAULT_POWER_INTERVAL;
+        /* Create sub-device for this fw instance */
+        if (aem_idr_get(&data->id))
+                goto id_err;
+        data->pdev = platform_device_alloc(DRVNAME, data->id);
+        if (!data->pdev)
+                goto dev_err;
+        data->pdev->dev.driver = &aem_driver;
+        res = platform_device_add(data->pdev);
+        if (res)
+                goto ipmi_err;
+        dev_set_drvdata(&data->pdev->dev, data);
+        /* Set up IPMI interface */
+        if (aem_init_ipmi_data(&data->ipmi, probe->interface,
+                               probe->bmc_device))
+                goto ipmi_err;
+        /* Register with hwmon */
+        data->hwmon_dev = hwmon_device_register(&data->pdev->dev);
+        if (IS_ERR(data->hwmon_dev)) {
+                dev_err(&data->pdev->dev, "Unable to register hwmon "
+                        "device for IPMI interface %d\n",
+                        probe->interface);
+                goto hwmon_reg_err;
+        }
+        data->update = update_aem1_sensors;
+        /* Find sensors */
+        if (aem1_find_sensors(data))
+                goto sensor_err;
+        /* Add to our list of AEM devices */
+        list_add_tail(&data->list, &driver_data.aem_devices);
+        dev_info(data->ipmi.bmc_device, "Found AEM v%d.%d at 0x%X\n",
+                 data->ver_major, data->ver_minor,
+                 data->module_handle);
+        return 0;
+sensor_err:
+        hwmon_device_unregister(data->hwmon_dev);
+hwmon_reg_err:
+        ipmi_destroy_user(data->ipmi.user);
+ipmi_err:
+        dev_set_drvdata(&data->pdev->dev, NULL);
+        platform_device_unregister(data->pdev);
+dev_err:
+        aem_idr_put(data->id);
+id_err:
+        kfree(data);
+        return res;
+}
+/* Find and initialize all AEM1 instances */
+static int aem_init_aem1(struct aem_ipmi_data *probe)
+{
+        int num, i, err;
+        num = aem_find_aem1_count(probe);
+        for (i = 0; i < num; i++) {
+                err = aem_init_aem1_inst(probe, i);
+                if (err) {
+                        dev_err(probe->bmc_device,
+                                "Error %d initializing AEM1 0x%X\n",
+                                err, i);
+                        return err;
+                }
+        }
+        return 0;
+}
+/* Probe functions for AEM2 devices */
+/* Retrieve version and module handle for an AEM2 instance */
+static int aem_find_aem2(struct aem_ipmi_data *data,
+                            struct aem_find_instance_resp *fi_resp,
+                            int instance_num)
+{
+        int res;
+        struct aem_find_instance_req fi_req;
+        fi_req.id = system_x_id;
+        fi_req.instance_number = instance_num;
+        fi_req.module_type_id = cpu_to_be16(AEM_MODULE_TYPE_ID);
+        data->tx_message.cmd = AEM_FW_INSTANCE_CMD;
+        data->tx_message.data = (char *)&fi_req;
+        data->tx_message.data_len = sizeof(fi_req);
+        data->rx_msg_data = fi_resp;
+        data->rx_msg_len = sizeof(*fi_resp);
+        aem_send_message(data);
+        res = wait_for_completion_timeout(&data->read_complete, IPMI_TIMEOUT);
+        if (!res)
+                return -ETIMEDOUT;
+        if (data->rx_result || data->rx_msg_len != sizeof(*fi_resp) ||
+            memcmp(&fi_resp->id, &system_x_id, sizeof(system_x_id)))
+                return -ENOENT;
+        return 0;
+}
+/* Find and initialize one AEM2 instance */
+static int aem_init_aem2_inst(struct aem_ipmi_data *probe,
+                              struct aem_find_instance_resp *fi_resp)
+{
+        struct aem_data *data;
+        int i;
+        int res = -ENOMEM;
+        data = kzalloc(sizeof(*data), GFP_KERNEL);
+        if (!data)
+                return res;
+        mutex_init(&data->lock);
+        /* Copy instance data */
+        data->ver_major = fi_resp->major;
+        data->ver_minor = fi_resp->minor;
+        data->module_handle = fi_resp->module_handle;
+        for (i = 0; i < AEM2_NUM_ENERGY_REGS; i++)
+                data->power_period[i] = AEM_DEFAULT_POWER_INTERVAL;
+        /* Create sub-device for this fw instance */
+        if (aem_idr_get(&data->id))
+                goto id_err;
+        data->pdev = platform_device_alloc(DRVNAME, data->id);
+        if (!data->pdev)
+                goto dev_err;
+        data->pdev->dev.driver = &aem_driver;
+        res = platform_device_add(data->pdev);
+        if (res)
+                goto ipmi_err;
+        dev_set_drvdata(&data->pdev->dev, data);
+        /* Set up IPMI interface */
+        if (aem_init_ipmi_data(&data->ipmi, probe->interface,
+                               probe->bmc_device))
+                goto ipmi_err;
+        /* Register with hwmon */
+        data->hwmon_dev = hwmon_device_register(&data->pdev->dev);
+        if (IS_ERR(data->hwmon_dev)) {
+                dev_err(&data->pdev->dev, "Unable to register hwmon "
+                        "device for IPMI interface %d\n",
+                        probe->interface);
+                goto hwmon_reg_err;
+        }
+        data->update = update_aem2_sensors;
+        /* Find sensors */
+        if (aem2_find_sensors(data))
+                goto sensor_err;
+        /* Add to our list of AEM devices */
+        list_add_tail(&data->list, &driver_data.aem_devices);
+        dev_info(data->ipmi.bmc_device, "Found AEM v%d.%d at 0x%X\n",
+                 data->ver_major, data->ver_minor,
+                 data->module_handle);
+        return 0;
+sensor_err:
+        hwmon_device_unregister(data->hwmon_dev);
+hwmon_reg_err:
+        ipmi_destroy_user(data->ipmi.user);
+ipmi_err:
+        dev_set_drvdata(&data->pdev->dev, NULL);
+        platform_device_unregister(data->pdev);
+dev_err:
+        aem_idr_put(data->id);
+id_err:
+        kfree(data);
+        return res;
+}
+/* Find and initialize all AEM2 instances */
+static int aem_init_aem2(struct aem_ipmi_data *probe)
+{
+        struct aem_find_instance_resp fi_resp;
+        int err;
+        int i = 0;
+        while (!aem_find_aem2(probe, &fi_resp, i)) {
+                if (fi_resp.major != 2) {
+                        dev_err(probe->bmc_device, "Unknown AEM v%d; please "
+                                "report this to the maintainer.\n",
+                                fi_resp.major);
+                        i++;
+                        continue;
+                }
+                err = aem_init_aem2_inst(probe, &fi_resp);
+                if (err) {
+                        dev_err(probe->bmc_device,
+                                "Error %d initializing AEM2 0x%X\n",
+                                err, fi_resp.module_handle);
+                        return err;
+                }
+                i++;
+        }
+        return 0;
+}
+/* Probe a BMC for AEM firmware instances */
+static void aem_register_bmc(int iface, struct device *dev)
+{
+        struct aem_ipmi_data probe;
+        if (aem_init_ipmi_data(&probe, iface, dev))
+                return;
+        /* Ignore probe errors; they won't cause problems */
+        aem_init_aem1(&probe);
+        aem_init_aem2(&probe);
+        ipmi_destroy_user(probe.user);
+}
+/* Handle BMC deletion */
+static void aem_bmc_gone(int iface)
+{
+        struct aem_data *p1, *next1;
+        list_for_each_entry_safe(p1, next1, &driver_data.aem_devices, list)
+                if (p1->ipmi.interface == iface)
+                        aem_delete(p1);
+}
+/* sysfs support functions */
+/* AEM device name */
+static ssize_t show_name(struct device *dev, struct device_attribute *devattr,
+                         char *buf)
+{
+        struct aem_data *data = dev_get_drvdata(dev);
+        return sprintf(buf, "%s%d\n", DRVNAME, data->ver_major);
+}
+static SENSOR_DEVICE_ATTR(name, S_IRUGO, show_name, NULL, 0);
+/* AEM device version */
+static ssize_t show_version(struct device *dev,
+                            struct device_attribute *devattr,
+                            char *buf)
+{
+        struct aem_data *data = dev_get_drvdata(dev);
+        return sprintf(buf, "%d.%d\n", data->ver_major, data->ver_minor);
+}
+static SENSOR_DEVICE_ATTR(version, S_IRUGO, show_version, NULL, 0);
+/* Display power use */
+static ssize_t aem_show_power(struct device *dev,
+                              struct device_attribute *devattr,
+                              char *buf)
+{
+        struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
+        struct aem_data *data = dev_get_drvdata(dev);
+        u64 before, after, delta, time;
+        signed long leftover;
+        struct timespec b, a;
+        mutex_lock(&data->lock);
+        update_aem_energy(data);
+        getnstimeofday(&b);
+        before = data->energy[attr->index];
+        leftover = schedule_timeout_interruptible(
+                        msecs_to_jiffies(data->power_period[attr->index])
+                   );
+        if (leftover) {
+                mutex_unlock(&data->lock);
+                return 0;
+        }
+        update_aem_energy(data);
+        getnstimeofday(&a);
+        after = data->energy[attr->index];
+        mutex_unlock(&data->lock);
+        time = timespec_to_ns(&a) - timespec_to_ns(&b);
+        delta = (after - before) * UJ_PER_MJ;
+        return sprintf(buf, "%llu\n",
+                (unsigned long long)div64_u64(delta * NSEC_PER_SEC, time));
+}
+/* Display energy use */
+static ssize_t aem_show_energy(struct device *dev,
+                               struct device_attribute *devattr,
+                               char *buf)
+{
+        struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
+        struct aem_data *a = dev_get_drvdata(dev);
+        a->update(a);
+        return sprintf(buf, "%llu\n",
+                        (unsigned long long)a->energy[attr->index] * 1000);
+}
+/* Display power interval registers */
+static ssize_t aem_show_power_period(struct device *dev,
+                                     struct device_attribute *devattr,
+                                     char *buf)
+{
+        struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
+        struct aem_data *a = dev_get_drvdata(dev);
+        a->update(a);
+        return sprintf(buf, "%lu\n", a->power_period[attr->index]);
+}
+/* Set power interval registers */
+static ssize_t aem_set_power_period(struct device *dev,
+                                    struct device_attribute *devattr,
+                                    const char *buf, size_t count)
+{
+        struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
+        struct aem_data *a = dev_get_drvdata(dev);
+        unsigned long temp;
+        int res;
+        res = strict_strtoul(buf, 10, &temp);
+        if (res)
+                return res;
+        if (temp < AEM_MIN_POWER_INTERVAL)
+                return -EINVAL;
+        mutex_lock(&a->lock);
+        a->power_period[attr->index] = temp;
+        mutex_unlock(&a->lock);
+        return count;
+}
+/* Discover sensors on an AEM device */
+static int aem_register_sensors(struct aem_data *data,
+                                struct aem_ro_sensor_template *ro,
+                                struct aem_rw_sensor_template *rw)
+{
+        struct device *dev = &data->pdev->dev;
+        struct sensor_device_attribute *sensors = data->sensors;
+        int err;
+        /* Set up read-only sensors */
+        while (ro->label) {
+                sensors->dev_attr.attr.name = ro->label;
+                sensors->dev_attr.attr.mode = S_IRUGO;
+                sensors->dev_attr.show = ro->show;
+                sensors->index = ro->index;
+                err = device_create_file(dev, &sensors->dev_attr);
+                if (err) {
+                        sensors->dev_attr.attr.name = NULL;
+                        goto error;
+                }
+                sensors++;
+                ro++;
+        }
+        /* Set up read-write sensors */
+        while (rw->label) {
+                sensors->dev_attr.attr.name = rw->label;
+                sensors->dev_attr.attr.mode = S_IRUGO | S_IWUSR;
+                sensors->dev_attr.show = rw->show;
+                sensors->dev_attr.store = rw->set;
+                sensors->index = rw->index;
+                err = device_create_file(dev, &sensors->dev_attr);
+                if (err) {
+                        sensors->dev_attr.attr.name = NULL;
+                        goto error;
+                }
+                sensors++;
+                rw++;
+        }
+        err = device_create_file(dev, &sensor_dev_attr_name.dev_attr);
+        if (err)
+                goto error;
+        err = device_create_file(dev, &sensor_dev_attr_version.dev_attr);
+        return err;
+error:
+        aem_remove_sensors(data);
+        return err;
+}
+/* sysfs support functions for AEM2 sensors */
+/* Display temperature use */
+static ssize_t aem2_show_temp(struct device *dev,
+                              struct device_attribute *devattr,
+                              char *buf)
+{
+        struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
+        struct aem_data *a = dev_get_drvdata(dev);
+        a->update(a);
+        return sprintf(buf, "%u\n", a->temp[attr->index] * 1000);
+}
+/* Display power-capping registers */
+static ssize_t aem2_show_pcap_value(struct device *dev,
+                                    struct device_attribute *devattr,
+                                    char *buf)
+{
+        struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
+        struct aem_data *a = dev_get_drvdata(dev);
+        a->update(a);
+        return sprintf(buf, "%u\n", a->pcap[attr->index] * 100000);
+}
+/* Remove sensors attached to an AEM device */
+static void aem_remove_sensors(struct aem_data *data)
+{
+        int i;
+        for (i = 0; i < AEM_NUM_SENSORS; i++) {
+                if (!data->sensors[i].dev_attr.attr.name)
+                        continue;
+                device_remove_file(&data->pdev->dev,
+                                   &data->sensors[i].dev_attr);
+        }
+        device_remove_file(&data->pdev->dev,
+                           &sensor_dev_attr_name.dev_attr);
+        device_remove_file(&data->pdev->dev,
+                           &sensor_dev_attr_version.dev_attr);
+}
+/* Sensor probe functions */
+/* Description of AEM1 sensors */
+static struct aem_ro_sensor_template aem1_ro_sensors[] = {
+{"energy1_input",  aem_show_energy, 0},
+{"power1_average", aem_show_power,  0},
+{NULL,             NULL,            0},
+};
+static struct aem_rw_sensor_template aem1_rw_sensors[] = {
+{"power1_average_interval", aem_show_power_period, aem_set_power_period, 0},
+{NULL,                      NULL,                  NULL,                 0},
+};
+/* Description of AEM2 sensors */
+static struct aem_ro_sensor_template aem2_ro_sensors[] = {
+{"energy1_input",         aem_show_energy,      0},
+{"energy2_input",         aem_show_energy,      1},
+{"power1_average",        aem_show_power,       0},
+{"power2_average",        aem_show_power,       1},
+{"temp1_input",           aem2_show_temp,       0},
+{"temp2_input",           aem2_show_temp,       1},
+{"power4_average",        aem2_show_pcap_value, POWER_CAP_MAX_HOTPLUG},
+{"power5_average",        aem2_show_pcap_value, POWER_CAP_MAX},
+{"power6_average",        aem2_show_pcap_value, POWER_CAP_MIN_WARNING},
+{"power7_average",        aem2_show_pcap_value, POWER_CAP_MIN},
+{"power3_average",        aem2_show_pcap_value, POWER_AUX},
+{"power_cap",             aem2_show_pcap_value, POWER_CAP},
+{NULL,                    NULL,                 0},
+};
+static struct aem_rw_sensor_template aem2_rw_sensors[] = {
+{"power1_average_interval", aem_show_power_period, aem_set_power_period, 0},
+{"power2_average_interval", aem_show_power_period, aem_set_power_period, 1},
+{NULL,                      NULL,                  NULL,                 0},
+};
+/* Set up AEM1 sensor attrs */
+static int aem1_find_sensors(struct aem_data *data)
+{
+        return aem_register_sensors(data, aem1_ro_sensors, aem1_rw_sensors);
+}
+/* Set up AEM2 sensor attrs */
+static int aem2_find_sensors(struct aem_data *data)
+{
+        return aem_register_sensors(data, aem2_ro_sensors, aem2_rw_sensors);
+}
+/* Module init/exit routines */
+static int __init aem_init(void)
+{
+        int res;
+        res = driver_register(&aem_driver);
+        if (res) {
+                printk(KERN_ERR "Can't register aem driver\n");
+                return res;
+        }
+        res = ipmi_smi_watcher_register(&driver_data.bmc_events);
+        if (res)
+                goto ipmi_reg_err;
+        return 0;
+ipmi_reg_err:
+        driver_unregister(&aem_driver);
+        return res;
+}
+static void __exit aem_exit(void)
+{
+        struct aem_data *p1, *next1;
+        ipmi_smi_watcher_unregister(&driver_data.bmc_events);
+        driver_unregister(&aem_driver);
+        list_for_each_entry_safe(p1, next1, &driver_data.aem_devices, list)
+                aem_delete(p1);
+}
+MODULE_AUTHOR("Darrick J. Wong <djwong@us.ibm.com>");
+MODULE_DESCRIPTION("IBM Active Energy Manager power/temp sensor driver");
+MODULE_LICENSE("GPL");
+module_init(aem_init);
+module_exit(aem_exit);
diff --git a/drivers/hwmon/lm63.c b/drivers/hwmon/lm63.c
index 116287008083..3195a265f0e9 100644
--- a/drivers/hwmon/lm63.c
+++ b/drivers/hwmon/lm63.c
@@ -1,7 +1,7 @@
 /*
 * lm63.c - driver for the National Semiconductor LM63 temperature sensor
 *          with integrated fan control
- * Copyright (C) 2004-2006  Jean Delvare <khali@linux-fr.org>
+ * Copyright (C) 2004-2008  Jean Delvare <khali@linux-fr.org>
 * Based on the lm90 driver.
 *
 * The LM63 is a sensor chip made by National Semiconductor. It measures
@@ -128,24 +128,36 @@ I2C_CLIENT_INSMOD_1(lm63);
 * Functions declaration
 */
-static int lm63_attach_adapter(struct i2c_adapter *adapter);
+static int lm63_probe(struct i2c_client *client,
-static int lm63_detach_client(struct i2c_client *client);
+                      const struct i2c_device_id *id);
+static int lm63_remove(struct i2c_client *client);
 static struct lm63_data *lm63_update_device(struct device *dev);
-static int lm63_detect(struct i2c_adapter *adapter, int address, int kind);
+static int lm63_detect(struct i2c_client *client, int kind,
+                       struct i2c_board_info *info);
 static void lm63_init_client(struct i2c_client *client);
 /*
 * Driver data (common to all clients)
 */
+static const struct i2c_device_id lm63_id[] = {
+        { "lm63", lm63 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, lm63_id);
 static struct i2c_driver lm63_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "lm63",
        },
-        .attach_adapter = lm63_attach_adapter,
+        .probe          = lm63_probe,
-        .detach_client  = lm63_detach_client,
+        .remove         = lm63_remove,
+        .id_table       = lm63_id,
+        .detect         = lm63_detect,
+        .address_data   = &addr_data,
 };
 /*
@@ -153,7 +165,6 @@ static struct i2c_driver lm63_driver = {
 */
 struct lm63_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid; /* zero until following fields are valid */
@@ -411,43 +422,14 @@ static const struct attribute_group lm63_group_fan1 = {
 * Real code
 */
-static int lm63_attach_adapter(struct i2c_adapter *adapter)
+/* Return 0 if detection is successful, -ENODEV otherwise */
+static int lm63_detect(struct i2c_client *new_client, int kind,
+                       struct i2c_board_info *info)
 {
-        if (!(adapter->class & I2C_CLASS_HWMON))
+        struct i2c_adapter *adapter = new_client->adapter;
-                return 0;
-        return i2c_probe(adapter, &addr_data, lm63_detect);
-}
-/*
- * The following function does more than just detection. If detection
- * succeeds, it also registers the new chip.
- */
-static int lm63_detect(struct i2c_adapter *adapter, int address, int kind)
-{
-        struct i2c_client *new_client;
-        struct lm63_data *data;
-        int err = 0;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
-                goto exit;
+                return -ENODEV;
-        if (!(data = kzalloc(sizeof(struct lm63_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        /* The common I2C client data is placed right before the
-           LM63-specific data. */
-        new_client = &data->client;
-        i2c_set_clientdata(new_client, data);
-        new_client->addr = address;
-        new_client->adapter = adapter;
-        new_client->driver = &lm63_driver;
-        new_client->flags = 0;
-        /* Default to an LM63 if forced */
-        if (kind == 0)
-                kind = lm63;
        if (kind < 0) { /* must identify */
                u8 man_id, chip_id, reg_config1, reg_config2;
@@ -477,25 +459,38 @@ static int lm63_detect(struct i2c_adapter *adapter, int address, int kind)
                        dev_dbg(&adapter->dev, "Unsupported chip "
                                "(man_id=0x%02X, chip_id=0x%02X).\n",
                                man_id, chip_id);
-                        goto exit_free;
+                        return -ENODEV;
                }
        }
-        strlcpy(new_client->name, "lm63", I2C_NAME_SIZE);
+        strlcpy(info->type, "lm63", I2C_NAME_SIZE);
+        return 0;
+}
+static int lm63_probe(struct i2c_client *new_client,
+                      const struct i2c_device_id *id)
+{
+        struct lm63_data *data;
+        int err;
+        data = kzalloc(sizeof(struct lm63_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(new_client, data);
        data->valid = 0;
        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
-        if ((err = i2c_attach_client(new_client)))
-                goto exit_free;
        /* Initialize the LM63 chip */
        lm63_init_client(new_client);
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&new_client->dev.kobj,
                                      &lm63_group)))
-                goto exit_detach;
+                goto exit_free;
        if (data->config & 0x04) { /* tachometer enabled */
                if ((err = sysfs_create_group(&new_client->dev.kobj,
                                              &lm63_group_fan1)))
@@ -513,8 +508,6 @@ static int lm63_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove_files:
        sysfs_remove_group(&new_client->dev.kobj, &lm63_group);
        sysfs_remove_group(&new_client->dev.kobj, &lm63_group_fan1);
-exit_detach:
-        i2c_detach_client(new_client);
 exit_free:
        kfree(data);
 exit:
@@ -556,18 +549,14 @@ static void lm63_init_client(struct i2c_client *client)
                (data->config_fan & 0x20) ? "manual" : "auto");
 }
-static int lm63_detach_client(struct i2c_client *client)
+static int lm63_remove(struct i2c_client *client)
 {
        struct lm63_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &lm63_group);
        sysfs_remove_group(&client->dev.kobj, &lm63_group_fan1);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
index fa7696905154..de698dc73020 100644
--- a/drivers/hwmon/lm75.c
+++ b/drivers/hwmon/lm75.c
@@ -251,10 +251,13 @@ static int lm75_detach_client(struct i2c_client *client)
   the SMBus standard. */
 static int lm75_read_value(struct i2c_client *client, u8 reg)
 {
+        int value;
        if (reg == LM75_REG_CONF)
                return i2c_smbus_read_byte_data(client, reg);
-        else
-                return swab16(i2c_smbus_read_word_data(client, reg));
+        value = i2c_smbus_read_word_data(client, reg);
+        return (value < 0) ? value : swab16(value);
 }
 static int lm75_write_value(struct i2c_client *client, u8 reg, u16 value)
@@ -287,9 +290,16 @@ static struct lm75_data *lm75_update_device(struct device *dev)
                int i;
                dev_dbg(&client->dev, "Starting lm75 update\n");
-                for (i = 0; i < ARRAY_SIZE(data->temp); i++)
+                for (i = 0; i < ARRAY_SIZE(data->temp); i++) {
-                        data->temp[i] = lm75_read_value(client,
+                        int status;
-                                                        LM75_REG_TEMP[i]);
+                        status = lm75_read_value(client, LM75_REG_TEMP[i]);
+                        if (status < 0)
+                                dev_dbg(&client->dev, "reg %d, err %d\n",
+                                                LM75_REG_TEMP[i], status);
+                        else
+                                data->temp[i] = status;
+                }
                data->last_updated = jiffies;
                data->valid = 1;
        }
diff --git a/drivers/hwmon/lm77.c b/drivers/hwmon/lm77.c
index 36d5a8c3ad8c..866b401ab6e8 100644
--- a/drivers/hwmon/lm77.c
+++ b/drivers/hwmon/lm77.c
@@ -52,7 +52,6 @@ I2C_CLIENT_INSMOD_1(lm77);
 /* Each client has this additional data */
 struct lm77_data {
-        struct i2c_client       client;
        struct device           *hwmon_dev;
        struct mutex            update_lock;
        char                    valid;
@@ -65,23 +64,35 @@ struct lm77_data {
        u8                      alarms;
 };
-static int lm77_attach_adapter(struct i2c_adapter *adapter);
+static int lm77_probe(struct i2c_client *client,
-static int lm77_detect(struct i2c_adapter *adapter, int address, int kind);
+                      const struct i2c_device_id *id);
+static int lm77_detect(struct i2c_client *client, int kind,
+                       struct i2c_board_info *info);
 static void lm77_init_client(struct i2c_client *client);
-static int lm77_detach_client(struct i2c_client *client);
+static int lm77_remove(struct i2c_client *client);
 static u16 lm77_read_value(struct i2c_client *client, u8 reg);
 static int lm77_write_value(struct i2c_client *client, u8 reg, u16 value);
 static struct lm77_data *lm77_update_device(struct device *dev);
+static const struct i2c_device_id lm77_id[] = {
+        { "lm77", lm77 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, lm77_id);
 /* This is the driver that will be inserted */
 static struct i2c_driver lm77_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "lm77",
        },
-        .attach_adapter = lm77_attach_adapter,
+        .probe          = lm77_probe,
-        .detach_client  = lm77_detach_client,
+        .remove         = lm77_remove,
+        .id_table       = lm77_id,
+        .detect         = lm77_detect,
+        .address_data   = &addr_data,
 };
 /* straight from the datasheet */
@@ -215,13 +226,6 @@ static SENSOR_DEVICE_ATTR(temp1_crit_alarm, S_IRUGO, show_alarm, NULL, 2);
 static SENSOR_DEVICE_ATTR(temp1_min_alarm, S_IRUGO, show_alarm, NULL, 0);
 static SENSOR_DEVICE_ATTR(temp1_max_alarm, S_IRUGO, show_alarm, NULL, 1);
-static int lm77_attach_adapter(struct i2c_adapter *adapter)
-{
-        if (!(adapter->class & I2C_CLASS_HWMON))
-                return 0;
-        return i2c_probe(adapter, &addr_data, lm77_detect);
-}
 static struct attribute *lm77_attributes[] = {
        &dev_attr_temp1_input.attr,
        &dev_attr_temp1_crit.attr,
@@ -240,32 +244,15 @@ static const struct attribute_group lm77_group = {
        .attrs = lm77_attributes,
 };
-/* This function is called by i2c_probe */
+/* Return 0 if detection is successful, -ENODEV otherwise */
-static int lm77_detect(struct i2c_adapter *adapter, int address, int kind)
+static int lm77_detect(struct i2c_client *new_client, int kind,
+                       struct i2c_board_info *info)
 {
-        struct i2c_client *new_client;
+        struct i2c_adapter *adapter = new_client->adapter;
-        struct lm77_data *data;
-        int err = 0;
-        const char *name = "";
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA |
                                     I2C_FUNC_SMBUS_WORD_DATA))
-                goto exit;
+                return -ENODEV;
-        /* OK. For now, we presume we have a valid client. We now create the
-           client structure, even though we cannot fill it completely yet.
-           But it allows us to access lm77_{read,write}_value. */
-        if (!(data = kzalloc(sizeof(struct lm77_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        new_client = &data->client;
-        i2c_set_clientdata(new_client, data);
-        new_client->addr = address;
-        new_client->adapter = adapter;
-        new_client->driver = &lm77_driver;
-        new_client->flags = 0;
        /* Here comes the remaining detection.  Since the LM77 has no
           register dedicated to identification, we have to rely on the
@@ -294,7 +281,7 @@ static int lm77_detect(struct i2c_adapter *adapter, int address, int kind)
                            || i2c_smbus_read_word_data(new_client, i + 3) != crit
                            || i2c_smbus_read_word_data(new_client, i + 4) != min
                            || i2c_smbus_read_word_data(new_client, i + 5) != max)
-                                goto exit_free;
+                                return -ENODEV;
                /* sign bits */
                if (((cur & 0x00f0) != 0xf0 && (cur & 0x00f0) != 0x0)
@@ -302,51 +289,55 @@ static int lm77_detect(struct i2c_adapter *adapter, int address, int kind)
                    || ((crit & 0x00f0) != 0xf0 && (crit & 0x00f0) != 0x0)
                    || ((min & 0x00f0) != 0xf0 && (min & 0x00f0) != 0x0)
                    || ((max & 0x00f0) != 0xf0 && (max & 0x00f0) != 0x0))
-                        goto exit_free;
+                        return -ENODEV;
                /* unused bits */
                if (conf & 0xe0)
-                        goto exit_free;
+                        return -ENODEV;
                /* 0x06 and 0x07 return the last read value */
                cur = i2c_smbus_read_word_data(new_client, 0);
                if (i2c_smbus_read_word_data(new_client, 6) != cur
                    || i2c_smbus_read_word_data(new_client, 7) != cur)
-                        goto exit_free;
+                        return -ENODEV;
                hyst = i2c_smbus_read_word_data(new_client, 2);
                if (i2c_smbus_read_word_data(new_client, 6) != hyst
                    || i2c_smbus_read_word_data(new_client, 7) != hyst)
-                        goto exit_free;
+                        return -ENODEV;
                min = i2c_smbus_read_word_data(new_client, 4);
                if (i2c_smbus_read_word_data(new_client, 6) != min
                    || i2c_smbus_read_word_data(new_client, 7) != min)
-                        goto exit_free;
+                        return -ENODEV;
        }
-        /* Determine the chip type - only one kind supported! */
+        strlcpy(info->type, "lm77", I2C_NAME_SIZE);
-        if (kind <= 0)
-                kind = lm77;
-        if (kind == lm77) {
+        return 0;
-                name = "lm77";
+}
+static int lm77_probe(struct i2c_client *new_client,
+                      const struct i2c_device_id *id)
+{
+        struct lm77_data *data;
+        int err;
+        data = kzalloc(sizeof(struct lm77_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
        }
-        /* Fill in the remaining client fields and put it into the global list */
+        i2c_set_clientdata(new_client, data);
-        strlcpy(new_client->name, name, I2C_NAME_SIZE);
        data->valid = 0;
        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
-        if ((err = i2c_attach_client(new_client)))
-                goto exit_free;
        /* Initialize the LM77 chip */
        lm77_init_client(new_client);
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&new_client->dev.kobj, &lm77_group)))
-                goto exit_detach;
+                goto exit_free;
        data->hwmon_dev = hwmon_device_register(&new_client->dev);
        if (IS_ERR(data->hwmon_dev)) {
@@ -358,20 +349,17 @@ static int lm77_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove:
        sysfs_remove_group(&new_client->dev.kobj, &lm77_group);
-exit_detach:
-        i2c_detach_client(new_client);
 exit_free:
        kfree(data);
 exit:
        return err;
 }
-static int lm77_detach_client(struct i2c_client *client)
+static int lm77_remove(struct i2c_client *client)
 {
        struct lm77_data *data = i2c_get_clientdata(client);
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &lm77_group);
-        i2c_detach_client(client);
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/lm80.c b/drivers/hwmon/lm80.c
index 26c91c9d4769..bcffc1899403 100644
--- a/drivers/hwmon/lm80.c
+++ b/drivers/hwmon/lm80.c
@@ -108,7 +108,6 @@ static inline long TEMP_FROM_REG(u16 temp)
 */
 struct lm80_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid;             /* !=0 if following fields are valid */
@@ -132,10 +131,12 @@ struct lm80_data {
 * Functions declaration
 */
-static int lm80_attach_adapter(struct i2c_adapter *adapter);
+static int lm80_probe(struct i2c_client *client,
-static int lm80_detect(struct i2c_adapter *adapter, int address, int kind);
+                      const struct i2c_device_id *id);
+static int lm80_detect(struct i2c_client *client, int kind,
+                       struct i2c_board_info *info);
 static void lm80_init_client(struct i2c_client *client);
-static int lm80_detach_client(struct i2c_client *client);
+static int lm80_remove(struct i2c_client *client);
 static struct lm80_data *lm80_update_device(struct device *dev);
 static int lm80_read_value(struct i2c_client *client, u8 reg);
 static int lm80_write_value(struct i2c_client *client, u8 reg, u8 value);
@@ -144,12 +145,22 @@ static int lm80_write_value(struct i2c_client *client, u8 reg, u8 value);
 * Driver data (common to all clients)
 */
+static const struct i2c_device_id lm80_id[] = {
+        { "lm80", lm80 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, lm80_id);
 static struct i2c_driver lm80_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "lm80",
        },
-        .attach_adapter = lm80_attach_adapter,
+        .probe          = lm80_probe,
-        .detach_client  = lm80_detach_client,
+        .remove         = lm80_remove,
+        .id_table       = lm80_id,
+        .detect         = lm80_detect,
+        .address_data   = &addr_data,
 };
 /*
@@ -383,13 +394,6 @@ static SENSOR_DEVICE_ATTR(temp1_crit_alarm, S_IRUGO, show_alarm, NULL, 13);
 * Real code
 */
-static int lm80_attach_adapter(struct i2c_adapter *adapter)
-{
-        if (!(adapter->class & I2C_CLASS_HWMON))
-                return 0;
-        return i2c_probe(adapter, &addr_data, lm80_detect);
-}
 static struct attribute *lm80_attributes[] = {
        &sensor_dev_attr_in0_min.dev_attr.attr,
        &sensor_dev_attr_in1_min.dev_attr.attr,
@@ -442,53 +446,46 @@ static const struct attribute_group lm80_group = {
        .attrs = lm80_attributes,
 };
-static int lm80_detect(struct i2c_adapter *adapter, int address, int kind)
+/* Return 0 if detection is successful, -ENODEV otherwise */
+static int lm80_detect(struct i2c_client *client, int kind,
+                       struct i2c_board_info *info)
 {
+        struct i2c_adapter *adapter = client->adapter;
        int i, cur;
-        struct i2c_client *client;
-        struct lm80_data *data;
-        int err = 0;
-        const char *name;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
-                goto exit;
+                return -ENODEV;
-        /* OK. For now, we presume we have a valid client. We now create the
-           client structure, even though we cannot fill it completely yet.
-           But it allows us to access lm80_{read,write}_value. */
-        if (!(data = kzalloc(sizeof(struct lm80_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        client = &data->client;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &lm80_driver;
        /* Now, we do the remaining detection. It is lousy. */
        if (lm80_read_value(client, LM80_REG_ALARM2) & 0xc0)
-                goto error_free;
+                return -ENODEV;
        for (i = 0x2a; i <= 0x3d; i++) {
                cur = i2c_smbus_read_byte_data(client, i);
                if ((i2c_smbus_read_byte_data(client, i + 0x40) != cur)
                 || (i2c_smbus_read_byte_data(client, i + 0x80) != cur)
                 || (i2c_smbus_read_byte_data(client, i + 0xc0) != cur))
-                    goto error_free;
+                    return -ENODEV;
        }
-        /* Determine the chip type - only one kind supported! */
+        strlcpy(info->type, "lm80", I2C_NAME_SIZE);
-        kind = lm80;
-        name = "lm80";
-        /* Fill in the remaining client fields */
+        return 0;
-        strlcpy(client->name, name, I2C_NAME_SIZE);
+}
-        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
+static int lm80_probe(struct i2c_client *client,
-        if ((err = i2c_attach_client(client)))
+                      const struct i2c_device_id *id)
-                goto error_free;
+{
+        struct lm80_data *data;
+        int err;
+        data = kzalloc(sizeof(struct lm80_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(client, data);
+        mutex_init(&data->update_lock);
        /* Initialize the LM80 chip */
        lm80_init_client(client);
@@ -499,7 +496,7 @@ static int lm80_detect(struct i2c_adapter *adapter, int address, int kind)
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&client->dev.kobj, &lm80_group)))
-                goto error_detach;
+                goto error_free;
        data->hwmon_dev = hwmon_device_register(&client->dev);
        if (IS_ERR(data->hwmon_dev)) {
@@ -511,23 +508,18 @@ static int lm80_detect(struct i2c_adapter *adapter, int address, int kind)
 error_remove:
        sysfs_remove_group(&client->dev.kobj, &lm80_group);
-error_detach:
-        i2c_detach_client(client);
 error_free:
        kfree(data);
 exit:
        return err;
 }
-static int lm80_detach_client(struct i2c_client *client)
+static int lm80_remove(struct i2c_client *client)
 {
        struct lm80_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &lm80_group);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
diff --git a/drivers/hwmon/lm83.c b/drivers/hwmon/lm83.c
index 6a8642fa25fb..e59e2d1f080c 100644
--- a/drivers/hwmon/lm83.c
+++ b/drivers/hwmon/lm83.c
@@ -1,7 +1,7 @@
 /*
 * lm83.c - Part of lm_sensors, Linux kernel modules for hardware
 *          monitoring
- * Copyright (C) 2003-2006  Jean Delvare <khali@linux-fr.org>
+ * Copyright (C) 2003-2008  Jean Delvare <khali@linux-fr.org>
 *
 * Heavily inspired from the lm78, lm75 and adm1021 drivers. The LM83 is
 * a sensor chip made by National Semiconductor. It reports up to four
@@ -118,21 +118,34 @@ static const u8 LM83_REG_W_HIGH[] = {
 * Functions declaration
 */
-static int lm83_attach_adapter(struct i2c_adapter *adapter);
+static int lm83_detect(struct i2c_client *new_client, int kind,
-static int lm83_detect(struct i2c_adapter *adapter, int address, int kind);
+                       struct i2c_board_info *info);
-static int lm83_detach_client(struct i2c_client *client);
+static int lm83_probe(struct i2c_client *client,
+                      const struct i2c_device_id *id);
+static int lm83_remove(struct i2c_client *client);
 static struct lm83_data *lm83_update_device(struct device *dev);
 /*
 * Driver data (common to all clients)
 */
 
+static const struct i2c_device_id lm83_id[] = {
+        { "lm83", lm83 },
+        { "lm82", lm82 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, lm83_id);
 static struct i2c_driver lm83_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "lm83",
        },
-        .attach_adapter = lm83_attach_adapter,
+        .probe          = lm83_probe,
-        .detach_client  = lm83_detach_client,
+        .remove         = lm83_remove,
+        .id_table       = lm83_id,
+        .detect         = lm83_detect,
+        .address_data   = &addr_data,
 };
 /*
@@ -140,7 +153,6 @@ static struct i2c_driver lm83_driver = {
 */
 struct lm83_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid; /* zero until following fields are valid */
@@ -278,40 +290,15 @@ static const struct attribute_group lm83_group_opt = {
 * Real code
 */
-static int lm83_attach_adapter(struct i2c_adapter *adapter)
+/* Return 0 if detection is successful, -ENODEV otherwise */
+static int lm83_detect(struct i2c_client *new_client, int kind,
+                       struct i2c_board_info *info)
 {
-        if (!(adapter->class & I2C_CLASS_HWMON))
+        struct i2c_adapter *adapter = new_client->adapter;
-                return 0;
-        return i2c_probe(adapter, &addr_data, lm83_detect);
-}
-/*
- * The following function does more than just detection. If detection
- * succeeds, it also registers the new chip.
- */
-static int lm83_detect(struct i2c_adapter *adapter, int address, int kind)
-{
-        struct i2c_client *new_client;
-        struct lm83_data *data;
-        int err = 0;
        const char *name = "";
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
-                goto exit;
+                return -ENODEV;
-        if (!(data = kzalloc(sizeof(struct lm83_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        /* The common I2C client data is placed right after the
-         * LM83-specific data. */
-        new_client = &data->client;
-        i2c_set_clientdata(new_client, data);
-        new_client->addr = address;
-        new_client->adapter = adapter;
-        new_client->driver = &lm83_driver;
-        new_client->flags = 0;
        /* Now we do the detection and identification. A negative kind
         * means that the driver was loaded with no force parameter
@@ -335,8 +322,9 @@ static int lm83_detect(struct i2c_adapter *adapter, int address, int kind)
                    ((i2c_smbus_read_byte_data(new_client, LM83_REG_R_CONFIG)
                    & 0x41) != 0x00)) {
                        dev_dbg(&adapter->dev,
-                            "LM83 detection failed at 0x%02x.\n", address);
+                                "LM83 detection failed at 0x%02x.\n",
-                        goto exit_free;
+                                new_client->addr);
+                        return -ENODEV;
                }
        }
@@ -361,7 +349,7 @@ static int lm83_detect(struct i2c_adapter *adapter, int address, int kind)
                        dev_info(&adapter->dev,
                            "Unsupported chip (man_id=0x%02X, "
                            "chip_id=0x%02X).\n", man_id, chip_id);
-                        goto exit_free;
+                        return -ENODEV;
                }
        }
@@ -372,15 +360,27 @@ static int lm83_detect(struct i2c_adapter *adapter, int address, int kind)
                name = "lm82";
        }
-        /* We can fill in the remaining client fields */
+        strlcpy(info->type, name, I2C_NAME_SIZE);
-        strlcpy(new_client->name, name, I2C_NAME_SIZE);
+        return 0;
+}
+static int lm83_probe(struct i2c_client *new_client,
+                      const struct i2c_device_id *id)
+{
+        struct lm83_data *data;
+        int err;
+        data = kzalloc(sizeof(struct lm83_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(new_client, data);
        data->valid = 0;
        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
-        if ((err = i2c_attach_client(new_client)))
-                goto exit_free;
        /*
         * Register sysfs hooks
         * The LM82 can only monitor one external diode which is
@@ -389,9 +389,9 @@ static int lm83_detect(struct i2c_adapter *adapter, int address, int kind)
         */
        if ((err = sysfs_create_group(&new_client->dev.kobj, &lm83_group)))
-                goto exit_detach;
+                goto exit_free;
-        if (kind == lm83) {
+        if (id->driver_data == lm83) {
                if ((err = sysfs_create_group(&new_client->dev.kobj,
                                              &lm83_group_opt)))
                        goto exit_remove_files;
@@ -408,26 +408,20 @@ static int lm83_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove_files:
        sysfs_remove_group(&new_client->dev.kobj, &lm83_group);
        sysfs_remove_group(&new_client->dev.kobj, &lm83_group_opt);
-exit_detach:
-        i2c_detach_client(new_client);
 exit_free:
        kfree(data);
 exit:
        return err;
 }
-static int lm83_detach_client(struct i2c_client *client)
+static int lm83_remove(struct i2c_client *client)
 {
        struct lm83_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &lm83_group);
        sysfs_remove_group(&client->dev.kobj, &lm83_group_opt);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/lm85.c b/drivers/hwmon/lm85.c
index 182fe6a5605f..ee5eca1c1921 100644
--- a/drivers/hwmon/lm85.c
+++ b/drivers/hwmon/lm85.c
@@ -192,23 +192,20 @@ static int RANGE_TO_REG( int range )
 {
        int i;
-        if ( range < lm85_range_map[0] ) { 
+        if (range >= lm85_range_map[15])
-                return 0 ;
-        } else if ( range > lm85_range_map[15] ) {
                return 15 ;
-        } else {  /* find closest match */
-                for ( i = 14 ; i >= 0 ; --i ) {
+        /* Find the closest match */
-                        if ( range > lm85_range_map[i] ) { /* range bracketed */
+        for (i = 14; i >= 0; --i) {
-                                if ((lm85_range_map[i+1] - range) < 
+                if (range >= lm85_range_map[i]) {
-                                        (range - lm85_range_map[i])) {
+                        if ((lm85_range_map[i + 1] - range) <
-                                        i++;
+                                        (range - lm85_range_map[i]))
-                                        break;
+                                return i + 1;
-                                }
+                        return i;
-                                break;
-                        }
                }
        }
-        return( i & 0x0f );
+        return 0;
 }
 #define RANGE_FROM_REG(val) (lm85_range_map[(val)&0x0f])
diff --git a/drivers/hwmon/lm87.c b/drivers/hwmon/lm87.c
index e1c183f0aae0..21970f0d53a1 100644
--- a/drivers/hwmon/lm87.c
+++ b/drivers/hwmon/lm87.c
@@ -5,7 +5,7 @@
 *                          Philip Edelbrock <phil@netroedge.com>
 *                          Stephen Rousset <stephen.rousset@rocketlogix.com>
 *                          Dan Eaton <dan.eaton@rocketlogix.com>
- * Copyright (C) 2004,2007  Jean Delvare <khali@linux-fr.org>
+ * Copyright (C) 2004-2008  Jean Delvare <khali@linux-fr.org>
 *
 * Original port to Linux 2.6 by Jeff Oliver.
 *
@@ -157,22 +157,35 @@ static u8 LM87_REG_TEMP_LOW[3] = { 0x3A, 0x38, 0x2C };
 * Functions declaration
 */
-static int lm87_attach_adapter(struct i2c_adapter *adapter);
+static int lm87_probe(struct i2c_client *client,
-static int lm87_detect(struct i2c_adapter *adapter, int address, int kind);
+                      const struct i2c_device_id *id);
+static int lm87_detect(struct i2c_client *new_client, int kind,
+                       struct i2c_board_info *info);
 static void lm87_init_client(struct i2c_client *client);
-static int lm87_detach_client(struct i2c_client *client);
+static int lm87_remove(struct i2c_client *client);
 static struct lm87_data *lm87_update_device(struct device *dev);
 /*
 * Driver data (common to all clients)
 */
+static const struct i2c_device_id lm87_id[] = {
+        { "lm87", lm87 },
+        { "adm1024", adm1024 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, lm87_id);
 static struct i2c_driver lm87_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "lm87",
        },
-        .attach_adapter = lm87_attach_adapter,
+        .probe          = lm87_probe,
-        .detach_client  = lm87_detach_client,
+        .remove         = lm87_remove,
+        .id_table       = lm87_id,
+        .detect         = lm87_detect,
+        .address_data   = &addr_data,
 };
 /*
@@ -180,7 +193,6 @@ static struct i2c_driver lm87_driver = {
 */
 struct lm87_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid; /* zero until following fields are valid */
@@ -562,13 +574,6 @@ static SENSOR_DEVICE_ATTR(temp3_fault, S_IRUGO, show_alarm, NULL, 15);
 * Real code
 */
-static int lm87_attach_adapter(struct i2c_adapter *adapter)
-{
-        if (!(adapter->class & I2C_CLASS_HWMON))
-                return 0;
-        return i2c_probe(adapter, &addr_data, lm87_detect);
-}
 static struct attribute *lm87_attributes[] = {
        &dev_attr_in1_input.attr,
        &dev_attr_in1_min.attr,
@@ -656,33 +661,15 @@ static const struct attribute_group lm87_group_opt = {
        .attrs = lm87_attributes_opt,
 };
-/*
+/* Return 0 if detection is successful, -ENODEV otherwise */
- * The following function does more than just detection. If detection
+static int lm87_detect(struct i2c_client *new_client, int kind,
- * succeeds, it also registers the new chip.
+                       struct i2c_board_info *info)
- */
-static int lm87_detect(struct i2c_adapter *adapter, int address, int kind)
 {
-        struct i2c_client *new_client;
+        struct i2c_adapter *adapter = new_client->adapter;
-        struct lm87_data *data;
-        int err = 0;
        static const char *names[] = { "lm87", "adm1024" };
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
-                goto exit;
+                return -ENODEV;
-        if (!(data = kzalloc(sizeof(struct lm87_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        /* The common I2C client data is placed right before the
-           LM87-specific data. */
-        new_client = &data->client;
-        i2c_set_clientdata(new_client, data);
-        new_client->addr = address;
-        new_client->adapter = adapter;
-        new_client->driver = &lm87_driver;
-        new_client->flags = 0;
        /* Default to an LM87 if forced */
        if (kind == 0)
@@ -704,20 +691,32 @@ static int lm87_detect(struct i2c_adapter *adapter, int address, int kind)
                 || (lm87_read_value(new_client, LM87_REG_CONFIG) & 0x80)) {
                        dev_dbg(&adapter->dev,
                                "LM87 detection failed at 0x%02x.\n",
-                                address);
+                                new_client->addr);
-                        goto exit_free;
+                        return -ENODEV;
                }
        }
-        /* We can fill in the remaining client fields */
+        strlcpy(info->type, names[kind - 1], I2C_NAME_SIZE);
-        strlcpy(new_client->name, names[kind - 1], I2C_NAME_SIZE);
+        return 0;
+}
+static int lm87_probe(struct i2c_client *new_client,
+                      const struct i2c_device_id *id)
+{
+        struct lm87_data *data;
+        int err;
+        data = kzalloc(sizeof(struct lm87_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(new_client, data);
        data->valid = 0;
        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
-        if ((err = i2c_attach_client(new_client)))
-                goto exit_free;
        /* Initialize the LM87 chip */
        lm87_init_client(new_client);
@@ -732,7 +731,7 @@ static int lm87_detect(struct i2c_adapter *adapter, int address, int kind)
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&new_client->dev.kobj, &lm87_group)))
-                goto exit_detach;
+                goto exit_free;
        if (data->channel & CHAN_NO_FAN(0)) {
                if ((err = device_create_file(&new_client->dev,
@@ -832,8 +831,6 @@ static int lm87_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove:
        sysfs_remove_group(&new_client->dev.kobj, &lm87_group);
        sysfs_remove_group(&new_client->dev.kobj, &lm87_group_opt);
-exit_detach:
-        i2c_detach_client(new_client);
 exit_free:
        kfree(data);
 exit:
@@ -877,18 +874,14 @@ static void lm87_init_client(struct i2c_client *client)
        }
 }
-static int lm87_detach_client(struct i2c_client *client)
+static int lm87_remove(struct i2c_client *client)
 {
        struct lm87_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &lm87_group);
        sysfs_remove_group(&client->dev.kobj, &lm87_group_opt);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c
index d1a3da3dd8e0..c24fe36ac787 100644
--- a/drivers/hwmon/lm90.c
+++ b/drivers/hwmon/lm90.c
@@ -187,23 +187,44 @@ I2C_CLIENT_INSMOD_7(lm90, adm1032, lm99, lm86, max6657, adt7461, max6680);
 * Functions declaration
 */
-static int lm90_attach_adapter(struct i2c_adapter *adapter);
+static int lm90_detect(struct i2c_client *client, int kind,
-static int lm90_detect(struct i2c_adapter *adapter, int address,
+                       struct i2c_board_info *info);
-        int kind);
+static int lm90_probe(struct i2c_client *client,
+                      const struct i2c_device_id *id);
 static void lm90_init_client(struct i2c_client *client);
-static int lm90_detach_client(struct i2c_client *client);
+static int lm90_remove(struct i2c_client *client);
 static struct lm90_data *lm90_update_device(struct device *dev);
 /*
 * Driver data (common to all clients)
 */
+static const struct i2c_device_id lm90_id[] = {
+        { "adm1032", adm1032 },
+        { "adt7461", adt7461 },
+        { "lm90", lm90 },
+        { "lm86", lm86 },
+        { "lm89", lm99 },
+        { "lm99", lm99 },       /* Missing temperature offset */
+        { "max6657", max6657 },
+        { "max6658", max6657 },
+        { "max6659", max6657 },
+        { "max6680", max6680 },
+        { "max6681", max6680 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, lm90_id);
 static struct i2c_driver lm90_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "lm90",
        },
-        .attach_adapter = lm90_attach_adapter,
+        .probe          = lm90_probe,
-        .detach_client  = lm90_detach_client,
+        .remove         = lm90_remove,
+        .id_table       = lm90_id,
+        .detect         = lm90_detect,
+        .address_data   = &addr_data,
 };
 /*
@@ -211,7 +232,6 @@ static struct i2c_driver lm90_driver = {
 */
 struct lm90_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid; /* zero until following fields are valid */
@@ -477,40 +497,16 @@ static int lm90_read_reg(struct i2c_client* client, u8 reg, u8 *value)
        return 0;
 }
-static int lm90_attach_adapter(struct i2c_adapter *adapter)
+/* Return 0 if detection is successful, -ENODEV otherwise */
-{
+static int lm90_detect(struct i2c_client *new_client, int kind,
-        if (!(adapter->class & I2C_CLASS_HWMON))
+                       struct i2c_board_info *info)
-                return 0;
-        return i2c_probe(adapter, &addr_data, lm90_detect);
-}
-/*
- * The following function does more than just detection. If detection
- * succeeds, it also registers the new chip.
- */
-static int lm90_detect(struct i2c_adapter *adapter, int address, int kind)
 {
-        struct i2c_client *new_client;
+        struct i2c_adapter *adapter = new_client->adapter;
-        struct lm90_data *data;
+        int address = new_client->addr;
-        int err = 0;
        const char *name = "";
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
-                goto exit;
+                return -ENODEV;
-        if (!(data = kzalloc(sizeof(struct lm90_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        /* The common I2C client data is placed right before the
-           LM90-specific data. */
-        new_client = &data->client;
-        i2c_set_clientdata(new_client, data);
-        new_client->addr = address;
-        new_client->adapter = adapter;
-        new_client->driver = &lm90_driver;
-        new_client->flags = 0;
        /*
         * Now we do the remaining detection. A negative kind means that
@@ -538,7 +534,7 @@ static int lm90_detect(struct i2c_adapter *adapter, int address, int kind)
                                                LM90_REG_R_CONFIG1)) < 0
                 || (reg_convrate = i2c_smbus_read_byte_data(new_client,
                                                LM90_REG_R_CONVRATE)) < 0)
-                        goto exit_free;
+                        return -ENODEV;
                
                if ((address == 0x4C || address == 0x4D)
                 && man_id == 0x01) { /* National Semiconductor */
@@ -546,7 +542,7 @@ static int lm90_detect(struct i2c_adapter *adapter, int address, int kind)
                        if ((reg_config2 = i2c_smbus_read_byte_data(new_client,
                                                LM90_REG_R_CONFIG2)) < 0)
-                                goto exit_free;
+                                return -ENODEV;
                        if ((reg_config1 & 0x2A) == 0x00
                         && (reg_config2 & 0xF8) == 0x00
@@ -610,10 +606,11 @@ static int lm90_detect(struct i2c_adapter *adapter, int address, int kind)
                        dev_info(&adapter->dev,
                            "Unsupported chip (man_id=0x%02X, "
                            "chip_id=0x%02X).\n", man_id, chip_id);
-                        goto exit_free;
+                        return -ENODEV;
                }
        }
+        /* Fill the i2c board info */
        if (kind == lm90) {
                name = "lm90";
        } else if (kind == adm1032) {
@@ -621,7 +618,7 @@ static int lm90_detect(struct i2c_adapter *adapter, int address, int kind)
                /* The ADM1032 supports PEC, but only if combined
                   transactions are not used. */
                if (i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE))
-                        new_client->flags |= I2C_CLIENT_PEC;
+                        info->flags |= I2C_CLIENT_PEC;
        } else if (kind == lm99) {
                name = "lm99";
        } else if (kind == lm86) {
@@ -633,23 +630,39 @@ static int lm90_detect(struct i2c_adapter *adapter, int address, int kind)
        } else if (kind == adt7461) {
                name = "adt7461";
        }
+        strlcpy(info->type, name, I2C_NAME_SIZE);
+        return 0;
+}
+static int lm90_probe(struct i2c_client *new_client,
+                      const struct i2c_device_id *id)
+{
+        struct i2c_adapter *adapter = to_i2c_adapter(new_client->dev.parent);
+        struct lm90_data *data;
+        int err;
-        /* We can fill in the remaining client fields */
+        data = kzalloc(sizeof(struct lm90_data), GFP_KERNEL);
-        strlcpy(new_client->name, name, I2C_NAME_SIZE);
+        if (!data) {
-        data->valid = 0;
+                err = -ENOMEM;
-        data->kind = kind;
+                goto exit;
+        }
+        i2c_set_clientdata(new_client, data);
        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
+        /* Set the device type */
-        if ((err = i2c_attach_client(new_client)))
+        data->kind = id->driver_data;
-                goto exit_free;
+        if (data->kind == adm1032) {
+                if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE))
+                        new_client->flags &= ~I2C_CLIENT_PEC;
+        }
        /* Initialize the LM90 chip */
        lm90_init_client(new_client);
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&new_client->dev.kobj, &lm90_group)))
-                goto exit_detach;
+                goto exit_free;
        if (new_client->flags & I2C_CLIENT_PEC) {
                if ((err = device_create_file(&new_client->dev,
                                              &dev_attr_pec)))
@@ -672,8 +685,6 @@ static int lm90_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove_files:
        sysfs_remove_group(&new_client->dev.kobj, &lm90_group);
        device_remove_file(&new_client->dev, &dev_attr_pec);
-exit_detach:
-        i2c_detach_client(new_client);
 exit_free:
        kfree(data);
 exit:
@@ -710,10 +721,9 @@ static void lm90_init_client(struct i2c_client *client)
                i2c_smbus_write_byte_data(client, LM90_REG_W_CONFIG1, config);
 }
-static int lm90_detach_client(struct i2c_client *client)
+static int lm90_remove(struct i2c_client *client)
 {
        struct lm90_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &lm90_group);
@@ -722,9 +732,6 @@ static int lm90_detach_client(struct i2c_client *client)
                device_remove_file(&client->dev,
                                   &sensor_dev_attr_temp2_offset.dev_attr);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/lm92.c b/drivers/hwmon/lm92.c
index c31942e08246..b2e00c5a7eec 100644
--- a/drivers/hwmon/lm92.c
+++ b/drivers/hwmon/lm92.c
@@ -1,6 +1,6 @@
 /*
 * lm92 - Hardware monitoring driver
- * Copyright (C) 2005  Jean Delvare <khali@linux-fr.org>
+ * Copyright (C) 2005-2008  Jean Delvare <khali@linux-fr.org>
 *
 * Based on the lm90 driver, with some ideas taken from the lm_sensors
 * lm92 driver as well.
@@ -96,7 +96,6 @@ static struct i2c_driver lm92_driver;
 /* Client data (each client gets its own) */
 struct lm92_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid; /* zero until following fields are valid */
@@ -319,32 +318,15 @@ static const struct attribute_group lm92_group = {
        .attrs = lm92_attributes,
 };
-/* The following function does more than just detection. If detection
+/* Return 0 if detection is successful, -ENODEV otherwise */
-   succeeds, it also registers the new chip. */
+static int lm92_detect(struct i2c_client *new_client, int kind,
-static int lm92_detect(struct i2c_adapter *adapter, int address, int kind)
+                       struct i2c_board_info *info)
 {
-        struct i2c_client *new_client;
+        struct i2c_adapter *adapter = new_client->adapter;
-        struct lm92_data *data;
-        int err = 0;
-        char *name;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA
                                            | I2C_FUNC_SMBUS_WORD_DATA))
-                goto exit;
+                return -ENODEV;
-        if (!(data = kzalloc(sizeof(struct lm92_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        /* Fill in enough client fields so that we can read from the chip,
-           which is required for identication */
-        new_client = &data->client;
-        i2c_set_clientdata(new_client, data);
-        new_client->addr = address;
-        new_client->adapter = adapter;
-        new_client->driver = &lm92_driver;
-        new_client->flags = 0;
        /* A negative kind means that the driver was loaded with no force
           parameter (default), so we must identify the chip. */
@@ -364,34 +346,36 @@ static int lm92_detect(struct i2c_adapter *adapter, int address, int kind)
                        kind = lm92; /* No separate prefix */
                }
                else
-                        goto exit_free;
+                        return -ENODEV;
-        } else
-        if (kind == 0) /* Default to an LM92 if forced */
-                kind = lm92;
-        /* Give it the proper name */
-        if (kind == lm92) {
-                name = "lm92";
-        } else { /* Supposedly cannot happen */
-                dev_dbg(&new_client->dev, "Kind out of range?\n");
-                goto exit_free;
        }
-        /* Fill in the remaining client fields */
+        strlcpy(info->type, "lm92", I2C_NAME_SIZE);
-        strlcpy(new_client->name, name, I2C_NAME_SIZE);
+        return 0;
+}
+static int lm92_probe(struct i2c_client *new_client,
+                      const struct i2c_device_id *id)
+{
+        struct lm92_data *data;
+        int err;
+        data = kzalloc(sizeof(struct lm92_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(new_client, data);
        data->valid = 0;
        mutex_init(&data->update_lock);
-        /* Tell the i2c subsystem a new client has arrived */
-        if ((err = i2c_attach_client(new_client)))
-                goto exit_free;
        /* Initialize the chipset */
        lm92_init_client(new_client);
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&new_client->dev.kobj, &lm92_group)))
-                goto exit_detach;
+                goto exit_free;
        data->hwmon_dev = hwmon_device_register(&new_client->dev);
        if (IS_ERR(data->hwmon_dev)) {
@@ -403,32 +387,19 @@ static int lm92_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove:
        sysfs_remove_group(&new_client->dev.kobj, &lm92_group);
-exit_detach:
-        i2c_detach_client(new_client);
 exit_free:
        kfree(data);
 exit:
        return err;
 }
-static int lm92_attach_adapter(struct i2c_adapter *adapter)
+static int lm92_remove(struct i2c_client *client)
-{
-        if (!(adapter->class & I2C_CLASS_HWMON))
-                return 0;
-        return i2c_probe(adapter, &addr_data, lm92_detect);
-}
-static int lm92_detach_client(struct i2c_client *client)
 {
        struct lm92_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &lm92_group);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
 }
@@ -438,12 +409,23 @@ static int lm92_detach_client(struct i2c_client *client)
 * Module and driver stuff
 */
+static const struct i2c_device_id lm92_id[] = {
+        { "lm92", lm92 },
+        /* max6635 could be added here */
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, lm92_id);
 static struct i2c_driver lm92_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "lm92",
        },
-        .attach_adapter = lm92_attach_adapter,
+        .probe          = lm92_probe,
-        .detach_client  = lm92_detach_client,
+        .remove         = lm92_remove,
+        .id_table       = lm92_id,
+        .detect         = lm92_detect,
+        .address_data   = &addr_data,
 };
 static int __init sensors_lm92_init(void)
diff --git a/drivers/hwmon/lm93.c b/drivers/hwmon/lm93.c
index 5e678f5c883d..fc36cadf36fb 100644
--- a/drivers/hwmon/lm93.c
+++ b/drivers/hwmon/lm93.c
@@ -200,7 +200,6 @@ struct block1_t {
 * Client-specific data
 */
 struct lm93_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
@@ -2501,45 +2500,14 @@ static void lm93_init_client(struct i2c_client *client)
                 "chip to signal ready!\n");
 }
-static int lm93_detect(struct i2c_adapter *adapter, int address, int kind)
+/* Return 0 if detection is successful, -ENODEV otherwise */
+static int lm93_detect(struct i2c_client *client, int kind,
+                       struct i2c_board_info *info)
 {
-        struct lm93_data *data;
+        struct i2c_adapter *adapter = client->adapter;
-        struct i2c_client *client;
-        int err = -ENODEV, func;
-        void (*update)(struct lm93_data *, struct i2c_client *);
-        /* choose update routine based on bus capabilities */
-        func = i2c_get_functionality(adapter);
-        if ( ((LM93_SMBUS_FUNC_FULL & func) == LM93_SMBUS_FUNC_FULL) &&
-                        (!disable_block) ) {
-                dev_dbg(&adapter->dev,"using SMBus block data transactions\n");
-                update = lm93_update_client_full;
-        } else if ((LM93_SMBUS_FUNC_MIN & func) == LM93_SMBUS_FUNC_MIN) {
-                dev_dbg(&adapter->dev,"disabled SMBus block data "
-                        "transactions\n");
-                update = lm93_update_client_min;
-        } else {
-                dev_dbg(&adapter->dev,"detect failed, "
-                        "smbus byte and/or word data not supported!\n");
-                goto err_out;
-        }
-        /* OK. For now, we presume we have a valid client. We now create the
+        if (!i2c_check_functionality(adapter, LM93_SMBUS_FUNC_MIN))
-           client structure, even though we cannot fill it completely yet.
+                return -ENODEV;
-           But it allows us to access lm78_{read,write}_value. */
-        if ( !(data = kzalloc(sizeof(struct lm93_data), GFP_KERNEL))) {
-                dev_dbg(&adapter->dev,"out of memory!\n");
-                err = -ENOMEM;
-                goto err_out;
-        }
-        client = &data->client;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &lm93_driver;
        /* detection */
        if (kind < 0) {
@@ -2548,7 +2516,7 @@ static int lm93_detect(struct i2c_adapter *adapter, int address, int kind)
                if (mfr != 0x01) {
                        dev_dbg(&adapter->dev,"detect failed, "
                                "bad manufacturer id 0x%02x!\n", mfr);
-                        goto err_free;
+                        return -ENODEV;
                }
        }
@@ -2563,31 +2531,61 @@ static int lm93_detect(struct i2c_adapter *adapter, int address, int kind)
                        if (kind == 0)
                                dev_dbg(&adapter->dev,
                                        "(ignored 'force' parameter)\n");
-                        goto err_free;
+                        return -ENODEV;
                }
        }
-        /* fill in remaining client fields */
+        strlcpy(info->type, "lm93", I2C_NAME_SIZE);
-        strlcpy(client->name, "lm93", I2C_NAME_SIZE);
        dev_dbg(&adapter->dev,"loading %s at %d,0x%02x\n",
                client->name, i2c_adapter_id(client->adapter),
                client->addr);
+        return 0;
+}
+static int lm93_probe(struct i2c_client *client,
+                      const struct i2c_device_id *id)
+{
+        struct lm93_data *data;
+        int err, func;
+        void (*update)(struct lm93_data *, struct i2c_client *);
+        /* choose update routine based on bus capabilities */
+        func = i2c_get_functionality(client->adapter);
+        if (((LM93_SMBUS_FUNC_FULL & func) == LM93_SMBUS_FUNC_FULL) &&
+                        (!disable_block)) {
+                dev_dbg(&client->dev, "using SMBus block data transactions\n");
+                update = lm93_update_client_full;
+        } else if ((LM93_SMBUS_FUNC_MIN & func) == LM93_SMBUS_FUNC_MIN) {
+                dev_dbg(&client->dev, "disabled SMBus block data "
+                        "transactions\n");
+                update = lm93_update_client_min;
+        } else {
+                dev_dbg(&client->dev, "detect failed, "
+                        "smbus byte and/or word data not supported!\n");
+                err = -ENODEV;
+                goto err_out;
+        }
+        data = kzalloc(sizeof(struct lm93_data), GFP_KERNEL);
+        if (!data) {
+                dev_dbg(&client->dev, "out of memory!\n");
+                err = -ENOMEM;
+                goto err_out;
+        }
+        i2c_set_clientdata(client, data);
        /* housekeeping */
        data->valid = 0;
        data->update = update;
        mutex_init(&data->update_lock);
-        /* tell the I2C layer a new client has arrived */
-        if ((err = i2c_attach_client(client)))
-                goto err_free;
        /* initialize the chip */
        lm93_init_client(client);
        err = sysfs_create_group(&client->dev.kobj, &lm93_attr_grp);
        if (err)
-                goto err_detach;
+                goto err_free;
        /* Register hwmon driver class */
        data->hwmon_dev = hwmon_device_register(&client->dev);
@@ -2597,43 +2595,39 @@ static int lm93_detect(struct i2c_adapter *adapter, int address, int kind)
        err = PTR_ERR(data->hwmon_dev);
        dev_err(&client->dev, "error registering hwmon device.\n");
        sysfs_remove_group(&client->dev.kobj, &lm93_attr_grp);
-err_detach:
-        i2c_detach_client(client);
 err_free:
        kfree(data);
 err_out:
        return err;
 }
-/* This function is called when:
+static int lm93_remove(struct i2c_client *client)
-     * lm93_driver is inserted (when this module is loaded), for each
-       available adapter
-     * when a new adapter is inserted (and lm93_driver is still present) */
-static int lm93_attach_adapter(struct i2c_adapter *adapter)
-{
-        return i2c_probe(adapter, &addr_data, lm93_detect);
-}
-static int lm93_detach_client(struct i2c_client *client)
 {
        struct lm93_data *data = i2c_get_clientdata(client);
-        int err = 0;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &lm93_attr_grp);
-        err = i2c_detach_client(client);
+        kfree(data);
-        if (!err)
+        return 0;
-                kfree(data);
-        return err;
 }
+static const struct i2c_device_id lm93_id[] = {
+        { "lm93", lm93 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, lm93_id);
 static struct i2c_driver lm93_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "lm93",
        },
-        .attach_adapter = lm93_attach_adapter,
+        .probe          = lm93_probe,
-        .detach_client  = lm93_detach_client,
+        .remove         = lm93_remove,
+        .id_table       = lm93_id,
+        .detect         = lm93_detect,
+        .address_data   = &addr_data,
 };
 static int __init lm93_init(void)
diff --git a/drivers/hwmon/max1619.c b/drivers/hwmon/max1619.c
index 7e7267a04544..1ab1cacad598 100644
--- a/drivers/hwmon/max1619.c
+++ b/drivers/hwmon/max1619.c
@@ -79,23 +79,34 @@ I2C_CLIENT_INSMOD_1(max1619);
 * Functions declaration
 */
-static int max1619_attach_adapter(struct i2c_adapter *adapter);
+static int max1619_probe(struct i2c_client *client,
-static int max1619_detect(struct i2c_adapter *adapter, int address,
+                         const struct i2c_device_id *id);
-        int kind);
+static int max1619_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info);
 static void max1619_init_client(struct i2c_client *client);
-static int max1619_detach_client(struct i2c_client *client);
+static int max1619_remove(struct i2c_client *client);
 static struct max1619_data *max1619_update_device(struct device *dev);
 /*
 * Driver data (common to all clients)
 */
+static const struct i2c_device_id max1619_id[] = {
+        { "max1619", max1619 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, max1619_id);
 static struct i2c_driver max1619_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "max1619",
        },
-        .attach_adapter = max1619_attach_adapter,
+        .probe          = max1619_probe,
-        .detach_client  = max1619_detach_client,
+        .remove         = max1619_remove,
+        .id_table       = max1619_id,
+        .detect         = max1619_detect,
+        .address_data   = &addr_data,
 };
 /*
@@ -103,7 +114,6 @@ static struct i2c_driver max1619_driver = {
 */
 struct max1619_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid; /* zero until following fields are valid */
@@ -208,41 +218,15 @@ static const struct attribute_group max1619_group = {
 * Real code
 */
-static int max1619_attach_adapter(struct i2c_adapter *adapter)
+/* Return 0 if detection is successful, -ENODEV otherwise */
-{
+static int max1619_detect(struct i2c_client *new_client, int kind,
-        if (!(adapter->class & I2C_CLASS_HWMON))
+                          struct i2c_board_info *info)
-                return 0;
-        return i2c_probe(adapter, &addr_data, max1619_detect);
-}
-/*
- * The following function does more than just detection. If detection
- * succeeds, it also registers the new chip.
- */
-static int max1619_detect(struct i2c_adapter *adapter, int address, int kind)
 {
-        struct i2c_client *new_client;
+        struct i2c_adapter *adapter = new_client->adapter;
-        struct max1619_data *data;
-        int err = 0;
-        const char *name = "";  
        u8 reg_config=0, reg_convrate=0, reg_status=0;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
-                goto exit;
+                return -ENODEV;
-        if (!(data = kzalloc(sizeof(struct max1619_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        /* The common I2C client data is placed right before the
-           MAX1619-specific data. */
-        new_client = &data->client;
-        i2c_set_clientdata(new_client, data);
-        new_client->addr = address;
-        new_client->adapter = adapter;
-        new_client->driver = &max1619_driver;
-        new_client->flags = 0;
        /*
         * Now we do the remaining detection. A negative kind means that
@@ -265,8 +249,8 @@ static int max1619_detect(struct i2c_adapter *adapter, int address, int kind)
                 || reg_convrate > 0x07 || (reg_status & 0x61 ) !=0x00) {
                        dev_dbg(&adapter->dev,
                                "MAX1619 detection failed at 0x%02x.\n",
-                                address);
+                                new_client->addr);
-                        goto exit_free;
+                        return -ENODEV;
                }
        }
@@ -285,28 +269,37 @@ static int max1619_detect(struct i2c_adapter *adapter, int address, int kind)
                        dev_info(&adapter->dev,
                            "Unsupported chip (man_id=0x%02X, "
                            "chip_id=0x%02X).\n", man_id, chip_id);
-                        goto exit_free;
+                        return -ENODEV;
                }
        }
-        if (kind == max1619)
+        strlcpy(info->type, "max1619", I2C_NAME_SIZE);
-                name = "max1619";
+        return 0;
+}
+static int max1619_probe(struct i2c_client *new_client,
+                         const struct i2c_device_id *id)
+{
+        struct max1619_data *data;
+        int err;
+        data = kzalloc(sizeof(struct max1619_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
-        /* We can fill in the remaining client fields */
+        i2c_set_clientdata(new_client, data);
-        strlcpy(new_client->name, name, I2C_NAME_SIZE);
        data->valid = 0;
        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
-        if ((err = i2c_attach_client(new_client)))
-                goto exit_free;
        /* Initialize the MAX1619 chip */
        max1619_init_client(new_client);
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&new_client->dev.kobj, &max1619_group)))
-                goto exit_detach;
+                goto exit_free;
        data->hwmon_dev = hwmon_device_register(&new_client->dev);
        if (IS_ERR(data->hwmon_dev)) {
@@ -318,8 +311,6 @@ static int max1619_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove_files:
        sysfs_remove_group(&new_client->dev.kobj, &max1619_group);
-exit_detach:
-        i2c_detach_client(new_client);
 exit_free:
        kfree(data);
 exit:
@@ -341,17 +332,13 @@ static void max1619_init_client(struct i2c_client *client)
                                          config & 0xBF); /* run */
 }
-static int max1619_detach_client(struct i2c_client *client)
+static int max1619_remove(struct i2c_client *client)
 {
        struct max1619_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &max1619_group);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/max6650.c b/drivers/hwmon/max6650.c
index 52d528b76cc3..f27af6a9da41 100644
--- a/drivers/hwmon/max6650.c
+++ b/drivers/hwmon/max6650.c
@@ -104,22 +104,34 @@ I2C_CLIENT_INSMOD_1(max6650);
 #define DIV_FROM_REG(reg) (1 << (reg & 7))
-static int max6650_attach_adapter(struct i2c_adapter *adapter);
+static int max6650_probe(struct i2c_client *client,
-static int max6650_detect(struct i2c_adapter *adapter, int address, int kind);
+                         const struct i2c_device_id *id);
+static int max6650_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info);
 static int max6650_init_client(struct i2c_client *client);
-static int max6650_detach_client(struct i2c_client *client);
+static int max6650_remove(struct i2c_client *client);
 static struct max6650_data *max6650_update_device(struct device *dev);
 /*
 * Driver data (common to all clients)
 */
+static const struct i2c_device_id max6650_id[] = {
+        { "max6650", max6650 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, max6650_id);
 static struct i2c_driver max6650_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "max6650",
        },
-        .attach_adapter = max6650_attach_adapter,
+        .probe          = max6650_probe,
-        .detach_client  = max6650_detach_client,
+        .remove         = max6650_remove,
+        .id_table       = max6650_id,
+        .detect         = max6650_detect,
+        .address_data   = &addr_data,
 };
 /*
@@ -128,7 +140,6 @@ static struct i2c_driver max6650_driver = {
 struct max6650_data
 {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid; /* zero until following fields are valid */
@@ -437,47 +448,21 @@ static struct attribute_group max6650_attr_grp = {
 * Real code
 */
-static int max6650_attach_adapter(struct i2c_adapter *adapter)
+/* Return 0 if detection is successful, -ENODEV otherwise */
+static int max6650_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info)
 {
-        if (!(adapter->class & I2C_CLASS_HWMON)) {
+        struct i2c_adapter *adapter = client->adapter;
-                dev_dbg(&adapter->dev,
+        int address = client->addr;
-                        "FATAL: max6650_attach_adapter class HWMON not set\n");
-                return 0;
-        }
-        return i2c_probe(adapter, &addr_data, max6650_detect);
-}
-/*
- * The following function does more than just detection. If detection
- * succeeds, it also registers the new chip.
- */
-static int max6650_detect(struct i2c_adapter *adapter, int address, int kind)
-{
-        struct i2c_client *client;
-        struct max6650_data *data;
-        int err = -ENODEV;
        dev_dbg(&adapter->dev, "max6650_detect called, kind = %d\n", kind);
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
                dev_dbg(&adapter->dev, "max6650: I2C bus doesn't support "
                                        "byte read mode, skipping.\n");
-                return 0;
+                return -ENODEV;
-        }
-        if (!(data = kzalloc(sizeof(struct max6650_data), GFP_KERNEL))) {
-                dev_err(&adapter->dev, "max6650: out of memory.\n");
-                return -ENOMEM;
        }
-        client = &data->client;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &max6650_driver;
        /*
         * Now we do the remaining detection. A negative kind means that
         * the driver was loaded with no force parameter (default), so we
@@ -501,28 +486,40 @@ static int max6650_detect(struct i2c_adapter *adapter, int address, int kind)
            ||(i2c_smbus_read_byte_data(client, MAX6650_REG_COUNT) & 0xFC))) {
                dev_dbg(&adapter->dev,
                        "max6650: detection failed at 0x%02x.\n", address);
-                goto err_free;
+                return -ENODEV;
        }
        dev_info(&adapter->dev, "max6650: chip found at 0x%02x.\n", address);
-        strlcpy(client->name, "max6650", I2C_NAME_SIZE);
+        strlcpy(info->type, "max6650", I2C_NAME_SIZE);
-        mutex_init(&data->update_lock);
-        if ((err = i2c_attach_client(client))) {
+        return 0;
-                dev_err(&adapter->dev, "max6650: failed to attach client.\n");
+}
-                goto err_free;
+static int max6650_probe(struct i2c_client *client,
+                         const struct i2c_device_id *id)
+{
+        struct max6650_data *data;
+        int err;
+        if (!(data = kzalloc(sizeof(struct max6650_data), GFP_KERNEL))) {
+                dev_err(&client->dev, "out of memory.\n");
+                return -ENOMEM;
        }
+        i2c_set_clientdata(client, data);
+        mutex_init(&data->update_lock);
        /*
         * Initialize the max6650 chip
         */
-        if (max6650_init_client(client))
+        err = max6650_init_client(client);
-                goto err_detach;
+        if (err)
+                goto err_free;
        err = sysfs_create_group(&client->dev.kobj, &max6650_attr_grp);
        if (err)
-                goto err_detach;
+                goto err_free;
        data->hwmon_dev = hwmon_device_register(&client->dev);
        if (!IS_ERR(data->hwmon_dev))
@@ -531,24 +528,19 @@ static int max6650_detect(struct i2c_adapter *adapter, int address, int kind)
        err = PTR_ERR(data->hwmon_dev);
        dev_err(&client->dev, "error registering hwmon device.\n");
        sysfs_remove_group(&client->dev.kobj, &max6650_attr_grp);
-err_detach:
-        i2c_detach_client(client);
 err_free:
        kfree(data);
        return err;
 }
-static int max6650_detach_client(struct i2c_client *client)
+static int max6650_remove(struct i2c_client *client)
 {
        struct max6650_data *data = i2c_get_clientdata(client);
-        int err;
        sysfs_remove_group(&client->dev.kobj, &max6650_attr_grp);
        hwmon_device_unregister(data->hwmon_dev);
-        err = i2c_detach_client(client);
+        kfree(data);
-        if (!err)
+        return 0;
-                kfree(data);
-        return err;
 }
 static int max6650_init_client(struct i2c_client *client)
diff --git a/drivers/hwmon/smsc47m192.c b/drivers/hwmon/smsc47m192.c
index 3c9db6598ba7..8bb5cb532d4d 100644
--- a/drivers/hwmon/smsc47m192.c
+++ b/drivers/hwmon/smsc47m192.c
@@ -96,7 +96,6 @@ static inline int TEMP_FROM_REG(s8 val)
 }
 struct smsc47m192_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid;             /* !=0 if following fields are valid */
@@ -114,18 +113,29 @@ struct smsc47m192_data {
        u8 vrm;
 };
-static int smsc47m192_attach_adapter(struct i2c_adapter *adapter);
+static int smsc47m192_probe(struct i2c_client *client,
-static int smsc47m192_detect(struct i2c_adapter *adapter, int address,
+                            const struct i2c_device_id *id);
-                int kind);
+static int smsc47m192_detect(struct i2c_client *client, int kind,
-static int smsc47m192_detach_client(struct i2c_client *client);
+                             struct i2c_board_info *info);
+static int smsc47m192_remove(struct i2c_client *client);
 static struct smsc47m192_data *smsc47m192_update_device(struct device *dev);
+static const struct i2c_device_id smsc47m192_id[] = {
+        { "smsc47m192", smsc47m192 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, smsc47m192_id);
 static struct i2c_driver smsc47m192_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "smsc47m192",
        },
-        .attach_adapter = smsc47m192_attach_adapter,
+        .probe          = smsc47m192_probe,
-        .detach_client  = smsc47m192_detach_client,
+        .remove         = smsc47m192_remove,
+        .id_table       = smsc47m192_id,
+        .detect         = smsc47m192_detect,
+        .address_data   = &addr_data,
 };
 /* Voltages */
@@ -440,17 +450,6 @@ static const struct attribute_group smsc47m192_group_in4 = {
        .attrs = smsc47m192_attributes_in4,
 };
-/* This function is called when:
-    * smsc47m192_driver is inserted (when this module is loaded), for each
-      available adapter
-    * when a new adapter is inserted (and smsc47m192_driver is still present) */
-static int smsc47m192_attach_adapter(struct i2c_adapter *adapter)
-{
-        if (!(adapter->class & I2C_CLASS_HWMON))
-                return 0;
-        return i2c_probe(adapter, &addr_data, smsc47m192_detect);
-}
 static void smsc47m192_init_client(struct i2c_client *client)
 {
        int i;
@@ -481,31 +480,15 @@ static void smsc47m192_init_client(struct i2c_client *client)
        }
 }
-/* This function is called by i2c_probe */
+/* Return 0 if detection is successful, -ENODEV otherwise */
-static int smsc47m192_detect(struct i2c_adapter *adapter, int address,
+static int smsc47m192_detect(struct i2c_client *client, int kind,
-                int kind)
+                             struct i2c_board_info *info)
 {
-        struct i2c_client *client;
+        struct i2c_adapter *adapter = client->adapter;
-        struct smsc47m192_data *data;
+        int version;
-        int err = 0;
-        int version, config;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
-                goto exit;
+                return -ENODEV;
-        if (!(data = kzalloc(sizeof(struct smsc47m192_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        client = &data->client;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &smsc47m192_driver;
-        if (kind == 0)
-                kind = smsc47m192;
        /* Detection criteria from sensors_detect script */
        if (kind < 0) {
@@ -523,26 +506,39 @@ static int smsc47m192_detect(struct i2c_adapter *adapter, int address,
                } else {
                        dev_dbg(&adapter->dev,
                                "SMSC47M192 detection failed at 0x%02x\n",
-                                address);
+                                client->addr);
-                        goto exit_free;
+                        return -ENODEV;
                }
        }
-        /* Fill in the remaining client fields and put into the global list */
+        strlcpy(info->type, "smsc47m192", I2C_NAME_SIZE);
-        strlcpy(client->name, "smsc47m192", I2C_NAME_SIZE);
+        return 0;
+}
+static int smsc47m192_probe(struct i2c_client *client,
+                            const struct i2c_device_id *id)
+{
+        struct smsc47m192_data *data;
+        int config;
+        int err;
+        data = kzalloc(sizeof(struct smsc47m192_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(client, data);
        data->vrm = vid_which_vrm();
        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
-        if ((err = i2c_attach_client(client)))
-                goto exit_free;
        /* Initialize the SMSC47M192 chip */
        smsc47m192_init_client(client);
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&client->dev.kobj, &smsc47m192_group)))
-                goto exit_detach;
+                goto exit_free;
        /* Pin 110 is either in4 (+12V) or VID4 */
        config = i2c_smbus_read_byte_data(client, SMSC47M192_REG_CONFIG);
@@ -563,26 +559,20 @@ static int smsc47m192_detect(struct i2c_adapter *adapter, int address,
 exit_remove_files:
        sysfs_remove_group(&client->dev.kobj, &smsc47m192_group);
        sysfs_remove_group(&client->dev.kobj, &smsc47m192_group_in4);
-exit_detach:
-        i2c_detach_client(client);
 exit_free:
        kfree(data);
 exit:
        return err;
 }
-static int smsc47m192_detach_client(struct i2c_client *client)
+static int smsc47m192_remove(struct i2c_client *client)
 {
        struct smsc47m192_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &smsc47m192_group);
        sysfs_remove_group(&client->dev.kobj, &smsc47m192_group_in4);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
diff --git a/drivers/hwmon/thmc50.c b/drivers/hwmon/thmc50.c
index 76a3859c3fbe..3b01001108c1 100644
--- a/drivers/hwmon/thmc50.c
+++ b/drivers/hwmon/thmc50.c
@@ -60,7 +60,6 @@ static const u8 THMC50_REG_TEMP_MAX[] = { 0x39, 0x37, 0x2B };
 /* Each client has this additional data */
 struct thmc50_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
@@ -77,17 +76,31 @@ struct thmc50_data {
        u8 alarms;
 };
-static int thmc50_attach_adapter(struct i2c_adapter *adapter);
+static int thmc50_detect(struct i2c_client *client, int kind,
-static int thmc50_detach_client(struct i2c_client *client);
+                         struct i2c_board_info *info);
+static int thmc50_probe(struct i2c_client *client,
+                        const struct i2c_device_id *id);
+static int thmc50_remove(struct i2c_client *client);
 static void thmc50_init_client(struct i2c_client *client);
 static struct thmc50_data *thmc50_update_device(struct device *dev);
+static const struct i2c_device_id thmc50_id[] = {
+        { "adm1022", adm1022 },
+        { "thmc50", thmc50 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, thmc50_id);
 static struct i2c_driver thmc50_driver = {
+        .class = I2C_CLASS_HWMON,
        .driver = {
                .name = "thmc50",
        },
-        .attach_adapter = thmc50_attach_adapter,
+        .probe = thmc50_probe,
-        .detach_client = thmc50_detach_client,
+        .remove = thmc50_remove,
+        .id_table = thmc50_id,
+        .detect = thmc50_detect,
+        .address_data = &addr_data,
 };
 static ssize_t show_analog_out(struct device *dev,
@@ -250,39 +263,23 @@ static const struct attribute_group temp3_group = {
        .attrs = temp3_attributes,
 };
-static int thmc50_detect(struct i2c_adapter *adapter, int address, int kind)
+/* Return 0 if detection is successful, -ENODEV otherwise */
+static int thmc50_detect(struct i2c_client *client, int kind,
+                         struct i2c_board_info *info)
 {
        unsigned company;
        unsigned revision;
        unsigned config;
-        struct i2c_client *client;
+        struct i2c_adapter *adapter = client->adapter;
-        struct thmc50_data *data;
-        struct device *dev;
        int err = 0;
        const char *type_name;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
                pr_debug("thmc50: detect failed, "
                         "smbus byte data not supported!\n");
-                goto exit;
+                return -ENODEV;
-        }
-        /* OK. For now, we presume we have a valid client. We now create the
-           client structure, even though we cannot fill it completely yet.
-           But it allows us to access thmc50 registers. */
-        if (!(data = kzalloc(sizeof(struct thmc50_data), GFP_KERNEL))) {
-                pr_debug("thmc50: detect failed, kzalloc failed!\n");
-                err = -ENOMEM;
-                goto exit;
        }
-        client = &data->client;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &thmc50_driver;
-        dev = &client->dev;
        pr_debug("thmc50: Probing for THMC50 at 0x%2X on bus %d\n",
                 client->addr, i2c_adapter_id(client->adapter));
@@ -307,21 +304,22 @@ static int thmc50_detect(struct i2c_adapter *adapter, int address, int kind)
        }
        if (err == -ENODEV) {
                pr_debug("thmc50: Detection of THMC50/ADM1022 failed\n");
-                goto exit_free;
+                return err;
        }
-        data->type = kind;
        if (kind == adm1022) {
                int id = i2c_adapter_id(client->adapter);
                int i;
                type_name = "adm1022";
-                data->has_temp3 = (config >> 7) & 1;    /* config MSB */
                for (i = 0; i + 1 < adm1022_temp3_num; i += 2)
                        if (adm1022_temp3[i] == id &&
-                            adm1022_temp3[i + 1] == address) {
+                            adm1022_temp3[i + 1] == client->addr) {
                                /* enable 2nd remote temp */
-                                data->has_temp3 = 1;
+                                config |= (1 << 7);
+                                i2c_smbus_write_byte_data(client,
+                                                          THMC50_REG_CONF,
+                                                          config);
                                break;
                        }
        } else {
@@ -330,19 +328,33 @@ static int thmc50_detect(struct i2c_adapter *adapter, int address, int kind)
        pr_debug("thmc50: Detected %s (version %x, revision %x)\n",
                 type_name, (revision >> 4) - 0xc, revision & 0xf);
-        /* Fill in the remaining client fields & put it into the global list */
+        strlcpy(info->type, type_name, I2C_NAME_SIZE);
-        strlcpy(client->name, type_name, I2C_NAME_SIZE);
-        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
+        return 0;
-        if ((err = i2c_attach_client(client)))
+}
-                goto exit_free;
+static int thmc50_probe(struct i2c_client *client,
+                        const struct i2c_device_id *id)
+{
+        struct thmc50_data *data;
+        int err;
+        data = kzalloc(sizeof(struct thmc50_data), GFP_KERNEL);
+        if (!data) {
+                pr_debug("thmc50: detect failed, kzalloc failed!\n");
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(client, data);
+        data->type = id->driver_data;
+        mutex_init(&data->update_lock);
        thmc50_init_client(client);
        /* Register sysfs hooks */
        if ((err = sysfs_create_group(&client->dev.kobj, &thmc50_group)))
-                goto exit_detach;
+                goto exit_free;
        /* Register ADM1022 sysfs hooks */
        if (data->has_temp3)
@@ -364,34 +376,21 @@ exit_remove_sysfs:
                sysfs_remove_group(&client->dev.kobj, &temp3_group);
 exit_remove_sysfs_thmc50:
        sysfs_remove_group(&client->dev.kobj, &thmc50_group);
-exit_detach:
-        i2c_detach_client(client);
 exit_free:
        kfree(data);
 exit:
        return err;
 }
-static int thmc50_attach_adapter(struct i2c_adapter *adapter)
+static int thmc50_remove(struct i2c_client *client)
-{
-        if (!(adapter->class & I2C_CLASS_HWMON))
-                return 0;
-        return i2c_probe(adapter, &addr_data, thmc50_detect);
-}
-static int thmc50_detach_client(struct i2c_client *client)
 {
        struct thmc50_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &thmc50_group);
        if (data->has_temp3)
                sysfs_remove_group(&client->dev.kobj, &temp3_group);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
@@ -412,8 +411,8 @@ static void thmc50_init_client(struct i2c_client *client)
        }
        config = i2c_smbus_read_byte_data(client, THMC50_REG_CONF);
        config |= 0x1;  /* start the chip if it is in standby mode */
-        if (data->has_temp3)
+        if (data->type == adm1022 && (config & (1 << 7)))
-                config |= 0x80;         /* enable 2nd remote temp */
+                data->has_temp3 = 1;
        i2c_smbus_write_byte_data(client, THMC50_REG_CONF, config);
 }
diff --git a/drivers/hwmon/w83791d.c b/drivers/hwmon/w83791d.c
index 85077c4c8039..e4e91c9d480a 100644
--- a/drivers/hwmon/w83791d.c
+++ b/drivers/hwmon/w83791d.c
@@ -247,7 +247,6 @@ static u8 div_to_reg(int nr, long val)
 }
 struct w83791d_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
@@ -286,9 +285,11 @@ struct w83791d_data {
        u8 vrm;                 /* hwmon-vid */
 };
-static int w83791d_attach_adapter(struct i2c_adapter *adapter);
+static int w83791d_probe(struct i2c_client *client,
-static int w83791d_detect(struct i2c_adapter *adapter, int address, int kind);
+                         const struct i2c_device_id *id);
-static int w83791d_detach_client(struct i2c_client *client);
+static int w83791d_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info);
+static int w83791d_remove(struct i2c_client *client);
 static int w83791d_read(struct i2c_client *client, u8 register);
 static int w83791d_write(struct i2c_client *client, u8 register, u8 value);
@@ -300,12 +301,22 @@ static void w83791d_print_debug(struct w83791d_data *data, struct device *dev);
 static void w83791d_init_client(struct i2c_client *client);
+static const struct i2c_device_id w83791d_id[] = {
+        { "w83791d", w83791d },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, w83791d_id);
 static struct i2c_driver w83791d_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name = "w83791d",
        },
-        .attach_adapter = w83791d_attach_adapter,
+        .probe          = w83791d_probe,
-        .detach_client = w83791d_detach_client,
+        .remove         = w83791d_remove,
+        .id_table       = w83791d_id,
+        .detect         = w83791d_detect,
+        .address_data   = &addr_data,
 };
 /* following are the sysfs callback functions */
@@ -905,49 +916,12 @@ static const struct attribute_group w83791d_group = {
        .attrs = w83791d_attributes,
 };
-/* This function is called when:
-     * w83791d_driver is inserted (when this module is loaded), for each
-       available adapter
-     * when a new adapter is inserted (and w83791d_driver is still present) */
-static int w83791d_attach_adapter(struct i2c_adapter *adapter)
-{
-        if (!(adapter->class & I2C_CLASS_HWMON))
-                return 0;
-        return i2c_probe(adapter, &addr_data, w83791d_detect);
-}
-static int w83791d_create_subclient(struct i2c_adapter *adapter,
+static int w83791d_detect_subclients(struct i2c_client *client)
-                                struct i2c_client *client, int addr,
-                                struct i2c_client **sub_cli)
-{
-        int err;
-        struct i2c_client *sub_client;
-        (*sub_cli) = sub_client =
-                        kzalloc(sizeof(struct i2c_client), GFP_KERNEL);
-        if (!(sub_client)) {
-                return -ENOMEM;
-        }
-        sub_client->addr = 0x48 + addr;
-        i2c_set_clientdata(sub_client, NULL);
-        sub_client->adapter = adapter;
-        sub_client->driver = &w83791d_driver;
-        strlcpy(sub_client->name, "w83791d subclient", I2C_NAME_SIZE);
-        if ((err = i2c_attach_client(sub_client))) {
-                dev_err(&client->dev, "subclient registration "
-                        "at address 0x%x failed\n", sub_client->addr);
-                kfree(sub_client);
-                return err;
-        }
-        return 0;
-}
-static int w83791d_detect_subclients(struct i2c_adapter *adapter, int address,
-                                int kind, struct i2c_client *client)
 {
+        struct i2c_adapter *adapter = client->adapter;
        struct w83791d_data *data = i2c_get_clientdata(client);
+        int address = client->addr;
        int i, id, err;
        u8 val;
@@ -971,10 +945,7 @@ static int w83791d_detect_subclients(struct i2c_adapter *adapter, int address,
        val = w83791d_read(client, W83791D_REG_I2C_SUBADDR);
        if (!(val & 0x08)) {
-                err = w83791d_create_subclient(adapter, client,
+                data->lm75[0] = i2c_new_dummy(adapter, 0x48 + (val & 0x7));
-                                                val & 0x7, &data->lm75[0]);
-                if (err < 0)
-                        goto error_sc_0;
        }
        if (!(val & 0x80)) {
                if ((data->lm75[0] != NULL) &&
@@ -986,10 +957,8 @@ static int w83791d_detect_subclients(struct i2c_adapter *adapter, int address,
                        err = -ENODEV;
                        goto error_sc_1;
                }
-                err = w83791d_create_subclient(adapter, client,
+                data->lm75[1] = i2c_new_dummy(adapter,
-                                        (val >> 4) & 0x7, &data->lm75[1]);
+                                              0x48 + ((val >> 4) & 0x7));
-                if (err < 0)
-                        goto error_sc_1;
        }
        return 0;
@@ -997,53 +966,31 @@ static int w83791d_detect_subclients(struct i2c_adapter *adapter, int address,
 /* Undo inits in case of errors */
 error_sc_1:
-        if (data->lm75[0] != NULL) {
+        if (data->lm75[0] != NULL)
-                i2c_detach_client(data->lm75[0]);
+                i2c_unregister_device(data->lm75[0]);
-                kfree(data->lm75[0]);
-        }
 error_sc_0:
        return err;
 }
-static int w83791d_detect(struct i2c_adapter *adapter, int address, int kind)
+/* Return 0 if detection is successful, -ENODEV otherwise */
+static int w83791d_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info)
 {
-        struct i2c_client *client;
+        struct i2c_adapter *adapter = client->adapter;
-        struct device *dev;
+        int val1, val2;
-        struct w83791d_data *data;
+        unsigned short address = client->addr;
-        int i, val1, val2;
-        int err = 0;
-        const char *client_name = "";
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
-                goto error0;
+                return -ENODEV;
        }
-        /* OK. For now, we presume we have a valid client. We now create the
-           client structure, even though we cannot fill it completely yet.
-           But it allows us to access w83791d_{read,write}_value. */
-        if (!(data = kzalloc(sizeof(struct w83791d_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto error0;
-        }
-        client = &data->client;
-        dev = &client->dev;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &w83791d_driver;
-        mutex_init(&data->update_lock);
-        /* Now, we do the remaining detection. */
        /* The w83791d may be stuck in some other bank than bank 0. This may
           make reading other information impossible. Specify a force=...
           parameter, and the Winbond will be reset to the right bank. */
        if (kind < 0) {
                if (w83791d_read(client, W83791D_REG_CONFIG) & 0x80) {
-                        dev_dbg(dev, "Detection failed at step 1\n");
+                        return -ENODEV;
-                        goto error1;
                }
                val1 = w83791d_read(client, W83791D_REG_BANK);
                val2 = w83791d_read(client, W83791D_REG_CHIPMAN);
@@ -1052,15 +999,13 @@ static int w83791d_detect(struct i2c_adapter *adapter, int address, int kind)
                        /* yes it is Bank0 */
                        if (((!(val1 & 0x80)) && (val2 != 0xa3)) ||
                            ((val1 & 0x80) && (val2 != 0x5c))) {
-                                dev_dbg(dev, "Detection failed at step 2\n");
+                                return -ENODEV;
-                                goto error1;
                        }
                }
                /* If Winbond chip, address of chip and W83791D_REG_I2C_ADDR
                   should match */
                if (w83791d_read(client, W83791D_REG_I2C_ADDR) != address) {
-                        dev_dbg(dev, "Detection failed at step 3\n");
+                        return -ENODEV;
-                        goto error1;
                }
        }
@@ -1075,30 +1020,33 @@ static int w83791d_detect(struct i2c_adapter *adapter, int address, int kind)
                /* get vendor ID */
                val2 = w83791d_read(client, W83791D_REG_CHIPMAN);
                if (val2 != 0x5c) {     /* the vendor is NOT Winbond */
-                        dev_dbg(dev, "Detection failed at step 4\n");
+                        return -ENODEV;
-                        goto error1;
                }
                val1 = w83791d_read(client, W83791D_REG_WCHIPID);
                if (val1 == 0x71) {
                        kind = w83791d;
                } else {
                        if (kind == 0)
-                                dev_warn(dev,
+                                dev_warn(&adapter->dev,
                                        "w83791d: Ignoring 'force' parameter "
                                        "for unknown chip at adapter %d, "
                                        "address 0x%02x\n",
                                        i2c_adapter_id(adapter), address);
-                        goto error1;
+                        return -ENODEV;
                }
        }
-        if (kind == w83791d) {
+        strlcpy(info->type, "w83791d", I2C_NAME_SIZE);
-                client_name = "w83791d";
-        } else {
+        return 0;
-                dev_err(dev, "w83791d: Internal error: unknown kind (%d)?!?\n",
+}
-                        kind);
-                goto error1;
+static int w83791d_probe(struct i2c_client *client,
-        }
+                         const struct i2c_device_id *id)
+{
+        struct w83791d_data *data;
+        struct device *dev = &client->dev;
+        int i, val1, err;
 #ifdef DEBUG
        val1 = w83791d_read(client, W83791D_REG_DID_VID4);
@@ -1106,15 +1054,18 @@ static int w83791d_detect(struct i2c_adapter *adapter, int address, int kind)
                        (val1 >> 5) & 0x07, (val1 >> 1) & 0x0f, val1);
 #endif
-        /* Fill in the remaining client fields and put into the global list */
+        data = kzalloc(sizeof(struct w83791d_data), GFP_KERNEL);
-        strlcpy(client->name, client_name, I2C_NAME_SIZE);
+        if (!data) {
+                err = -ENOMEM;
+                goto error0;
+        }
-        /* Tell the I2C layer a new client has arrived */
+        i2c_set_clientdata(client, data);
-        if ((err = i2c_attach_client(client)))
+        mutex_init(&data->update_lock);
-                goto error1;
-        if ((err = w83791d_detect_subclients(adapter, address, kind, client)))
+        err = w83791d_detect_subclients(client);
-                goto error2;
+        if (err)
+                goto error1;
        /* Initialize the chip */
        w83791d_init_client(client);
@@ -1141,43 +1092,29 @@ static int w83791d_detect(struct i2c_adapter *adapter, int address, int kind)
 error4:
        sysfs_remove_group(&client->dev.kobj, &w83791d_group);
 error3:
-        if (data->lm75[0] != NULL) {
+        if (data->lm75[0] != NULL)
-                i2c_detach_client(data->lm75[0]);
+                i2c_unregister_device(data->lm75[0]);
-                kfree(data->lm75[0]);
+        if (data->lm75[1] != NULL)
-        }
+                i2c_unregister_device(data->lm75[1]);
-        if (data->lm75[1] != NULL) {
-                i2c_detach_client(data->lm75[1]);
-                kfree(data->lm75[1]);
-        }
-error2:
-        i2c_detach_client(client);
 error1:
        kfree(data);
 error0:
        return err;
 }
-static int w83791d_detach_client(struct i2c_client *client)
+static int w83791d_remove(struct i2c_client *client)
 {
        struct w83791d_data *data = i2c_get_clientdata(client);
-        int err;
-        /* main client */
-        if (data) {
-                hwmon_device_unregister(data->hwmon_dev);
-                sysfs_remove_group(&client->dev.kobj, &w83791d_group);
-        }
-        if ((err = i2c_detach_client(client)))
+        hwmon_device_unregister(data->hwmon_dev);
-                return err;
+        sysfs_remove_group(&client->dev.kobj, &w83791d_group);
-        /* main client */
+        if (data->lm75[0] != NULL)
-        if (data)
+                i2c_unregister_device(data->lm75[0]);
-                kfree(data);
+        if (data->lm75[1] != NULL)
-        /* subclient */
+                i2c_unregister_device(data->lm75[1]);
-        else
-                kfree(client);
+        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/w83792d.c b/drivers/hwmon/w83792d.c
index 299629d47ed6..cf94c5b0c879 100644
--- a/drivers/hwmon/w83792d.c
+++ b/drivers/hwmon/w83792d.c
@@ -267,9 +267,7 @@ DIV_TO_REG(long val)
 }
 struct w83792d_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
-        enum chips type;
        struct mutex update_lock;
        char valid;             /* !=0 if following fields are valid */
@@ -299,9 +297,11 @@ struct w83792d_data {
        u8 sf2_levels[3][4];    /* Smart FanII: Fan1,2,3 duty cycle levels */
 };
-static int w83792d_attach_adapter(struct i2c_adapter *adapter);
+static int w83792d_probe(struct i2c_client *client,
-static int w83792d_detect(struct i2c_adapter *adapter, int address, int kind);
+                         const struct i2c_device_id *id);
-static int w83792d_detach_client(struct i2c_client *client);
+static int w83792d_detect(struct i2c_client *client, int kind,
+                          struct i2c_board_info *info);
+static int w83792d_remove(struct i2c_client *client);
 static struct w83792d_data *w83792d_update_device(struct device *dev);
 #ifdef DEBUG
@@ -310,12 +310,22 @@ static void w83792d_print_debug(struct w83792d_data *data, struct device *dev);
 static void w83792d_init_client(struct i2c_client *client);
+static const struct i2c_device_id w83792d_id[] = {
+        { "w83792d", w83792d },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, w83792d_id);
 static struct i2c_driver w83792d_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name = "w83792d",
        },
-        .attach_adapter = w83792d_attach_adapter,
+        .probe          = w83792d_probe,
-        .detach_client = w83792d_detach_client,
+        .remove         = w83792d_remove,
+        .id_table       = w83792d_id,
+        .detect         = w83792d_detect,
+        .address_data   = &addr_data,
 };
 static inline long in_count_from_reg(int nr, struct w83792d_data *data)
@@ -864,53 +874,14 @@ store_sf2_level(struct device *dev, struct device_attribute *attr,
        return count;
 }
-/* This function is called when:
-     * w83792d_driver is inserted (when this module is loaded), for each
-       available adapter
-     * when a new adapter is inserted (and w83792d_driver is still present) */
-static int
-w83792d_attach_adapter(struct i2c_adapter *adapter)
-{
-        if (!(adapter->class & I2C_CLASS_HWMON))
-                return 0;
-        return i2c_probe(adapter, &addr_data, w83792d_detect);
-}
-static int
-w83792d_create_subclient(struct i2c_adapter *adapter,
-                                struct i2c_client *new_client, int addr,
-                                struct i2c_client **sub_cli)
-{
-        int err;
-        struct i2c_client *sub_client;
-        (*sub_cli) = sub_client = kzalloc(sizeof(struct i2c_client), GFP_KERNEL);
-        if (!(sub_client)) {
-                return -ENOMEM;
-        }
-        sub_client->addr = 0x48 + addr;
-        i2c_set_clientdata(sub_client, NULL);
-        sub_client->adapter = adapter;
-        sub_client->driver = &w83792d_driver;
-        sub_client->flags = 0;
-        strlcpy(sub_client->name, "w83792d subclient", I2C_NAME_SIZE);
-        if ((err = i2c_attach_client(sub_client))) {
-                dev_err(&new_client->dev, "subclient registration "
-                        "at address 0x%x failed\n", sub_client->addr);
-                kfree(sub_client);
-                return err;
-        }
-        return 0;
-}
 static int
-w83792d_detect_subclients(struct i2c_adapter *adapter, int address, int kind,
+w83792d_detect_subclients(struct i2c_client *new_client)
-                struct i2c_client *new_client)
 {
        int i, id, err;
+        int address = new_client->addr;
        u8 val;
+        struct i2c_adapter *adapter = new_client->adapter;
        struct w83792d_data *data = i2c_get_clientdata(new_client);
        id = i2c_adapter_id(adapter);
@@ -932,10 +903,7 @@ w83792d_detect_subclients(struct i2c_adapter *adapter, int address, int kind,
        val = w83792d_read_value(new_client, W83792D_REG_I2C_SUBADDR);
        if (!(val & 0x08)) {
-                err = w83792d_create_subclient(adapter, new_client, val & 0x7,
+                data->lm75[0] = i2c_new_dummy(adapter, 0x48 + (val & 0x7));
-                                                &data->lm75[0]);
-                if (err < 0)
-                        goto ERROR_SC_0;
        }
        if (!(val & 0x80)) {
                if ((data->lm75[0] != NULL) &&
@@ -945,10 +913,8 @@ w83792d_detect_subclients(struct i2c_adapter *adapter, int address, int kind,
                        err = -ENODEV;
                        goto ERROR_SC_1;
                }
-                err = w83792d_create_subclient(adapter, new_client,
+                data->lm75[1] = i2c_new_dummy(adapter,
-                                                (val >> 4) & 0x7, &data->lm75[1]);
+                                              0x48 + ((val >> 4) & 0x7));
-                if (err < 0)
-                        goto ERROR_SC_1;
        }
        return 0;
@@ -956,10 +922,8 @@ w83792d_detect_subclients(struct i2c_adapter *adapter, int address, int kind,
 /* Undo inits in case of errors */
 ERROR_SC_1:
-        if (data->lm75[0] != NULL) {
+        if (data->lm75[0] != NULL)
-                i2c_detach_client(data->lm75[0]);
+                i2c_unregister_device(data->lm75[0]);
-                kfree(data->lm75[0]);
-        }
 ERROR_SC_0:
        return err;
 }
@@ -1294,47 +1258,25 @@ static const struct attribute_group w83792d_group = {
        .attrs = w83792d_attributes,
 };
+/* Return 0 if detection is successful, -ENODEV otherwise */
 static int
-w83792d_detect(struct i2c_adapter *adapter, int address, int kind)
+w83792d_detect(struct i2c_client *client, int kind, struct i2c_board_info *info)
 {
-        int i = 0, val1 = 0, val2;
+        struct i2c_adapter *adapter = client->adapter;
-        struct i2c_client *client;
+        int val1, val2;
-        struct device *dev;
+        unsigned short address = client->addr;
-        struct w83792d_data *data;
-        int err = 0;
-        const char *client_name = "";
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
-                goto ERROR0;
+                return -ENODEV;
-        }
-        /* OK. For now, we presume we have a valid client. We now create the
-           client structure, even though we cannot fill it completely yet.
-           But it allows us to access w83792d_{read,write}_value. */
-        if (!(data = kzalloc(sizeof(struct w83792d_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto ERROR0;
        }
-        client = &data->client;
-        dev = &client->dev;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &w83792d_driver;
-        client->flags = 0;
-        /* Now, we do the remaining detection. */
        /* The w83792d may be stuck in some other bank than bank 0. This may
           make reading other information impossible. Specify a force=... or
           force_*=... parameter, and the Winbond will be reset to the right
           bank. */
        if (kind < 0) {
                if (w83792d_read_value(client, W83792D_REG_CONFIG) & 0x80) {
-                        dev_dbg(dev, "Detection failed at step 1\n");
+                        return -ENODEV;
-                        goto ERROR1;
                }
                val1 = w83792d_read_value(client, W83792D_REG_BANK);
                val2 = w83792d_read_value(client, W83792D_REG_CHIPMAN);
@@ -1342,16 +1284,14 @@ w83792d_detect(struct i2c_adapter *adapter, int address, int kind)
                if (!(val1 & 0x07)) {  /* is Bank0 */
                        if (((!(val1 & 0x80)) && (val2 != 0xa3)) ||
                             ((val1 & 0x80) && (val2 != 0x5c))) {
-                                dev_dbg(dev, "Detection failed at step 2\n");
+                                return -ENODEV;
-                                goto ERROR1;
                        }
                }
                /* If Winbond chip, address of chip and W83792D_REG_I2C_ADDR
                   should match */
                if (w83792d_read_value(client,
                                        W83792D_REG_I2C_ADDR) != address) {
-                        dev_dbg(dev, "Detection failed at step 3\n");
+                        return -ENODEV;
-                        goto ERROR1;
                }
        }
@@ -1367,45 +1307,48 @@ w83792d_detect(struct i2c_adapter *adapter, int address, int kind)
                /* get vendor ID */
                val2 = w83792d_read_value(client, W83792D_REG_CHIPMAN);
                if (val2 != 0x5c) {  /* the vendor is NOT Winbond */
-                        goto ERROR1;
+                        return -ENODEV;
                }
                val1 = w83792d_read_value(client, W83792D_REG_WCHIPID);
                if (val1 == 0x7a) {
                        kind = w83792d;
                } else {
                        if (kind == 0)
-                                        dev_warn(dev,
+                                dev_warn(&adapter->dev,
                                        "w83792d: Ignoring 'force' parameter for"
                                        " unknown chip at adapter %d, address"
                                        " 0x%02x\n", i2c_adapter_id(adapter),
                                        address);
-                        goto ERROR1;
+                        return -ENODEV;
                }
        }
-        if (kind == w83792d) {
+        strlcpy(info->type, "w83792d", I2C_NAME_SIZE);
-                client_name = "w83792d";
-        } else {
+        return 0;
-                dev_err(dev, "w83792d: Internal error: unknown kind (%d)?!?\n",
+}
-                        kind);
-                goto ERROR1;
+static int
-        }
+w83792d_probe(struct i2c_client *client, const struct i2c_device_id *id)
+{
+        struct w83792d_data *data;
+        struct device *dev = &client->dev;
+        int i, val1, err;
-        /* Fill in the remaining client fields and put into the global list */
+        data = kzalloc(sizeof(struct w83792d_data), GFP_KERNEL);
-        strlcpy(client->name, client_name, I2C_NAME_SIZE);
+        if (!data) {
-        data->type = kind;
+                err = -ENOMEM;
+                goto ERROR0;
+        }
+        i2c_set_clientdata(client, data);
        data->valid = 0;
        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
+        err = w83792d_detect_subclients(client);
-        if ((err = i2c_attach_client(client)))
+        if (err)
                goto ERROR1;
-        if ((err = w83792d_detect_subclients(adapter, address,
-                        kind, client)))
-                goto ERROR2;
        /* Initialize the chip */
        w83792d_init_client(client);
@@ -1457,16 +1400,10 @@ exit_remove_files:
        for (i = 0; i < ARRAY_SIZE(w83792d_group_fan); i++)
                sysfs_remove_group(&dev->kobj, &w83792d_group_fan[i]);
 ERROR3:
-        if (data->lm75[0] != NULL) {
+        if (data->lm75[0] != NULL)
-                i2c_detach_client(data->lm75[0]);
+                i2c_unregister_device(data->lm75[0]);
-                kfree(data->lm75[0]);
+        if (data->lm75[1] != NULL)
-        }
+                i2c_unregister_device(data->lm75[1]);
-        if (data->lm75[1] != NULL) {
-                i2c_detach_client(data->lm75[1]);
-                kfree(data->lm75[1]);
-        }
-ERROR2:
-        i2c_detach_client(client);
 ERROR1:
        kfree(data);
 ERROR0:
@@ -1474,30 +1411,23 @@ ERROR0:
 }
 static int
-w83792d_detach_client(struct i2c_client *client)
+w83792d_remove(struct i2c_client *client)
 {
        struct w83792d_data *data = i2c_get_clientdata(client);
-        int err, i;
+        int i;
-        /* main client */
-        if (data) {
-                hwmon_device_unregister(data->hwmon_dev);
-                sysfs_remove_group(&client->dev.kobj, &w83792d_group);
-                for (i = 0; i < ARRAY_SIZE(w83792d_group_fan); i++)
-                        sysfs_remove_group(&client->dev.kobj,
-                                           &w83792d_group_fan[i]);
-        }
-        if ((err = i2c_detach_client(client)))
+        hwmon_device_unregister(data->hwmon_dev);
-                return err;
+        sysfs_remove_group(&client->dev.kobj, &w83792d_group);
+        for (i = 0; i < ARRAY_SIZE(w83792d_group_fan); i++)
+                sysfs_remove_group(&client->dev.kobj,
+                                   &w83792d_group_fan[i]);
-        /* main client */
+        if (data->lm75[0] != NULL)
-        if (data)
+                i2c_unregister_device(data->lm75[0]);
-                kfree(data);
+        if (data->lm75[1] != NULL)
-        /* subclient */
+                i2c_unregister_device(data->lm75[1]);
-        else
-                kfree(client);
+        kfree(data);
        return 0;
 }
diff --git a/drivers/hwmon/w83793.c b/drivers/hwmon/w83793.c
index ed3c019b78c7..0a739f1c69be 100644
--- a/drivers/hwmon/w83793.c
+++ b/drivers/hwmon/w83793.c
@@ -179,7 +179,6 @@ static inline s8 TEMP_TO_REG(long val, s8 min, s8 max)
 }
 struct w83793_data {
-        struct i2c_client client;
        struct i2c_client *lm75[2];
        struct device *hwmon_dev;
        struct mutex update_lock;
@@ -226,19 +225,31 @@ struct w83793_data {
 static u8 w83793_read_value(struct i2c_client *client, u16 reg);
 static int w83793_write_value(struct i2c_client *client, u16 reg, u8 value);
-static int w83793_attach_adapter(struct i2c_adapter *adapter);
+static int w83793_probe(struct i2c_client *client,
-static int w83793_detect(struct i2c_adapter *adapter, int address, int kind);
+                        const struct i2c_device_id *id);
-static int w83793_detach_client(struct i2c_client *client);
+static int w83793_detect(struct i2c_client *client, int kind,
+                         struct i2c_board_info *info);
+static int w83793_remove(struct i2c_client *client);
 static void w83793_init_client(struct i2c_client *client);
 static void w83793_update_nonvolatile(struct device *dev);
 static struct w83793_data *w83793_update_device(struct device *dev);
+static const struct i2c_device_id w83793_id[] = {
+        { "w83793", w83793 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, w83793_id);
 static struct i2c_driver w83793_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                   .name = "w83793",
        },
-        .attach_adapter = w83793_attach_adapter,
+        .probe          = w83793_probe,
-        .detach_client = w83793_detach_client,
+        .remove         = w83793_remove,
+        .id_table       = w83793_id,
+        .detect         = w83793_detect,
+        .address_data   = &addr_data,
 };
 static ssize_t
@@ -1053,89 +1064,51 @@ static void w83793_init_client(struct i2c_client *client)
 }
-static int w83793_attach_adapter(struct i2c_adapter *adapter)
+static int w83793_remove(struct i2c_client *client)
-{
-        if (!(adapter->class & I2C_CLASS_HWMON))
-                return 0;
-        return i2c_probe(adapter, &addr_data, w83793_detect);
-}
-static int w83793_detach_client(struct i2c_client *client)
 {
        struct w83793_data *data = i2c_get_clientdata(client);
        struct device *dev = &client->dev;
-        int err, i;
+        int i;
-        /* main client */
+        hwmon_device_unregister(data->hwmon_dev);
-        if (data) {
-                hwmon_device_unregister(data->hwmon_dev);
-                for (i = 0; i < ARRAY_SIZE(w83793_sensor_attr_2); i++)
+        for (i = 0; i < ARRAY_SIZE(w83793_sensor_attr_2); i++)
-                        device_remove_file(dev,
+                device_remove_file(dev,
-                                           &w83793_sensor_attr_2[i].dev_attr);
+                                   &w83793_sensor_attr_2[i].dev_attr);
-                for (i = 0; i < ARRAY_SIZE(sda_single_files); i++)
+        for (i = 0; i < ARRAY_SIZE(sda_single_files); i++)
-                        device_remove_file(dev, &sda_single_files[i].dev_attr);
+                device_remove_file(dev, &sda_single_files[i].dev_attr);
-                for (i = 0; i < ARRAY_SIZE(w83793_vid); i++)
+        for (i = 0; i < ARRAY_SIZE(w83793_vid); i++)
-                        device_remove_file(dev, &w83793_vid[i].dev_attr);
+                device_remove_file(dev, &w83793_vid[i].dev_attr);
-                device_remove_file(dev, &dev_attr_vrm);
+        device_remove_file(dev, &dev_attr_vrm);
-                for (i = 0; i < ARRAY_SIZE(w83793_left_fan); i++)
+        for (i = 0; i < ARRAY_SIZE(w83793_left_fan); i++)
-                        device_remove_file(dev, &w83793_left_fan[i].dev_attr);
+                device_remove_file(dev, &w83793_left_fan[i].dev_attr);
-                for (i = 0; i < ARRAY_SIZE(w83793_left_pwm); i++)
+        for (i = 0; i < ARRAY_SIZE(w83793_left_pwm); i++)
-                        device_remove_file(dev, &w83793_left_pwm[i].dev_attr);
+                device_remove_file(dev, &w83793_left_pwm[i].dev_attr);
-                for (i = 0; i < ARRAY_SIZE(w83793_temp); i++)
+        for (i = 0; i < ARRAY_SIZE(w83793_temp); i++)
-                        device_remove_file(dev, &w83793_temp[i].dev_attr);
+                device_remove_file(dev, &w83793_temp[i].dev_attr);
-        }
-        if ((err = i2c_detach_client(client)))
+        if (data->lm75[0] != NULL)
-                return err;
+                i2c_unregister_device(data->lm75[0]);
+        if (data->lm75[1] != NULL)
+                i2c_unregister_device(data->lm75[1]);
-        /* main client */
+        kfree(data);
-        if (data)
-                kfree(data);
-        /* subclient */
-        else
-                kfree(client);
        return 0;
 }
 static int
-w83793_create_subclient(struct i2c_adapter *adapter,
+w83793_detect_subclients(struct i2c_client *client)
-                        struct i2c_client *client, int addr,
-                        struct i2c_client **sub_cli)
-{
-        int err = 0;
-        struct i2c_client *sub_client;
-        (*sub_cli) = sub_client =
-            kzalloc(sizeof(struct i2c_client), GFP_KERNEL);
-        if (!(sub_client)) {
-                return -ENOMEM;
-        }
-        sub_client->addr = 0x48 + addr;
-        i2c_set_clientdata(sub_client, NULL);
-        sub_client->adapter = adapter;
-        sub_client->driver = &w83793_driver;
-        strlcpy(sub_client->name, "w83793 subclient", I2C_NAME_SIZE);
-        if ((err = i2c_attach_client(sub_client))) {
-                dev_err(&client->dev, "subclient registration "
-                        "at address 0x%x failed\n", sub_client->addr);
-                kfree(sub_client);
-        }
-        return err;
-}
-static int
-w83793_detect_subclients(struct i2c_adapter *adapter, int address,
-                         int kind, struct i2c_client *client)
 {
        int i, id, err;
+        int address = client->addr;
        u8 tmp;
+        struct i2c_adapter *adapter = client->adapter;
        struct w83793_data *data = i2c_get_clientdata(client);
        id = i2c_adapter_id(adapter);
@@ -1158,11 +1131,7 @@ w83793_detect_subclients(struct i2c_adapter *adapter, int address,
        tmp = w83793_read_value(client, W83793_REG_I2C_SUBADDR);
        if (!(tmp & 0x08)) {
-                err =
+                data->lm75[0] = i2c_new_dummy(adapter, 0x48 + (tmp & 0x7));
-                    w83793_create_subclient(adapter, client, tmp & 0x7,
-                                            &data->lm75[0]);
-                if (err < 0)
-                        goto ERROR_SC_0;
        }
        if (!(tmp & 0x80)) {
                if ((data->lm75[0] != NULL)
@@ -1173,10 +1142,8 @@ w83793_detect_subclients(struct i2c_adapter *adapter, int address,
                        err = -ENODEV;
                        goto ERROR_SC_1;
                }
-                err = w83793_create_subclient(adapter, client,
+                data->lm75[1] = i2c_new_dummy(adapter,
-                                              (tmp >> 4) & 0x7, &data->lm75[1]);
+                                              0x48 + ((tmp >> 4) & 0x7));
-                if (err < 0)
-                        goto ERROR_SC_1;
        }
        return 0;
@@ -1184,69 +1151,44 @@ w83793_detect_subclients(struct i2c_adapter *adapter, int address,
        /* Undo inits in case of errors */
 ERROR_SC_1:
-        if (data->lm75[0] != NULL) {
+        if (data->lm75[0] != NULL)
-                i2c_detach_client(data->lm75[0]);
+                i2c_unregister_device(data->lm75[0]);
-                kfree(data->lm75[0]);
-        }
 ERROR_SC_0:
        return err;
 }
-static int w83793_detect(struct i2c_adapter *adapter, int address, int kind)
+/* Return 0 if detection is successful, -ENODEV otherwise */
+static int w83793_detect(struct i2c_client *client, int kind,
+                         struct i2c_board_info *info)
 {
-        int i;
+        u8 tmp, bank;
-        u8 tmp, val;
+        struct i2c_adapter *adapter = client->adapter;
-        struct i2c_client *client;
+        unsigned short address = client->addr;
-        struct device *dev;
-        struct w83793_data *data;
-        int files_fan = ARRAY_SIZE(w83793_left_fan) / 7;
-        int files_pwm = ARRAY_SIZE(w83793_left_pwm) / 5;
-        int files_temp = ARRAY_SIZE(w83793_temp) / 6;
-        int err = 0;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
-                goto exit;
+                return -ENODEV;
        }
-        /* OK. For now, we presume we have a valid client. We now create the
+        bank = i2c_smbus_read_byte_data(client, W83793_REG_BANKSEL);
-           client structure, even though we cannot fill it completely yet.
-           But it allows us to access w83793_{read,write}_value. */
-        if (!(data = kzalloc(sizeof(struct w83793_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        client = &data->client;
-        dev = &client->dev;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &w83793_driver;
-        data->bank = i2c_smbus_read_byte_data(client, W83793_REG_BANKSEL);
-        /* Now, we do the remaining detection. */
        if (kind < 0) {
-                tmp = data->bank & 0x80 ? 0x5c : 0xa3;
+                tmp = bank & 0x80 ? 0x5c : 0xa3;
                /* Check Winbond vendor ID */
                if (tmp != i2c_smbus_read_byte_data(client,
                                                        W83793_REG_VENDORID)) {
                        pr_debug("w83793: Detection failed at check "
                                 "vendor id\n");
-                        err = -ENODEV;
+                        return -ENODEV;
-                        goto free_mem;
                }
                /* If Winbond chip, address of chip and W83793_REG_I2C_ADDR
                   should match */
-                if ((data->bank & 0x07) == 0
+                if ((bank & 0x07) == 0
                 && i2c_smbus_read_byte_data(client, W83793_REG_I2C_ADDR) !=
                    (address << 1)) {
                        pr_debug("w83793: Detection failed at check "
                                 "i2c addr\n");
-                        err = -ENODEV;
+                        return -ENODEV;
-                        goto free_mem;
                }
        }
@@ -1255,30 +1197,47 @@ static int w83793_detect(struct i2c_adapter *adapter, int address, int kind)
           Winbond. Determine the chip type now */
        if (kind <= 0) {
-                if (0x7b == w83793_read_value(client, W83793_REG_CHIPID)) {
+                if (0x7b == i2c_smbus_read_byte_data(client,
+                                                     W83793_REG_CHIPID)) {
                        kind = w83793;
                } else {
                        if (kind == 0)
                                dev_warn(&adapter->dev, "w83793: Ignoring "
                                         "'force' parameter for unknown chip "
                                         "at address 0x%02x\n", address);
-                        err = -ENODEV;
+                        return -ENODEV;
-                        goto free_mem;
                }
        }
-        /* Fill in the remaining client fields and put into the global list */
+        strlcpy(info->type, "w83793", I2C_NAME_SIZE);
-        strlcpy(client->name, "w83793", I2C_NAME_SIZE);
+        return 0;
+}
+static int w83793_probe(struct i2c_client *client,
+                        const struct i2c_device_id *id)
+{
+        struct device *dev = &client->dev;
+        struct w83793_data *data;
+        int i, tmp, val, err;
+        int files_fan = ARRAY_SIZE(w83793_left_fan) / 7;
+        int files_pwm = ARRAY_SIZE(w83793_left_pwm) / 5;
+        int files_temp = ARRAY_SIZE(w83793_temp) / 6;
+        data = kzalloc(sizeof(struct w83793_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(client, data);
+        data->bank = i2c_smbus_read_byte_data(client, W83793_REG_BANKSEL);
        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
+        err = w83793_detect_subclients(client);
-        if ((err = i2c_attach_client(client)))
+        if (err)
                goto free_mem;
-        if ((err = w83793_detect_subclients(adapter, address, kind, client)))
-                goto detach_client;
        /* Initialize the chip */
        w83793_init_client(client);
@@ -1459,16 +1418,10 @@ exit_remove:
        for (i = 0; i < ARRAY_SIZE(w83793_temp); i++)
                device_remove_file(dev, &w83793_temp[i].dev_attr);
-        if (data->lm75[0] != NULL) {
+        if (data->lm75[0] != NULL)
-                i2c_detach_client(data->lm75[0]);
+                i2c_unregister_device(data->lm75[0]);
-                kfree(data->lm75[0]);
+        if (data->lm75[1] != NULL)
-        }
+                i2c_unregister_device(data->lm75[1]);
-        if (data->lm75[1] != NULL) {
-                i2c_detach_client(data->lm75[1]);
-                kfree(data->lm75[1]);
-        }
-detach_client:
-        i2c_detach_client(client);
 free_mem:
        kfree(data);
 exit:
diff --git a/drivers/hwmon/w83l785ts.c b/drivers/hwmon/w83l785ts.c
index 52e268e25dab..ea295b9fc4f4 100644
--- a/drivers/hwmon/w83l785ts.c
+++ b/drivers/hwmon/w83l785ts.c
@@ -81,10 +81,11 @@ I2C_CLIENT_INSMOD_1(w83l785ts);
 * Functions declaration
 */
-static int w83l785ts_attach_adapter(struct i2c_adapter *adapter);
+static int w83l785ts_probe(struct i2c_client *client,
-static int w83l785ts_detect(struct i2c_adapter *adapter, int address,
+                           const struct i2c_device_id *id);
-        int kind);
+static int w83l785ts_detect(struct i2c_client *client, int kind,
-static int w83l785ts_detach_client(struct i2c_client *client);
+                            struct i2c_board_info *info);
+static int w83l785ts_remove(struct i2c_client *client);
 static u8 w83l785ts_read_value(struct i2c_client *client, u8 reg, u8 defval);
 static struct w83l785ts_data *w83l785ts_update_device(struct device *dev);
@@ -92,12 +93,22 @@ static struct w83l785ts_data *w83l785ts_update_device(struct device *dev);
 * Driver data (common to all clients)
 */
 
+static const struct i2c_device_id w83l785ts_id[] = {
+        { "w83l785ts", w83l785ts },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, w83l785ts_id);
 static struct i2c_driver w83l785ts_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                .name   = "w83l785ts",
        },
-        .attach_adapter = w83l785ts_attach_adapter,
+        .probe          = w83l785ts_probe,
-        .detach_client  = w83l785ts_detach_client,
+        .remove         = w83l785ts_remove,
+        .id_table       = w83l785ts_id,
+        .detect         = w83l785ts_detect,
+        .address_data   = &addr_data,
 };
 /*
@@ -105,7 +116,6 @@ static struct i2c_driver w83l785ts_driver = {
 */
 struct w83l785ts_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid; /* zero until following fields are valid */
@@ -135,40 +145,14 @@ static SENSOR_DEVICE_ATTR(temp1_max, S_IRUGO, show_temp, NULL, 1);
 * Real code
 */
-static int w83l785ts_attach_adapter(struct i2c_adapter *adapter)
+/* Return 0 if detection is successful, -ENODEV otherwise */
-{
+static int w83l785ts_detect(struct i2c_client *new_client, int kind,
-        if (!(adapter->class & I2C_CLASS_HWMON))
+                            struct i2c_board_info *info)
-                return 0;
-        return i2c_probe(adapter, &addr_data, w83l785ts_detect);
-}
-/*
- * The following function does more than just detection. If detection
- * succeeds, it also registers the new chip.
- */
-static int w83l785ts_detect(struct i2c_adapter *adapter, int address, int kind)
 {
-        struct i2c_client *new_client;
+        struct i2c_adapter *adapter = new_client->adapter;
-        struct w83l785ts_data *data;
-        int err = 0;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
-                goto exit;
+                return -ENODEV;
-        if (!(data = kzalloc(sizeof(struct w83l785ts_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
-        }
-        /* The common I2C client data is placed right before the
-         * W83L785TS-specific data. */
-        new_client = &data->client;
-        i2c_set_clientdata(new_client, data);
-        new_client->addr = address;
-        new_client->adapter = adapter;
-        new_client->driver = &w83l785ts_driver;
-        new_client->flags = 0;
        /*
         * Now we do the remaining detection. A negative kind means that
@@ -188,8 +172,8 @@ static int w83l785ts_detect(struct i2c_adapter *adapter, int address, int kind)
                      W83L785TS_REG_TYPE, 0) & 0xFC) != 0x00)) {
                        dev_dbg(&adapter->dev,
                                "W83L785TS-S detection failed at 0x%02x.\n",
-                                address);
+                                new_client->addr);
-                        goto exit_free;
+                        return -ENODEV;
                }
        }
@@ -214,22 +198,34 @@ static int w83l785ts_detect(struct i2c_adapter *adapter, int address, int kind)
                        dev_info(&adapter->dev,
                                 "Unsupported chip (man_id=0x%04X, "
                                 "chip_id=0x%02X).\n", man_id, chip_id);
-                        goto exit_free;
+                        return -ENODEV;
                }
        }
-        /* We can fill in the remaining client fields. */
+        strlcpy(info->type, "w83l785ts", I2C_NAME_SIZE);
-        strlcpy(new_client->name, "w83l785ts", I2C_NAME_SIZE);
+        return 0;
+}
+static int w83l785ts_probe(struct i2c_client *new_client,
+                           const struct i2c_device_id *id)
+{
+        struct w83l785ts_data *data;
+        int err = 0;
+        data = kzalloc(sizeof(struct w83l785ts_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(new_client, data);
        data->valid = 0;
        mutex_init(&data->update_lock);
        /* Default values in case the first read fails (unlikely). */
        data->temp[1] = data->temp[0] = 0;
-        /* Tell the I2C layer a new client has arrived. */
-        if ((err = i2c_attach_client(new_client))) 
-                goto exit_free;
        /*
         * Initialize the W83L785TS chip
         * Nothing yet, assume it is already started.
@@ -259,25 +255,20 @@ exit_remove:
                           &sensor_dev_attr_temp1_input.dev_attr);
        device_remove_file(&new_client->dev,
                           &sensor_dev_attr_temp1_max.dev_attr);
-        i2c_detach_client(new_client);
-exit_free:
        kfree(data);
 exit:
        return err;
 }
-static int w83l785ts_detach_client(struct i2c_client *client)
+static int w83l785ts_remove(struct i2c_client *client)
 {
        struct w83l785ts_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        device_remove_file(&client->dev,
                           &sensor_dev_attr_temp1_input.dev_attr);
        device_remove_file(&client->dev,
                           &sensor_dev_attr_temp1_max.dev_attr);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
@@ -286,6 +277,18 @@ static int w83l785ts_detach_client(struct i2c_client *client)
 static u8 w83l785ts_read_value(struct i2c_client *client, u8 reg, u8 defval)
 {
        int value, i;
+        struct device *dev;
+        const char *prefix;
+        /* We might be called during detection, at which point the client
+           isn't yet fully initialized, so we can't use dev_dbg on it */
+        if (i2c_get_clientdata(client)) {
+                dev = &client->dev;
+                prefix = "";
+        } else {
+                dev = &client->adapter->dev;
+                prefix = "w83l785ts: ";
+        }
        /* Frequent read errors have been reported on Asus boards, so we
         * retry on read errors. If it still fails (unlikely), return the
@@ -293,15 +296,15 @@ static u8 w83l785ts_read_value(struct i2c_client *client, u8 reg, u8 defval)
        for (i = 1; i <= MAX_RETRIES; i++) {
                value = i2c_smbus_read_byte_data(client, reg);
                if (value >= 0) {
-                        dev_dbg(&client->dev, "Read 0x%02x from register "
+                        dev_dbg(dev, "%sRead 0x%02x from register 0x%02x.\n",
-                                "0x%02x.\n", value, reg);
+                                prefix, value, reg);
                        return value;
                }
-                dev_dbg(&client->dev, "Read failed, will retry in %d.\n", i);
+                dev_dbg(dev, "%sRead failed, will retry in %d.\n", prefix, i);
                msleep(i);
        }
-        dev_err(&client->dev, "Couldn't read value from register 0x%02x.\n",
+        dev_err(dev, "%sCouldn't read value from register 0x%02x.\n", prefix,
                reg);
        return defval;
 }
diff --git a/drivers/hwmon/w83l786ng.c b/drivers/hwmon/w83l786ng.c
index 41e22ddb568a..badca769f350 100644
--- a/drivers/hwmon/w83l786ng.c
+++ b/drivers/hwmon/w83l786ng.c
@@ -121,7 +121,6 @@ DIV_TO_REG(long val)
 }
 struct w83l786ng_data {
-        struct i2c_client client;
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid;                     /* !=0 if following fields are valid */
@@ -146,18 +145,30 @@ struct w83l786ng_data {
        u8 tolerance[2];
 };
-static int w83l786ng_attach_adapter(struct i2c_adapter *adapter);
+static int w83l786ng_probe(struct i2c_client *client,
-static int w83l786ng_detect(struct i2c_adapter *adapter, int address, int kind);
+                           const struct i2c_device_id *id);
-static int w83l786ng_detach_client(struct i2c_client *client);
+static int w83l786ng_detect(struct i2c_client *client, int kind,
+                            struct i2c_board_info *info);
+static int w83l786ng_remove(struct i2c_client *client);
 static void w83l786ng_init_client(struct i2c_client *client);
 static struct w83l786ng_data *w83l786ng_update_device(struct device *dev);
+static const struct i2c_device_id w83l786ng_id[] = {
+        { "w83l786ng", w83l786ng },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, w83l786ng_id);
 static struct i2c_driver w83l786ng_driver = {
+        .class          = I2C_CLASS_HWMON,
        .driver = {
                   .name = "w83l786ng",
        },
-        .attach_adapter = w83l786ng_attach_adapter,
+        .probe          = w83l786ng_probe,
-        .detach_client = w83l786ng_detach_client,
+        .remove         = w83l786ng_remove,
+        .id_table       = w83l786ng_id,
+        .detect         = w83l786ng_detect,
+        .address_data   = &addr_data,
 };
 static u8
@@ -575,42 +586,15 @@ static const struct attribute_group w83l786ng_group = {
 };
 static int
-w83l786ng_attach_adapter(struct i2c_adapter *adapter)
+w83l786ng_detect(struct i2c_client *client, int kind,
+                 struct i2c_board_info *info)
 {
-        if (!(adapter->class & I2C_CLASS_HWMON))
+        struct i2c_adapter *adapter = client->adapter;
-                return 0;
-        return i2c_probe(adapter, &addr_data, w83l786ng_detect);
-}
-static int
-w83l786ng_detect(struct i2c_adapter *adapter, int address, int kind)
-{
-        struct i2c_client *client;
-        struct device *dev;
-        struct w83l786ng_data *data;
-        int i, err = 0;
-        u8 reg_tmp;
        if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
-                goto exit;
+                return -ENODEV;
-        }
-        /* OK. For now, we presume we have a valid client. We now create the
-           client structure, even though we cannot fill it completely yet.
-           But it allows us to access w83l786ng_{read,write}_value. */
-        if (!(data = kzalloc(sizeof(struct w83l786ng_data), GFP_KERNEL))) {
-                err = -ENOMEM;
-                goto exit;
        }
-        client = &data->client;
-        dev = &client->dev;
-        i2c_set_clientdata(client, data);
-        client->addr = address;
-        client->adapter = adapter;
-        client->driver = &w83l786ng_driver;
        /*
         * Now we do the remaining detection. A negative kind means that
         * the driver was loaded with no force parameter (default), so we
@@ -627,8 +611,8 @@ w83l786ng_detect(struct i2c_adapter *adapter, int address, int kind)
                    W83L786NG_REG_CONFIG) & 0x80) != 0x00)) {
                        dev_dbg(&adapter->dev,
                                "W83L786NG detection failed at 0x%02x.\n",
-                                address);
+                                client->addr);
-                        goto exit_free;
+                        return -ENODEV;
                }
        }
@@ -651,17 +635,31 @@ w83l786ng_detect(struct i2c_adapter *adapter, int address, int kind)
                        dev_info(&adapter->dev,
                            "Unsupported chip (man_id=0x%04X, "
                            "chip_id=0x%02X).\n", man_id, chip_id);
-                        goto exit_free;
+                        return -ENODEV;
                }
        }
-        /* Fill in the remaining client fields and put into the global list */
+        strlcpy(info->type, "w83l786ng", I2C_NAME_SIZE);
-        strlcpy(client->name, "w83l786ng", I2C_NAME_SIZE);
-        mutex_init(&data->update_lock);
-        /* Tell the I2C layer a new client has arrived */
+        return 0;
-        if ((err = i2c_attach_client(client)))
+}
-                goto exit_free;
+static int
+w83l786ng_probe(struct i2c_client *client, const struct i2c_device_id *id)
+{
+        struct device *dev = &client->dev;
+        struct w83l786ng_data *data;
+        int i, err = 0;
+        u8 reg_tmp;
+        data = kzalloc(sizeof(struct w83l786ng_data), GFP_KERNEL);
+        if (!data) {
+                err = -ENOMEM;
+                goto exit;
+        }
+        i2c_set_clientdata(client, data);
+        mutex_init(&data->update_lock);
        /* Initialize the chip */
        w83l786ng_init_client(client);
@@ -693,25 +691,19 @@ w83l786ng_detect(struct i2c_adapter *adapter, int address, int kind)
 exit_remove:
        sysfs_remove_group(&client->dev.kobj, &w83l786ng_group);
-        i2c_detach_client(client);
-exit_free:
        kfree(data);
 exit:
        return err;
 }
 static int
-w83l786ng_detach_client(struct i2c_client *client)
+w83l786ng_remove(struct i2c_client *client)
 {
        struct w83l786ng_data *data = i2c_get_clientdata(client);
-        int err;
        hwmon_device_unregister(data->hwmon_dev);
        sysfs_remove_group(&client->dev.kobj, &w83l786ng_group);
-        if ((err = i2c_detach_client(client)))
-                return err;
        kfree(data);
        return 0;
author	Dmitry Torokhov <dmitry.torokhov@gmail.com>	2008-07-21 00:55:14 -0400
committer	Dmitry Torokhov <dmitry.torokhov@gmail.com>	2008-07-21 00:55:14 -0400
commit	908cf4b925e419bc74f3297b2f0e51d6f8a81da2 (patch)
tree	6c2da79366d4695a9c2560ab18259eca8a2a25b4 /drivers/hwmon
parent	92c49890922d54cba4b1eadeb0b185773c2c9570 (diff)
parent	14b395e35d1afdd8019d11b92e28041fad591b71 (diff)