aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/hwmon
diff options
context:
space:
mode:
authorGuenter Roeck <guenter.roeck@ericsson.com>2011-11-06 14:25:18 -0500
committerJean Delvare <khali@endymion.delvare>2011-11-06 14:25:18 -0500
commitbfa02b0da66965caf46e441270af87edda4fea14 (patch)
tree374d3bc3993c7027eac330b3184437a27bf2e0a8 /drivers/hwmon
parent2aba6cac2a84f3b80e11a680c34d55e7739b474d (diff)
hwmon: (w83627ehf) Fix broken driver init
Commit 2265cef2 (hwmon: (w83627ehf) Properly report PECI and AMD-SI sensor types) results in kernel panic if data->temp_label was not initialized. The problem was found with chip W83627DHG-P. Add check if data->temp->label was set before use. Based on incomplete patch by Alexander Beregalov. Reported-by: Alexander Beregalov <a.beregalov@gmail.com> Tested-by: Alexander Beregalov <a.beregalov@gmail.com> Cc: stable@kernel.org Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com> Signed-off-by: Jean Delvare <khali@linux-fr.org>
Diffstat (limited to 'drivers/hwmon')
-rw-r--r--drivers/hwmon/w83627ehf.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
index 483cb268781e..93f5fc7d6059 100644
--- a/drivers/hwmon/w83627ehf.c
+++ b/drivers/hwmon/w83627ehf.c
@@ -1835,12 +1835,15 @@ static inline void __devinit w83627ehf_init_device(struct w83627ehf_data *data,
1835 diode = 0x70; 1835 diode = 0x70;
1836 } 1836 }
1837 for (i = 0; i < 3; i++) { 1837 for (i = 0; i < 3; i++) {
1838 const char *label = data->temp_label[data->temp_src[i]]; 1838 const char *label = NULL;
1839
1840 if (data->temp_label)
1841 label = data->temp_label[data->temp_src[i]];
1839 1842
1840 /* Digital source overrides analog type */ 1843 /* Digital source overrides analog type */
1841 if (strncmp(label, "PECI", 4) == 0) 1844 if (label && strncmp(label, "PECI", 4) == 0)
1842 data->temp_type[i] = 6; 1845 data->temp_type[i] = 6;
1843 else if (strncmp(label, "AMD", 3) == 0) 1846 else if (label && strncmp(label, "AMD", 3) == 0)
1844 data->temp_type[i] = 5; 1847 data->temp_type[i] = 5;
1845 else if ((tmp & (0x02 << i))) 1848 else if ((tmp & (0x02 << i)))
1846 data->temp_type[i] = (diode & (0x10 << i)) ? 1 : 3; 1849 data->temp_type[i] = (diode & (0x10 << i)) ? 1 : 3;