diff options
author | Jean Delvare <khali@linux-fr.org> | 2007-12-01 05:25:33 -0500 |
---|---|---|
committer | Mark M. Hoffman <mhoffman@lightlink.com> | 2008-02-07 20:39:44 -0500 |
commit | 8f74efe81d122c071410fd74f42879ef81439fa4 (patch) | |
tree | 3febd18d58fb42d248ea565d23daa468094797e7 /drivers/hwmon/w83791d.c | |
parent | 345a22245451c0fd2c44b2afb5dfb75628b487fa (diff) |
hwmon: VRM is not written to registers
What was true of reading the VRM value is also true of writing it: not
being a register value, it doesn't need hardware access, so we don't
need a reference to the i2c client. This allows for a minor code
cleanup. As gcc appears to be smart enough to simplify the generated
code by itself, this cleanup only affects the source code, the
generated binaries are unchanged.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Mark M. Hoffman <mhoffman@lightlink.com>
Diffstat (limited to 'drivers/hwmon/w83791d.c')
-rw-r--r-- | drivers/hwmon/w83791d.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/hwmon/w83791d.c b/drivers/hwmon/w83791d.c index a9c01a6f0057..85bd21ee3298 100644 --- a/drivers/hwmon/w83791d.c +++ b/drivers/hwmon/w83791d.c | |||
@@ -840,14 +840,12 @@ static ssize_t store_vrm_reg(struct device *dev, | |||
840 | struct device_attribute *attr, | 840 | struct device_attribute *attr, |
841 | const char *buf, size_t count) | 841 | const char *buf, size_t count) |
842 | { | 842 | { |
843 | struct i2c_client *client = to_i2c_client(dev); | 843 | struct w83791d_data *data = dev_get_drvdata(dev); |
844 | struct w83791d_data *data = i2c_get_clientdata(client); | ||
845 | unsigned long val = simple_strtoul(buf, NULL, 10); | ||
846 | 844 | ||
847 | /* No lock needed as vrm is internal to the driver | 845 | /* No lock needed as vrm is internal to the driver |
848 | (not read from a chip register) and so is not | 846 | (not read from a chip register) and so is not |
849 | updated in w83791d_update_device() */ | 847 | updated in w83791d_update_device() */ |
850 | data->vrm = val; | 848 | data->vrm = simple_strtoul(buf, NULL, 10); |
851 | 849 | ||
852 | return count; | 850 | return count; |
853 | } | 851 | } |