aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/hwmon/w83627hf.c
diff options
context:
space:
mode:
authorJean Delvare <khali@linux-fr.org>2008-08-06 16:41:04 -0400
committerJean Delvare <khali@mahadeva.delvare>2008-08-06 16:41:04 -0400
commit2f8ea97a45e9db382787dd7afa7f500ee661aa7b (patch)
tree6992736c62dbe96b8096d05a4998883e12c854bb /drivers/hwmon/w83627hf.c
parenta95a5ed856e902e513119d4cc5b745faa202f761 (diff)
hwmon: (w83627hf) Drop reset module parameter
Drop the reset parameter of the w83627hf driver. It seems it wasn't that useful. It was dropped from the Linux 2.4 version of this driver back in July 2004. The only users who have reported that they were still using this parameter, needed it to switch the chip from automatic fan speed control back to manual mode. Now that the driver creates pwmN_enable sysfs files, users will be able to use these files instead, which is way less agressive. Signed-off-by: Jean Delvare <khali@linux-fr.org> Acked-by: Dominik Geyer <dominik.geyer@gmx.de>
Diffstat (limited to 'drivers/hwmon/w83627hf.c')
-rw-r--r--drivers/hwmon/w83627hf.c27
1 files changed, 0 insertions, 27 deletions
diff --git a/drivers/hwmon/w83627hf.c b/drivers/hwmon/w83627hf.c
index ba8b069b1082..b30e5796cb26 100644
--- a/drivers/hwmon/w83627hf.c
+++ b/drivers/hwmon/w83627hf.c
@@ -67,10 +67,6 @@ module_param(force_i2c, byte, 0);
67MODULE_PARM_DESC(force_i2c, 67MODULE_PARM_DESC(force_i2c,
68 "Initialize the i2c address of the sensors"); 68 "Initialize the i2c address of the sensors");
69 69
70static int reset;
71module_param(reset, bool, 0);
72MODULE_PARM_DESC(reset, "Set to one to reset chip on load");
73
74static int init = 1; 70static int init = 1;
75module_param(init, bool, 0); 71module_param(init, bool, 0);
76MODULE_PARM_DESC(init, "Set to zero to bypass chip initialization"); 72MODULE_PARM_DESC(init, "Set to zero to bypass chip initialization");
@@ -1600,29 +1596,6 @@ static void __devinit w83627hf_init_device(struct platform_device *pdev)
1600 enum chips type = data->type; 1596 enum chips type = data->type;
1601 u8 tmp; 1597 u8 tmp;
1602 1598
1603 if (reset) {
1604 /* Resetting the chip has been the default for a long time,
1605 but repeatedly caused problems (fans going to full
1606 speed...) so it is now optional. It might even go away if
1607 nobody reports it as being useful, as I see very little
1608 reason why this would be needed at all. */
1609 dev_info(&pdev->dev, "If reset=1 solved a problem you were "
1610 "having, please report!\n");
1611
1612 /* save this register */
1613 i = w83627hf_read_value(data, W83781D_REG_BEEP_CONFIG);
1614 /* Reset all except Watchdog values and last conversion values
1615 This sets fan-divs to 2, among others */
1616 w83627hf_write_value(data, W83781D_REG_CONFIG, 0x80);
1617 /* Restore the register and disable power-on abnormal beep.
1618 This saves FAN 1/2/3 input/output values set by BIOS. */
1619 w83627hf_write_value(data, W83781D_REG_BEEP_CONFIG, i | 0x80);
1620 /* Disable master beep-enable (reset turns it on).
1621 Individual beeps should be reset to off but for some reason
1622 disabling this bit helps some people not get beeped */
1623 w83627hf_write_value(data, W83781D_REG_BEEP_INTS2, 0);
1624 }
1625
1626 /* Minimize conflicts with other winbond i2c-only clients... */ 1599 /* Minimize conflicts with other winbond i2c-only clients... */
1627 /* disable i2c subclients... how to disable main i2c client?? */ 1600 /* disable i2c subclients... how to disable main i2c client?? */
1628 /* force i2c address to relatively uncommon address */ 1601 /* force i2c address to relatively uncommon address */