diff options
author | Jean Delvare <khali@linux-fr.org> | 2005-07-27 16:14:49 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2005-09-05 12:14:14 -0400 |
commit | 7bef559455fc71f66f8573cc1aafe1dd33966c1c (patch) | |
tree | 6c342574710f730d39bf5383f81eaa9f9bb10a25 /drivers/hwmon/lm87.c | |
parent | 1ff4e3065b41847b6fe5908b1214cb508dd49e61 (diff) |
[PATCH] I2C: refactor message in i2c_detach_client
We could refactor the error message 34 different i2c drivers print if
i2c_detach_client() fails in this function itself. Saves quite a few
lines of code. Documentation is updated to reflect that change.
Note that this patch should be applied after Rudolf Marek's w83792d
patches.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/hwmon/lm87.c')
-rw-r--r-- | drivers/hwmon/lm87.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/hwmon/lm87.c b/drivers/hwmon/lm87.c index 1dc3bf52b40d..f0ffe58e3670 100644 --- a/drivers/hwmon/lm87.c +++ b/drivers/hwmon/lm87.c | |||
@@ -734,11 +734,8 @@ static int lm87_detach_client(struct i2c_client *client) | |||
734 | 734 | ||
735 | hwmon_device_unregister(data->class_dev); | 735 | hwmon_device_unregister(data->class_dev); |
736 | 736 | ||
737 | if ((err = i2c_detach_client(client))) { | 737 | if ((err = i2c_detach_client(client))) |
738 | dev_err(&client->dev, "Client deregistration failed, " | ||
739 | "client not detached.\n"); | ||
740 | return err; | 738 | return err; |
741 | } | ||
742 | 739 | ||
743 | kfree(data); | 740 | kfree(data); |
744 | return 0; | 741 | return 0; |