diff options
author | Frans Meulenbroeks <fransmeulenbroeks@gmail.com> | 2012-01-10 09:49:35 -0500 |
---|---|---|
committer | Guenter Roeck <guenter.roeck@ericsson.com> | 2012-03-18 21:26:41 -0400 |
commit | 6a9e7c4c0365e246d85166a5ee04a8dd4dcfada9 (patch) | |
tree | 7f56f905bc0b8bd21dd0988be79aadba29a64878 /drivers/hwmon/lm80.c | |
parent | 6b904b623ab4646ce64124462c4bec6f0d3f78a6 (diff) |
hwmon: (lm80) fix checkpatch warnings
fix:
WARNING: simple_strtol is obsolete, use kstrtol instead
WARNING: simple_strtoul is obsolete, use kstrtoul instead
Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
[guenter.roeck@ericsson.com: kstrtol->kstrtoul where appropriate]
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Diffstat (limited to 'drivers/hwmon/lm80.c')
-rw-r--r-- | drivers/hwmon/lm80.c | 20 |
1 files changed, 16 insertions, 4 deletions
diff --git a/drivers/hwmon/lm80.c b/drivers/hwmon/lm80.c index 616f470c38b3..c4de272f3aaf 100644 --- a/drivers/hwmon/lm80.c +++ b/drivers/hwmon/lm80.c | |||
@@ -185,7 +185,10 @@ static ssize_t set_in_##suffix(struct device *dev, \ | |||
185 | int nr = to_sensor_dev_attr(attr)->index; \ | 185 | int nr = to_sensor_dev_attr(attr)->index; \ |
186 | struct i2c_client *client = to_i2c_client(dev); \ | 186 | struct i2c_client *client = to_i2c_client(dev); \ |
187 | struct lm80_data *data = i2c_get_clientdata(client); \ | 187 | struct lm80_data *data = i2c_get_clientdata(client); \ |
188 | long val = simple_strtol(buf, NULL, 10); \ | 188 | long val; \ |
189 | int err = kstrtol(buf, 10, &val); \ | ||
190 | if (err < 0) \ | ||
191 | return err; \ | ||
189 | \ | 192 | \ |
190 | mutex_lock(&data->update_lock);\ | 193 | mutex_lock(&data->update_lock);\ |
191 | data->value[nr] = IN_TO_REG(val); \ | 194 | data->value[nr] = IN_TO_REG(val); \ |
@@ -226,7 +229,10 @@ static ssize_t set_fan_min(struct device *dev, struct device_attribute *attr, | |||
226 | int nr = to_sensor_dev_attr(attr)->index; | 229 | int nr = to_sensor_dev_attr(attr)->index; |
227 | struct i2c_client *client = to_i2c_client(dev); | 230 | struct i2c_client *client = to_i2c_client(dev); |
228 | struct lm80_data *data = i2c_get_clientdata(client); | 231 | struct lm80_data *data = i2c_get_clientdata(client); |
229 | long val = simple_strtoul(buf, NULL, 10); | 232 | unsigned long val; |
233 | int err = kstrtoul(buf, 10, &val); | ||
234 | if (err < 0) | ||
235 | return err; | ||
230 | 236 | ||
231 | mutex_lock(&data->update_lock); | 237 | mutex_lock(&data->update_lock); |
232 | data->fan_min[nr] = FAN_TO_REG(val, DIV_FROM_REG(data->fan_div[nr])); | 238 | data->fan_min[nr] = FAN_TO_REG(val, DIV_FROM_REG(data->fan_div[nr])); |
@@ -245,8 +251,11 @@ static ssize_t set_fan_div(struct device *dev, struct device_attribute *attr, | |||
245 | int nr = to_sensor_dev_attr(attr)->index; | 251 | int nr = to_sensor_dev_attr(attr)->index; |
246 | struct i2c_client *client = to_i2c_client(dev); | 252 | struct i2c_client *client = to_i2c_client(dev); |
247 | struct lm80_data *data = i2c_get_clientdata(client); | 253 | struct lm80_data *data = i2c_get_clientdata(client); |
248 | unsigned long min, val = simple_strtoul(buf, NULL, 10); | 254 | unsigned long min, val; |
249 | u8 reg; | 255 | u8 reg; |
256 | int err = kstrtoul(buf, 10, &val); | ||
257 | if (err < 0) | ||
258 | return err; | ||
250 | 259 | ||
251 | /* Save fan_min */ | 260 | /* Save fan_min */ |
252 | mutex_lock(&data->update_lock); | 261 | mutex_lock(&data->update_lock); |
@@ -314,7 +323,10 @@ static ssize_t set_temp_##suffix(struct device *dev, \ | |||
314 | { \ | 323 | { \ |
315 | struct i2c_client *client = to_i2c_client(dev); \ | 324 | struct i2c_client *client = to_i2c_client(dev); \ |
316 | struct lm80_data *data = i2c_get_clientdata(client); \ | 325 | struct lm80_data *data = i2c_get_clientdata(client); \ |
317 | long val = simple_strtoul(buf, NULL, 10); \ | 326 | long val; \ |
327 | int err = kstrtol(buf, 10, &val); \ | ||
328 | if (err < 0) \ | ||
329 | return err; \ | ||
318 | \ | 330 | \ |
319 | mutex_lock(&data->update_lock); \ | 331 | mutex_lock(&data->update_lock); \ |
320 | data->value = TEMP_LIMIT_TO_REG(val); \ | 332 | data->value = TEMP_LIMIT_TO_REG(val); \ |