hwmon: Fix unchecked return status, batch 4

hwmon: Fix unchecked return status, batch 4

Fix up some hwmon drivers so that they no longer ignore return status
from device_create_file().

Note: f71805f actually checked the status from device_create_file
already. However it did not remove the files on device destruction.
It was also an opportunity to use sysfs_create/remove_group instead
of hand-made loops. This makes the changes much more important but
I think the result is worth it.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1 files changed, 52 insertions, 37 deletions

diff --git a/drivers/hwmon/lm63.c b/drivers/hwmon/lm63.c
index 00a50bea7cbd..d69f3cf07122 100644
--- a/drivers/hwmon/lm63.c
+++ b/drivers/hwmon/lm63.c
@@ -46,6 +46,7 @@
 #include <linux/hwmon.h>
 #include <linux/err.h>
 #include <linux/mutex.h>
+#include <linux/sysfs.h>
 
 /*
  * Addresses to scan
@@ -370,6 +371,42 @@ static SENSOR_DEVICE_ATTR(temp1_max_alarm, S_IRUGO, show_alarm, NULL, 6);
 /* Raw alarm file for compatibility */
 static DEVICE_ATTR(alarms, S_IRUGO, show_alarms, NULL);
 
+static struct attribute *lm63_attributes[] = {
+        &dev_attr_pwm1.attr,
+        &dev_attr_pwm1_enable.attr,
+        &sensor_dev_attr_temp1_input.dev_attr.attr,
+        &sensor_dev_attr_temp2_input.dev_attr.attr,
+        &sensor_dev_attr_temp2_min.dev_attr.attr,
+        &sensor_dev_attr_temp1_max.dev_attr.attr,
+        &sensor_dev_attr_temp2_max.dev_attr.attr,
+        &sensor_dev_attr_temp2_crit.dev_attr.attr,
+        &dev_attr_temp2_crit_hyst.attr,
+
+        &sensor_dev_attr_temp2_crit_alarm.dev_attr.attr,
+        &sensor_dev_attr_temp2_input_fault.dev_attr.attr,
+        &sensor_dev_attr_temp2_min_alarm.dev_attr.attr,
+        &sensor_dev_attr_temp2_max_alarm.dev_attr.attr,
+        &sensor_dev_attr_temp1_max_alarm.dev_attr.attr,
+        &dev_attr_alarms.attr,
+        NULL
+};
+
+static const struct attribute_group lm63_group = {
+        .attrs = lm63_attributes,
+};
+
+static struct attribute *lm63_attributes_fan1[] = {
+        &sensor_dev_attr_fan1_input.dev_attr.attr,
+        &sensor_dev_attr_fan1_min.dev_attr.attr,
+
+        &sensor_dev_attr_fan1_min_alarm.dev_attr.attr,
+        NULL
+};
+
+static const struct attribute_group lm63_group_fan1 = {
+        .attrs = lm63_attributes_fan1,
+};
+
 /*
  * Real code
  */
@@ -456,50 +493,26 @@ static int lm63_detect(struct i2c_adapter *adapter, int address, int kind)
         lm63_init_client(new_client);
 
         /* Register sysfs hooks */
-        data->class_dev = hwmon_device_register(&new_client->dev);
-        if (IS_ERR(data->class_dev)) {
-                err = PTR_ERR(data->class_dev);
+        if ((err = sysfs_create_group(&new_client->dev.kobj,
+                                      &lm63_group)))
                 goto exit_detach;
+        if (data->config & 0x04) { /* tachometer enabled */
+                if ((err = sysfs_create_group(&new_client->dev.kobj,
+                                              &lm63_group_fan1)))
+                        goto exit_remove_files;
         }
 
-        if (data->config & 0x04) { /* tachometer enabled */
-                device_create_file(&new_client->dev,
-                                   &sensor_dev_attr_fan1_input.dev_attr);
-                device_create_file(&new_client->dev,
-                                   &sensor_dev_attr_fan1_min.dev_attr);
-                device_create_file(&new_client->dev,
-                                   &sensor_dev_attr_fan1_min_alarm.dev_attr);
+        data->class_dev = hwmon_device_register(&new_client->dev);
+        if (IS_ERR(data->class_dev)) {
+                err = PTR_ERR(data->class_dev);
+                goto exit_remove_files;
         }
-        device_create_file(&new_client->dev, &dev_attr_pwm1);
-        device_create_file(&new_client->dev, &dev_attr_pwm1_enable);
-        device_create_file(&new_client->dev,
-                           &sensor_dev_attr_temp1_input.dev_attr);
-        device_create_file(&new_client->dev,
-                           &sensor_dev_attr_temp2_input.dev_attr);
-        device_create_file(&new_client->dev,
-                           &sensor_dev_attr_temp2_min.dev_attr);
-        device_create_file(&new_client->dev,
-                           &sensor_dev_attr_temp1_max.dev_attr);
-        device_create_file(&new_client->dev,
-                           &sensor_dev_attr_temp2_max.dev_attr);
-        device_create_file(&new_client->dev,
-                           &sensor_dev_attr_temp2_crit.dev_attr);
-        device_create_file(&new_client->dev, &dev_attr_temp2_crit_hyst);
-
-        device_create_file(&new_client->dev,
-                           &sensor_dev_attr_temp2_input_fault.dev_attr);
-        device_create_file(&new_client->dev,
-                           &sensor_dev_attr_temp2_min_alarm.dev_attr);
-        device_create_file(&new_client->dev,
-                           &sensor_dev_attr_temp1_max_alarm.dev_attr);
-        device_create_file(&new_client->dev,
-                           &sensor_dev_attr_temp2_max_alarm.dev_attr);
-        device_create_file(&new_client->dev,
-                           &sensor_dev_attr_temp2_crit_alarm.dev_attr);
-        device_create_file(&new_client->dev, &dev_attr_alarms);
 
         return 0;
 
+exit_remove_files:
+        sysfs_remove_group(&new_client->dev.kobj, &lm63_group);
+        sysfs_remove_group(&new_client->dev.kobj, &lm63_group_fan1);
 exit_detach:
         i2c_detach_client(new_client);
 exit_free:
@@ -549,6 +562,8 @@ static int lm63_detach_client(struct i2c_client *client)
         int err;
 
         hwmon_device_unregister(data->class_dev);
+        sysfs_remove_group(&client->dev.kobj, &lm63_group);
+        sysfs_remove_group(&client->dev.kobj, &lm63_group_fan1);
 
         if ((err = i2c_detach_client(client)))
                 return err;