hwmon: Clean up detect functions

As kind is now hard-coded to -1, there is room for code clean-ups.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Acked-by: Corentin Labbe <corentin.labbe@geomatys.fr>
Cc: "Mark M. Hoffman" <mhoffman@lightlink.com>
Cc: Juerg Haefliger <juergh@gmail.com>
Cc: Riku Voipio <riku.voipio@iki.fi>
Acked-by: "Hans J. Koch" <hjk@linutronix.de>
Cc: Rudolf Marek <r.marek@assembler.cz>

1 files changed, 24 insertions, 30 deletions

diff --git a/drivers/hwmon/lm63.c b/drivers/hwmon/lm63.c
index 3195a265f0e9..5da66ab04f74 100644
--- a/drivers/hwmon/lm63.c
+++ b/drivers/hwmon/lm63.c
@@ -427,40 +427,34 @@ static int lm63_detect(struct i2c_client *new_client, int kind,
                        struct i2c_board_info *info)
 {
         struct i2c_adapter *adapter = new_client->adapter;
+        u8 man_id, chip_id, reg_config1, reg_config2;
+        u8 reg_alert_status, reg_alert_mask;
 
         if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
                 return -ENODEV;
 
-        if (kind < 0) { /* must identify */
-                u8 man_id, chip_id, reg_config1, reg_config2;
-                u8 reg_alert_status, reg_alert_mask;
-
-                man_id = i2c_smbus_read_byte_data(new_client,
-                         LM63_REG_MAN_ID);
-                chip_id = i2c_smbus_read_byte_data(new_client,
-                          LM63_REG_CHIP_ID);
-                reg_config1 = i2c_smbus_read_byte_data(new_client,
-                              LM63_REG_CONFIG1);
-                reg_config2 = i2c_smbus_read_byte_data(new_client,
-                              LM63_REG_CONFIG2);
-                reg_alert_status = i2c_smbus_read_byte_data(new_client,
-                                   LM63_REG_ALERT_STATUS);
-                reg_alert_mask = i2c_smbus_read_byte_data(new_client,
-                                 LM63_REG_ALERT_MASK);
-
-                if (man_id == 0x01 /* National Semiconductor */
-                 && chip_id == 0x41 /* LM63 */
-                 && (reg_config1 & 0x18) == 0x00
-                 && (reg_config2 & 0xF8) == 0x00
-                 && (reg_alert_status & 0x20) == 0x00
-                 && (reg_alert_mask & 0xA4) == 0xA4) {
-                        kind = lm63;
-                } else { /* failed */
-                        dev_dbg(&adapter->dev, "Unsupported chip "
-                                "(man_id=0x%02X, chip_id=0x%02X).\n",
-                                man_id, chip_id);
-                        return -ENODEV;
-                }
+        man_id = i2c_smbus_read_byte_data(new_client, LM63_REG_MAN_ID);
+        chip_id = i2c_smbus_read_byte_data(new_client, LM63_REG_CHIP_ID);
+
+        reg_config1 = i2c_smbus_read_byte_data(new_client,
+                      LM63_REG_CONFIG1);
+        reg_config2 = i2c_smbus_read_byte_data(new_client,
+                      LM63_REG_CONFIG2);
+        reg_alert_status = i2c_smbus_read_byte_data(new_client,
+                           LM63_REG_ALERT_STATUS);
+        reg_alert_mask = i2c_smbus_read_byte_data(new_client,
+                         LM63_REG_ALERT_MASK);
+
+        if (man_id != 0x01 /* National Semiconductor */
+         || chip_id != 0x41 /* LM63 */
+         || (reg_config1 & 0x18) != 0x00
+         || (reg_config2 & 0xF8) != 0x00
+         || (reg_alert_status & 0x20) != 0x00
+         || (reg_alert_mask & 0xA4) != 0xA4) {
+                dev_dbg(&adapter->dev,
+                        "Unsupported chip (man_id=0x%02X, chip_id=0x%02X)\n",
+                        man_id, chip_id);
+                return -ENODEV;
         }
 
         strlcpy(info->type, "lm63", I2C_NAME_SIZE);