diff options
author | Guenter Roeck <linux@roeck-us.net> | 2013-09-13 13:38:09 -0400 |
---|---|---|
committer | Guenter Roeck <linux@roeck-us.net> | 2013-10-13 19:16:26 -0400 |
commit | bb34c0da646530425d9ae0e6e6229e641469da4c (patch) | |
tree | 8a14b118dcb684c766bd3d61482f93dfbf150560 /drivers/hwmon/adt7462.c | |
parent | af78fdf4a61827bed7f0fcbba8cc9ae393a3ad82 (diff) |
hwmon: (adt7462) Use error value returned from find_trange_value()
find_trange_value() returns -ENODEV in case of errors, only to have it
ignored and replaced with -EINVAL. Make it return -EINVAL and use it.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Jean Delvare <khali@linux-fr.org>
Diffstat (limited to 'drivers/hwmon/adt7462.c')
-rw-r--r-- | drivers/hwmon/adt7462.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/hwmon/adt7462.c b/drivers/hwmon/adt7462.c index addb5a4d5064..562cc3881d33 100644 --- a/drivers/hwmon/adt7462.c +++ b/drivers/hwmon/adt7462.c | |||
@@ -700,7 +700,7 @@ static int find_trange_value(int trange) | |||
700 | if (trange_values[i] == trange) | 700 | if (trange_values[i] == trange) |
701 | return i; | 701 | return i; |
702 | 702 | ||
703 | return -ENODEV; | 703 | return -EINVAL; |
704 | } | 704 | } |
705 | 705 | ||
706 | static struct adt7462_data *adt7462_update_device(struct device *dev) | 706 | static struct adt7462_data *adt7462_update_device(struct device *dev) |
@@ -1294,9 +1294,8 @@ static ssize_t set_pwm_tmax(struct device *dev, | |||
1294 | /* trange = tmax - tmin */ | 1294 | /* trange = tmax - tmin */ |
1295 | tmin = (data->pwm_tmin[attr->index] - 64) * 1000; | 1295 | tmin = (data->pwm_tmin[attr->index] - 64) * 1000; |
1296 | trange_value = find_trange_value(trange - tmin); | 1296 | trange_value = find_trange_value(trange - tmin); |
1297 | |||
1298 | if (trange_value < 0) | 1297 | if (trange_value < 0) |
1299 | return -EINVAL; | 1298 | return trange_value; |
1300 | 1299 | ||
1301 | temp = trange_value << ADT7462_PWM_RANGE_SHIFT; | 1300 | temp = trange_value << ADT7462_PWM_RANGE_SHIFT; |
1302 | temp |= data->pwm_trange[attr->index] & ADT7462_PWM_HYST_MASK; | 1301 | temp |= data->pwm_trange[attr->index] & ADT7462_PWM_HYST_MASK; |