diff options
author | Jason Wang <jasowang@redhat.com> | 2012-08-17 06:52:43 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-08-17 12:51:59 -0400 |
commit | 0592969e73ae50ce6852d1aff3d222a335289094 (patch) | |
tree | 15d579b39ad1835773ae101759832be40500f1ec /drivers/hv | |
parent | 4a52c4af48a2a35282ddc4dcf2df83486d636754 (diff) |
hv: fail the probing immediately when we are not in hyperv platform
We wait for about 5 seconds for the success of the hyperv registration even if
we were not in hyperv platform. This is suboptimal, so the patch check the cpuid
in the beginning of hv_acpi_init() instead of in vmbus_bus_init() to fail the
probing immediately.
Signed-off-by: Jason Wang <jasowang@redhat.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Acked-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hv')
-rw-r--r-- | drivers/hv/hv.c | 25 | ||||
-rw-r--r-- | drivers/hv/vmbus_drv.c | 25 |
2 files changed, 25 insertions, 25 deletions
diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c index 771e24f2981d..3648f8f0f368 100644 --- a/drivers/hv/hv.c +++ b/drivers/hv/hv.c | |||
@@ -39,28 +39,6 @@ struct hv_context hv_context = { | |||
39 | }; | 39 | }; |
40 | 40 | ||
41 | /* | 41 | /* |
42 | * query_hypervisor_presence | ||
43 | * - Query the cpuid for presence of windows hypervisor | ||
44 | */ | ||
45 | static int query_hypervisor_presence(void) | ||
46 | { | ||
47 | unsigned int eax; | ||
48 | unsigned int ebx; | ||
49 | unsigned int ecx; | ||
50 | unsigned int edx; | ||
51 | unsigned int op; | ||
52 | |||
53 | eax = 0; | ||
54 | ebx = 0; | ||
55 | ecx = 0; | ||
56 | edx = 0; | ||
57 | op = HVCPUID_VERSION_FEATURES; | ||
58 | cpuid(op, &eax, &ebx, &ecx, &edx); | ||
59 | |||
60 | return ecx & HV_PRESENT_BIT; | ||
61 | } | ||
62 | |||
63 | /* | ||
64 | * query_hypervisor_info - Get version info of the windows hypervisor | 42 | * query_hypervisor_info - Get version info of the windows hypervisor |
65 | */ | 43 | */ |
66 | static int query_hypervisor_info(void) | 44 | static int query_hypervisor_info(void) |
@@ -160,9 +138,6 @@ int hv_init(void) | |||
160 | memset(hv_context.synic_message_page, 0, | 138 | memset(hv_context.synic_message_page, 0, |
161 | sizeof(void *) * NR_CPUS); | 139 | sizeof(void *) * NR_CPUS); |
162 | 140 | ||
163 | if (!query_hypervisor_presence()) | ||
164 | goto cleanup; | ||
165 | |||
166 | max_leaf = query_hypervisor_info(); | 141 | max_leaf = query_hypervisor_info(); |
167 | 142 | ||
168 | /* | 143 | /* |
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index b76e8b321266..f40dd57bbec1 100644 --- a/drivers/hv/vmbus_drv.c +++ b/drivers/hv/vmbus_drv.c | |||
@@ -719,10 +719,35 @@ static struct acpi_driver vmbus_acpi_driver = { | |||
719 | }, | 719 | }, |
720 | }; | 720 | }; |
721 | 721 | ||
722 | /* | ||
723 | * query_hypervisor_presence | ||
724 | * - Query the cpuid for presence of windows hypervisor | ||
725 | */ | ||
726 | static int query_hypervisor_presence(void) | ||
727 | { | ||
728 | unsigned int eax; | ||
729 | unsigned int ebx; | ||
730 | unsigned int ecx; | ||
731 | unsigned int edx; | ||
732 | unsigned int op; | ||
733 | |||
734 | eax = 0; | ||
735 | ebx = 0; | ||
736 | ecx = 0; | ||
737 | edx = 0; | ||
738 | op = HVCPUID_VERSION_FEATURES; | ||
739 | cpuid(op, &eax, &ebx, &ecx, &edx); | ||
740 | |||
741 | return ecx & HV_PRESENT_BIT; | ||
742 | } | ||
743 | |||
722 | static int __init hv_acpi_init(void) | 744 | static int __init hv_acpi_init(void) |
723 | { | 745 | { |
724 | int ret, t; | 746 | int ret, t; |
725 | 747 | ||
748 | if (!query_hypervisor_presence()) | ||
749 | return -ENODEV; | ||
750 | |||
726 | init_completion(&probe_event); | 751 | init_completion(&probe_event); |
727 | 752 | ||
728 | /* | 753 | /* |