aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/hid
diff options
context:
space:
mode:
authorAndrew Duggan <aduggan@synaptics.com>2014-07-11 17:35:51 -0400
committerJiri Kosina <jkosina@suse.cz>2014-07-29 05:08:42 -0400
commit01a5f8a401a2a525b9546d65ddf69aaba37f288d (patch)
treeba5173e59fe5bcabe470168bb80e534bdab25727 /drivers/hid
parent9e2c327ee85e37264a1e04109efc7b97844afd0b (diff)
HID: rmi: change logging level of log messages related to unexpected reports
Userspace tools may use hidraw to perform operations on the device from userspace while hid-rmi is bound to the device. This can cause hid-rmi to print error messages when its ->raw_event() callback gets called as the reports pass through the HID stack. In this case receiving responses which were not initiated by hid-rmi is not actually an error so the resulting error messages are incorrect and misleading. This patch changes the log messages to debug so that the messages can be turned on in the event that there is a problem and there is not a userspace tool running. Signed-off-by: Andrew Duggan <aduggan@synaptics.com> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
-rw-r--r--drivers/hid/hid-rmi.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index 3221a95ed97c..2c3524bacca6 100644
--- a/drivers/hid/hid-rmi.c
+++ b/drivers/hid/hid-rmi.c
@@ -377,7 +377,7 @@ static int rmi_input_event(struct hid_device *hdev, u8 *data, int size)
377 irq_mask |= hdata->f30.irq_mask; 377 irq_mask |= hdata->f30.irq_mask;
378 378
379 if (data[1] & ~irq_mask) 379 if (data[1] & ~irq_mask)
380 hid_warn(hdev, "unknown intr source:%02lx %s:%d\n", 380 hid_dbg(hdev, "unknown intr source:%02lx %s:%d\n",
381 data[1] & ~irq_mask, __FILE__, __LINE__); 381 data[1] & ~irq_mask, __FILE__, __LINE__);
382 382
383 if (hdata->f11.interrupt_base < hdata->f30.interrupt_base) { 383 if (hdata->f11.interrupt_base < hdata->f30.interrupt_base) {
@@ -400,7 +400,7 @@ static int rmi_read_data_event(struct hid_device *hdev, u8 *data, int size)
400 struct rmi_data *hdata = hid_get_drvdata(hdev); 400 struct rmi_data *hdata = hid_get_drvdata(hdev);
401 401
402 if (!test_bit(RMI_READ_REQUEST_PENDING, &hdata->flags)) { 402 if (!test_bit(RMI_READ_REQUEST_PENDING, &hdata->flags)) {
403 hid_err(hdev, "no read request pending\n"); 403 hid_dbg(hdev, "no read request pending\n");
404 return 0; 404 return 0;
405 } 405 }
406 406