diff options
author | Benjamin Tissoires <benjamin.tissoires@redhat.com> | 2014-07-25 20:31:51 -0400 |
---|---|---|
committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2014-07-25 21:55:53 -0400 |
commit | d70420b914c98a3758674c6e9858810e0ab4ea30 (patch) | |
tree | 7ac23e36fd6f69d3450b9a875f12e3a8b0c10943 /drivers/hid/wacom_sys.c | |
parent | ac8d10101b0e3a0a1478f8bb51bbbb0a56fe0956 (diff) |
Input: wacom - use a uniq name for the battery device
The current implementation uses "wacom_battery" as a generic name for
batteries. This prevents us to have two Wacom devices with a battery
attached as the power system will complain about the name which is already
registered.
Use an incremental name for each battery attached.
Related bug:
https://sourceforge.net/p/linuxwacom/bugs/248/
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Acked-by: Przemo Firszt <przemo@firszt.eu>
Acked-by: Ping Cheng <pingc@wacom.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/hid/wacom_sys.c')
-rw-r--r-- | drivers/hid/wacom_sys.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index f8744c4d3b18..a27404d6e98d 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c | |||
@@ -809,12 +809,16 @@ static int wacom_battery_get_property(struct power_supply *psy, | |||
809 | static int wacom_initialize_battery(struct wacom *wacom) | 809 | static int wacom_initialize_battery(struct wacom *wacom) |
810 | { | 810 | { |
811 | int error = 0; | 811 | int error = 0; |
812 | static atomic_t battery_no = ATOMIC_INIT(0); | ||
813 | unsigned long n; | ||
812 | 814 | ||
813 | if (wacom->wacom_wac.features.quirks & WACOM_QUIRK_BATTERY) { | 815 | if (wacom->wacom_wac.features.quirks & WACOM_QUIRK_BATTERY) { |
816 | n = atomic_inc_return(&battery_no) - 1; | ||
814 | wacom->battery.properties = wacom_battery_props; | 817 | wacom->battery.properties = wacom_battery_props; |
815 | wacom->battery.num_properties = ARRAY_SIZE(wacom_battery_props); | 818 | wacom->battery.num_properties = ARRAY_SIZE(wacom_battery_props); |
816 | wacom->battery.get_property = wacom_battery_get_property; | 819 | wacom->battery.get_property = wacom_battery_get_property; |
817 | wacom->battery.name = "wacom_battery"; | 820 | sprintf(wacom->wacom_wac.bat_name, "wacom_battery_%ld", n); |
821 | wacom->battery.name = wacom->wacom_wac.bat_name; | ||
818 | wacom->battery.type = POWER_SUPPLY_TYPE_BATTERY; | 822 | wacom->battery.type = POWER_SUPPLY_TYPE_BATTERY; |
819 | wacom->battery.use_for_apm = 0; | 823 | wacom->battery.use_for_apm = 0; |
820 | 824 | ||