diff options
author | Benjamin Tissoires <benjamin.tissoires@gmail.com> | 2013-02-25 05:31:47 -0500 |
---|---|---|
committer | Jiri Kosina <jkosina@suse.cz> | 2013-02-25 07:26:41 -0500 |
commit | b7966a4d7be0a10329f03330390f4bdaf453d74a (patch) | |
tree | 73e1456d2199e16edf22af60929507ae25cff281 /drivers/hid/usbhid/hiddev.c | |
parent | d881427253da011495f4193663d809d0e9dfa215 (diff) |
HID: use hid_hw_wait() instead of direct call to usbhid
This removes most of the dependencies between hid drivers and usbhid.
The patch was constructed by replacing all occurences of
usbhid_wait_io() by its hid_hw_wait() counterpart.
Then, drivers not requiring USB_HID anymore have their USB_HID
dependency cleaned in the Kconfig file.
As of today, few drivers are still requiring an explicit USB layer
dependency:
* ntrig (a patch is on its way)
* multitouch (one patch following and another on its way)
* lenovo tpkbd
* roccat
* sony
The last three are two deeply using direct calls to the usb subsystem
to be able to be cleaned right now.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/usbhid/hiddev.c')
-rw-r--r-- | drivers/hid/usbhid/hiddev.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c index 430d2a9e4521..2f1ddca6f2e0 100644 --- a/drivers/hid/usbhid/hiddev.c +++ b/drivers/hid/usbhid/hiddev.c | |||
@@ -706,7 +706,7 @@ static long hiddev_ioctl(struct file *file, unsigned int cmd, unsigned long arg) | |||
706 | break; | 706 | break; |
707 | 707 | ||
708 | hid_hw_request(hid, report, HID_REQ_GET_REPORT); | 708 | hid_hw_request(hid, report, HID_REQ_GET_REPORT); |
709 | usbhid_wait_io(hid); | 709 | hid_hw_wait(hid); |
710 | 710 | ||
711 | r = 0; | 711 | r = 0; |
712 | break; | 712 | break; |
@@ -725,7 +725,7 @@ static long hiddev_ioctl(struct file *file, unsigned int cmd, unsigned long arg) | |||
725 | break; | 725 | break; |
726 | 726 | ||
727 | hid_hw_request(hid, report, HID_REQ_SET_REPORT); | 727 | hid_hw_request(hid, report, HID_REQ_SET_REPORT); |
728 | usbhid_wait_io(hid); | 728 | hid_hw_wait(hid); |
729 | 729 | ||
730 | r = 0; | 730 | r = 0; |
731 | break; | 731 | break; |