HID: make debugging output runtime-configurable

There have been many reports recently about broken HID devices, the
diagnosis of which required users to recompile their kernels in order
to be able to provide debugging output needed for coding a quirk for
a particular device.

This patch makes CONFIG_HID_DEBUG default y if !EMBEDDED and makes it
possible to control debugging output produced by HID code by supplying
'debug=1' module parameter.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>

1 files changed, 2 insertions, 6 deletions

diff --git a/drivers/hid/usbhid/hid-zpff.c b/drivers/hid/usbhid/hid-zpff.c
index a7fbffcdaf36..5a688274f6a3 100644
--- a/drivers/hid/usbhid/hid-zpff.c
+++ b/drivers/hid/usbhid/hid-zpff.c
@@ -21,10 +21,6 @@
  */
 
 
-/* #define DEBUG */
-
-#define debug(format, arg...) pr_debug("hid-zpff: " format "\n" , ## arg)
-
 #include <linux/input.h>
 #include <linux/usb.h>
 #include <linux/hid.h>
@@ -49,14 +45,14 @@ static int hid_zpff_play(struct input_dev *dev, void *data,
 
         left = effect->u.rumble.strong_magnitude;
         right = effect->u.rumble.weak_magnitude;
-        debug("called with 0x%04x 0x%04x", left, right);
+        dbg_hid("called with 0x%04x 0x%04x\n", left, right);
 
         left = left * 0x7f / 0xffff;
         right = right * 0x7f / 0xffff;
 
         zpff->report->field[2]->value[0] = left;
         zpff->report->field[3]->value[0] = right;
-        debug("running with 0x%02x 0x%02x", left, right);
+        dbg_hid("running with 0x%02x 0x%02x\n", left, right);
         usbhid_submit_report(hid, zpff->report, USB_DIR_OUT);
 
         return 0;