HID: Add and use hid_<level>: dev_<level> equivalents

Neaten current uses of dev_<level> by adding and using
hid specific hid_<level> macros.

Convert existing uses of dev_<level> uses to hid_<level>.
Convert hid-pidff printk uses to hid_<level>.

Remove err_hid and use hid_err instead.

Add missing newlines to logging messages where necessary.
Coalesce format strings.

Add and use pr_fmt(fmt) KBUILD_MODNAME ": " fmt

Other miscellaneous changes:

Add const struct hid_device * argument to hid-core functions
extract() and implement() so hid_<level> can be used by them.
Fix bad indentation in hid-core hid_input_field function
that calls extract() function above.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

1 files changed, 5 insertions, 5 deletions

diff --git a/drivers/hid/hid-roccat.c b/drivers/hid/hid-roccat.c
index a9d9b29ff47f..4bc7a93dc1f5 100644
--- a/drivers/hid/hid-roccat.c
+++ b/drivers/hid/hid-roccat.c
@@ -21,6 +21,8 @@
  * It is inspired by hidraw, but uses only one circular buffer for all readers.
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/cdev.h>
 #include <linux/poll.h>
 #include <linux/sched.h>
@@ -165,8 +167,7 @@ static int roccat_open(struct inode *inode, struct file *file)
         mutex_lock(&device->readers_lock);
 
         if (!device) {
-                printk(KERN_EMERG "roccat device with minor %d doesn't exist\n",
-                                minor);
+                pr_emerg("roccat device with minor %d doesn't exist\n", minor);
                 error = -ENODEV;
                 goto exit_err;
         }
@@ -214,8 +215,7 @@ static int roccat_release(struct inode *inode, struct file *file)
         device = devices[minor];
         if (!device) {
                 mutex_unlock(&devices_lock);
-                printk(KERN_EMERG "roccat device with minor %d doesn't exist\n",
-                                minor);
+                pr_emerg("roccat device with minor %d doesn't exist\n", minor);
                 return -ENODEV;
         }
 
@@ -392,7 +392,7 @@ static int __init roccat_init(void)
         roccat_major = MAJOR(dev_id);
 
         if (retval < 0) {
-                printk(KERN_WARNING "roccat: can't get major number\n");
+                pr_warn("can't get major number\n");
                 return retval;
         }