diff options
author | Benjamin Tissoires <benjamin.tissoires@gmail.com> | 2013-02-25 05:31:46 -0500 |
---|---|---|
committer | Jiri Kosina <jkosina@suse.cz> | 2013-02-25 07:26:41 -0500 |
commit | d881427253da011495f4193663d809d0e9dfa215 (patch) | |
tree | fe4eb817ab712f7049b1d3ef675fec69d9207675 /drivers/hid/hid-pl.c | |
parent | f3757cea18fadce23c95a4c4bc3123af73a95e65 (diff) |
HID: use hid_hw_request() instead of direct call to usbhid
This allows the hid drivers to be independent from the transport layer.
The patch was constructed by replacing all occurences of
usbhid_submit_report() by its hid_hw_request() counterpart.
Then, drivers not requiring USB_HID anymore have their USB_HID
dependency cleaned in the Kconfig file.
Finally, few drivers still depends on USB_HID. Many of them
are requiring the io wait callback. They are found in the next patch.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
For the sensor-hub part:
Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hid-pl.c')
-rw-r--r-- | drivers/hid/hid-pl.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/hid/hid-pl.c b/drivers/hid/hid-pl.c index b0199d27787b..d29112fa5cd5 100644 --- a/drivers/hid/hid-pl.c +++ b/drivers/hid/hid-pl.c | |||
@@ -43,13 +43,11 @@ | |||
43 | #include <linux/input.h> | 43 | #include <linux/input.h> |
44 | #include <linux/slab.h> | 44 | #include <linux/slab.h> |
45 | #include <linux/module.h> | 45 | #include <linux/module.h> |
46 | #include <linux/usb.h> | ||
47 | #include <linux/hid.h> | 46 | #include <linux/hid.h> |
48 | 47 | ||
49 | #include "hid-ids.h" | 48 | #include "hid-ids.h" |
50 | 49 | ||
51 | #ifdef CONFIG_PANTHERLORD_FF | 50 | #ifdef CONFIG_PANTHERLORD_FF |
52 | #include "usbhid/usbhid.h" | ||
53 | 51 | ||
54 | struct plff_device { | 52 | struct plff_device { |
55 | struct hid_report *report; | 53 | struct hid_report *report; |
@@ -75,7 +73,7 @@ static int hid_plff_play(struct input_dev *dev, void *data, | |||
75 | *plff->strong = left; | 73 | *plff->strong = left; |
76 | *plff->weak = right; | 74 | *plff->weak = right; |
77 | debug("running with 0x%02x 0x%02x", left, right); | 75 | debug("running with 0x%02x 0x%02x", left, right); |
78 | usbhid_submit_report(hid, plff->report, USB_DIR_OUT); | 76 | hid_hw_request(hid, plff->report, HID_REQ_SET_REPORT); |
79 | 77 | ||
80 | return 0; | 78 | return 0; |
81 | } | 79 | } |
@@ -169,7 +167,7 @@ static int plff_init(struct hid_device *hid) | |||
169 | 167 | ||
170 | *strong = 0x00; | 168 | *strong = 0x00; |
171 | *weak = 0x00; | 169 | *weak = 0x00; |
172 | usbhid_submit_report(hid, plff->report, USB_DIR_OUT); | 170 | hid_hw_request(hid, plff->report, HID_REQ_SET_REPORT); |
173 | } | 171 | } |
174 | 172 | ||
175 | hid_info(hid, "Force feedback for PantherLord/GreenAsia devices by Anssi Hannula <anssi.hannula@gmail.com>\n"); | 173 | hid_info(hid, "Force feedback for PantherLord/GreenAsia devices by Anssi Hannula <anssi.hannula@gmail.com>\n"); |