diff options
author | Benjamin Tissoires <benjamin.tissoires@gmail.com> | 2013-02-25 05:31:46 -0500 |
---|---|---|
committer | Jiri Kosina <jkosina@suse.cz> | 2013-02-25 07:26:41 -0500 |
commit | d881427253da011495f4193663d809d0e9dfa215 (patch) | |
tree | fe4eb817ab712f7049b1d3ef675fec69d9207675 /drivers/hid/hid-picolcd_leds.c | |
parent | f3757cea18fadce23c95a4c4bc3123af73a95e65 (diff) |
HID: use hid_hw_request() instead of direct call to usbhid
This allows the hid drivers to be independent from the transport layer.
The patch was constructed by replacing all occurences of
usbhid_submit_report() by its hid_hw_request() counterpart.
Then, drivers not requiring USB_HID anymore have their USB_HID
dependency cleaned in the Kconfig file.
Finally, few drivers still depends on USB_HID. Many of them
are requiring the io wait callback. They are found in the next patch.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
For the sensor-hub part:
Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hid-picolcd_leds.c')
-rw-r--r-- | drivers/hid/hid-picolcd_leds.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/hid/hid-picolcd_leds.c b/drivers/hid/hid-picolcd_leds.c index 28cb6a4f9634..e994f9c29012 100644 --- a/drivers/hid/hid-picolcd_leds.c +++ b/drivers/hid/hid-picolcd_leds.c | |||
@@ -21,8 +21,6 @@ | |||
21 | #include <linux/hid-debug.h> | 21 | #include <linux/hid-debug.h> |
22 | #include <linux/input.h> | 22 | #include <linux/input.h> |
23 | #include "hid-ids.h" | 23 | #include "hid-ids.h" |
24 | #include "usbhid/usbhid.h" | ||
25 | #include <linux/usb.h> | ||
26 | 24 | ||
27 | #include <linux/fb.h> | 25 | #include <linux/fb.h> |
28 | #include <linux/vmalloc.h> | 26 | #include <linux/vmalloc.h> |
@@ -55,7 +53,7 @@ void picolcd_leds_set(struct picolcd_data *data) | |||
55 | spin_lock_irqsave(&data->lock, flags); | 53 | spin_lock_irqsave(&data->lock, flags); |
56 | hid_set_field(report->field[0], 0, data->led_state); | 54 | hid_set_field(report->field[0], 0, data->led_state); |
57 | if (!(data->status & PICOLCD_FAILED)) | 55 | if (!(data->status & PICOLCD_FAILED)) |
58 | usbhid_submit_report(data->hdev, report, USB_DIR_OUT); | 56 | hid_hw_request(data->hdev, report, HID_REQ_SET_REPORT); |
59 | spin_unlock_irqrestore(&data->lock, flags); | 57 | spin_unlock_irqrestore(&data->lock, flags); |
60 | } | 58 | } |
61 | 59 | ||