diff options
author | Benjamin Tissoires <benjamin.tissoires@gmail.com> | 2013-02-25 05:31:46 -0500 |
---|---|---|
committer | Jiri Kosina <jkosina@suse.cz> | 2013-02-25 07:26:41 -0500 |
commit | d881427253da011495f4193663d809d0e9dfa215 (patch) | |
tree | fe4eb817ab712f7049b1d3ef675fec69d9207675 /drivers/hid/hid-holtekff.c | |
parent | f3757cea18fadce23c95a4c4bc3123af73a95e65 (diff) |
HID: use hid_hw_request() instead of direct call to usbhid
This allows the hid drivers to be independent from the transport layer.
The patch was constructed by replacing all occurences of
usbhid_submit_report() by its hid_hw_request() counterpart.
Then, drivers not requiring USB_HID anymore have their USB_HID
dependency cleaned in the Kconfig file.
Finally, few drivers still depends on USB_HID. Many of them
are requiring the io wait callback. They are found in the next patch.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
For the sensor-hub part:
Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hid-holtekff.c')
-rw-r--r-- | drivers/hid/hid-holtekff.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/hid/hid-holtekff.c b/drivers/hid/hid-holtekff.c index f34d1186a3e1..9a8f05124525 100644 --- a/drivers/hid/hid-holtekff.c +++ b/drivers/hid/hid-holtekff.c | |||
@@ -27,12 +27,10 @@ | |||
27 | #include <linux/input.h> | 27 | #include <linux/input.h> |
28 | #include <linux/module.h> | 28 | #include <linux/module.h> |
29 | #include <linux/slab.h> | 29 | #include <linux/slab.h> |
30 | #include <linux/usb.h> | ||
31 | 30 | ||
32 | #include "hid-ids.h" | 31 | #include "hid-ids.h" |
33 | 32 | ||
34 | #ifdef CONFIG_HOLTEK_FF | 33 | #ifdef CONFIG_HOLTEK_FF |
35 | #include "usbhid/usbhid.h" | ||
36 | 34 | ||
37 | MODULE_LICENSE("GPL"); | 35 | MODULE_LICENSE("GPL"); |
38 | MODULE_AUTHOR("Anssi Hannula <anssi.hannula@iki.fi>"); | 36 | MODULE_AUTHOR("Anssi Hannula <anssi.hannula@iki.fi>"); |
@@ -102,7 +100,7 @@ static void holtekff_send(struct holtekff_device *holtekff, | |||
102 | 100 | ||
103 | dbg_hid("sending %*ph\n", 7, data); | 101 | dbg_hid("sending %*ph\n", 7, data); |
104 | 102 | ||
105 | usbhid_submit_report(hid, holtekff->field->report, USB_DIR_OUT); | 103 | hid_hw_request(hid, holtekff->field->report, HID_REQ_SET_REPORT); |
106 | } | 104 | } |
107 | 105 | ||
108 | static int holtekff_play(struct input_dev *dev, void *data, | 106 | static int holtekff_play(struct input_dev *dev, void *data, |