diff options
author | Jesse Barnes <jbarnes@virtuousgeek.org> | 2010-04-23 12:32:23 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-04-23 13:39:20 -0400 |
commit | 1918ad77f7f908ed67cf37c505c6ad4ac52f1ecf (patch) | |
tree | ee34f9435901f83ee8a4649f66991d4de6be444b /drivers/gpu | |
parent | d5a30458a90597915977f06e79406b664a41b8ac (diff) |
drm/i915: fix non-Ironlake 965 class crashes
My PIPE_CONTROL fix (just sent via Eric's tree) was buggy; I was
testing a whole set of patches together and missed a conversion to the
new HAS_PIPE_CONTROL macro, which will cause breakage on non-Ironlake
965 class chips. Fortunately, the fix is trivial and has been tested.
Be sure to use the HAS_PIPE_CONTROL macro in i915_get_gem_seqno, or
we'll end up reading the wrong graphics memory, likely causing hangs,
crashes, or worse.
Reported-by: Zdenek Kabelac <zdenek.kabelac@gmail.com>
Reported-by: Toralf Förster <toralf.foerster@gmx.de>
Tested-by: Toralf Förster <toralf.foerster@gmx.de>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/gpu')
-rw-r--r-- | drivers/gpu/drm/i915/i915_gem.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 7f52cc124cfe..ef3d91dda71a 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c | |||
@@ -1793,7 +1793,7 @@ i915_get_gem_seqno(struct drm_device *dev) | |||
1793 | { | 1793 | { |
1794 | drm_i915_private_t *dev_priv = dev->dev_private; | 1794 | drm_i915_private_t *dev_priv = dev->dev_private; |
1795 | 1795 | ||
1796 | if (IS_I965G(dev)) | 1796 | if (HAS_PIPE_CONTROL(dev)) |
1797 | return ((volatile u32 *)(dev_priv->seqno_page))[0]; | 1797 | return ((volatile u32 *)(dev_priv->seqno_page))[0]; |
1798 | else | 1798 | else |
1799 | return READ_HWSP(dev_priv, I915_GEM_HWS_INDEX); | 1799 | return READ_HWSP(dev_priv, I915_GEM_HWS_INDEX); |