aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu
diff options
context:
space:
mode:
authorFrancisco Jerez <currojerez@riseup.net>2010-08-25 06:54:53 -0400
committerBen Skeggs <bskeggs@redhat.com>2010-08-26 01:12:19 -0400
commitee508b821c2042fb852a078e594bd36606973780 (patch)
treec4fbeac6d8ddba5d408cde20480afabcaa7e8d2a /drivers/gpu
parentfba675283429e41270feb661a1f6f3bc05d71981 (diff)
drm/nv20: Don't use pushbuf calls on the original nv20.
The "return" command is buggy on the original nv20, it jumps back to the caller address as expected, but it doesn't clear the subroutine active bit making the subsequent pushbuf calls fail with a "stack" overflow. Signed-off-by: Francisco Jerez <currojerez@riseup.net> Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Diffstat (limited to 'drivers/gpu')
-rw-r--r--drivers/gpu/drm/nouveau/nouveau_gem.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c
index a915dcdd9a49..613f878e6d0f 100644
--- a/drivers/gpu/drm/nouveau/nouveau_gem.c
+++ b/drivers/gpu/drm/nouveau/nouveau_gem.c
@@ -663,7 +663,7 @@ nouveau_gem_ioctl_pushbuf(struct drm_device *dev, void *data,
663 push[i].length); 663 push[i].length);
664 } 664 }
665 } else 665 } else
666 if (dev_priv->card_type >= NV_20) { 666 if (dev_priv->chipset >= 0x25) {
667 ret = RING_SPACE(chan, req->nr_push * 2); 667 ret = RING_SPACE(chan, req->nr_push * 2);
668 if (ret) { 668 if (ret) {
669 NV_ERROR(dev, "cal_space: %d\n", ret); 669 NV_ERROR(dev, "cal_space: %d\n", ret);
@@ -738,7 +738,7 @@ out_next:
738 req->suffix0 = 0x00000000; 738 req->suffix0 = 0x00000000;
739 req->suffix1 = 0x00000000; 739 req->suffix1 = 0x00000000;
740 } else 740 } else
741 if (dev_priv->card_type >= NV_20) { 741 if (dev_priv->chipset >= 0x25) {
742 req->suffix0 = 0x00020000; 742 req->suffix0 = 0x00020000;
743 req->suffix1 = 0x00000000; 743 req->suffix1 = 0x00000000;
744 } else { 744 } else {