diff options
author | Ben Skeggs <bskeggs@redhat.com> | 2011-08-02 04:54:43 -0400 |
---|---|---|
committer | Ben Skeggs <bskeggs@redhat.com> | 2011-09-20 02:09:53 -0400 |
commit | 730764812ded8b53643670131219b3abbdab52c8 (patch) | |
tree | 14db7a1ea2f75df9638d9d2ca707c5acf49872ff /drivers/gpu/drm | |
parent | 68c9918479834c19d0c2a1d38b75227b01355674 (diff) |
drm/nouveau/backlight: make more consistent with rest of driver style
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Diffstat (limited to 'drivers/gpu/drm')
-rw-r--r-- | drivers/gpu/drm/nouveau/nouveau_backlight.c | 70 |
1 files changed, 39 insertions, 31 deletions
diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c index 00a55dfdba82..d412adc67403 100644 --- a/drivers/gpu/drm/nouveau/nouveau_backlight.c +++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c | |||
@@ -38,7 +38,8 @@ | |||
38 | #include "nouveau_drm.h" | 38 | #include "nouveau_drm.h" |
39 | #include "nouveau_reg.h" | 39 | #include "nouveau_reg.h" |
40 | 40 | ||
41 | static int nv40_get_intensity(struct backlight_device *bd) | 41 | static int |
42 | nv40_get_intensity(struct backlight_device *bd) | ||
42 | { | 43 | { |
43 | struct drm_device *dev = bl_get_data(bd); | 44 | struct drm_device *dev = bl_get_data(bd); |
44 | int val = (nv_rd32(dev, NV40_PMC_BACKLIGHT) & NV40_PMC_BACKLIGHT_MASK) | 45 | int val = (nv_rd32(dev, NV40_PMC_BACKLIGHT) & NV40_PMC_BACKLIGHT_MASK) |
@@ -47,7 +48,8 @@ static int nv40_get_intensity(struct backlight_device *bd) | |||
47 | return val; | 48 | return val; |
48 | } | 49 | } |
49 | 50 | ||
50 | static int nv40_set_intensity(struct backlight_device *bd) | 51 | static int |
52 | nv40_set_intensity(struct backlight_device *bd) | ||
51 | { | 53 | { |
52 | struct drm_device *dev = bl_get_data(bd); | 54 | struct drm_device *dev = bl_get_data(bd); |
53 | int val = bd->props.brightness; | 55 | int val = bd->props.brightness; |
@@ -65,30 +67,8 @@ static const struct backlight_ops nv40_bl_ops = { | |||
65 | .update_status = nv40_set_intensity, | 67 | .update_status = nv40_set_intensity, |
66 | }; | 68 | }; |
67 | 69 | ||
68 | static int nv50_get_intensity(struct backlight_device *bd) | 70 | static int |
69 | { | 71 | nv40_backlight_init(struct drm_connector *connector) |
70 | struct drm_device *dev = bl_get_data(bd); | ||
71 | |||
72 | return nv_rd32(dev, NV50_PDISPLAY_SOR_BACKLIGHT); | ||
73 | } | ||
74 | |||
75 | static int nv50_set_intensity(struct backlight_device *bd) | ||
76 | { | ||
77 | struct drm_device *dev = bl_get_data(bd); | ||
78 | int val = bd->props.brightness; | ||
79 | |||
80 | nv_wr32(dev, NV50_PDISPLAY_SOR_BACKLIGHT, | ||
81 | val | NV50_PDISPLAY_SOR_BACKLIGHT_ENABLE); | ||
82 | return 0; | ||
83 | } | ||
84 | |||
85 | static const struct backlight_ops nv50_bl_ops = { | ||
86 | .options = BL_CORE_SUSPENDRESUME, | ||
87 | .get_brightness = nv50_get_intensity, | ||
88 | .update_status = nv50_set_intensity, | ||
89 | }; | ||
90 | |||
91 | static int nouveau_nv40_backlight_init(struct drm_connector *connector) | ||
92 | { | 72 | { |
93 | struct drm_device *dev = connector->dev; | 73 | struct drm_device *dev = connector->dev; |
94 | struct drm_nouveau_private *dev_priv = dev->dev_private; | 74 | struct drm_nouveau_private *dev_priv = dev->dev_private; |
@@ -113,7 +93,33 @@ static int nouveau_nv40_backlight_init(struct drm_connector *connector) | |||
113 | return 0; | 93 | return 0; |
114 | } | 94 | } |
115 | 95 | ||
116 | static int nouveau_nv50_backlight_init(struct drm_connector *connector) | 96 | static int |
97 | nv50_get_intensity(struct backlight_device *bd) | ||
98 | { | ||
99 | struct drm_device *dev = bl_get_data(bd); | ||
100 | |||
101 | return nv_rd32(dev, NV50_PDISPLAY_SOR_BACKLIGHT); | ||
102 | } | ||
103 | |||
104 | static int | ||
105 | nv50_set_intensity(struct backlight_device *bd) | ||
106 | { | ||
107 | struct drm_device *dev = bl_get_data(bd); | ||
108 | int val = bd->props.brightness; | ||
109 | |||
110 | nv_wr32(dev, NV50_PDISPLAY_SOR_BACKLIGHT, | ||
111 | val | NV50_PDISPLAY_SOR_BACKLIGHT_ENABLE); | ||
112 | return 0; | ||
113 | } | ||
114 | |||
115 | static const struct backlight_ops nv50_bl_ops = { | ||
116 | .options = BL_CORE_SUSPENDRESUME, | ||
117 | .get_brightness = nv50_get_intensity, | ||
118 | .update_status = nv50_set_intensity, | ||
119 | }; | ||
120 | |||
121 | static int | ||
122 | nv50_backlight_init(struct drm_connector *connector) | ||
117 | { | 123 | { |
118 | struct drm_device *dev = connector->dev; | 124 | struct drm_device *dev = connector->dev; |
119 | struct drm_nouveau_private *dev_priv = dev->dev_private; | 125 | struct drm_nouveau_private *dev_priv = dev->dev_private; |
@@ -137,7 +143,8 @@ static int nouveau_nv50_backlight_init(struct drm_connector *connector) | |||
137 | return 0; | 143 | return 0; |
138 | } | 144 | } |
139 | 145 | ||
140 | int nouveau_backlight_init(struct drm_connector *connector) | 146 | int |
147 | nouveau_backlight_init(struct drm_connector *connector) | ||
141 | { | 148 | { |
142 | struct drm_device *dev = connector->dev; | 149 | struct drm_device *dev = connector->dev; |
143 | struct drm_nouveau_private *dev_priv = dev->dev_private; | 150 | struct drm_nouveau_private *dev_priv = dev->dev_private; |
@@ -152,9 +159,9 @@ int nouveau_backlight_init(struct drm_connector *connector) | |||
152 | 159 | ||
153 | switch (dev_priv->card_type) { | 160 | switch (dev_priv->card_type) { |
154 | case NV_40: | 161 | case NV_40: |
155 | return nouveau_nv40_backlight_init(connector); | 162 | return nv40_backlight_init(connector); |
156 | case NV_50: | 163 | case NV_50: |
157 | return nouveau_nv50_backlight_init(connector); | 164 | return nv50_backlight_init(connector); |
158 | default: | 165 | default: |
159 | break; | 166 | break; |
160 | } | 167 | } |
@@ -162,7 +169,8 @@ int nouveau_backlight_init(struct drm_connector *connector) | |||
162 | return 0; | 169 | return 0; |
163 | } | 170 | } |
164 | 171 | ||
165 | void nouveau_backlight_exit(struct drm_connector *connector) | 172 | void |
173 | nouveau_backlight_exit(struct drm_connector *connector) | ||
166 | { | 174 | { |
167 | struct drm_device *dev = connector->dev; | 175 | struct drm_device *dev = connector->dev; |
168 | struct drm_nouveau_private *dev_priv = dev->dev_private; | 176 | struct drm_nouveau_private *dev_priv = dev->dev_private; |