diff options
author | Dave Airlie <airlied@redhat.com> | 2009-06-29 04:29:11 -0400 |
---|---|---|
committer | Dave Airlie <airlied@redhat.com> | 2009-07-15 03:13:02 -0400 |
commit | ed10f95d60d41033d356fdcf88c240d7065bd5b4 (patch) | |
tree | 319558df2249b066c6678c2b54a8ae2fdfa7ae5c /drivers/gpu/drm/radeon/rs400.c | |
parent | 44b572809581d5a10dbe35aa6bf689f32b9c5ad6 (diff) |
drm/radeon/kms: fix some GART table entry bugs.
1. rv370 can accept 40-bit addresses - also at 24-bit shift not 4 bits
2. rs480 table can be in 40-bit space. - 4 bit shift for top 8 bits
3. rs480 table entries can be in 40-bit space.
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/radeon/rs400.c')
-rw-r--r-- | drivers/gpu/drm/radeon/rs400.c | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/drivers/gpu/drm/radeon/rs400.c b/drivers/gpu/drm/radeon/rs400.c index cc074b5a8f74..3275de4b6e3b 100644 --- a/drivers/gpu/drm/radeon/rs400.c +++ b/drivers/gpu/drm/radeon/rs400.c | |||
@@ -164,7 +164,9 @@ int rs400_gart_enable(struct radeon_device *rdev) | |||
164 | WREG32(RADEON_BUS_CNTL, tmp); | 164 | WREG32(RADEON_BUS_CNTL, tmp); |
165 | } | 165 | } |
166 | /* Table should be in 32bits address space so ignore bits above. */ | 166 | /* Table should be in 32bits address space so ignore bits above. */ |
167 | tmp = rdev->gart.table_addr & 0xfffff000; | 167 | tmp = (u32)rdev->gart.table_addr & 0xfffff000; |
168 | tmp |= (upper_32_bits(rdev->gart.table_addr) & 0xff) << 4; | ||
169 | |||
168 | WREG32_MC(RS480_GART_BASE, tmp); | 170 | WREG32_MC(RS480_GART_BASE, tmp); |
169 | /* TODO: more tweaking here */ | 171 | /* TODO: more tweaking here */ |
170 | WREG32_MC(RS480_GART_FEATURE_ID, | 172 | WREG32_MC(RS480_GART_FEATURE_ID, |
@@ -201,10 +203,17 @@ void rs400_gart_disable(struct radeon_device *rdev) | |||
201 | 203 | ||
202 | int rs400_gart_set_page(struct radeon_device *rdev, int i, uint64_t addr) | 204 | int rs400_gart_set_page(struct radeon_device *rdev, int i, uint64_t addr) |
203 | { | 205 | { |
206 | uint32_t entry; | ||
207 | |||
204 | if (i < 0 || i > rdev->gart.num_gpu_pages) { | 208 | if (i < 0 || i > rdev->gart.num_gpu_pages) { |
205 | return -EINVAL; | 209 | return -EINVAL; |
206 | } | 210 | } |
207 | rdev->gart.table.ram.ptr[i] = cpu_to_le32(((uint32_t)addr) | 0xC); | 211 | |
212 | entry = (lower_32_bits(addr) & PAGE_MASK) | | ||
213 | ((upper_32_bits(addr) & 0xff) << 4) | | ||
214 | 0xc; | ||
215 | entry = cpu_to_le32(entry); | ||
216 | rdev->gart.table.ram.ptr[i] = entry; | ||
208 | return 0; | 217 | return 0; |
209 | } | 218 | } |
210 | 219 | ||