drm/radeon/kms: use drm_mode directly for panel modes

This reduces the number of mode format conversions needed
and makes native panel mode support cleaner.

Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>

1 files changed, 31 insertions, 33 deletions

diff --git a/drivers/gpu/drm/radeon/radeon_combios.c b/drivers/gpu/drm/radeon/radeon_combios.c
index 748265a105b3..e91aba8530b6 100644
--- a/drivers/gpu/drm/radeon/radeon_combios.c
+++ b/drivers/gpu/drm/radeon/radeon_combios.c
@@ -808,25 +808,25 @@ static struct radeon_encoder_lvds *radeon_legacy_get_lvds_info_from_regs(struct
         lvds->panel_blon_delay = (lvds_ss_gen_cntl >> RADEON_LVDS_PWRSEQ_DELAY2_SHIFT) & 0xf;
 
         if (fp_vert_stretch & RADEON_VERT_STRETCH_ENABLE)
-                lvds->native_mode.panel_yres =
+                lvds->native_mode.vdisplay =
                     ((fp_vert_stretch & RADEON_VERT_PANEL_SIZE) >>
                      RADEON_VERT_PANEL_SHIFT) + 1;
         else
-                lvds->native_mode.panel_yres =
+                lvds->native_mode.vdisplay =
                     (RREG32(RADEON_CRTC_V_TOTAL_DISP) >> 16) + 1;
 
         if (fp_horz_stretch & RADEON_HORZ_STRETCH_ENABLE)
-                lvds->native_mode.panel_xres =
+                lvds->native_mode.hdisplay =
                     (((fp_horz_stretch & RADEON_HORZ_PANEL_SIZE) >>
                       RADEON_HORZ_PANEL_SHIFT) + 1) * 8;
         else
-                lvds->native_mode.panel_xres =
+                lvds->native_mode.hdisplay =
                     ((RREG32(RADEON_CRTC_H_TOTAL_DISP) >> 16) + 1) * 8;
 
-        if ((lvds->native_mode.panel_xres < 640) ||
-            (lvds->native_mode.panel_yres < 480)) {
-                lvds->native_mode.panel_xres = 640;
-                lvds->native_mode.panel_yres = 480;
+        if ((lvds->native_mode.hdisplay < 640) ||
+            (lvds->native_mode.vdisplay < 480)) {
+                lvds->native_mode.hdisplay = 640;
+                lvds->native_mode.vdisplay = 480;
         }
 
         ppll_div_sel = RREG8(RADEON_CLOCK_CNTL_INDEX + 1) & 0x3;
@@ -846,8 +846,8 @@ static struct radeon_encoder_lvds *radeon_legacy_get_lvds_info_from_regs(struct
         lvds->panel_vcc_delay = 200;
 
         DRM_INFO("Panel info derived from registers\n");
-        DRM_INFO("Panel Size %dx%d\n", lvds->native_mode.panel_xres,
-                 lvds->native_mode.panel_yres);
+        DRM_INFO("Panel Size %dx%d\n", lvds->native_mode.hdisplay,
+                 lvds->native_mode.vdisplay);
 
         return lvds;
 }
@@ -882,11 +882,11 @@ struct radeon_encoder_lvds *radeon_combios_get_lvds_info(struct radeon_encoder
 
                 DRM_INFO("Panel ID String: %s\n", stmp);
 
-                lvds->native_mode.panel_xres = RBIOS16(lcd_info + 0x19);
-                lvds->native_mode.panel_yres = RBIOS16(lcd_info + 0x1b);
+                lvds->native_mode.hdisplay = RBIOS16(lcd_info + 0x19);
+                lvds->native_mode.vdisplay = RBIOS16(lcd_info + 0x1b);
 
-                DRM_INFO("Panel Size %dx%d\n", lvds->native_mode.panel_xres,
-                         lvds->native_mode.panel_yres);
+                DRM_INFO("Panel Size %dx%d\n", lvds->native_mode.hdisplay,
+                         lvds->native_mode.vdisplay);
 
                 lvds->panel_vcc_delay = RBIOS16(lcd_info + 0x2c);
                 if (lvds->panel_vcc_delay > 2000 || lvds->panel_vcc_delay < 0)
@@ -944,27 +944,25 @@ struct radeon_encoder_lvds *radeon_combios_get_lvds_info(struct radeon_encoder
                         if (tmp == 0)
                                 break;
 
-                        if ((RBIOS16(tmp) == lvds->native_mode.panel_xres) &&
+                        if ((RBIOS16(tmp) == lvds->native_mode.hdisplay) &&
                             (RBIOS16(tmp + 2) ==
-                             lvds->native_mode.panel_yres)) {
-                                lvds->native_mode.hblank =
-                                    (RBIOS16(tmp + 17) - RBIOS16(tmp + 19)) * 8;
-                                lvds->native_mode.hoverplus =
-                                    (RBIOS16(tmp + 21) - RBIOS16(tmp + 19) -
-                                     1) * 8;
-                                lvds->native_mode.hsync_width =
-                                    RBIOS8(tmp + 23) * 8;
-
-                                lvds->native_mode.vblank = (RBIOS16(tmp + 24) -
-                                                            RBIOS16(tmp + 26));
-                                lvds->native_mode.voverplus =
-                                    ((RBIOS16(tmp + 28) & 0x7ff) -
-                                     RBIOS16(tmp + 26));
-                                lvds->native_mode.vsync_width =
-                                    ((RBIOS16(tmp + 28) & 0xf800) >> 11);
-                                lvds->native_mode.dotclock =
-                                    RBIOS16(tmp + 9) * 10;
+                             lvds->native_mode.vdisplay)) {
+                                lvds->native_mode.htotal = RBIOS16(tmp + 17) * 8;
+                                lvds->native_mode.hsync_start = RBIOS16(tmp + 21) * 8;
+                                lvds->native_mode.hsync_end = (RBIOS8(tmp + 23) +
+                                                               RBIOS16(tmp + 21)) * 8;
+
+                                lvds->native_mode.vtotal = RBIOS16(tmp + 24);
+                                lvds->native_mode.vsync_start = RBIOS16(tmp + 28) & 0x7ff;
+                                lvds->native_mode.vsync_end =
+                                        ((RBIOS16(tmp + 28) & 0xf800) >> 11) +
+                                        (RBIOS16(tmp + 28) & 0x7ff);
+
+                                lvds->native_mode.clock = RBIOS16(tmp + 9) * 10;
                                 lvds->native_mode.flags = 0;
+                                /* set crtc values */
+                                drm_mode_set_crtcinfo(&lvds->native_mode, CRTC_INTERLACE_HALVE_V);
+
                         }
                 }
         } else {