aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/nouveau/nv04_tv.c
diff options
context:
space:
mode:
authorFrancisco Jerez <currojerez@riseup.net>2010-07-19 21:08:25 -0400
committerBen Skeggs <bskeggs@redhat.com>2010-07-25 21:42:42 -0400
commit03cd06ca9046190e8418749c2c8f636e2625556c (patch)
tree632eaef04358ff0e1e4c0d1078d23d8ca09d4b41 /drivers/gpu/drm/nouveau/nv04_tv.c
parentd06ab841d14f3747823e88e5172047367e051a32 (diff)
drm/nouveau: No need to lock/unlock the VGA CRTC regs all the time.
Locking only makes sense in the VBIOS parsing code as it's executed before CRTC init. Signed-off-by: Francisco Jerez <currojerez@riseup.net> Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/nouveau/nv04_tv.c')
-rw-r--r--drivers/gpu/drm/nouveau/nv04_tv.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/gpu/drm/nouveau/nv04_tv.c b/drivers/gpu/drm/nouveau/nv04_tv.c
index 8de1eef3594a..94e299cef0b2 100644
--- a/drivers/gpu/drm/nouveau/nv04_tv.c
+++ b/drivers/gpu/drm/nouveau/nv04_tv.c
@@ -194,7 +194,6 @@ nv04_tv_create(struct drm_connector *connector, struct dcb_entry *entry)
194 struct nouveau_i2c_chan *i2c = 194 struct nouveau_i2c_chan *i2c =
195 nouveau_i2c_find(dev, entry->i2c_index); 195 nouveau_i2c_find(dev, entry->i2c_index);
196 int type, ret; 196 int type, ret;
197 bool was_locked;
198 197
199 /* Ensure that we can talk to this encoder */ 198 /* Ensure that we can talk to this encoder */
200 type = nv04_tv_identify(dev, entry->i2c_index); 199 type = nv04_tv_identify(dev, entry->i2c_index);
@@ -224,13 +223,8 @@ nv04_tv_create(struct drm_connector *connector, struct dcb_entry *entry)
224 nv_encoder->or = ffs(entry->or) - 1; 223 nv_encoder->or = ffs(entry->or) - 1;
225 224
226 /* Run the slave-specific initialization */ 225 /* Run the slave-specific initialization */
227 was_locked = NVLockVgaCrtcs(dev, false);
228
229 ret = drm_i2c_encoder_init(dev, to_encoder_slave(encoder), 226 ret = drm_i2c_encoder_init(dev, to_encoder_slave(encoder),
230 &i2c->adapter, &nv04_tv_encoder_info[type]); 227 &i2c->adapter, &nv04_tv_encoder_info[type]);
231
232 NVLockVgaCrtcs(dev, was_locked);
233
234 if (ret < 0) 228 if (ret < 0)
235 goto fail_cleanup; 229 goto fail_cleanup;
236 230