diff options
author | James Simmons <jsimmons@infradead.org> | 2010-12-20 14:10:39 -0500 |
---|---|---|
committer | Dave Airlie <airlied@redhat.com> | 2010-12-20 21:49:44 -0500 |
commit | 57084d05379fe5c081d024006129b0565a11855f (patch) | |
tree | ff13b1d40642d7ff8d1b3215bad93554a5a42af5 /drivers/gpu/drm/nouveau/nouveau_fbcon.c | |
parent | b08ebe7e776e5be0271ed1e1bbb384e1f29dd117 (diff) |
drm/fb: Don't expose mmio for fbdev emulation layer
For the fbdev api if the struct fb_var_screeninfo accel_flags field is set
to FB_ACCELF_TEXT then userland applications can not mmap the mmio region.
Since it is a bad idea for DRM drivers to expose the mmio region via the
fbdev layer we always set the accel_flags to prevent this. Please apply.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/nouveau/nouveau_fbcon.c')
-rw-r--r-- | drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c index ea861c915149..9dbe1eff2ae5 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c | |||
@@ -348,10 +348,6 @@ nouveau_fbcon_create(struct nouveau_fbdev *nfbdev, | |||
348 | drm_fb_helper_fill_fix(info, fb->pitch, fb->depth); | 348 | drm_fb_helper_fill_fix(info, fb->pitch, fb->depth); |
349 | drm_fb_helper_fill_var(info, &nfbdev->helper, sizes->fb_width, sizes->fb_height); | 349 | drm_fb_helper_fill_var(info, &nfbdev->helper, sizes->fb_width, sizes->fb_height); |
350 | 350 | ||
351 | /* FIXME: we really shouldn't expose mmio space at all */ | ||
352 | info->fix.mmio_start = pci_resource_start(pdev, 1); | ||
353 | info->fix.mmio_len = pci_resource_len(pdev, 1); | ||
354 | |||
355 | /* Set aperture base/size for vesafb takeover */ | 351 | /* Set aperture base/size for vesafb takeover */ |
356 | info->apertures = dev_priv->apertures; | 352 | info->apertures = dev_priv->apertures; |
357 | if (!info->apertures) { | 353 | if (!info->apertures) { |