diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-04-05 04:06:16 -0400 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-04-22 09:39:04 -0400 |
commit | 4cb8802e28c14a4b34827154ab1537bbde796cc2 (patch) | |
tree | 567a6366c12ae3ca6de46e2e6c01c4589483bb19 /drivers/gpu/drm/mgag200/mgag200_main.c | |
parent | 36b347fb31e74075315a782809007b9192c486ea (diff) |
drm/mgag200: Remove unecessary NULL check in gem_free
The ->gem_free_object never gets called with a NULL pointer, the check
is redundant. Also checking after the upcast allows compilers to elide
it anyway.
Spotted by coverity.
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/mgag200/mgag200_main.c')
-rw-r--r-- | drivers/gpu/drm/mgag200/mgag200_main.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_main.c index 0722d18992f4..f6b283b8375e 100644 --- a/drivers/gpu/drm/mgag200/mgag200_main.c +++ b/drivers/gpu/drm/mgag200/mgag200_main.c | |||
@@ -329,8 +329,6 @@ void mgag200_gem_free_object(struct drm_gem_object *obj) | |||
329 | { | 329 | { |
330 | struct mgag200_bo *mgag200_bo = gem_to_mga_bo(obj); | 330 | struct mgag200_bo *mgag200_bo = gem_to_mga_bo(obj); |
331 | 331 | ||
332 | if (!mgag200_bo) | ||
333 | return; | ||
334 | mgag200_bo_unref(&mgag200_bo); | 332 | mgag200_bo_unref(&mgag200_bo); |
335 | } | 333 | } |
336 | 334 | ||