diff options
author | Jesse Barnes <jbarnes@virtuousgeek.org> | 2010-10-07 19:01:10 -0400 |
---|---|---|
committer | Chris Wilson <chris@chris-wilson.co.uk> | 2010-10-08 04:23:18 -0400 |
commit | 1d85036278f1b3eb3b7c5db805e5c4c847d1415d (patch) | |
tree | fbccc5edb53e61b5119f5634296d242571b48f84 /drivers/gpu/drm/i915 | |
parent | 814948adec172dbc41252b1815e4e83aedfe91b9 (diff) |
drm/i915: remove broken intel_pch_has_edp function
Since we set the output type of PCH attached eDP panels to
INTEL_OUTPUT_eDP this function would never return true when it should.
It's been replaced by working functions.
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Diffstat (limited to 'drivers/gpu/drm/i915')
-rw-r--r-- | drivers/gpu/drm/i915/intel_display.c | 5 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_dp.c | 19 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_drv.h | 1 |
3 files changed, 2 insertions, 23 deletions
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 7fe92d06eb26..0ef52db4685f 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c | |||
@@ -2001,8 +2001,7 @@ static void ironlake_crtc_enable(struct drm_crtc *crtc) | |||
2001 | 2001 | ||
2002 | /* Enable panel fitting for LVDS */ | 2002 | /* Enable panel fitting for LVDS */ |
2003 | if (dev_priv->pch_pf_size && | 2003 | if (dev_priv->pch_pf_size && |
2004 | (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS) | 2004 | (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS) || HAS_eDP)) { |
2005 | || HAS_eDP || intel_pch_has_edp(crtc))) { | ||
2006 | /* Force use of hard-coded filter coefficients | 2005 | /* Force use of hard-coded filter coefficients |
2007 | * as some pre-programmed values are broken, | 2006 | * as some pre-programmed values are broken, |
2008 | * e.g. x201. | 2007 | * e.g. x201. |
@@ -3717,7 +3716,7 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc, | |||
3717 | temp |= PIPE_8BPC; | 3716 | temp |= PIPE_8BPC; |
3718 | else | 3717 | else |
3719 | temp |= PIPE_6BPC; | 3718 | temp |= PIPE_6BPC; |
3720 | } else if (has_edp_encoder || (is_dp && intel_pch_has_edp(crtc))) { | 3719 | } else if (has_edp_encoder) { |
3721 | switch (dev_priv->edp.bpp/3) { | 3720 | switch (dev_priv->edp.bpp/3) { |
3722 | case 8: | 3721 | case 8: |
3723 | temp |= PIPE_8BPC; | 3722 | temp |= PIPE_8BPC; |
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index da71263f6fab..57bfc3e7b40a 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c | |||
@@ -648,25 +648,6 @@ intel_dp_compute_m_n(int bpp, | |||
648 | intel_reduce_ratio(&m_n->link_m, &m_n->link_n); | 648 | intel_reduce_ratio(&m_n->link_m, &m_n->link_n); |
649 | } | 649 | } |
650 | 650 | ||
651 | bool intel_pch_has_edp(struct drm_crtc *crtc) | ||
652 | { | ||
653 | struct drm_device *dev = crtc->dev; | ||
654 | struct drm_mode_config *mode_config = &dev->mode_config; | ||
655 | struct drm_encoder *encoder; | ||
656 | |||
657 | list_for_each_entry(encoder, &mode_config->encoder_list, head) { | ||
658 | struct intel_dp *intel_dp; | ||
659 | |||
660 | if (encoder->crtc != crtc) | ||
661 | continue; | ||
662 | |||
663 | intel_dp = enc_to_intel_dp(encoder); | ||
664 | if (intel_dp->base.type == INTEL_OUTPUT_DISPLAYPORT) | ||
665 | return intel_dp->is_pch_edp; | ||
666 | } | ||
667 | return false; | ||
668 | } | ||
669 | |||
670 | void | 651 | void |
671 | intel_dp_set_m_n(struct drm_crtc *crtc, struct drm_display_mode *mode, | 652 | intel_dp_set_m_n(struct drm_crtc *crtc, struct drm_display_mode *mode, |
672 | struct drm_display_mode *adjusted_mode) | 653 | struct drm_display_mode *adjusted_mode) |
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index c946c48b472f..0581e5e5ac55 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h | |||
@@ -209,7 +209,6 @@ extern void intel_dp_init(struct drm_device *dev, int dp_reg); | |||
209 | void | 209 | void |
210 | intel_dp_set_m_n(struct drm_crtc *crtc, struct drm_display_mode *mode, | 210 | intel_dp_set_m_n(struct drm_crtc *crtc, struct drm_display_mode *mode, |
211 | struct drm_display_mode *adjusted_mode); | 211 | struct drm_display_mode *adjusted_mode); |
212 | extern bool intel_pch_has_edp(struct drm_crtc *crtc); | ||
213 | extern bool intel_dpd_is_edp(struct drm_device *dev); | 212 | extern bool intel_dpd_is_edp(struct drm_device *dev); |
214 | extern void intel_edp_link_config (struct intel_encoder *, int *, int *); | 213 | extern void intel_edp_link_config (struct intel_encoder *, int *, int *); |
215 | extern bool intel_encoder_is_pch_edp(struct drm_encoder *encoder); | 214 | extern bool intel_encoder_is_pch_edp(struct drm_encoder *encoder); |