aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915
diff options
context:
space:
mode:
authorClint Taylor <clinton.a.taylor@intel.com>2015-04-09 16:42:06 -0400
committerJani Nikula <jani.nikula@intel.com>2015-04-10 07:30:35 -0400
commitaf8fcb9c58f1b2f02ddc04ba64710aaa52da00db (patch)
tree243d374078c84350b28d4324eff94cd62980046a /drivers/gpu/drm/i915
parent88f933a8b03474ebcd16935d3620e5c10b557f6f (diff)
drm/i915/chv: Remove DPIO force latency causing interpair skew issue
Latest version of the "CHV DPIO programming notes" no longer requires writes to TX DW 11 to fix a +2UI interpair skew issue. The current code from April 2014 was actually causing additional skew issues between all TMDS pairs. ver2: added same treatment to intel_dp.c based on Ville's testing. Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Diffstat (limited to 'drivers/gpu/drm/i915')
-rw-r--r--drivers/gpu/drm/i915/intel_dp.c5
-rw-r--r--drivers/gpu/drm/i915/intel_hdmi.c5
2 files changed, 0 insertions, 10 deletions
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 8e0d1015fb36..60e8d5d77fc5 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -2742,11 +2742,6 @@ static void chv_pre_enable_dp(struct intel_encoder *encoder)
2742 2742
2743 /* Program Tx lane latency optimal setting*/ 2743 /* Program Tx lane latency optimal setting*/
2744 for (i = 0; i < 4; i++) { 2744 for (i = 0; i < 4; i++) {
2745 /* Set the latency optimal bit */
2746 data = (i == 1) ? 0x0 : 0x6;
2747 vlv_dpio_write(dev_priv, pipe, CHV_TX_DW11(ch, i),
2748 data << DPIO_FRC_LATENCY_SHFIT);
2749
2750 /* Set the upar bit */ 2745 /* Set the upar bit */
2751 data = (i == 1) ? 0x0 : 0x1; 2746 data = (i == 1) ? 0x0 : 0x1;
2752 vlv_dpio_write(dev_priv, pipe, CHV_TX_DW14(ch, i), 2747 vlv_dpio_write(dev_priv, pipe, CHV_TX_DW14(ch, i),
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index cacbafdad3ab..bfabd5fd9334 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -1515,11 +1515,6 @@ static void chv_hdmi_pre_enable(struct intel_encoder *encoder)
1515 1515
1516 /* Program Tx latency optimal setting */ 1516 /* Program Tx latency optimal setting */
1517 for (i = 0; i < 4; i++) { 1517 for (i = 0; i < 4; i++) {
1518 /* Set the latency optimal bit */
1519 data = (i == 1) ? 0x0 : 0x6;
1520 vlv_dpio_write(dev_priv, pipe, CHV_TX_DW11(ch, i),
1521 data << DPIO_FRC_LATENCY_SHFIT);
1522
1523 /* Set the upar bit */ 1518 /* Set the upar bit */
1524 data = (i == 1) ? 0x0 : 0x1; 1519 data = (i == 1) ? 0x0 : 0x1;
1525 vlv_dpio_write(dev_priv, pipe, CHV_TX_DW14(ch, i), 1520 vlv_dpio_write(dev_priv, pipe, CHV_TX_DW14(ch, i),