aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915/intel_ringbuffer.c
diff options
context:
space:
mode:
authorChris Wilson <chris@chris-wilson.co.uk>2012-04-17 11:38:12 -0400
committerDaniel Vetter <daniel.vetter@ffwll.ch>2012-04-18 05:11:14 -0400
commit65f5687603ea6ede1cb01b3d6c16a8c1fac88541 (patch)
tree0c474dd28afcf1350f3e781aadf9476026f1bc0b /drivers/gpu/drm/i915/intel_ringbuffer.c
parent7b09638f45379fd1f8cbcb0a95ea2b11f0c8b850 (diff)
drm/i915: Replace open coded MI_BATCH_GTT
The (2<<6) virtual memory space selector harks back to gen3 and is mandatory given our use of GTT space for batchbuffers. On gen4+, use of the GTT became mandatory and bit6 marked reserved. However the code must now explicitly set (1<<7), which conveniently is also (2<<6). To clarify the meaning for future readers, replace the open coded (2<<6) with MI_BATCH_GTT. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_ringbuffer.c')
-rw-r--r--drivers/gpu/drm/i915/intel_ringbuffer.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 492812db537b..4ae651bb1c97 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -786,7 +786,8 @@ i965_dispatch_execbuffer(struct intel_ring_buffer *ring, u32 offset, u32 length)
786 return ret; 786 return ret;
787 787
788 intel_ring_emit(ring, 788 intel_ring_emit(ring,
789 MI_BATCH_BUFFER_START | (2 << 6) | 789 MI_BATCH_BUFFER_START |
790 MI_BATCH_GTT |
790 MI_BATCH_NON_SECURE_I965); 791 MI_BATCH_NON_SECURE_I965);
791 intel_ring_emit(ring, offset); 792 intel_ring_emit(ring, offset);
792 intel_ring_advance(ring); 793 intel_ring_advance(ring);
@@ -823,7 +824,7 @@ i915_dispatch_execbuffer(struct intel_ring_buffer *ring,
823 if (ret) 824 if (ret)
824 return ret; 825 return ret;
825 826
826 intel_ring_emit(ring, MI_BATCH_BUFFER_START | (2 << 6)); 827 intel_ring_emit(ring, MI_BATCH_BUFFER_START | MI_BATCH_GTT);
827 intel_ring_emit(ring, offset | MI_BATCH_NON_SECURE); 828 intel_ring_emit(ring, offset | MI_BATCH_NON_SECURE);
828 intel_ring_advance(ring); 829 intel_ring_advance(ring);
829 830