diff options
author | Chris Wilson <chris@chris-wilson.co.uk> | 2010-11-09 05:16:56 -0500 |
---|---|---|
committer | Chris Wilson <chris@chris-wilson.co.uk> | 2010-11-11 12:46:00 -0500 |
commit | e74cfed521746544e6eeee84b24bd31c1e59ffe2 (patch) | |
tree | fe7d41f0b6cf278f3b8ac1005615ac31d4cf70a8 /drivers/gpu/drm/i915/intel_ringbuffer.c | |
parent | cae5852dcaa1139b198e13ebd3aeb7f3c065f875 (diff) |
Revert "drm/i915/ringbuffer: Ignore failure to setup the ring on Sandybridge"
This reverts commit 629e894173c9de589913cf649deaadec4b0579bd.
Diffstat (limited to 'drivers/gpu/drm/i915/intel_ringbuffer.c')
-rw-r--r-- | drivers/gpu/drm/i915/intel_ringbuffer.c | 32 |
1 files changed, 8 insertions, 24 deletions
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 99f2c96a9c70..1db860d7989a 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c | |||
@@ -180,30 +180,14 @@ static int init_ring_common(struct intel_ring_buffer *ring) | |||
180 | if ((I915_READ_CTL(ring) & RING_VALID) == 0 || | 180 | if ((I915_READ_CTL(ring) & RING_VALID) == 0 || |
181 | I915_READ_START(ring) != obj_priv->gtt_offset || | 181 | I915_READ_START(ring) != obj_priv->gtt_offset || |
182 | (I915_READ_HEAD(ring) & HEAD_ADDR) != 0) { | 182 | (I915_READ_HEAD(ring) & HEAD_ADDR) != 0) { |
183 | if (IS_GEN6(ring->dev) && ring->dev->pdev->revision <= 8) { | 183 | DRM_ERROR("%s initialization failed " |
184 | /* Early revisions of Sandybridge do not like | 184 | "ctl %08x head %08x tail %08x start %08x\n", |
185 | * revealing the contents of the ring buffer | 185 | ring->name, |
186 | * registers whilst idle. Fortunately, the | 186 | I915_READ_CTL(ring), |
187 | * auto-reporting mechanism prevents most hangs, | 187 | I915_READ_HEAD(ring), |
188 | * but this will bite us eventually... | 188 | I915_READ_TAIL(ring), |
189 | */ | 189 | I915_READ_START(ring)); |
190 | DRM_DEBUG("%s initialization failed " | 190 | return -EIO; |
191 | "ctl %08x head %08x tail %08x start %08x. Ignoring, hope for the best!\n", | ||
192 | ring->name, | ||
193 | I915_READ_CTL(ring), | ||
194 | I915_READ_HEAD(ring), | ||
195 | I915_READ_TAIL(ring), | ||
196 | I915_READ_START(ring)); | ||
197 | } else { | ||
198 | DRM_ERROR("%s initialization failed " | ||
199 | "ctl %08x head %08x tail %08x start %08x\n", | ||
200 | ring->name, | ||
201 | I915_READ_CTL(ring), | ||
202 | I915_READ_HEAD(ring), | ||
203 | I915_READ_TAIL(ring), | ||
204 | I915_READ_START(ring)); | ||
205 | return -EIO; | ||
206 | } | ||
207 | } | 191 | } |
208 | 192 | ||
209 | if (!drm_core_check_feature(ring->dev, DRIVER_MODESET)) | 193 | if (!drm_core_check_feature(ring->dev, DRIVER_MODESET)) |