drm/i915: Return the real error code from intel_set_mode()

Note: This patch also adds a little helper intel_crtc_restore_mode for
the common case where we do a full modeset but with the same
parameters, e.g. to undo bios damage or update a property.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
[danvet: Added note.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

1 files changed, 2 insertions, 5 deletions

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 2d3b26832397..1dd89d5fe511 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -2483,11 +2483,8 @@ intel_dp_set_property(struct drm_connector *connector,
         return -EINVAL;
 
 done:
-        if (intel_encoder->base.crtc) {
-                struct drm_crtc *crtc = intel_encoder->base.crtc;
-                intel_set_mode(crtc, &crtc->mode,
-                               crtc->x, crtc->y, crtc->fb);
-        }
+        if (intel_encoder->base.crtc)
+                intel_crtc_restore_mode(intel_encoder->base.crtc);
 
         return 0;
 }