diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-09-30 04:56:39 -0400 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-10-01 04:52:59 -0400 |
commit | f458ebbc3329a6f064e0f40ed5909fe3a7133238 (patch) | |
tree | ad0045e378d96efca269980d45c723dc8125297e /drivers/gpu/drm/i915/i915_dma.c | |
parent | 9c065a7d5b679e7fabe3cace4faadb283f2b0c1f (diff) |
drm/i915: Bikeshed rpm functions name a bit.
- fini goes with init, so call it intel_power_domains_fini. While
at it shovel some of the fini code that leaked out of it back in.
- give power_enabled functions the verb _is_ to make the meaning clearer.
Also use a __ prefix instead of _unlocked to really discourage users.
- rename runtime_pm_init/fini to enable/disable since that's what they do.
Reviewed-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915/i915_dma.c')
-rw-r--r-- | drivers/gpu/drm/i915/i915_dma.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index 1c035c49577e..261fc0b60f25 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c | |||
@@ -1798,12 +1798,12 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags) | |||
1798 | if (IS_GEN5(dev)) | 1798 | if (IS_GEN5(dev)) |
1799 | intel_gpu_ips_init(dev_priv); | 1799 | intel_gpu_ips_init(dev_priv); |
1800 | 1800 | ||
1801 | intel_init_runtime_pm(dev_priv); | 1801 | intel_runtime_pm_enable(dev_priv); |
1802 | 1802 | ||
1803 | return 0; | 1803 | return 0; |
1804 | 1804 | ||
1805 | out_power_well: | 1805 | out_power_well: |
1806 | intel_power_domains_remove(dev_priv); | 1806 | intel_power_domains_fini(dev_priv); |
1807 | drm_vblank_cleanup(dev); | 1807 | drm_vblank_cleanup(dev); |
1808 | out_gem_unload: | 1808 | out_gem_unload: |
1809 | WARN_ON(unregister_oom_notifier(&dev_priv->mm.oom_notifier)); | 1809 | WARN_ON(unregister_oom_notifier(&dev_priv->mm.oom_notifier)); |
@@ -1846,15 +1846,11 @@ int i915_driver_unload(struct drm_device *dev) | |||
1846 | return ret; | 1846 | return ret; |
1847 | } | 1847 | } |
1848 | 1848 | ||
1849 | intel_fini_runtime_pm(dev_priv); | 1849 | intel_runtime_pm_disable(dev_priv); |
1850 | 1850 | ||
1851 | intel_gpu_ips_teardown(); | 1851 | intel_gpu_ips_teardown(); |
1852 | 1852 | ||
1853 | /* The i915.ko module is still not prepared to be loaded when | 1853 | intel_power_domains_fini(dev_priv); |
1854 | * the power well is not enabled, so just enable it in case | ||
1855 | * we're going to unload/reload. */ | ||
1856 | intel_display_set_init_power(dev_priv, true); | ||
1857 | intel_power_domains_remove(dev_priv); | ||
1858 | 1854 | ||
1859 | i915_teardown_sysfs(dev); | 1855 | i915_teardown_sysfs(dev); |
1860 | 1856 | ||