diff options
author | Andrzej Hajda <a.hajda@samsung.com> | 2014-07-03 09:10:31 -0400 |
---|---|---|
committer | Inki Dae <daeinki@gmail.com> | 2014-08-03 03:52:18 -0400 |
commit | 187d5edf1eaa8f6dc29f8a39fc10225d74a80d16 (patch) | |
tree | 7b500d45b0349f455575a05205a53fc2ab7322e6 /drivers/gpu/drm/exynos | |
parent | 73b00232acb98aff95558c9395df4d2c70356a92 (diff) |
drm/exynos/ipp: remove incorrect checks of list_first_entry result
list_first_entry does not return NULL on empty list so this check
does not make sense. Moreover there is already code which prevents calling
list_first_entry on empty lists.
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Diffstat (limited to 'drivers/gpu/drm/exynos')
-rw-r--r-- | drivers/gpu/drm/exynos/exynos_drm_ipp.c | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm/exynos/exynos_drm_ipp.c index f84ef8a90592..89ff7e34a6fb 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_ipp.c +++ b/drivers/gpu/drm/exynos/exynos_drm_ipp.c | |||
@@ -1277,11 +1277,6 @@ static int ipp_start_property(struct exynos_drm_ippdrv *ippdrv, | |||
1277 | 1277 | ||
1278 | m_node = list_first_entry(head, | 1278 | m_node = list_first_entry(head, |
1279 | struct drm_exynos_ipp_mem_node, list); | 1279 | struct drm_exynos_ipp_mem_node, list); |
1280 | if (!m_node) { | ||
1281 | DRM_ERROR("failed to get node.\n"); | ||
1282 | ret = -EFAULT; | ||
1283 | goto err_unlock; | ||
1284 | } | ||
1285 | 1280 | ||
1286 | DRM_DEBUG_KMS("m_node[0x%x]\n", (int)m_node); | 1281 | DRM_DEBUG_KMS("m_node[0x%x]\n", (int)m_node); |
1287 | 1282 | ||
@@ -1539,11 +1534,6 @@ static int ipp_send_event(struct exynos_drm_ippdrv *ippdrv, | |||
1539 | 1534 | ||
1540 | m_node = list_first_entry(head, | 1535 | m_node = list_first_entry(head, |
1541 | struct drm_exynos_ipp_mem_node, list); | 1536 | struct drm_exynos_ipp_mem_node, list); |
1542 | if (!m_node) { | ||
1543 | DRM_ERROR("empty memory node.\n"); | ||
1544 | ret = -ENOMEM; | ||
1545 | goto err_mem_unlock; | ||
1546 | } | ||
1547 | 1537 | ||
1548 | tbuf_id[i] = m_node->buf_id; | 1538 | tbuf_id[i] = m_node->buf_id; |
1549 | DRM_DEBUG_KMS("%s buf_id[%d]\n", | 1539 | DRM_DEBUG_KMS("%s buf_id[%d]\n", |
@@ -1580,11 +1570,6 @@ static int ipp_send_event(struct exynos_drm_ippdrv *ippdrv, | |||
1580 | 1570 | ||
1581 | m_node = list_first_entry(head, | 1571 | m_node = list_first_entry(head, |
1582 | struct drm_exynos_ipp_mem_node, list); | 1572 | struct drm_exynos_ipp_mem_node, list); |
1583 | if (!m_node) { | ||
1584 | DRM_ERROR("empty memory node.\n"); | ||
1585 | ret = -ENOMEM; | ||
1586 | goto err_mem_unlock; | ||
1587 | } | ||
1588 | 1573 | ||
1589 | tbuf_id[EXYNOS_DRM_OPS_SRC] = m_node->buf_id; | 1574 | tbuf_id[EXYNOS_DRM_OPS_SRC] = m_node->buf_id; |
1590 | 1575 | ||