diff options
author | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2013-06-07 11:43:07 -0400 |
---|---|---|
committer | Dave Airlie <airlied@redhat.com> | 2013-06-10 18:13:56 -0400 |
commit | d20d3174806ef6589cb912a488657d21fcd7ece2 (patch) | |
tree | 61b40825fc9a2eacd6e2fe94ff4b3c3cc509d077 /drivers/gpu/drm/drm_crtc.c | |
parent | 4ee62c7669be1a6f1dd407e5ba7e38c0e2204e92 (diff) |
drm: Constify the pretty-print functions
The structures and strings involved with various pretty-print functions
aren't meant to be modified, so make them all const. The exception is
drm_connector_enum_list which does get modified in drm_connector_init().
While at it move the drm_get_connector_status_name() prototype from
drmP.h to drm_crtc.h where it belongs.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/drm_crtc.c')
-rw-r--r-- | drivers/gpu/drm/drm_crtc.c | 30 |
1 files changed, 15 insertions, 15 deletions
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 079996ad02a7..44c3421899bb 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c | |||
@@ -92,7 +92,7 @@ EXPORT_SYMBOL(drm_warn_on_modeset_not_all_locked); | |||
92 | 92 | ||
93 | /* Avoid boilerplate. I'm tired of typing. */ | 93 | /* Avoid boilerplate. I'm tired of typing. */ |
94 | #define DRM_ENUM_NAME_FN(fnname, list) \ | 94 | #define DRM_ENUM_NAME_FN(fnname, list) \ |
95 | char *fnname(int val) \ | 95 | const char *fnname(int val) \ |
96 | { \ | 96 | { \ |
97 | int i; \ | 97 | int i; \ |
98 | for (i = 0; i < ARRAY_SIZE(list); i++) { \ | 98 | for (i = 0; i < ARRAY_SIZE(list); i++) { \ |
@@ -105,7 +105,7 @@ EXPORT_SYMBOL(drm_warn_on_modeset_not_all_locked); | |||
105 | /* | 105 | /* |
106 | * Global properties | 106 | * Global properties |
107 | */ | 107 | */ |
108 | static struct drm_prop_enum_list drm_dpms_enum_list[] = | 108 | static const struct drm_prop_enum_list drm_dpms_enum_list[] = |
109 | { { DRM_MODE_DPMS_ON, "On" }, | 109 | { { DRM_MODE_DPMS_ON, "On" }, |
110 | { DRM_MODE_DPMS_STANDBY, "Standby" }, | 110 | { DRM_MODE_DPMS_STANDBY, "Standby" }, |
111 | { DRM_MODE_DPMS_SUSPEND, "Suspend" }, | 111 | { DRM_MODE_DPMS_SUSPEND, "Suspend" }, |
@@ -117,7 +117,7 @@ DRM_ENUM_NAME_FN(drm_get_dpms_name, drm_dpms_enum_list) | |||
117 | /* | 117 | /* |
118 | * Optional properties | 118 | * Optional properties |
119 | */ | 119 | */ |
120 | static struct drm_prop_enum_list drm_scaling_mode_enum_list[] = | 120 | static const struct drm_prop_enum_list drm_scaling_mode_enum_list[] = |
121 | { | 121 | { |
122 | { DRM_MODE_SCALE_NONE, "None" }, | 122 | { DRM_MODE_SCALE_NONE, "None" }, |
123 | { DRM_MODE_SCALE_FULLSCREEN, "Full" }, | 123 | { DRM_MODE_SCALE_FULLSCREEN, "Full" }, |
@@ -125,7 +125,7 @@ static struct drm_prop_enum_list drm_scaling_mode_enum_list[] = | |||
125 | { DRM_MODE_SCALE_ASPECT, "Full aspect" }, | 125 | { DRM_MODE_SCALE_ASPECT, "Full aspect" }, |
126 | }; | 126 | }; |
127 | 127 | ||
128 | static struct drm_prop_enum_list drm_dithering_mode_enum_list[] = | 128 | static const struct drm_prop_enum_list drm_dithering_mode_enum_list[] = |
129 | { | 129 | { |
130 | { DRM_MODE_DITHERING_OFF, "Off" }, | 130 | { DRM_MODE_DITHERING_OFF, "Off" }, |
131 | { DRM_MODE_DITHERING_ON, "On" }, | 131 | { DRM_MODE_DITHERING_ON, "On" }, |
@@ -135,7 +135,7 @@ static struct drm_prop_enum_list drm_dithering_mode_enum_list[] = | |||
135 | /* | 135 | /* |
136 | * Non-global properties, but "required" for certain connectors. | 136 | * Non-global properties, but "required" for certain connectors. |
137 | */ | 137 | */ |
138 | static struct drm_prop_enum_list drm_dvi_i_select_enum_list[] = | 138 | static const struct drm_prop_enum_list drm_dvi_i_select_enum_list[] = |
139 | { | 139 | { |
140 | { DRM_MODE_SUBCONNECTOR_Automatic, "Automatic" }, /* DVI-I and TV-out */ | 140 | { DRM_MODE_SUBCONNECTOR_Automatic, "Automatic" }, /* DVI-I and TV-out */ |
141 | { DRM_MODE_SUBCONNECTOR_DVID, "DVI-D" }, /* DVI-I */ | 141 | { DRM_MODE_SUBCONNECTOR_DVID, "DVI-D" }, /* DVI-I */ |
@@ -144,7 +144,7 @@ static struct drm_prop_enum_list drm_dvi_i_select_enum_list[] = | |||
144 | 144 | ||
145 | DRM_ENUM_NAME_FN(drm_get_dvi_i_select_name, drm_dvi_i_select_enum_list) | 145 | DRM_ENUM_NAME_FN(drm_get_dvi_i_select_name, drm_dvi_i_select_enum_list) |
146 | 146 | ||
147 | static struct drm_prop_enum_list drm_dvi_i_subconnector_enum_list[] = | 147 | static const struct drm_prop_enum_list drm_dvi_i_subconnector_enum_list[] = |
148 | { | 148 | { |
149 | { DRM_MODE_SUBCONNECTOR_Unknown, "Unknown" }, /* DVI-I and TV-out */ | 149 | { DRM_MODE_SUBCONNECTOR_Unknown, "Unknown" }, /* DVI-I and TV-out */ |
150 | { DRM_MODE_SUBCONNECTOR_DVID, "DVI-D" }, /* DVI-I */ | 150 | { DRM_MODE_SUBCONNECTOR_DVID, "DVI-D" }, /* DVI-I */ |
@@ -154,7 +154,7 @@ static struct drm_prop_enum_list drm_dvi_i_subconnector_enum_list[] = | |||
154 | DRM_ENUM_NAME_FN(drm_get_dvi_i_subconnector_name, | 154 | DRM_ENUM_NAME_FN(drm_get_dvi_i_subconnector_name, |
155 | drm_dvi_i_subconnector_enum_list) | 155 | drm_dvi_i_subconnector_enum_list) |
156 | 156 | ||
157 | static struct drm_prop_enum_list drm_tv_select_enum_list[] = | 157 | static const struct drm_prop_enum_list drm_tv_select_enum_list[] = |
158 | { | 158 | { |
159 | { DRM_MODE_SUBCONNECTOR_Automatic, "Automatic" }, /* DVI-I and TV-out */ | 159 | { DRM_MODE_SUBCONNECTOR_Automatic, "Automatic" }, /* DVI-I and TV-out */ |
160 | { DRM_MODE_SUBCONNECTOR_Composite, "Composite" }, /* TV-out */ | 160 | { DRM_MODE_SUBCONNECTOR_Composite, "Composite" }, /* TV-out */ |
@@ -165,7 +165,7 @@ static struct drm_prop_enum_list drm_tv_select_enum_list[] = | |||
165 | 165 | ||
166 | DRM_ENUM_NAME_FN(drm_get_tv_select_name, drm_tv_select_enum_list) | 166 | DRM_ENUM_NAME_FN(drm_get_tv_select_name, drm_tv_select_enum_list) |
167 | 167 | ||
168 | static struct drm_prop_enum_list drm_tv_subconnector_enum_list[] = | 168 | static const struct drm_prop_enum_list drm_tv_subconnector_enum_list[] = |
169 | { | 169 | { |
170 | { DRM_MODE_SUBCONNECTOR_Unknown, "Unknown" }, /* DVI-I and TV-out */ | 170 | { DRM_MODE_SUBCONNECTOR_Unknown, "Unknown" }, /* DVI-I and TV-out */ |
171 | { DRM_MODE_SUBCONNECTOR_Composite, "Composite" }, /* TV-out */ | 171 | { DRM_MODE_SUBCONNECTOR_Composite, "Composite" }, /* TV-out */ |
@@ -177,7 +177,7 @@ static struct drm_prop_enum_list drm_tv_subconnector_enum_list[] = | |||
177 | DRM_ENUM_NAME_FN(drm_get_tv_subconnector_name, | 177 | DRM_ENUM_NAME_FN(drm_get_tv_subconnector_name, |
178 | drm_tv_subconnector_enum_list) | 178 | drm_tv_subconnector_enum_list) |
179 | 179 | ||
180 | static struct drm_prop_enum_list drm_dirty_info_enum_list[] = { | 180 | static const struct drm_prop_enum_list drm_dirty_info_enum_list[] = { |
181 | { DRM_MODE_DIRTY_OFF, "Off" }, | 181 | { DRM_MODE_DIRTY_OFF, "Off" }, |
182 | { DRM_MODE_DIRTY_ON, "On" }, | 182 | { DRM_MODE_DIRTY_ON, "On" }, |
183 | { DRM_MODE_DIRTY_ANNOTATE, "Annotate" }, | 183 | { DRM_MODE_DIRTY_ANNOTATE, "Annotate" }, |
@@ -185,7 +185,7 @@ static struct drm_prop_enum_list drm_dirty_info_enum_list[] = { | |||
185 | 185 | ||
186 | struct drm_conn_prop_enum_list { | 186 | struct drm_conn_prop_enum_list { |
187 | int type; | 187 | int type; |
188 | char *name; | 188 | const char *name; |
189 | int count; | 189 | int count; |
190 | }; | 190 | }; |
191 | 191 | ||
@@ -211,7 +211,7 @@ static struct drm_conn_prop_enum_list drm_connector_enum_list[] = | |||
211 | { DRM_MODE_CONNECTOR_VIRTUAL, "Virtual", 0}, | 211 | { DRM_MODE_CONNECTOR_VIRTUAL, "Virtual", 0}, |
212 | }; | 212 | }; |
213 | 213 | ||
214 | static struct drm_prop_enum_list drm_encoder_enum_list[] = | 214 | static const struct drm_prop_enum_list drm_encoder_enum_list[] = |
215 | { { DRM_MODE_ENCODER_NONE, "None" }, | 215 | { { DRM_MODE_ENCODER_NONE, "None" }, |
216 | { DRM_MODE_ENCODER_DAC, "DAC" }, | 216 | { DRM_MODE_ENCODER_DAC, "DAC" }, |
217 | { DRM_MODE_ENCODER_TMDS, "TMDS" }, | 217 | { DRM_MODE_ENCODER_TMDS, "TMDS" }, |
@@ -220,7 +220,7 @@ static struct drm_prop_enum_list drm_encoder_enum_list[] = | |||
220 | { DRM_MODE_ENCODER_VIRTUAL, "Virtual" }, | 220 | { DRM_MODE_ENCODER_VIRTUAL, "Virtual" }, |
221 | }; | 221 | }; |
222 | 222 | ||
223 | char *drm_get_encoder_name(struct drm_encoder *encoder) | 223 | const char *drm_get_encoder_name(const struct drm_encoder *encoder) |
224 | { | 224 | { |
225 | static char buf[32]; | 225 | static char buf[32]; |
226 | 226 | ||
@@ -231,7 +231,7 @@ char *drm_get_encoder_name(struct drm_encoder *encoder) | |||
231 | } | 231 | } |
232 | EXPORT_SYMBOL(drm_get_encoder_name); | 232 | EXPORT_SYMBOL(drm_get_encoder_name); |
233 | 233 | ||
234 | char *drm_get_connector_name(struct drm_connector *connector) | 234 | const char *drm_get_connector_name(const struct drm_connector *connector) |
235 | { | 235 | { |
236 | static char buf[32]; | 236 | static char buf[32]; |
237 | 237 | ||
@@ -242,7 +242,7 @@ char *drm_get_connector_name(struct drm_connector *connector) | |||
242 | } | 242 | } |
243 | EXPORT_SYMBOL(drm_get_connector_name); | 243 | EXPORT_SYMBOL(drm_get_connector_name); |
244 | 244 | ||
245 | char *drm_get_connector_status_name(enum drm_connector_status status) | 245 | const char *drm_get_connector_status_name(enum drm_connector_status status) |
246 | { | 246 | { |
247 | if (status == connector_status_connected) | 247 | if (status == connector_status_connected) |
248 | return "connected"; | 248 | return "connected"; |
@@ -258,7 +258,7 @@ static char printable_char(int c) | |||
258 | return isascii(c) && isprint(c) ? c : '?'; | 258 | return isascii(c) && isprint(c) ? c : '?'; |
259 | } | 259 | } |
260 | 260 | ||
261 | char *drm_get_format_name(uint32_t format) | 261 | const char *drm_get_format_name(uint32_t format) |
262 | { | 262 | { |
263 | static char buf[32]; | 263 | static char buf[32]; |
264 | 264 | ||