Merge branch 'for-linus-dma-masks' of git://git.linaro.org/people/rmk/linux-arm

Pull DMA mask updates from Russell King:
 "This series cleans up the handling of DMA masks in a lot of drivers,
  fixing some bugs as we go.

  Some of the more serious errors include:
   - drivers which only set their coherent DMA mask if the attempt to
     set the streaming mask fails.
   - drivers which test for a NULL dma mask pointer, and then set the
     dma mask pointer to a location in their module .data section -
     which will cause problems if the module is reloaded.

  To counter these, I have introduced two helper functions:
   - dma_set_mask_and_coherent() takes care of setting both the
     streaming and coherent masks at the same time, with the correct
     error handling as specified by the API.
   - dma_coerce_mask_and_coherent() which resolves the problem of
     drivers forcefully setting DMA masks.  This is more a marker for
     future work to further clean these locations up - the code which
     creates the devices really should be initialising these, but to fix
     that in one go along with this change could potentially be very
     disruptive.

  The last thing this series does is prise away some of Linux's addition
  to "DMA addresses are physical addresses and RAM always starts at
  zero".  We have ARM LPAE systems where all system memory is above 4GB
  physical, hence having DMA masks interpreted by (eg) the block layers
  as describing physical addresses in the range 0..DMAMASK fails on
  these platforms.  Santosh Shilimkar addresses this in this series; the
  patches were copied to the appropriate people multiple times but were
  ignored.

  Fixing this also gets rid of some ARM weirdness in the setup of the
  max*pfn variables, and brings ARM into line with every other Linux
  architecture as far as those go"

* 'for-linus-dma-masks' of git://git.linaro.org/people/rmk/linux-arm: (52 commits)
  ARM: 7805/1: mm: change max*pfn to include the physical offset of memory
  ARM: 7797/1: mmc: Use dma_max_pfn(dev) helper for bounce_limit calculations
  ARM: 7796/1: scsi: Use dma_max_pfn(dev) helper for bounce_limit calculations
  ARM: 7795/1: mm: dma-mapping: Add dma_max_pfn(dev) helper function
  ARM: 7794/1: block: Rename parameter dma_mask to max_addr for blk_queue_bounce_limit()
  ARM: DMA-API: better handing of DMA masks for coherent allocations
  ARM: 7857/1: dma: imx-sdma: setup dma mask
  DMA-API: firmware/google/gsmi.c: avoid direct access to DMA masks
  DMA-API: dcdbas: update DMA mask handing
  DMA-API: dma: edma.c: no need to explicitly initialize DMA masks
  DMA-API: usb: musb: use platform_device_register_full() to avoid directly messing with dma masks
  DMA-API: crypto: remove last references to 'static struct device *dev'
  DMA-API: crypto: fix ixp4xx crypto platform device support
  DMA-API: others: use dma_set_coherent_mask()
  DMA-API: staging: use dma_set_coherent_mask()
  DMA-API: usb: use new dma_coerce_mask_and_coherent()
  DMA-API: usb: use dma_set_coherent_mask()
  DMA-API: parport: parport_pc.c: use dma_coerce_mask_and_coherent()
  DMA-API: net: octeon: use dma_coerce_mask_and_coherent()
  DMA-API: net: nxp/lpc_eth: use dma_coerce_mask_and_coherent()
  ...

2 files changed, 27 insertions, 18 deletions

diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c
index ff080ee20197..1b5e8e46226d 100644
--- a/drivers/firmware/dcdbas.c
+++ b/drivers/firmware/dcdbas.c
@@ -545,12 +545,15 @@ static int dcdbas_probe(struct platform_device *dev)
         host_control_action = HC_ACTION_NONE;
         host_control_smi_type = HC_SMITYPE_NONE;
 
+        dcdbas_pdev = dev;
+
         /*
          * BIOS SMI calls require buffer addresses be in 32-bit address space.
          * This is done by setting the DMA mask below.
          */
-        dcdbas_pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
-        dcdbas_pdev->dev.dma_mask = &dcdbas_pdev->dev.coherent_dma_mask;
+        error = dma_set_coherent_mask(&dcdbas_pdev->dev, DMA_BIT_MASK(32));
+        if (error)
+                return error;
 
         error = sysfs_create_group(&dev->dev.kobj, &dcdbas_attr_group);
         if (error)
@@ -581,6 +584,14 @@ static struct platform_driver dcdbas_driver = {
         .remove         = dcdbas_remove,
 };
 
+static const struct platform_device_info dcdbas_dev_info __initdata = {
+        .name           = DRIVER_NAME,
+        .id             = -1,
+        .dma_mask       = DMA_BIT_MASK(32),
+};
+
+static struct platform_device *dcdbas_pdev_reg;
+
 /**
  * dcdbas_init: initialize driver
  */
@@ -592,20 +603,14 @@ static int __init dcdbas_init(void)
         if (error)
                 return error;
 
-        dcdbas_pdev = platform_device_alloc(DRIVER_NAME, -1);
-        if (!dcdbas_pdev) {
-                error = -ENOMEM;
+        dcdbas_pdev_reg = platform_device_register_full(&dcdbas_dev_info);
+        if (IS_ERR(dcdbas_pdev_reg)) {
+                error = PTR_ERR(dcdbas_pdev_reg);
                 goto err_unregister_driver;
         }
 
-        error = platform_device_add(dcdbas_pdev);
-        if (error)
-                goto err_free_device;
-
         return 0;
 
- err_free_device:
-        platform_device_put(dcdbas_pdev);
  err_unregister_driver:
         platform_driver_unregister(&dcdbas_driver);
         return error;
@@ -628,8 +633,9 @@ static void __exit dcdbas_exit(void)
          * all sysfs attributes belonging to this module have been
          * released.
          */
-        smi_data_buf_free();
-        platform_device_unregister(dcdbas_pdev);
+        if (dcdbas_pdev)
+                smi_data_buf_free();
+        platform_device_unregister(dcdbas_pdev_reg);
         platform_driver_unregister(&dcdbas_driver);
 }
 
diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c
index 6eb535ffeddc..e5a67b24587a 100644
--- a/drivers/firmware/google/gsmi.c
+++ b/drivers/firmware/google/gsmi.c
@@ -764,6 +764,13 @@ static __init int gsmi_system_valid(void)
 static struct kobject *gsmi_kobj;
 static struct efivars efivars;
 
+static const struct platform_device_info gsmi_dev_info = {
+        .name           = "gsmi",
+        .id             = -1,
+        /* SMI callbacks require 32bit addresses */
+        .dma_mask       = DMA_BIT_MASK(32),
+};
+
 static __init int gsmi_init(void)
 {
         unsigned long flags;
@@ -776,7 +783,7 @@ static __init int gsmi_init(void)
         gsmi_dev.smi_cmd = acpi_gbl_FADT.smi_command;
 
         /* register device */
-        gsmi_dev.pdev = platform_device_register_simple("gsmi", -1, NULL, 0);
+        gsmi_dev.pdev = platform_device_register_full(&gsmi_dev_info);
         if (IS_ERR(gsmi_dev.pdev)) {
                 printk(KERN_ERR "gsmi: unable to register platform device\n");
                 return PTR_ERR(gsmi_dev.pdev);
@@ -785,10 +792,6 @@ static __init int gsmi_init(void)
         /* SMI access needs to be serialized */
         spin_lock_init(&gsmi_dev.lock);
 
-        /* SMI callbacks require 32bit addresses */
-        gsmi_dev.pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
-        gsmi_dev.pdev->dev.dma_mask =
-                &gsmi_dev.pdev->dev.coherent_dma_mask;
         ret = -ENOMEM;
         gsmi_dev.dma_pool = dma_pool_create("gsmi", &gsmi_dev.pdev->dev,
                                              GSMI_BUF_SIZE, GSMI_BUF_ALIGN, 0);