[PATCH] sysfs: (rest) if show/store is missing return -EIO

sysfs: fix the rest of the kernel so if an attribute doesn't
       implement show or store method read/write will return
       -EIO instead of 0 or -EINVAL or -EPERM.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

2 files changed, 3 insertions, 3 deletions

diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c
index 33b669e6f977..6996476669f1 100644
--- a/drivers/firmware/edd.c
+++ b/drivers/firmware/edd.c
@@ -115,7 +115,7 @@ edd_attr_show(struct kobject * kobj, struct attribute *attr, char *buf)
 {
         struct edd_device *dev = to_edd_device(kobj);
         struct edd_attribute *edd_attr = to_edd_attr(attr);
-        ssize_t ret = 0;
+        ssize_t ret = -EIO;
 
         if (edd_attr->show)
                 ret = edd_attr->show(dev, buf);
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index 0287ff65963b..a3451cb94004 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers/firmware/efivars.c
@@ -352,7 +352,7 @@ static ssize_t efivar_attr_show(struct kobject *kobj, struct attribute *attr,
 {
         struct efivar_entry *var = to_efivar_entry(kobj);
         struct efivar_attribute *efivar_attr = to_efivar_attr(attr);
-        ssize_t ret = 0;
+        ssize_t ret = -EIO;
 
         if (!capable(CAP_SYS_ADMIN))
                 return -EACCES;
@@ -368,7 +368,7 @@ static ssize_t efivar_attr_store(struct kobject *kobj, struct attribute *attr,
 {
         struct efivar_entry *var = to_efivar_entry(kobj);
         struct efivar_attribute *efivar_attr = to_efivar_attr(attr);
-        ssize_t ret = 0;
+        ssize_t ret = -EIO;
 
         if (!capable(CAP_SYS_ADMIN))
                 return -EACCES;