aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/firewire
diff options
context:
space:
mode:
authorStefan Richter <stefanr@s5r6.in-berlin.de>2010-06-20 16:50:35 -0400
committerStefan Richter <stefanr@s5r6.in-berlin.de>2010-06-20 17:11:55 -0400
commit33e553fe2b4a983ef34a57ab1440d8d33397bb12 (patch)
tree3a7098a935f0b678a6e6a565619d0d990f9122f3 /drivers/firewire
parent56d04cb189f955e5167c27944d61aa57ad69b598 (diff)
firewire: remove an unused function argument
void (*fw_address_callback_t)(..., int speed, ...) is the speed that a remote node chose to transmit a request to us. In case of split transactions, firewire-core will transmit the response at that speed. Upper layer drivers on the other hand (firewire-net, -sbp2, firedtv, and userspace drivers) cannot do anything useful with that speed datum, except log it for debug purposes. But data that is merely potentially (not even actually) used for debug purposes does not belong into the API. Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/firewire')
-rw-r--r--drivers/firewire/core-cdev.c3
-rw-r--r--drivers/firewire/core-transaction.c14
-rw-r--r--drivers/firewire/net.c4
-rw-r--r--drivers/firewire/sbp2.c3
4 files changed, 11 insertions, 13 deletions
diff --git a/drivers/firewire/core-cdev.c b/drivers/firewire/core-cdev.c
index ca72cdaa68c9..4e0478d70d4d 100644
--- a/drivers/firewire/core-cdev.c
+++ b/drivers/firewire/core-cdev.c
@@ -632,8 +632,7 @@ static void release_request(struct client *client,
632 632
633static void handle_request(struct fw_card *card, struct fw_request *request, 633static void handle_request(struct fw_card *card, struct fw_request *request,
634 int tcode, int destination, int source, 634 int tcode, int destination, int source,
635 int generation, int speed, 635 int generation, unsigned long long offset,
636 unsigned long long offset,
637 void *payload, size_t length, void *callback_data) 636 void *payload, size_t length, void *callback_data)
638{ 637{
639 struct address_handler_resource *handler = callback_data; 638 struct address_handler_resource *handler = callback_data;
diff --git a/drivers/firewire/core-transaction.c b/drivers/firewire/core-transaction.c
index cb6390fe3686..2f67c8d5ce91 100644
--- a/drivers/firewire/core-transaction.c
+++ b/drivers/firewire/core-transaction.c
@@ -802,7 +802,7 @@ static void handle_exclusive_region_request(struct fw_card *card,
802 else 802 else
803 handler->address_callback(card, request, 803 handler->address_callback(card, request,
804 tcode, destination, source, 804 tcode, destination, source,
805 p->generation, p->speed, offset, 805 p->generation, offset,
806 request->data, request->length, 806 request->data, request->length,
807 handler->callback_data); 807 handler->callback_data);
808} 808}
@@ -840,8 +840,8 @@ static void handle_fcp_region_request(struct fw_card *card,
840 if (is_enclosing_handler(handler, offset, request->length)) 840 if (is_enclosing_handler(handler, offset, request->length))
841 handler->address_callback(card, NULL, tcode, 841 handler->address_callback(card, NULL, tcode,
842 destination, source, 842 destination, source,
843 p->generation, p->speed, 843 p->generation, offset,
844 offset, request->data, 844 request->data,
845 request->length, 845 request->length,
846 handler->callback_data); 846 handler->callback_data);
847 } 847 }
@@ -951,8 +951,8 @@ static const struct fw_address_region topology_map_region =
951 951
952static void handle_topology_map(struct fw_card *card, struct fw_request *request, 952static void handle_topology_map(struct fw_card *card, struct fw_request *request,
953 int tcode, int destination, int source, int generation, 953 int tcode, int destination, int source, int generation,
954 int speed, unsigned long long offset, 954 unsigned long long offset, void *payload, size_t length,
955 void *payload, size_t length, void *callback_data) 955 void *callback_data)
956{ 956{
957 int start; 957 int start;
958 958
@@ -996,8 +996,8 @@ static void update_split_timeout(struct fw_card *card)
996 996
997static void handle_registers(struct fw_card *card, struct fw_request *request, 997static void handle_registers(struct fw_card *card, struct fw_request *request,
998 int tcode, int destination, int source, int generation, 998 int tcode, int destination, int source, int generation,
999 int speed, unsigned long long offset, 999 unsigned long long offset, void *payload, size_t length,
1000 void *payload, size_t length, void *callback_data) 1000 void *callback_data)
1001{ 1001{
1002 int reg = offset & ~CSR_REGISTER_BASE; 1002 int reg = offset & ~CSR_REGISTER_BASE;
1003 __be32 *data = payload; 1003 __be32 *data = payload;
diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
index 2d3dc7ded0a9..4bb3fb882f63 100644
--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
@@ -805,8 +805,8 @@ static int fwnet_incoming_packet(struct fwnet_device *dev, __be32 *buf, int len,
805 805
806static void fwnet_receive_packet(struct fw_card *card, struct fw_request *r, 806static void fwnet_receive_packet(struct fw_card *card, struct fw_request *r,
807 int tcode, int destination, int source, int generation, 807 int tcode, int destination, int source, int generation,
808 int speed, unsigned long long offset, void *payload, 808 unsigned long long offset, void *payload, size_t length,
809 size_t length, void *callback_data) 809 void *callback_data)
810{ 810{
811 struct fwnet_device *dev = callback_data; 811 struct fwnet_device *dev = callback_data;
812 int rcode; 812 int rcode;
diff --git a/drivers/firewire/sbp2.c b/drivers/firewire/sbp2.c
index ae715c82da2e..1931964c4fbf 100644
--- a/drivers/firewire/sbp2.c
+++ b/drivers/firewire/sbp2.c
@@ -410,8 +410,7 @@ static void free_orb(struct kref *kref)
410 410
411static void sbp2_status_write(struct fw_card *card, struct fw_request *request, 411static void sbp2_status_write(struct fw_card *card, struct fw_request *request,
412 int tcode, int destination, int source, 412 int tcode, int destination, int source,
413 int generation, int speed, 413 int generation, unsigned long long offset,
414 unsigned long long offset,
415 void *payload, size_t length, void *callback_data) 414 void *payload, size_t length, void *callback_data)
416{ 415{
417 struct sbp2_logical_unit *lu = callback_data; 416 struct sbp2_logical_unit *lu = callback_data;