diff options
author | Ben Hutchings <bhutchings@solarflare.com> | 2010-08-17 05:31:15 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-08-17 05:31:15 -0400 |
commit | 01414802054c382072b6cb9a1bdc6e243c74b2d5 (patch) | |
tree | f09b05eb9fff16a69d83ec28653992d1bae8d74c /drivers/firewire | |
parent | bb8a10bbd10a45db0eb45bac520489bdbc0917ef (diff) |
ethtool: Provide a default implementation of ethtool_ops::get_drvinfo
The driver name and bus address for a net_device can normally be found
through the driver model now. Instead of requiring drivers to provide
this information redundantly through the ethtool_ops::get_drvinfo
operation, use the driver model to do so if the driver does not define
the operation. Since ETHTOOL_GDRVINFO no longer requires the driver
to implement any operations, do not require net_device::ethtool_ops to
be set either.
Remove implementations of get_drvinfo and ethtool_ops that provide
only this information.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/firewire')
-rw-r--r-- | drivers/firewire/net.c | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c index da17d409a244..51e8a35ebd7e 100644 --- a/drivers/firewire/net.c +++ b/drivers/firewire/net.c | |||
@@ -8,7 +8,6 @@ | |||
8 | 8 | ||
9 | #include <linux/bug.h> | 9 | #include <linux/bug.h> |
10 | #include <linux/device.h> | 10 | #include <linux/device.h> |
11 | #include <linux/ethtool.h> | ||
12 | #include <linux/firewire.h> | 11 | #include <linux/firewire.h> |
13 | #include <linux/firewire-constants.h> | 12 | #include <linux/firewire-constants.h> |
14 | #include <linux/highmem.h> | 13 | #include <linux/highmem.h> |
@@ -1359,17 +1358,6 @@ static int fwnet_change_mtu(struct net_device *net, int new_mtu) | |||
1359 | return 0; | 1358 | return 0; |
1360 | } | 1359 | } |
1361 | 1360 | ||
1362 | static void fwnet_get_drvinfo(struct net_device *net, | ||
1363 | struct ethtool_drvinfo *info) | ||
1364 | { | ||
1365 | strcpy(info->driver, KBUILD_MODNAME); | ||
1366 | strcpy(info->bus_info, "ieee1394"); | ||
1367 | } | ||
1368 | |||
1369 | static const struct ethtool_ops fwnet_ethtool_ops = { | ||
1370 | .get_drvinfo = fwnet_get_drvinfo, | ||
1371 | }; | ||
1372 | |||
1373 | static const struct net_device_ops fwnet_netdev_ops = { | 1361 | static const struct net_device_ops fwnet_netdev_ops = { |
1374 | .ndo_open = fwnet_open, | 1362 | .ndo_open = fwnet_open, |
1375 | .ndo_stop = fwnet_stop, | 1363 | .ndo_stop = fwnet_stop, |
@@ -1388,7 +1376,6 @@ static void fwnet_init_dev(struct net_device *net) | |||
1388 | net->hard_header_len = FWNET_HLEN; | 1376 | net->hard_header_len = FWNET_HLEN; |
1389 | net->type = ARPHRD_IEEE1394; | 1377 | net->type = ARPHRD_IEEE1394; |
1390 | net->tx_queue_len = 10; | 1378 | net->tx_queue_len = 10; |
1391 | SET_ETHTOOL_OPS(net, &fwnet_ethtool_ops); | ||
1392 | } | 1379 | } |
1393 | 1380 | ||
1394 | /* caller must hold fwnet_device_mutex */ | 1381 | /* caller must hold fwnet_device_mutex */ |