diff options
author | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2013-08-05 09:14:36 -0400 |
---|---|---|
committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2013-08-19 03:02:05 -0400 |
commit | 0dbe15f88be5b2cdf4ca4145797861dfb0d583a5 (patch) | |
tree | 40e1f53be70068ee895d7d6d997cdc2bda10d7e9 /drivers/firewire/ohci.c | |
parent | af53122a2a6239ef235e55cedc324499e31dad87 (diff) |
firewire: ohci: beautify some macro definitions
a) Sort device IDs by vendor -- device -- revision.
b) Write quirk flags in hexadecimal. This affects the user-visible
output of "modinfo firewire-ohci". Since more flags have been added
recently, it is now easier to cope with them in hexadecimal represen-
tation. Besides, the device-specific combination of quirk flags is
shown in hexadecimal in the kernel log too. (And firewire-sbp2
presents its own quirk flags in modinfo as hexadecimals as well.)
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/firewire/ohci.c')
-rw-r--r-- | drivers/firewire/ohci.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index 4dc65679312c..04e6eb127b73 100644 --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c | |||
@@ -271,6 +271,7 @@ static inline struct fw_ohci *fw_ohci(struct fw_card *card) | |||
271 | 271 | ||
272 | static char ohci_driver_name[] = KBUILD_MODNAME; | 272 | static char ohci_driver_name[] = KBUILD_MODNAME; |
273 | 273 | ||
274 | #define PCI_VENDOR_ID_PINNACLE_SYSTEMS 0x11bd | ||
274 | #define PCI_DEVICE_ID_AGERE_FW643 0x5901 | 275 | #define PCI_DEVICE_ID_AGERE_FW643 0x5901 |
275 | #define PCI_DEVICE_ID_CREATIVE_SB1394 0x4001 | 276 | #define PCI_DEVICE_ID_CREATIVE_SB1394 0x4001 |
276 | #define PCI_DEVICE_ID_JMICRON_JMB38X_FW 0x2380 | 277 | #define PCI_DEVICE_ID_JMICRON_JMB38X_FW 0x2380 |
@@ -278,17 +279,16 @@ static char ohci_driver_name[] = KBUILD_MODNAME; | |||
278 | #define PCI_DEVICE_ID_TI_TSB12LV26 0x8020 | 279 | #define PCI_DEVICE_ID_TI_TSB12LV26 0x8020 |
279 | #define PCI_DEVICE_ID_TI_TSB82AA2 0x8025 | 280 | #define PCI_DEVICE_ID_TI_TSB82AA2 0x8025 |
280 | #define PCI_DEVICE_ID_VIA_VT630X 0x3044 | 281 | #define PCI_DEVICE_ID_VIA_VT630X 0x3044 |
281 | #define PCI_VENDOR_ID_PINNACLE_SYSTEMS 0x11bd | ||
282 | #define PCI_REV_ID_VIA_VT6306 0x46 | 282 | #define PCI_REV_ID_VIA_VT6306 0x46 |
283 | 283 | ||
284 | #define QUIRK_CYCLE_TIMER 1 | 284 | #define QUIRK_CYCLE_TIMER 0x1 |
285 | #define QUIRK_RESET_PACKET 2 | 285 | #define QUIRK_RESET_PACKET 0x2 |
286 | #define QUIRK_BE_HEADERS 4 | 286 | #define QUIRK_BE_HEADERS 0x4 |
287 | #define QUIRK_NO_1394A 8 | 287 | #define QUIRK_NO_1394A 0x8 |
288 | #define QUIRK_NO_MSI 16 | 288 | #define QUIRK_NO_MSI 0x10 |
289 | #define QUIRK_TI_SLLZ059 32 | 289 | #define QUIRK_TI_SLLZ059 0x20 |
290 | #define QUIRK_IR_WAKE 64 | 290 | #define QUIRK_IR_WAKE 0x40 |
291 | #define QUIRK_PHY_LCTRL_TIMEOUT 128 | 291 | #define QUIRK_PHY_LCTRL_TIMEOUT 0x80 |
292 | 292 | ||
293 | /* In case of multiple matches in ohci_quirks[], only the first one is used. */ | 293 | /* In case of multiple matches in ohci_quirks[], only the first one is used. */ |
294 | static const struct { | 294 | static const struct { |