diff options
author | Kristian Høgsberg <krh@redhat.com> | 2007-05-09 19:23:09 -0400 |
---|---|---|
committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2007-05-10 12:24:14 -0400 |
commit | e1b68c4dcfb8bb7d79b6771e48767039ffbe00a8 (patch) | |
tree | 5d175ff06ec568a2efa2e6468371bf7acbdd6f05 /drivers/firewire/fw-sbp2.c | |
parent | 95ffc5e314e2bba87ec012c6e3adc487c5a7b4bb (diff) |
firewire: Return SCSI_MLQUEUE_HOST_BUSY for out of memory cases in queuecommand.
Signed-off-by: Kristian Hoegsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/firewire/fw-sbp2.c')
-rw-r--r-- | drivers/firewire/fw-sbp2.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/firewire/fw-sbp2.c b/drivers/firewire/fw-sbp2.c index c32254e94187..07be24e2d201 100644 --- a/drivers/firewire/fw-sbp2.c +++ b/drivers/firewire/fw-sbp2.c | |||
@@ -1017,7 +1017,9 @@ static int sbp2_scsi_queuecommand(struct scsi_cmnd *cmd, scsi_done_fn_t done) | |||
1017 | */ | 1017 | */ |
1018 | if (cmd->sc_data_direction == DMA_BIDIRECTIONAL) { | 1018 | if (cmd->sc_data_direction == DMA_BIDIRECTIONAL) { |
1019 | fw_error("Cannot handle DMA_BIDIRECTIONAL - rejecting command"); | 1019 | fw_error("Cannot handle DMA_BIDIRECTIONAL - rejecting command"); |
1020 | goto fail_alloc; | 1020 | cmd->result = DID_ERROR << 16; |
1021 | done(cmd); | ||
1022 | return 0; | ||
1021 | } | 1023 | } |
1022 | 1024 | ||
1023 | orb = kzalloc(sizeof *orb, GFP_ATOMIC); | 1025 | orb = kzalloc(sizeof *orb, GFP_ATOMIC); |
@@ -1093,9 +1095,7 @@ static int sbp2_scsi_queuecommand(struct scsi_cmnd *cmd, scsi_done_fn_t done) | |||
1093 | fail_mapping: | 1095 | fail_mapping: |
1094 | kfree(orb); | 1096 | kfree(orb); |
1095 | fail_alloc: | 1097 | fail_alloc: |
1096 | cmd->result = DID_ERROR << 16; | 1098 | return SCSI_MLQUEUE_HOST_BUSY; |
1097 | done(cmd); | ||
1098 | return 0; | ||
1099 | } | 1099 | } |
1100 | 1100 | ||
1101 | static int sbp2_scsi_slave_alloc(struct scsi_device *sdev) | 1101 | static int sbp2_scsi_slave_alloc(struct scsi_device *sdev) |